GitLab

If transition-entering-stylesheet is defined in the response headers for the incoming document, they're parsed out, passed to the TransitionPageHelper in the embedder, and are applied to the page via addStyleSheetByUrl at the appropriate time in the transition. 

This is the chrome side of the CL, blink side here: https://codereview.chromium.org/285623003/ 

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# 
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 
BUG=370696

Review URL: https://codereview.chromium.org/309143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278856 0039d316-1c4b-4281-b951-d872f2087c98

Optimized 51/86 files in 01:05:47s
Result: 57369 => 40173 bytes (17196 bytes: 29%)

BUG=387254
TBR=msw@chromium.rog

Review URL: https://codereview.chromium.org/332343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278855 0039d316-1c4b-4281-b951-d872f2087c98

When the extension/app requests to read and modify the accessibility settings, two messages are displayed to the user during install-time. The CL aims to combine these into one message to say "Read and modify ...".

BUG=344566
R=jww,meacer,kalman

Review URL: https://codereview.chromium.org/324273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278854 0039d316-1c4b-4281-b951-d872f2087c98

First stop to fix favicon for fractional scale factor.

I'll convert the rest of ui::ScaleFactor in 38

BUG=376367,381601
R=pkotwicz@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/335233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278853 0039d316-1c4b-4281-b951-d872f2087c98

> Ensure all members of OriginChipInfo/OriginChipView get initialized.
> 
> BUG=382921
> TEST=none
> TBR=gbillock
> 
> Review URL: https://codereview.chromium.org/345183005

TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/341313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278851 0039d316-1c4b-4281-b951-d872f2087c98

IPC enforces a limit on receipt, but we should check on the sending side
and reject the (un)registration promise too.

BUG=386724
R=falken@chromium.org, michaeln@chromium.org

Review URL: https://codereview.chromium.org/342163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278850 0039d316-1c4b-4281-b951-d872f2087c98

The android_webview build will require there only be
a single R class (details in bug).
This change makes the necessary changes to the build
infrastructure for this to happen but the actual swap
to building the webview this way will land as a subsequent
CL.

BUG=387155
build-only change, all trybots compile fine.
NOTRY=true

Review URL: https://codereview.chromium.org/255613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278849 0039d316-1c4b-4281-b951-d872f2087c98

The CL disables the incognito link on the gaia page if parental control is on. It adds a cached version for windows parental control check so that it may be accessed from IO thread. A similar CL for thread-safe android parental control check is under review at https://chrome-internal-review.googlesource.com/#/c/166265/.

BUG=383682

Review URL: https://codereview.chromium.org/336213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278848 0039d316-1c4b-4281-b951-d872f2087c98

The ComponentCloudPolicyService needs to work with the SchemaRegistry,
so it was initially owned by the DeviceLocalAccountPolicyProvider
(which always has a valid reference to the registry). However, this
means that the ComponentCloudPolicyService can't precache any policies
until the session is started.

To enable precaching at enrollment time and at the login screen, the
ComponentCloudPolicyService has been moved to the broker instead.
This allows some code simplifications too, but requires changing the
ownership of the SchemaRegistry for device local accounts.

This CL is just moving code around; a subsequent CL will trigger
the precaching.

TBR=zelidrag@chromium.org
BUG=224596

Review URL: https://codereview.chromium.org/342233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141

Review URL: https://codereview.chromium.org/334923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382921
TEST=none
TBR=gbillock

Review URL: https://codereview.chromium.org/345183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278845 0039d316-1c4b-4281-b951-d872f2087c98

The Android snapshot was found to be chopping off the bottom content.  This is
due to not accounting for the height of the toolbar.  This patch enlarges the
snapshot by that offset.

BUG=384551

Review URL: https://codereview.chromium.org/340603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278843 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Need to revert the blink side and this (incorrectly) adds an OVERRIDE for a cross-repository override.

Original issue's description:
> Accelerate small canvases if Ganesh is on.
>
> cc side of change.
>
> TBR=phajdan.jr@chromium.org
> BUG=382738
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276753

TBR=ajuma@chromium.org,kbr@chromium.org,phajdan.jr@chromium.org,chrishtr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=382738

Review URL: https://codereview.chromium.org/349733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278842 0039d316-1c4b-4281-b951-d872f2087c98

The virtual keyboard bindings will be provided by mojo soon. Until then, this is
a temporary hack to provide an implementation for the missing API. The virtual
keyboard shows up in athena with this last change.

BUG=380215
R=bshe@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/348823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278841 0039d316-1c4b-4281-b951-d872f2087c98

In this CL:
- crbug.com/343688: when editing the profile name but not changing it, the text field would
freeze. this is because it would remain enabled, but hidden, and steal the button click
(because it used to be a first responder)
- add a separator between the "not you" and "lock" bottom option buttons, to
match the mocks. I added this as a vertical separator to the BaseBubbleController itself, 
so that other classes can use it in the future.
- center the profile name correctly. Because of the pencil icon, the name would be shifted
slightly to the left
- the "change photo" overlay should be more opaque
- the bubble bottom corners were overlapped by the option buttons, and didn't appear rounded.

BUG=343688

Review URL: https://codereview.chromium.org/323143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278840 0039d316-1c4b-4281-b951-d872f2087c98

Was previously flushing the actual LevelDB table on disk and then corrupting.
This approach is more loosely coupled with LevelDB disk format and lays the
groundwork for future tests (and refactoring) to not rely on an actual
corrupted db.

Also reduced the number of test objects written to the db to 5.

Review URL: https://codereview.chromium.org/334303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278838 0039d316-1c4b-4281-b951-d872f2087c98

We try to set the scaling governor for all CPU cores, but
this doesn't work SOCs that dynamically disable cores
entirely (ie. Qualcomm). Since this only happens on Qcomm,
this patch stops the 'mpdecision' process on Qualcomm, which
makes it behave like other devices.

PERF-SHERIFFS: This may improve metrics for the better given
all cores are in 'performance' mode now. It should hopefully
reduce noise, since a different number of cores might have
had 'performance' set on each run, and any code that runs on
a non-performance core will suffer from noisy timings/rates.

Example: Tough-compositor-cases std-dev went from 0.25ms to
0.04ms with this change.

BUG=383566

Review URL: https://codereview.chromium.org/338233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278837 0039d316-1c4b-4281-b951-d872f2087c98

with -o2
Optimized 6/16 files in 00:03:20s
Result: 6014 => 4014 bytes (2000 bytes: 33%)

BUG=387254
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/343203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278836 0039d316-1c4b-4281-b951-d872f2087c98

To analyze the impact of prefetching high-confidence search suggestions in Android Chrome, this CL,
- Adds a listener for counting Google searches from various search access points. No actual search query content is observed.
- Records the search count based on the prerendering settings.

(see trybot results in patchset #8).

BUG=382694
R=asvitkine@chromium.org, davidben@chromium.org, jam@chromium.org, pkasting@chromium.org, samarth@chromium.org

Review URL: https://codereview.chromium.org/342053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278835 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/348553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278834 0039d316-1c4b-4281-b951-d872f2087c98

With this change, a Key object's algorithm member is copied on every read access. Effectively preventing it's modification as required by the WebCrypto specification.

BUG=385143
R=bartfab@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/332233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278833 0039d316-1c4b-4281-b951-d872f2087c98

This method doesn't belong in ExtensionService, and can instead live in
PermissionsUpdater. This helps keep the permissions updating logic together.

Also update PermissionsUpdater to use a browser context instead of a profile,
where possible.

BUG=351891

Review URL: https://codereview.chromium.org/347803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367863
R=avi@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/341073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278831 0039d316-1c4b-4281-b951-d872f2087c98

As much as I would like to keep all tests working,
it seems unreasonable to hold-back performance improvements
for all of Chromium (particularly android) to keep
this test "passing".

https://codereview.chromium.org/302063002/

BUG=387101
TBR=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/343213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278830 0039d316-1c4b-4281-b951-d872f2087c98

Make sure battery status works with proper default values
on Android. Add an exception for battery present check for
Galaxy Nexus because it wrongly reports that the battery
is not present (see http://crbug.com/384348).

BUG=122593, 384348, 360068
TEST=http://jsbin.com/battery-status-diagnostics (manual)

Review URL: https://codereview.chromium.org/330333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278829 0039d316-1c4b-4281-b951-d872f2087c98

Adds extensions common API target and extensions templates.

Adds a number of new targets: widevine, flash, sync proto, metrics proto, device serial.

Minor enhancements to protobuf and mojo templates.

TBR=jamesr

Review URL: https://codereview.chromium.org/343233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/344863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278827 0039d316-1c4b-4281-b951-d872f2087c98

This CL depends on: https://codereview.chromium.org/334053003/

BUG=380421
R=oshima@chromium.org, jamescook@chromium.org
TBR=sheib@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/345773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278825 0039d316-1c4b-4281-b951-d872f2087c98

Adds a field trial flag to control whether to use an alternate Instant search base page URL for prefetching search results.

BUG=382694
TEST=Run chrome with the following field trial flag and observe the Instant search base page url.
     --force-fieldtrials="EmbeddedSearch/Group1 use_alternate_instant_url:1 /"

Review URL: https://codereview.chromium.org/330653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278824 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/343243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369659
TBR=vapier@chromium.org

Review URL: https://codereview.chromium.org/345133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278821 0039d316-1c4b-4281-b951-d872f2087c98

This is a special component that only gets registered when the user reset the profile settings and has enabled UMA reporting.

Once installed (or if already installed), the component is executed and it's exit code is reported via UMA.

In case the component doesn't have time to be installed and executed before Chrome exits, a local state pref identifies that we have a pending registration or execution so that it can be continued on next Chrome startup.

BUG=377601
R=asvitkine@chromium.org, battre@chromium.org, jhawkins@chromium.org, robertshield@chromium.org, sorin@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/333193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375430
TBR=rsleevi

Review URL: https://codereview.chromium.org/345213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278818 0039d316-1c4b-4281-b951-d872f2087c98

    
ChromeOS on bare hardware will do display configuration and cursor
movement from the GPU process. This is the conduit for the messages
needed to make this work.
    
This plumbing also supports other platforms with similar requirements
(e.g. wayland's port). X11 does not need any specific messaging here,
since we just call the X server from the browser.
    
TBR=piman@chromium.org,rjkroege@chromium.org,alexst@chromium.org,chrishtr@chromium.org
NOTRY=true
BUG=377497

Review URL: https://codereview.chromium.org/341253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278817 0039d316-1c4b-4281-b951-d872f2087c98

When Reset() is called outside of a config change, we need to clear
the active splice flag.

BUG=386782
TEST=new unittest
R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/347813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278816 0039d316-1c4b-4281-b951-d872f2087c98

Avatar bubble:
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMT2xPMnp3dEJvUms/edit?usp=sharing
- the previous code was using a temporary warning icon (while we were waiting
on UI resources), so this CL updates both the avatar button and bubble to 
use the correct one
- only the warning icon was clickable for accounts with an auth error in the
avatar bubble; changed this to have the entire account name be clickable, after
chatting with Travis/Alan
- moved the icon to in front of the account name, after
conversations with UI
- fixed eliding for the account button (which wasn't missing
one of the horizontal edge margins). Screenshot:
https://drive.google.com/file/d/0B1B1Up4p2NRMczBVQ29IRlREcG8/edit?usp=sharing

Avatar button:
Screenshots:
https://drive.google.com/file/d/0B1B1Up4p2NRMZnJsV3hlZTFjcGM/edit?usp=sharing
- fixes a bug where the avatar button text for glass windows was
displayed incorrectly when the window was maximized.

BUG=311235, 381713

Review URL: https://codereview.chromium.org/297143008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278814 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/333173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278813 0039d316-1c4b-4281-b951-d872f2087c98

Normally a child process kills itself if it can't connect to the browser in 15 seconds. This is to prevent a child process from staying around if the browser crashed right after launching it but before connecting to it.

When browser tests are sharded, sometimes tests run slower because of resource starvation which is why we have longer timeouts. So increase the child process connection timeout to match this.

BUG=TODO
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/343543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278812 0039d316-1c4b-4281-b951-d872f2087c98

Currently when HistoryURL provider decides to promote a match
for inline autocompletion, it will then decline to offer a what-you-typed
match even if it's valid and reasonable.

This behavior can cause problems in DisableInling mode because
this means that sometimes HistoryURL provider will not create a UWYT
match. Consequently, the default match in this mode can become a
search-what-you-typed even when the input is a valid URL. This causes
all sorts of badness and irritation.

This changelist creates a new mechanism, controlled through a field
trial parameter, that forces creation of the UWYT match if it wasn't
added due to this reason (promoted URL for inline autocompletion).

This is one approach to implement this strategy. The other approach
is in https://codereview.chromium.org/321243003/

Did some basic tests using a local field trial server with the
proper params.

TBR=pkasting
(to get this in M-37)

BUG=380357

Review URL: https://codereview.chromium.org/347963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278811 0039d316-1c4b-4281-b951-d872f2087c98