- 15 Oct, 2019 40 commits
-
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: Iaeaf5ba584d6592a64226d9b57c37e6c9d5544a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863021Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#706033}
-
chrome://appsElly Fong-Jones authored
This change adjusts the color scheme on chrome://apps: * The webstore link is now Blue 600 and has no hover effect, to make it look like the link it is * Other text in the footer is #666 so it's readable on the background * The background is white instead of a near-white translucent gradient * The logo image is now an image without text, since the text was not contrast-y enough Bug: 957393 Change-Id: I3b3f08554222b23f63d167b54875004a4ddb5c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856541Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706032}
-
Peter Kasting authored
These should be ints per our style guide, and were both set and used as ints (via implicit and explicit casts, respectively). Bug: none Change-Id: I815879e38e5ec363a50bb2f58a0b607f716ad8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855198 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706031}
-
Xiaohan Wang authored
External Clear Key is a test key system. This CL updates the comment to explain what it is used for and how it's supported in different cases. Change-Id: I955a6bb2db039069122ecf98ebe944628526e700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863111Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706030}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df18296f9844..fb6a1abe4567 git log df18296f9844..fb6a1abe4567 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 mtklein@google.com try un-teaching TSAN about Mac semaphores Created with: gclient setdep -r src/third_party/skia@fb6a1abe4567 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I5b8244727d408b0cb1c5466fa74d8ee6bc8a41c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706029}
-
Jeremy Roman authored
Change-Id: I661ebde62fbe9b010d923a4948ecb942a214cb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862625 Commit-Queue: Andreas Haas <ahaas@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8e512c1e9ab..14df22429d27 Created with: gclient setdep -r src-internal@14df22429d27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1005965,chromium:None Change-Id: I469ea22a0741a670033f0aeceb48e00549e85e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706027}
-
Yuwei Huang authored
Mojave users might have already granted a11y permission to the old helper script. In order not to unnecessarily break them, this CL implements a fallback logic in the host service executable to always delegate to the old script if the script exists and the user is on macOS 10.14. Bug: 10142116 Change-Id: I301585cf25ca3c37ac1ebedac8b4dee6c1251c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861278Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#706026}
-
Xing Liu authored
This test is failing on some Android builders. Disable it for now. TBR=ricea@chromium.org Bug: 1014556 Change-Id: Iad4dbb959199476e08c90848ebd325143d6eeb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862717Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706025}
-
jonross authored
Update the example usage of --local-run for pixel tests. This is a follow-up to a change of how the argument is used: https://chromium-review.googlesource.com/c/chromium/src/+/1860677 Bug: 1013358 Change-Id: Id1ccdd5b55c89e976ff77853925c0db9c7bcd835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862624Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#706024}
-
John Budorick authored
Became very clear that this was too much noise at info level while working on pushing data deps for the emulator. Bug: 922145 Change-Id: I038c478feed4e0f3bb39d8f9e7dc3ea21a22fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861111 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#706023}
-
liberato@chromium.org authored
Instead of using the current src URL when downloading media, use the final target after all redirects from resource selection. Additionally, do not download the media file if any cross-origin redirect is requested by the server. Bug: 990867 Change-Id: Ibcd7a7aff8959b7f5bbfdcc38290a701f06c6123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845773Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#706022}
-
Peter Boström authored
Replaces OnBoundsChanged overrides. Also removes std::unique_ptr from GetButtonHighlightPath which reduces heap allocations. Bug: chromium:1007546 Change-Id: I763d32ba39907a34ca4356979038e0f93e231d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861274Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706021}
-
Andrey Kosyakov authored
This reverts commit 3d4ab06a. Reason for revert: broke history navigation with virtual time. Original change's description: > Encapsulate WebScopedVirtualTimePauser inside Blink > > This moves history navigation virtual time pauser from > RenderViewImpl to Page, which has two benefits: > - slimming down RenderViewImpl; > - encapsulating virtual time inside Blink. > > Most of changes are moving virtual time pauser creation > from thread scheduler to page scheduler. > > Bug: none > Change-Id: I9fc2683e974e005d8cea35ced0f5f82931215b5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856929 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705679} TBR=dgozman@chromium.org,alexclarke@chromium.org,altimin@google.com,altimin@chromium.org Change-Id: Ib2ebc3ebb4710201969a24e8d63f1f022df7fa9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862249Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706020}
-
John Budorick authored
This reverts commit 8af63978. Reason for revert: suspected of causing compile failure in https://ci.chromium.org/p/chromium/builders/ci/mac-archive-dbg/3670 Original change's description: > Roll src/third_party/dawn/ 1093c4de2..c57b18020 (2 commits) > > https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..c57b1802088a > > $ git log 1093c4de2..c57b18020 --date=short --no-merges --format='%ad %ae %s' > 2019-10-15 cwallez Add dawnGetProcAddress. > 2019-10-15 cwallez Split the libdawn target in components with a single purpose. > > Created with: > roll-dep src/third_party/dawn > > BUG=dawn:22 > > Change-Id: Ibc6a154143d98e2c9a5d770e766388e43d05b5ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863013 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705998} TBR=kbr@chromium.org,cwallez@chromium.org Change-Id: I621465bddca007213307e862b68192953eac49ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862991Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706019}
-
Anushruth authored
This will be removed in the future once errors due to isolate corruption disappear. R=bpastene@chromium.org Bug: 1013093 Change-Id: I24976ec89c2a34900cade8e549766bb10858b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856871Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#706018}
-
Mounir Lamouri authored
Bug: None Change-Id: Icc2d8edc147173bdeaf0c895a199c0a86c5b78f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863030Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#706017}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b17e79b773ba..f8e512c1e9ab Created with: gclient setdep -r src-internal@f8e512c1e9ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I278212026dad0bb47d9ac3121f151264d25f03f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862239Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706016}
-
Michael Lippautz authored
Tbr: bikineev@chromium.org Bug: 1014414 Change-Id: I914c6be2723656b4c24d37f46f3e95beaf16452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863411Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706015}
-
Maksim Moskvitin authored
This CL has two goals: 1. Prevent setting custom passphrase while we have pending keys. We can't build correct keybag otherwise. 2. Allow users with backward-compatible keystore Nigori exit pending encryption state by providing old passphrase. Bug: 922900 Change-Id: I34e62ca41c1baf48ffc66fb9a13ea1bde438a8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855965 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706014}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9b58c027..65c6e8ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I547b00fee905d36cfedbe8b6c459e93703752dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863229Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706013}
-
Ben Kelly authored
Bug: 1014486,1010624 Change-Id: I175e6390cb67be4acff89caebee33c86d07230c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863230Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#706012}
-
Camille Lamy authored
This CL updates test expectations for two flaky WPT layout tests. Bug: 1014327, 1014326 Change-Id: I53b47ecf81338df03eaa75e5520db56cb2c6f49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863027Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706011}
-
Rohit Agarwal authored
Chrome didn't warn the users about open incognito windows that would be lost during the update. Added a general warning in the settings and a personailzed warning, indicating the count of open incognito windows in the Relaunch Chrome dialog. Bug: 810989 Change-Id: Ibd6bf11024e94b0490964f3cdf2236d10c14d998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814924Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#706010}
-
Avery Musbach authored
The present CL is similar to [1]. The rationale in the commit message of [1] does not apply to the current plan for multi-display split view, but similar code changes seem reasonable anyway. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1726310 Bug: 970013 Change-Id: I1a1572d89c2d25ac60b9ac25dc37edce7b74fce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856890 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#706009}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61d3d4b0bd55..ba97f6065ed1 git log 61d3d4b0bd55..ba97f6065ed1 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 chrishall@google.com Trivial: Removing gendered pronouns from watchlists.py. Created with: gclient setdep -r src/third_party/depot_tools@ba97f6065ed1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:879943 Change-Id: Icd118e802cc33046b5e36f3ef73130c45b717d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706008}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d3b93d4c73b8..260e87e6956a git log d3b93d4c73b8..260e87e6956a --date=short --no-merges --format='%ad %ae %s' 2019-10-15 wbbradley@chromium.org shellcheck: look inside the chroot first for shellcheck Created with: gclient setdep -r src/third_party/chromite@260e87e6956a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I521acfbcce01fcc8c3ef77b6151d56c600405985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706007}
-
Clemens Arbesser authored
This CL fixes issues for users of autofill assistant who have disabled their autofill addresses. Prior to this CL, credit card validation logic relied on the personal data manager to retrieve the corresponding billing addresses. Now, this is decoupled such that billing address and credit card are treated independently by autofill assistant. This allows users to ad-hoc fill the user form (with newly created credit cards and billing addresses). Bug: b/142630213 Change-Id: I3edbdac9dfc8efbda5a40d5f5868f642bcf459c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859775 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706006}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f22c57ddcc8c..df18296f9844 git log f22c57ddcc8c..df18296f9844 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 brianosman@google.com Add accessors to get/set SkParticleEffect fields Created with: gclient setdep -r src/third_party/skia@df18296f9844 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I46a1247c9a3c264b7593c3148cdf97dfa8133dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706005}
-
Raul Tambre authored
itervalues() has been removed in Python 3 in favour of values(). They're functionally equivalent, but values() is slightly slower in Python 2. In this case there shouldn't be a difference because sys.modules is usually pretty small. Example backtrace: Traceback (most recent call last): File "../../tools/licenses.py", line 809, in <module> sys.exit(main()) File "../../tools/licenses.py", line 791, in main if not GenerateCredits(args.file_template, args.entry_template, File "../../tools/licenses.py", line 717, in GenerateCredits build_utils.WriteDepfile(depfile, output_file, File "C:\Google\chromium\src\build/android/gyp\util\build_utils.py", line 563, in WriteDepfile inputs = _ComputePythonDependencies() + inputs File "C:\Google\chromium\src\build/android/gyp\util\build_utils.py", line 514, in _ComputePythonDependencies module_paths = (m.__file__ for m in sys.modules.itervalues() AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I3a5e1602f3dda99ea97f328811d941de73cb76eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857124 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#706004}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc3b617bc9f8..b9fad2fbcc49 git log cc3b617bc9f8..b9fad2fbcc49 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 perezju@chromium.org [Telemetry] Make results.AddValue API private Created with: gclient setdep -r src/third_party/catapult@b9fad2fbcc49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:999484 Change-Id: I738ac1d124bb25ab0b61cd5574f059617832bd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706003}
-
Robert Liao authored
Convert PlatformSensorReaderWin32's EventListener And Related Tests to use Microsoft::WRL::RuntimeClass Instead of IUnknownImpl BUG=1014283 Change-Id: I916d449e9bd6922eadd77a2ddbaa83a2a1a0eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860986 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706002}
-
Friedrich Horschig authored
Non-functional change. This CL moves the URL formatting into the mediator which separates the logic from the view binder. Bug: 957532 Change-Id: I172f20f00ab3e9fa998c82bd8c41ef8159cf08d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857129 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#706001}
-
Michael Lippautz authored
Change-Id: Ie060c1a6e9cac18c8366e89235961917f0e4b146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862927 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#706000}
-
Vadym Doroshenko authored
There are 2 more fields are required for username first flow. Bug: 959776 Change-Id: I02b336ec078e46f48a6bbed86f29ed5bb8d9f288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859959 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#705999}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..c57b1802088a $ git log 1093c4de2..c57b18020 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 cwallez Add dawnGetProcAddress. 2019-10-15 cwallez Split the libdawn target in components with a single purpose. Created with: roll-dep src/third_party/dawn BUG=dawn:22 Change-Id: Ibc6a154143d98e2c9a5d770e766388e43d05b5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863013Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705998}
-
Pâris MEULEMAN authored
This removes unused includes from signin_manager_android.cc to primary_account_manager and primary_account_mutator. Including the DEPS exception for primary_account_manager which is internal to identity_manager. Bug: 934688 Change-Id: I85a84245d0bb3e12bf4746f603d0051926b6a430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862445 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705997}
-
Arthur Hemery authored
Currently kBackForwardCacheNoTimeEviction overrides specific setup in the BackForwardCacheTest suite, where we want to preserve the previous behavior. Explicitly override it at construction time. Change-Id: I39cc378f2cc03bd798ef4306db6eeecfd8abc72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859790Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705996}
-
Peter Boström authored
Uses a pill-shape generator for SearchResultSuggestionChipView. This replaces a custom InkDropMask for the same shape and overriding the focus ring's path inside OnBoundsChanged. Bug: chromium:1007546 Change-Id: I229ad7529ad4d593f32b39cfe3fda948332eb32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861046 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705995}
-
Kai Ninomiya authored
This reverts commit f061988f. Reason for revert: Failures on webgl(2)_conformance_gl_passthrough_tests on Mac FYI bots Original change's description: > WebGL: Don't expose ARB_texture_rectangle on Mac passthrough > > Uses the new DisableExtension functionality from > https://chromium-review.googlesource.com/c/angle/angle/+/1838418 > to prevent ARB_texture_rectangle from being exposed to WebGL shaders. > > Bug: angleproject:3770 > Change-Id: I106785757235f3f1748d74ddf25dac9384caa281 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842223 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705802} TBR=kbr@chromium.org,jdarpinian@chromium.org Change-Id: I924e7a306fbb91feb914973b9a3a24b857d738e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863155Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#705994}
-