- 15 May, 2019 40 commits
-
-
Parastoo Geranmayeh authored
Consider <input type="search"...> for heuristics type predictions when dropdowns might be have been used. Bug: 963119 Change-Id: I6604f86cb2a8978ec594531bd2d28aa40257e9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610096Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#660030}
-
Michael Giuffrida authored
Updates the Feedback app to allow the landing page type to be empty, for cases where we don't want to show a landing page after sending feedback (ie, when using Kiosk Next). Also fixes the board parsing logic so only eve devices (instead of all boards containing the substring "eve") are treated as Pixelbooks. Bug: 957784 Change-Id: Ie46153e0c7d08e213373d8acfb6593c6d6f45ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602448 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#660029}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibacfb7f20d2119103022f1ab52e1a20f695266d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660028}
-
siyua authored
Previously the highlighted button for the bubble is set to be the icon in OmniboxPageActionIconContainer, so when the icon is actually in ToolbarPageActionIconContainer, the highlight will not be updated in BubbleDialogDelegateView::HandleVisibilityChanged() when the bubble is dismissed. Bug: 932818 Change-Id: Ic0aba1e922f7c240195cdef3d422422e5d9c6861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612363Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#660027}
-
Robert Ogden authored
Sorry for the size... many things have come to link against this code and they all needed to be removed or changed, esp the lofi code. Bug: 942572 Change-Id: I7e760ad51e78a83e7ef3a7884c5c3a7ddcc13fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603323Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#660026}
-
danakj authored
When WebContentsImpl destroys, it deletes the speculative main frame, but the renderer may have taken ownership of it already, and the notice of such action is in flight to the browser still. This leads to DCHECKs failing in the renderer. So inform the FrameMsg_Delete IPC what the intention of the browser is, there are 3 modes: - Deleting a non-main frame. This is the common case. These frames are all owned by the browser so it's all good, no races. - Deleting a speculative main frame at shutdown. This is the race we address here. - Deleting a speculative main frame because it's no longer needed. This race is not handled by this CL but we CHECK() it explicitly now instead of letting the renderer continue with a missing RenderFrame that it expects to be present until it crashes somewhere random later. R=avi@chromium.org, dcheng@chromium.org Bug: 957858, 838348 Change-Id: I2110bdaf8b116df48037f69db6cb992fa3796e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594834 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#660025}
-
Tommy Steimel authored
Bug: 963032 Change-Id: I347570b37044f9679f94bbe60b9e24d578892ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611216Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660024}
-
Eric Karl authored
This reverts commit 91d93479. It turns out that future work / optimizations around Android colorspace handling and Skia SW raster optimization require that we cache mixed colorspace images. Reverting this patch to bring back this option. If we see performance regressions on the bots, I'll address these in a follow-up. Bug: 955161 Change-Id: I0dda536cf05d349b615f55e7ec1a670df2026a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592803Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
Change-Id: I0db54e83879a12f83bafd251f7b10cabe344f2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612537Reviewed-by:
-
rbpotter authored
Temporary file names created with tempfile.NamedTemporaryFile cannot be used to open the file a second time on Windows, see: https://docs.python.org/2/library/tempfile.html Set the temp files to not be automatically deleted on close, close them after creation so they can be re-opened, and delete the files at the end of the tests. Bug: 961359 Change-Id: I88a86332f4454c1e98f7e5b0f7753771e7d4b4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612043Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#660021}
-
Michael Lippautz authored
The bit is set whenever writing free list entries. Bug: 945806 Change-Id: Ifd5b7e6a8c4d7e4d557afd02fa79b1f1d60f4ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609912 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#660020}
-
arthursonzogni authored
This reverts commit c0700f9c. Reason for revert: https://crbug.com/963330 When a frame commit in process A, it tells the proxy of the focused frame for process A to "SetFocusedFrame". The problems happens when the focused frame is "pending deletion", it doesn't have any proxy anymore. The solution might be: 1) Unset the focused frame when it starts unloading. 2) Do not depends on the proxy to exist. This will be done in the reland. Original change's description: > Detached subframes with unload handler should not be visible to others. > > When a frame is unloading in one process, it must not be visible from the other > processes at some point. Previously, it was done when the frame completed the > unload, now it will be done when it starts unloading. > > To achieve that, the RenderFrameProxyHost are removed when the frame starts > unloading. Moreover, no new RenderFrameProxyHosts are created in a frame with an > unloading current document. > > + 2 tests added, originally made by lukasza@chromium.org (Thanks!) > > Bug: 960006, 950625 > Change-Id: I3f6fc405219a08d9d61f5c0ed8772601f9dc8835 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599182 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659004} TBR=creis@chromium.org,alexmos@chromium.org,lukasza@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960006, 950625, 963330 Change-Id: I06a1eb44c05eaaff380e1b96f796c5b064c16c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613183Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#660019}
-
rbpotter authored
(1) Use relative paths in the downloads UI, instead of prefixing everything with chrome://downloads. (2) To make this work, add a <base href="chrome://downloads> to non optimized builds. (3) Match the behavior for incorrect subpaths like chrome://downloads/a/b/ to the behavior for other Web UIs (settings, extensions, and print preview). Bug: none Change-Id: I34978c736126537fddbb8118d03de0dce8201917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604054 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660018}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/023ca2db25ad..ddbdb74d5561 git log 023ca2db25ad..ddbdb74d5561 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 dhanyaganesh@chromium.org cros_uprevchrome: change LIMIT to be Buildbucket's request Created with: gclient setdep -r src/third_party/chromite@ddbdb74d5561 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Icd47e2ec194cc314a4d697782a42e9c68bad7046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613322Reviewed-by:
-
Alex Cooper authored
This reverts commit f9706cfd. Reason for revert:963529 Original change's description: > Update XRInputSource Gamepad to comply with SameObject requirement > > The WebXR spec requires that the Gamepad object on an XRInputSource be > tagged as "SameObject." The current implementation would allow for > the Gamepad to be toggled between null and present on the same > XRInputSource object as it currently is written. This change exposes a > method "NeedsReCreation" as well as static helper methods (and a deep- > copy constructor) to allow for that re-creation to occur in a pattern > which could be re-used by 958019 if the spec requires those changes. > While this change adds an xr_browser_test to validate the blink code > that destroys/re-creates the object, the work to add a WPT test for all > of the same object properties is tracked by 960958. > > The exemption to audit_non_blink_usage was added because the xr module > was currently utilizing device::Gamepad, but since it was previously > wrapped in base::Optional, that usage was not flagged. > > Note that 955101 (currently tagged for 77) may relax/change this > requirement, but this makes the code compliant with the spec for M76. > > Bug: 960978 > Change-Id: Ie36990f47e43c6df91af3fca06dd269a860a2a1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606421 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659625} TBR=dcheng@chromium.org,bajones@chromium.org,billorr@chromium.org,alcooper@chromium.org Change-Id: Ia5b987d3e4e5746d94a65cd2e8786012345b8c5d No-Presubmit: true No-Try: true Bug: 960978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613557 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#660016}
-
Jun Mukai authored
It seems ash/dbus/display_service_provider is the only user of this interface, so the mojo interface isn't necessary anymore. Simply removing it would be fine. Bug: 958190 Test: trybot Change-Id: I8f96dd9192ecf07d134194a60abd5353abebb029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609594Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660015}
-
Saman Sami authored
This reverts commit 1374013c and disables some media tests that flake due to a race that is exposed by the revert. Reason for revert: causes jank https://crbug.com/947587 The original reason for landing this CL does not apply anymore. It is no longer the case that viz skips a BeginFrame if an undrawn frame exists. See https://crrev.com/c/1521967 Original change's description: > Skip MISSED frames in browser compositor > > This CL fixes a dropped frame issue when a scroll transitions from > dragging to a momentum "fling" phase. When the user is scrolling and > lifts their finger with velocity, the scroll continues according to a > decelerating animation curve. When this happens, the FlingController > receives a FlingStart instead of a ScrollUpdate and it uses that to > create an animation curve. > > When this happens the browser process registers itself as an animation > observer so that it begins to receive BeginFrame signals. However, the > display service issues a MISSED BeginFrame for the frame in which the > animation was registered. This will frequently miss submission in the > current frame, so it submit next frame and won't receive a BeginFrame > then. This leads to a frame without the browser ticking the fling > animation. See https://crbug.com/882907#c50 for a diagram and more > complete explanation of the issue. > > The browser process shouldn't require processing MISSED frames so in > this CL we simply drop MISSED frames if we're in the browser compositor > (commit_to_active_tree is true). Longer term, the display scheduler > should make these decisions but this is an immediate fix for the fling > issue. > > Bug: 882907 > Change-Id: Ieb6d14051dc05c5e177da1920dbd27684f941d29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517164 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640172} TBR=bokan@chromium.org,sunnyps@chromium.org Bug: 947587,882907,963141 Change-Id: Id23b586f89de67f9e77212ee265f4ad2db5a6fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613363Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#660014}
-
Xianzhu Wang authored
Change-Id: Ice79a3783b57f26fb928ae19b4001e68460138b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612236 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660013}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e62a08a87a6f..7581ff73754e git log e62a08a87a6f..7581ff73754e --date=short --no-merges --format='%ad %ae %s' 2019-05-15 titovartem@webrtc.org Add screen share support to PC level test framework 2019-05-15 titovartem@webrtc.org Reduce flakiness of NetworkEmulationManagerTest.ThroughputStats 2019-05-15 kuddai@google.com Remove streaming_mode as it is always false. 2019-05-15 ilnik@webrtc.org Fix metadata setting in H264 decoder 2019-05-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3820725a..eacdc75a (659764:659866) 2019-05-15 hta@webrtc.org Send and parse SCTP max-message-size in SDP 2019-05-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 279d4550..3820725a (659647:659764) 2019-05-14 sukhanov@webrtc.org Add datagram_transport and congestion_control interface 2019-05-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1c80f902..279d4550 (659511:659647) 2019-05-14 hta@webrtc.org Change default SDP syntax for SCTP to spec-compliant. 2019-05-14 hta@webrtc.org Change default secure SCTP protocol to UDP/DTLS/SCTP 2019-05-14 sprang@webrtc.org Remove redundant capture time adjustment in RtpSender 2019-05-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9500673d..1c80f902 (659367:659511) 2019-05-14 kthelgason@webrtc.org Check for uninitialized audio unit in HandleInterruptionEnd. 2019-05-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a1c6ffe8..9500673d (659234:659367) 2019-05-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b06ee6f3..a1c6ffe8 (659110:659234) Created with: gclient setdep -r src/third_party/webrtc@7581ff73754e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:962860,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic05485f799bc532b3404ba91574deee1371bec30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613235Reviewed-by:
-
Ehsan Karamad authored
This CL makes some more tests pass with MHVICPF. Essentially, * BrowserPlugin tests return early as they expect a BrowserPlugin and with MHVCICPF we do not create one. * PDFExtensionInternal* tests are changed to use direct input routing to the guest WebContents when the flag is on. * PDFExtensionTest.EmbeddedPdfGetFocus will early return when MHVICPF is present (this is also a BrowserPlugin related test). Bug: 961786 Change-Id: Ib90ee540283f23dccba1b7f8abfb4ee28e06654f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611855Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
It's possible for BigBufferView::shared_memory_ to be null if memory mapping fails. This change adds a check that the mapping is not null before trying to write there. Bug: 961256 Change-Id: I72772e07583ab62df5544d419604356071071e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611311Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/71e1bec28dde..0aa89afdae25 git log 71e1bec28dde..0aa89afdae25 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 jalissia@microsoft.com Remove unused chrome_v8.json testdata file Created with: gclient setdep -r src/third_party/catapult@0aa89afdae25 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Change-Id: I225a8a9730191955218e2a90496d998cbdb8a62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612188Reviewed-by:
-
Greg Kerr authored
This was test very useful to test the V2 style rules across the macOS fleet. It is no longer testing anything, since there are unit tests for the actual V2 profiles. SandboxMacCompilerTest covers the compiler class. Bug: 917445 Change-Id: I0559fe9484e52a7b9b19361345d858c3a1d70aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600312Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660008}
-
Scott Violet authored
With mash/window-service going away none of this code is used anymore. BUG=958245 TEST=covered by tests Change-Id: Iadafa0685571986c04c38aa9f6fea8c21bd6b2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612332Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#660007}
-
Yuwei Huang authored
This reverts commit 95b433f3. Reason for revert: Build breakage: https://ci.chromium.org/p/chromium/builders/ci/win32-rel/16318 Original change's description: > [remoting] Implement It2MeCliHost > > This CL implements a binary that allows starting an IT2ME host from > command line. This will help debugging the FTL migration process for > ChromeOS enterprise. > > The code is mostly copied and modified from CRDHostDelegate. > > Bug: 962765 > Change-Id: I74d5b6c49b7c55703f6d52a81aa0327456f8174e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610891 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Auto-Submit: Yuwei Huang <yuweih@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659992} TBR=sergeyu@chromium.org,joedow@chromium.org,yuweih@chromium.org Change-Id: I35b257d8908937ee4530a3e59ac6c863f9f98bf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 962765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613638Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#660006}
-
Jun Mukai authored
The change of the view causes redrawing during the animation which causes stuttering. Either way it's going to be closed, it does not have to change the view. On nocturne, this improves the closing animation smoothness significantly when searched. With EnableBackgroundBlur, LauncherAnimationsTest.FullscreenSearch's Close smoothness will be improved from 13-33 to 73-93. Bug: 961467 Test: LauncherAnimationsTest Change-Id: If6454a7b3200f0f42d15c50b6f035e5d3da4f3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611200Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660005}
-
Alex Clarke authored
As requested this changed the way we disable DCHECK_DEATH tests on ChromeOS. Bug: 906125 Change-Id: I271af5bc387db9121951354d608c98c07f6ae01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613184 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#660004}
-
John Abd-El-Malek authored
This reverts commit c81955d5. Reason for revert: https://crbug.com/961531 Original change's description: > Remove AdaptCallbackForRepeating() in ImportantFileWriter. > > If posting the task fails then it's not an appropriate task runner. See > https://crrev.com/c/1572809/3/base/files/important_file_writer.cc#258 > for more context. > > Bug: 714018 > Change-Id: I620bd978ec2a1d6b6219fa3d85ac6fbcd5563af2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580041 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654577} TBR=fdoray@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 714018 Change-Id: I46e759e3035b73f59a9960bb95b96d238dc4953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613365Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#660003}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/10186cb85fd6..67cf8a9266d0 git log 10186cb85fd6..67cf8a9266d0 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 sugoi@google.com 32 bit safe code 2019-05-15 chrisforbes@google.com Remove Context::separateAlphaBlendEnable etc 2019-05-15 chrisforbes@google.com Now that we have swizzles forced, don't bother with channel replacement Created with: gclient setdep -r src/third_party/swiftshader@67cf8a9266d0 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132280877,chromium:b/119620767 TBR=swiftshader-team+autoroll@google.com Change-Id: Ic2b99c6cc0432ed6caf189e0cd9e35202d422886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612709Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed36a5728bd9..13e71f2526be Created with: gclient setdep -r src-internal@13e71f2526be The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I9b026137c73678794dedd634f38e9ad4709f6ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613319Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660001}
-
Kevin Bailey authored
We currently have the ability to demote suggestion relevance scores based on suggestion type. This has the unfortunate tendency to make the default match change more than is desirable. This change adds a flag which, if enabled, causes the choice of default match to remain the best unmodified score. Change-Id: I002d6d010bb10c2e11e9da26970bcd11359e0cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610209 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#660000}
-
Xianzhu Wang authored
Its behavior was not well-defined and the implementation was wrong in some places. The only usages were for slider thumb element through LayoutObject::AbsoluteBoundingBoxRectIgnoringTransforms(). Remove them and change the way that slider thumb element gets offset between the slider and the thumb. Change-Id: I8237778995bbf68fa68fae93ccda1441346e1f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609974 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
- We should use PhysicalLocation() instead of Location() when converting a physical rect in parent space to child space. - Added test, and comment about the false-negative (which is allowed) in vertical-rl mode. Change-Id: Ifcbf93bb3ff3fd6d88267838057a616e05f4b7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607574Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1f09898e9a8a..945d1e538c62 git log 1f09898e9a8a..945d1e538c62 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 mtklein@google.com simplify rtree loops in Skia too 2019-05-15 bungeman@google.com Add SkShaper which just shapes. 2019-05-15 bungeman@google.com Move SkMessageBus.h into src/core 2019-05-15 michaelludwig@google.com Revert "Clear and discard stencil buffers on tilers" Created with: gclient setdep -r src/third_party/skia@945d1e538c62 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Icde83fbece29b718dc593c745b438e33c46f098f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613323Reviewed-by:
-
Yun Liu authored
Bug: 843307, 961804 Change-Id: I14eb6329d84b86d655c8689249356ffa542c14c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610650 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#659996}
-
Navid Zolghadr authored
Add wpt tests to cover click targeting in the cases that down and up are child and parent. Change-Id: I2405247d8126914a48386b6bcd1a8cb8e10334df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611654Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659995}
-
Peter Kotwicz authored
This CL makes SameTaskWebApkActivity translucent. This is needed to avoid visual artifacts during launch. BUG=817263 R=dominickn TBR=yfriedman Change-Id: Ia3f132af7ed8a9db9b814e825068466c14b853e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611269 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#659994}
-
Mohamed Amir Yosef authored
Before this CL: the processor will try to commit tombstones for entities that has never been committed. After this CL: if the processor is sure that the server never heard or an entity, it will never a tombstone for it. Bug: 963365 Change-Id: Iae101094b80eb2c4d080cb92b253a2886373aedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609851 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#659993}
-
Yuwei Huang authored
This CL implements a binary that allows starting an IT2ME host from command line. This will help debugging the FTL migration process for ChromeOS enterprise. The code is mostly copied and modified from CRDHostDelegate. Bug: 962765 Change-Id: I74d5b6c49b7c55703f6d52a81aa0327456f8174e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610891 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#659992}
-
kylechar authored
Remove some usage of deprecated callback types in base/*. Where possible convert to the corresponding once type, otherwise replace with the repeating type. Also delete type-parameterized test base TaskRunnerAffinityTest since it's not instantiated anywhere. Bug: 714018 Change-Id: Ibf0a2a14a11b36db1017d0bb7e6021e51c90ba88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612254Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#659991}
-
