GitLab

Review URL: https://codereview.chromium.org/14369004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195394 0039d316-1c4b-4281-b951-d872f2087c98

1. Add the resource to chrome.exe so that omaha can use it for app commands.
2. Make extension install not prompt because the window launches behind the
current window (along with other problems) which results in a bad user experience.

Note that the only code path touched is strictly only hit by the limited install from
webstore code path.


TESTED=The unit test and tested the functionality using a test page which calls the app command.
BUG=233783

Review URL: https://chromiumcodereview.appspot.com/14381004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195393 0039d316-1c4b-4281-b951-d872f2087c98

> url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2.
> 
> To not break the buildbot, this creates a fake target that copies url_unittests
> to googleurl_unittests as temporary scaffolding.
> 
> BUG=229660
> R=brettw@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/14199009

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/14028022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195392 0039d316-1c4b-4281-b951-d872f2087c98

http://i.imgur.com/OOjPmDJ.png

Sideloaded extensions that have a webstore update URL have a global error bubble replacing the normal extension install dialog.

Still TODO:
- Making this not appear for new profiles.
- Unit tests.

BUG=229083

Review URL: https://chromiumcodereview.appspot.com/14328029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195391 0039d316-1c4b-4281-b951-d872f2087c98

handle is requested.

GLES2DecoderImpl::DoTexImageIOSurface2DCHROMIUM uses
GLContext::GetHandle's result as an argument to 
CGLTexImageIOSurface2D, which expects a valid CGLContextObj
as the handle (not NULL).

BUG=230300

Review URL: https://chromiumcodereview.appspot.com/14241007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195390 0039d316-1c4b-4281-b951-d872f2087c98

To not break the buildbot, this creates a fake target that copies url_unittests
to googleurl_unittests as temporary scaffolding.

BUG=229660
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14199009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224531

Review URL: https://chromiumcodereview.appspot.com/14199008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195388 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily adding libpeerconnection as a dependency on three test targets that fail to link on lucid32.
I'm looking into what the problems are, but in the meantime checking this in to fix the build.

BUG=231068
TBR=grunell@chromium.org

Review URL: https://codereview.chromium.org/13923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195385 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233709
TBR=hans
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195220

Review URL: https://chromiumcodereview.appspot.com/14169006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195379 0039d316-1c4b-4281-b951-d872f2087c98

to extensions that need it for release.

BUG=chromium:233718
TEST=built

Review URL: https://chromiumcodereview.appspot.com/13852050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195378 0039d316-1c4b-4281-b951-d872f2087c98

This updates PowerPolicyController to always send the power
management policy contained in Chrome's preferences to the
power manager, rather than only sending prefs that have been
changed from their defaults.  Note that this currently only
takes effect once the user has logged in.

It also makes the screen get locked at the same time as when
it's turned off when the "Require password to wake from
sleep" setting is enabled.

BUG=225730,225969

Review URL: https://codereview.chromium.org/14134004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195376 0039d316-1c4b-4281-b951-d872f2087c98

This fix sends a DeviceChanged notification to all the
BluetoothAdapter::Observer when a BluetoothDevice::Connect makes the
BluetoothDevice::IsConnecting property change.

BUG=231985
TEST=None

Review URL: https://chromiumcodereview.appspot.com/12374062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=2204

Review URL: https://chromiumcodereview.appspot.com/12886022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195374 0039d316-1c4b-4281-b951-d872f2087c98

- Search requests uses both: current cookies and OAuth2 token for device Robot Account.
- User cookies or OAuth2 used in search for operation with a printer (print, get capabilities etc.)
- Put printer accessible for Robot Account to local destination.

BUG=179229
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/14370003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195371 0039d316-1c4b-4281-b951-d872f2087c98

And, Don't stack screenshot notifications.

Changed profile handling. The profile is now retrieved everytime a screenshot is taken and
not only once in Ash init. The reason is that the profile can change, which caused this crash.

Changed behavior for a subsequent screenshot notification. It will replace the previous
notification (rather than add a new one).

When saving to Google Drive we have two path: screenshot path (used in notification) and
local path (for internal cash/work; used in writing). Add proper handling of both paths.


BUG=231707, 232876, 233574
R=jamescook@chromium.org
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/14027009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195370 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
BUG=176312
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14378007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195369 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195368 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=148734%3A148757&mode=html

TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/14378005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233149

Review URL: https://chromiumcodereview.appspot.com/14367006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195365 0039d316-1c4b-4281-b951-d872f2087c98

Fix bugs wrt focus and anchored widgets and immersive mode being disabled. See bugs below for more details.

BUG=188567, 233483
Test=ImmersiveModeControllerAshTest.*

Review URL: https://chromiumcodereview.appspot.com/13942011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195364 0039d316-1c4b-4281-b951-d872f2087c98

This CL is adding a minimize function for clicks on launcher items if only a single item (already active) is associated with it. This is done to avoid that the user clicks and nothing happens (and people expect it to do that). The feature is guarded by a flag.

If the minimize action is not wanted, we use a bouncing animation which gives the user at least some feedback that he has done something.

BUG=231663
TEST=unittest & visual

Review URL: https://chromiumcodereview.appspot.com/14328031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195362 0039d316-1c4b-4281-b951-d872f2087c98

This adds ability to serialize cc::Picture to base64 string
and to initialize the picture back from that serialization.

Review URL: https://chromiumcodereview.appspot.com/13884018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195361 0039d316-1c4b-4281-b951-d872f2087c98

This feature was broken in crrev.com/189540.

Review URL: https://codereview.chromium.org/14070016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195360 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/14373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195359 0039d316-1c4b-4281-b951-d872f2087c98

Use enabled/disabled flags as this will allow us to turn it off by default
after a branch point without changing the strings for about:flags.

BUG=233329
TEST=manual, toggle the option in about:flags, by default F4 should enter fullscreen
TBR=sky@chromium.org for trivial test expectation change in c/b/ui/browser_browsertest.cc

Review URL: https://chromiumcodereview.appspot.com/14366004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195358 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14205008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195357 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/14057020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195356 0039d316-1c4b-4281-b951-d872f2087c98

R=jar@chromium.org
Review URL: https://codereview.chromium.org/13895010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176592

Review URL: https://codereview.chromium.org/14177006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233381

Review URL: https://chromiumcodereview.appspot.com/14188045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/14362040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195352 0039d316-1c4b-4281-b951-d872f2087c98

All the necessary files, like resources.pak and ffmpegsumo.so, are already
mapping deep inside Chromium.app/. Mapping the ones in PRODUCT_DIR is useless.

Technically, Chromium.dmg could be used but it's harder to start from the
command line, and mapping each individual files permits caching modules that
haven't changed, like the resource files.

TBR=csharp@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14109022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195351 0039d316-1c4b-4281-b951-d872f2087c98

Implements the D-Bus client for the new Input1 interface currently
exporting only one property.

BUG=220553
TEST=device_unittests pass.

Review URL: https://chromiumcodereview.appspot.com/14048007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195350 0039d316-1c4b-4281-b951-d872f2087c98

This fixes "Hisilicon" GPUs, which is an instance of a
Vivante's GPU design. This involves enabling virtual
contexts, since they don't support share-groups, and further
adds a work-around for switching surfaces. Without the work-
around the view surface "inherits" the size of the last
bound surface (which for Chrome tends to be a 1x1 pbuffer)
resulting in a black screen. The following steps "repair"
the view surface every time it is made current:

- Make it current.
- Bind the default frame-buffer.
- Make it not current.
- Destroy/recreate it from the native handle.
- Make it current again.

NOTE: The "Recreate" function is added to surface because
the Destroy/Initialize may be intercepted or modified by
wrapper surface classes. Recreate is similar to resize,
which after being forwarded by a wrapper can call
Destroy/Initialize on the 'real' surface.

BUG=179250
NOTRY=true

No-try, as all the relevant bots are already green.

Review URL: https://chromiumcodereview.appspot.com/13852023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195349 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195348 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp@chromium.org
BUG=229611

Review URL: https://codereview.chromium.org/14348039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195347 0039d316-1c4b-4281-b951-d872f2087c98

If update happens with different ids, it essentially means a removal
and an add from notification_list point of view. Sending Update() will
confuse the observers.

It is possible to pass both ids for Update(), but handling update of
different ids on each observer doesn't make much sense. It will be better
to send both Removed() and Added() in this case.

BUG=233221
TEST=manually on the reported page in the bug

Review URL: https://chromiumcodereview.appspot.com/14127003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231985
TEST=device_unittests

Review URL: https://codereview.chromium.org/14199010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195345 0039d316-1c4b-4281-b951-d872f2087c98

Revert 195188 - Add interface to set the sub resource crash key from Flash

BUG=N/A
TEST=N/A

Review URL: https://chromiumcodereview.appspot.com/14311004

TBR=cdn@chromium.org
Review URL: https://codereview.chromium.org/13875006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195344 0039d316-1c4b-4281-b951-d872f2087c98