- 29 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f8df30f1ad44..b07147b04082 git log f8df30f1ad44..b07147b04082 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sugoi@google.com Provoking vertex fixes 2019-10-28 sugoi@google.com VK_EXT_provoking_vertex support 2019-10-28 jonahr@google.com Fix vulkan builds in ANGLE on MacOS 2019-10-25 sugoi@google.com Removed stencil reference from PixelProcessor::States 2019-10-25 amaiorano@google.com Fix LLVM7 partially initialized ManagedStatic 2019-10-24 sugoi@google.com Fixed using an offset in Blitter::blitFromBuffer() Created with: gclient setdep -r src/third_party/swiftshader@b07147b04082 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:1015454,chromium:b/143288278,chromium:1015904 Change-Id: I0c957affa260014664c34f0257fba3fff4bf664b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710467}
-
Johannes Henkel authored
Also we're not creating these any more via StringUtil in blink, so these two helpers can go. Change-Id: Id676e4c35bc00392166f00f645178cd17720d02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888270 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#710466}
-
Elly Fong-Jones authored
This changed during the bundle restructure but gcapi was never updated to match. Bug: 958976 Change-Id: I1a1e50823d454ba807fc352373909fdb395a8a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888110Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#710465}
-
Mohamed Heikal authored
While the check is under discussion and its documentation being improved, this check is temporarily disabled (by setting the limit to be 'over 9000' aka 100). Bug: 1012373 Change-Id: Iba21eadbdd77ddec94443b7d904959a1e324ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888372 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710464}
-
Victor Fei authored
This is a reland of 81487c55 The original change was reverted because it failed win7 bots for the following tests: DumpAccessibilityTreeTest.AccessibilityButtonNameCalc/uia DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/blink DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/win This reland fixes these test failures on win7. Original change's description: > Exposing button's children internally and to AT > > The motivation behind this change is that we want text pattern APIs to > access the text content of both native buttons and ARIA role=button. > In order to achieve the above, we need to be able to serialize button > element's children to AXTree. This change enables all children of button > to be exposed in the AXTree. > > Additionally, if the button's children are text only and also exposed > in the Browser Accessibility tree, screen readers may double speak the > button's name. To prevent this, if button's only child is a static text > we mark the button Browser A11y node as leaf. > > On Android, we treat all its Browser A11y button nodes as leaves and > expose no child. > > Summary: > -------------------------------------------------------------------- > BEFORE: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[N],BATree[N] | AXTree[N],BATree[N] > BATreeAndroid[N] | BATreeAndroid[N] > > complex children: AXTree[N],BATree[N] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[Y] > -------------------------------------------------------------------- > AFTER: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[Y],BATree[N], | AXTree[Y],BATree[N], > BATreeAndroid[N] | BATreeAndroid[N] > > multiple children: AXTree[Y],BATree[Y] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[N] > -------------------------------------------------------------------- > > Note: > According to the ARIA spec (below), the children of role=button are > presentational, which means they should not be exposed to ATs > (a.k.a. should all be treated as leaf nodes). > However, we need the button contents to be exposed sometimes because > they may contain many rich, interactive descendants such as buttons > inside a calendar popup and screen readers need to interact with these > contents (See https://crbug.com/689204). > > Additionally, Firefox also expose the children of both native button and > role=button. > Due to the above, we decided to departure from the ARIA spec and not > enforce the leafiness of buttons. > > ARIA && core-aam specs: > https://w3c.github.io/aria/#button > https://www.w3.org/TR/core-aam-1.1/#exclude_elements > > ~~~~~~ > Note: > The actual functional changes are in the two files below, the rest are > tests: > content/browser/accessibility/browser_accessibility.cc > content/browser/accessibility/browser_accessibility_android.cc > third_party/blink/renderer/modules/accessibility/ax_node_object.cc > ~~~~~~ > > Bug:1013609 > > Change-Id: Ia7c4bac9940b34dd3a3122938057cb48e847b76a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845810 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709728} Bug: 1013609 Change-Id: I088fac4c42a9c95ddee16e40f28f0154da1a9f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883619Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710463}
-
Asanka Herath authored
This CL does a few things: * Moves the ftp feature flag from //chrome to //content. There are a few places in //content that assume the network service supports FTP despite //content never configuring it to be so. Rather than replumb these code paths I've elected to move the switch down to //content. Once FTP is deprecated, these code paths will disappear. * Updates content::IsURLHandledByNetworkService() to only return true for FTP if the FTP feature is enabled. * Updates ProfileIOData::IsHandledProtocol() to only return true for FTP if the FTP feature is enabled. Unlike content::IsURLHandledByNetworkService(), this function doesn't affect how navigations work, but rather informs other subsystems about whether a URL is likely to be handled by the renderer or not. * Adds the "enable-ftp" flag to about:flags. This will allow users to (temporarily) enable FTP during the turn-down period. * Tests all of the above via //chrome/browser/net/ftp_browsertests. Bug: 333943 Change-Id: Idf90cf6332637c92b41036d80815dd20e37ffad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860934 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#710462}
-
Carlos IL authored
The code in this CL does not include handling user interaction with the interstitials, so they will be displayed, but will not react to commands. Bindings for commands will be added in a follow up CL. Bug: 1016581 Change-Id: I7817205e6f48b0380e8e15a3faa9b8d134028624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872945Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#710461}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: I72ec694120fa8443396fd317771560c8f922a4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884460Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710460}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/94885526dc61..882b743a85b7 git log 94885526dc61..882b743a85b7 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 seanabraham@chromium.org chromeos_config: make tatl and tael experimental 2019-10-29 saklein@chromium.org service/sdk: Add chroot size check. 2019-10-29 manojgupta@google.com cros_fuzz: Don't error on missing corpus directory. 2019-10-29 tcwang@google.com afdo: Fix bug that afdo builders check wrong artifact name. 2019-10-28 dtor@chromium.org Add -kvm as another suffix to non-unibuild board list 2019-10-28 richardfung@google.com Remove betty-arcnext 2019-10-28 mmortensen@google.com Add api/controller unit tests and mock responses for GetChromeVersion. Created with: gclient setdep -r src/third_party/chromite@882b743a85b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8fc5d3d5fa78b1d353c3d6b176e109840522a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888052Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15b40236bd8b..b69001f36f76 git log 15b40236bd8b..b69001f36f76 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 robertphillips@google.com Make GrFillRectOp and GrTextureOp consistent re AA-upgrading and size checks 2019-10-29 egdaniel@google.com Cache simple descriptor sets on GrVkTexture. 2019-10-29 kjlubick@google.com [canvaskit] Add tentative support for savelayerrec 2019-10-29 egdaniel@google.com Use GrSurfaceProxyView in RenderTasks. Created with: gclient setdep -r src/third_party/skia@b69001f36f76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: I33cc5b7b5c1eb50d11c43cca5b3b1da92be2527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888053Reviewed-by:
-
Jon Mann authored
When navigating through the network list in quick settings, announce the connection status of the highlighted network when available. Bug: 1006005 Change-Id: Ib2a640af72742817118dea76e2b210e12180bff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879435 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710457}
-
Vladimir Levin authored
This patch makes the following changes: - Renames content-size to intrinsic-size following the new spec draft: https://drafts.csswg.org/css-sizing-4/#intrinsic-size-override - Implements new functionality to apply even if size containment is not present - Updates tests / implements new tests for the new functionality. This patch is the first step to implement intrinsic-size. Follow-up here is to write more tests for flex/grid and other algorithms, and ensure they work correctly. I2I (under content-size): https://groups.google.com/a/chromium.org/d/msg/blink-dev/RMCpsWaqds0/_H9hTQ5tAgAJ R=chrishtr@chromium.org, cbiesinger@chromium.org, futhark@chromium.org, ikilpatrick@chromium.org Bug: 991096 Change-Id: I407d4d1e50df04d493416321f81da7138d97b35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867043 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#710456}
-
Reilly Grant authored
Waiting for stream closure before closing a port can be tricky if the streams are being piped through transforms. This change adds tests demonstrating how this is expected to work. Bug: 893334 Change-Id: I84309034c6120bb8513b75dc6754ecb77b1dc35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879437Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710455}
-
Jan Wilken Dörrie authored
This change reduces string copies in base::HistogramTester by changing its APIs to take base::StringPieces instead of const std::string&. The majority of callsites pass string literals to the HistogramTester APIs, resulting in a deep copy with the old implementation. Furthermore, this change updates the underlying std::maps to use the heterogeneous std::less<> comparator, allowing the direct comparison of base::StringPiece with std::string. Bug: 384011 Change-Id: I6a8dd3e76280162b6046eac63a3d1ac84ed2ee6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887612Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#710454}
-
Chris Hamilton authored
This aggregates frame priorities and uses them to infer process priorities. Once workers are hooked up we will add worker priorities to this logic. BUG=971272 Change-Id: I421613de9a30caf9fed8a7db394273220c97e344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880008 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710453}
-
Avery Musbach authored
OverviewWindowDragController::GetSnapPosition uses the split view divider position as though it is relative to the whole screen. It is actually relative to the work area. Test: ash_unittests SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.Dragging Bug: 1019219 Change-Id: I8530e53f70f5b5c62c5c4cbedd078abd835ceb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887653Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#710452}
-
Tommy Steimel authored
This reverts commit 75651994. Reason for revert: Suspected cause of ios compile failures: https://ci.chromium.org/p/chromium/builders/ci/ios-device/139770 Original change's description: > Introduce DataDecoder API > > This provides a new DataDecoder API in the data_decoder client library, > allowing for clients to use the service for isolated and batched > operations without any dependency on the Service Manager or the > cumbersome usage of batch IDs. > > Only JSON parsing facilities are added to DataDecoder in this CL. > > The JsonSanitizer API is cleaned up a bit too, as is some test code. > > Bug: 977637 > Change-Id: I5798982a500a403ddb345ab40db35d466dc6b7fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879792 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710438} TBR=avi@chromium.org,rockot@google.com,blundell@chromium.org,sorin@chromium.org,rsesek@chromium.org Change-Id: I6c7d890c5ce7abea1d80b26a85c867e72bab32d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888739Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#710451}
-
Austin Eng authored
This reverts commit 32cfad60. Reason for revert: Suspect causing deqp/functional/gles3/framebufferblit/conversion_29.html and deqp/functional/gles3/framebufferblit/conversion_33.html to fail webgl2_conformance_gl_passthrough_tests Original change's description: > Merge WEBGL_multi_draw_instanced into WEBGL_multi_draw > > The WebGL working group decided there is enough WebGL 1 support for > instancing that it would be simpler to only expose the instanced > version of the extension. > > This also rolls WebGL 2701c13..69e333c which includes the spec and > conformance test changes. > > Bug: chromium:890539 > Change-Id: Ib4dccf56f488cedf8161268ac3467d27c9b371c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881712 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710310} TBR=dcheng@chromium.org,kbr@chromium.org,enga@chromium.org Change-Id: If3d20cc176ecc1404ba4acbdfff481a4ae9adbb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:890539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888184Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#710450}
-
Michael Lippautz authored
- Allow TraceWrapperV8Reference in HeapVector (previously, the test would not compile) - Fix usage of TraceWrapperV8Reference in ephemerons Change-Id: I1430307a5c8692a7fa38fd4857be391c2a243a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886857 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710449}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d50a9c98..c165bf48 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iea14f847bad5df0d1ef21300da287398fe3107ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887371Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710448}
-
Megan Jablonski authored
Additionally, fix the width of the language dropdown. https://drive.google.com/file/d/1xaTNVnz2RvUnleI4w_06tgMTdC2AY52v/view?usp=sharing https://drive.google.com/file/d/1wCPdx1dWUsiU5LVz8M4tLssGgBxSdQX9/view?usp=sharing Bug: 1017490 Change-Id: I780ccbcdbeae91edd8ba5e3643ffcec6107c4262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877658Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#710447}
-
evliu authored
Bug: 997813 Change-Id: Iaaa4aa2527d9a0f8e76cef84e17b0f1273f045ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884365 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710446}
-
David Grogan authored
Bug: 845235 Change-Id: I12097a71dbebd03effe45883cf354597d380dd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881982Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710445}
-
Henrique Nakashima authored
This call happens rarely (1/60000), but it causes a crash when it does. Change-Id: I0d584f0cd4017252ab80fc23fe0a41124bd13c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880705Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710444}
-
Yi Gu authored
Some tests relied on time equality which could be flaky because internally the time value is converted to base::TimeTicks. Bug: 1014810 Change-Id: I9530f087c1273907af653f0d81f75569572d2e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886293Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710443}
-
Ken MacKay authored
Change-Id: I72e4845177d9c7c41b3c2ebd04c00ef34807976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887832Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#710442}
-
Christian Dullweber authored
To simplify the UI, we remove the omnibox icon when third-party cookie blocking is on but no cookies have been blocked. This is similar to how the old cookies blocked icon worked. Bug: 1019131 Change-Id: Id755ddcd10976d22cbcc67de18725382ab9eee78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886862 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710441}
-
Nasko Oskov authored
Unfortunately, the WebUIReuseInSubframe test is running into issues with the memory allocator returning separate instances of WebUI objects at the exact same memory address. This means that even though we have different instances of the object, which is what the test aims to assert it isn't possible to use pointer inequality as the assertion. I've modified the test to use the RenderFrameHost global routing id since one cannot have the same WebUI instance be owned by more than one RenderFrameHost instance. Bug: 713313, 1002276 Change-Id: Iea036b5cd10962c75f86a5b25d9f655012caf686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886292Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#710440}
-
dpapad authored
CL produced with ESLint --fix and clang-format. This is in preparation for turning on no-var and prefer-const ESLint checks for that folder. Bug: 720034 Change-Id: I6467d1308118f67f076708612247852568fba2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885652 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710439}
-
Ken Rockot authored
This provides a new DataDecoder API in the data_decoder client library, allowing for clients to use the service for isolated and batched operations without any dependency on the Service Manager or the cumbersome usage of batch IDs. Only JSON parsing facilities are added to DataDecoder in this CL. The JsonSanitizer API is cleaned up a bit too, as is some test code. Bug: 977637 Change-Id: I5798982a500a403ddb345ab40db35d466dc6b7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879792Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710438}
-
Alex Gough authored
This copies policy rule opcodes when snapshotting policies, and serializes them for display in chrome://sandbox's raw view. Example rule: "NtQueryAttributesFile": [ "!(p[1] & 1) && !(prefix(p[0], '\\??\\')) -> askBroker", "!(p[1] & 1) && scan(p[0], '~') -> askBroker", "prefix_i(p[0], '\\??\\pipe\\chrome.') -> askBroker", "prefix_i(p[0], '\\??\\C:\\src\\chromium\\src\\out\\release-x86\\') && ends_i(p[0], '.pdb') -> askBroker" ], Bug: 997273 Change-Id: I54f82b0a9523fa1ed94cecf982f2b25203ae7351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872304 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710437}
-
Clark DuVall authored
the backing string was getting destroyed too early. base: :FeatureList::SplitFeatureListString takes in a StringPiece, and Change-Id: Id054a40451031bc41cbae3d4caa95f25568d0011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887830Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710436}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/918853e6112f..0e87f1419824 git log 918853e6112f..0e87f1419824 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 bsheedy@chromium.org Revert "Deduplicate desktop/CrOS minidump code" 2019-10-29 khokhlov@google.com [Telemetry] Update intermediate file format Created with: gclient setdep -r src/third_party/catapult@0e87f1419824 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:994274,chromium:1018248 Change-Id: I5381b039fd4c3cbfe35c44ae135eff41752f4b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888051Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 79-3904.41-1571046112-benchmark-79.0.3940.0-r1 to 80-3931.2-1572259441-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I64047232b0703769b3335b1d3fabe6a473a58f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887682Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 79-3928.0-1571049528-benchmark-79.0.3940.0-r1 to 80-3940.0-1572255699-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ie14ea4e9aab90f13b61794582e02eff9c6fd90fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887680Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 79-3931.2-1571054549-benchmark-79.0.3940.0-r1 to 80-3940.0-1572260209-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I2dee2448a6264d052e677b11c0b0730b9068903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887681Reviewed-by:
-
David Van Cleve authored
This change extends the DNS host cache to store responses to ESNI queries: - adds a new member of type EsniContent and corresponding accessor - adds serialization and deserialization routines R=ericorth Test: expands HostCache's merging and serialization tests Bug: 1003494 Change-Id: I4977d4f12b2253e5895c36e0a86429f6074d9cbd Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865611Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710431}
-
Asanka Herath authored
There already existed http_auth_handler_ntlm_{portable,win}.cc. And yet there was platform specific code in http_auth_handler_ntlm.cc along with lots of preprocessor directives. This CL cleans out the rest of http_auth_handler_ntlm.cc so that that file only contains cross platform code. No changes in behavior. This CL just moves code around. R: mmenke@chromium.org Bug: 927182 Change-Id: I25e20a658ad4fa46e1e9929f992bad2dcbb6dd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881323 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by: -
Juan Antonio Navarro Perez authored
Tweak URLs to match their latest form as used by LUCI builders. Also rename "buildbot_url" to the more generic "builder_url", as buildbot is not related to these any more. Bug: 958739 Change-Id: Ie8a8889b78b36962c19698d776fafb6f5c1b18db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886673 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#710429}
-
Daniel Rubery authored
Add a few metrics to the BinaryFCMService just to detect that it behaves generally as expected when launched. Bug: 1018226 Change-Id: I8ff23455fadbe1808d1bb1dbf3cb8c97c39dd9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880704 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#710428}
-
