- 03 Oct, 2017 5 commits
-
-
Devlin Cronin authored
Bug: None Change-Id: Ifc8bcd58f5f65af62dbf38226f360ef6b2a94ee9 Reviewed-on: https://chromium-review.googlesource.com/695003Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505866}
-
Tom Sepez authored
Currently, these live in .grd resource files, which won't be available under the service manager. Putting these into the binary has the added benefit that they may be harder to tamper with. A subsequent patch will move the mac sandbox content/common stuff to service manager, cleaning up some of the DEPS. Change-Id: I22473e63f762a55a0e9f99b6d5d66186ed84da7c Reviewed-on: https://chromium-review.googlesource.com/693287 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505865}
-
Matt Mueller authored
(This is the format used by der2ascii and ascii2der.) Bug: Change-Id: I025281f85a5953e69c3485da554be514aaa7b47f Reviewed-on: https://chromium-review.googlesource.com/693348 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505864}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 666525 Change-Id: I233ff68af8f61aebb07aaed58fbe2c197b970322 Reviewed-on: https://chromium-review.googlesource.com/689136Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505863}
-
dpapad authored
Bug: 769568, 769567 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I80710e77d7568acbfb28f402dea4bcd20c07d972 Reviewed-on: https://chromium-review.googlesource.com/691047 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505862}
-
- 02 Oct, 2017 35 commits
-
-
Stephen Martinis authored
The story seems to be failing, so disabling it on mac for now. TBR=rnephew Bug: 770904 Change-Id: I5516cd57f726361e09ac976fdc32da1bd87abcfa Reviewed-on: https://chromium-review.googlesource.com/696283Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#505861}
-
Devlin Cronin authored
webkit_layout_tests failing on Win7 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56163 TBR=mkwst@chromium.org Bug: 770971 Notry: True Change-Id: I35034ffbbd1a0d727920855544b8d8519895156d Reviewed-on: https://chromium-review.googlesource.com/696131Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505860}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 666525 Change-Id: I168b6fe1b435c1df42affb65266a9e1099d4cb90 Reviewed-on: https://chromium-review.googlesource.com/688171Reviewed-by:
-
Tommy Steimel authored
Bug: 768924 Change-Id: I1136888cf78b4fcec7bc357eb494ed83946d9f0f Reviewed-on: https://chromium-review.googlesource.com/696035Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#505858}
-
erikchen authored
Chrome now requires Xcode 8, macOS 10.12, and 10.12 SDK. Bug: 669240 Change-Id: I71b0f4238ac3b7baa657bb469480c1a17eaf1e77 Reviewed-on: https://chromium-review.googlesource.com/696291Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505857}
-
Min Qin authored
HttpUtils is looking for "\n\n" and "\n\r\n" as the end of the header. So if the headers are already ending with "\n\n", we shouldn't append "\r\n" to it. Otherwise, the appended "\r\n" will be treated as the body BUG=715630 Change-Id: Ia087f3ec7f7644c088635f375782841f2c6a32d0 Reviewed-on: https://chromium-review.googlesource.com/693323Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505856}
-
Mitsuru Oshima authored
BUG=None Change-Id: I8d0d23a9947b5e4eb56ba02e16c1561076276f08 Reviewed-on: https://chromium-review.googlesource.com/695747Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#505855}
-
Yuke Liao authored
This CL makes the paths in the code coverage html report relative so that the reports are portable. Bug: 757515 Change-Id: I5685437a4b946ec30c3fcab17fa3bb5ddeb7c744 Reviewed-on: https://chromium-review.googlesource.com/696294Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505854}
-
Benjamin Pastene authored
From 30m to 40m. It's hovering pretty close to 30 min currently: https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=user&c=bot&c=duration&et=1506978420000&f=buildername%3AKitKat%20Tablet%20Tester&f=name%3Achrome_public_test_apk&l=50&n=true&q=dura&s=created_ts%3Adesc&st=1506892020000 R=dpranke@chromium.org Bug: Change-Id: I6c050bdb6ca5a8528b132de5bdaad98ab6aeadbd Reviewed-on: https://chromium-review.googlesource.com/695837Reviewed-by:
-
Yuwei Huang authored
* Changes the accessibility focus order to Cancel button->PIN input-> Pairing switch->Continue button. * Makes the status label the default focus instead of the cancel button. Bug: 770841 Change-Id: I02f0261a7b20da71485dacb4f7a09506fc09976b Reviewed-on: https://chromium-review.googlesource.com/695838Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#505852}
-
Ian Vollick authored
With this CL we start to track our progress through the frame lifecycle in order to check that we don't use values that are stale or invalid. Bug: 770401 Change-Id: I50ffc569a6baeae9d0d43e2ed0b84b7a5b701cc0 Reviewed-on: https://chromium-review.googlesource.com/693226 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#505851}
-
David Benjamin authored
Converting Latin-1 to UTF-8 is reasonably straightforward. Note this converts actual Latin-1, not CP-1252, so a text expectation had to be fixed. Based on the test, my impression is the pre-use_byte_certs code treated TeletexString as Latin-1, not CP-1252, so this should be fine? Bug: none Change-Id: Ida9d3439536bbd742ba9814f19b753b5ede067b3 Reviewed-on: https://chromium-review.googlesource.com/693090Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#505850}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d4b32ba384da..b30d11319bac $ git log d4b32ba38..b30d11319 --date=short --no-merges --format='%ad %ae %s' 2017-10-02 scroggo Do not try to time kFailedLoops 2017-10-02 csmartdalton CCPR: Add WAR for an Intel GLSL compiler assertion 2017-10-02 robertphillips Temporarily disable deferred texture proxies Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ie66aefeaf17a15d95acd5f786ae3cea8e017aea7 Reviewed-on: https://chromium-review.googlesource.com/695936Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505849}
-
Yuke Liao authored
The code coverage script fails when top level directory is the source root('.'), and this CL fixes it. Bug: 757515 Change-Id: I965cf24d4d2b71227657e490c97a7c76de41439f Reviewed-on: https://chromium-review.googlesource.com/695828Reviewed-by: -
Yuzhu Shen authored
This CL reverts commits - d01fe371. - 5fc67636. The memory corruption should be fixed by https://chromium-review.googlesource.com/688035 Bug=750267, 754946 TBR=rockot@chromium.org Change-Id: I8474a5d9f85c2a552cbaac74771aea9ff9e43faa Reviewed-on: https://chromium-review.googlesource.com/695831Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
-
Eric Karl authored
Currently, both Chrome and Skia maintain independent blacklists for MSAA on certain GPUs. When Chrome believes MSAA is available and Skia believes it is not, we can end up with rendering glitches, as Skia will be given an MSAA buffer to use, and it will believe it cannot raster into it. This change reads the MSAA status from Skia and only enables MSAA in Chrome if Skia also believes MSAA is available. Bug: 751919 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8e119aab1cf9459013c300137c6aa2179528feb Reviewed-on: https://chromium-review.googlesource.com/629897Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#505846}
-
Nathan Bruer authored
For code health removes @unrestricted closure doc from NetworkConfigView.js. R=dgozman,luoe,einbinder BUG=None Change-Id: Ia7ffd3260602fc892e5a16df44642cab7fc1975e Reviewed-on: https://chromium-review.googlesource.com/691188 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#505845}
-
Catherine Mullings authored
Refactor checks of whether a menu item id is an extension custom id or not. The static ContextMenuMatcher::IsExtensionsCustomCommandId() function is used instead. Bug: 765829 Change-Id: I2143e9449beb82a2e6580d82e86055b83c6ca41c Reviewed-on: https://chromium-review.googlesource.com/695718Reviewed-by:
-
Devlin authored
This reverts commit fa1f0b26. Reason for revert: Looks to have broken the build. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Mac%2F26445%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout In file included from ../../sandbox/mac/mojom/seatbelt_extension_token_struct_traits.cc:5: ../../sandbox/mac/mojom/seatbelt_extension_token_struct_traits.h:10:10: fatal error: 'sandbox/mac/mojom/seatbelt_extension_token.mojom-shared.h' file not found #include "sandbox/mac/mojom/seatbelt_extension_token.mojom-shared.h" Original change's description: > Create sandbox::SeatbeltExtension to dynamically expand the Mac sandbox policy. > > Sandbox policy extensions can be issued for resources in a trusted process, > which generates a token that may be passed over Mojo IPC. The receiving process > can then consume the token to be granted access to the resource. Currently only > file-read extensions are permitted. > > Bug: 510604 > Change-Id: Iaa92c48c120e051c5df72602d09329ebe84ea317 > Reviewed-on: https://chromium-review.googlesource.com/685583 > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Justin Schuh <jschuh@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Justin Schuh <jschuh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505819} TBR=jschuh@chromium.org,rockot@chromium.org,kerrnel@chromium.org,rsesek@chromium.org Change-Id: Ic0fc32e651db586169ecd127c1674cd8dc205915 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 510604 Reviewed-on: https://chromium-review.googlesource.com/696343Reviewed-by:
-
Kenneth Russell authored
BUG=763260 TBR=ccameron@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic487862b1da9406c2d38947b9f9826631c18c63d Reviewed-on: https://chromium-review.googlesource.com/692997 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505842}
-
Thomas Anderson authored
This reverts commit fa1f0b26. Reason for revert: Causing build failure on Mac official builder: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Mac%2F26445%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Create sandbox::SeatbeltExtension to dynamically expand the Mac sandbox policy. > > Sandbox policy extensions can be issued for resources in a trusted process, > which generates a token that may be passed over Mojo IPC. The receiving process > can then consume the token to be granted access to the resource. Currently only > file-read extensions are permitted. > > Bug: 510604 > Change-Id: Iaa92c48c120e051c5df72602d09329ebe84ea317 > Reviewed-on: https://chromium-review.googlesource.com/685583 > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Justin Schuh <jschuh@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Justin Schuh <jschuh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505819} TBR=jschuh@chromium.org,rockot@chromium.org,kerrnel@chromium.org,rsesek@chromium.org Change-Id: I943e64875b7d83d61d85ad3f4626d8abdc44e553 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 510604 Reviewed-on: https://chromium-review.googlesource.com/696302Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#505841}
-
Erik Chen authored
This CL has consists of several small changes: * The browser process now asks the profiling service to dump all profiled processes. Previously, the browser process was incorrectly iterating through all processes on the system and requesting dumps. * The profiling service now only requests a single global vm_regions dump from the memory_instrumentation interface. * The browser process now emits the results with the correct dump guid and pid. Bug: 769579 Change-Id: I67778d806729df1fe7c2d82a27a2cf4cf6b62745 Reviewed-on: https://chromium-review.googlesource.com/688717 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505840}
-
Will Chen authored
Because legacy audits is deprecated and has very low usage, we should make it a remote module to slim down Chrome's binary size. Bug: 717085 Change-Id: I9e79912853a1340f059b8787d53de36b3f2343ad Reviewed-on: https://chromium-review.googlesource.com/692991 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
-
Eric Willigers authored
The test has sometimes been timing out. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fanimations%2Fresponsive%2Fzoom-responsive-transform-animation.html BUG=750549 Change-Id: I66df550c126985f597ab391b16dd8f217f6955bc Reviewed-on: https://chromium-review.googlesource.com/695421 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505838}
-
Lucas Garron authored
Bug: b/67038254 (Google-internal) Change-Id: Id26940af69e8d56b0f4740ef447226d29b2368ef TBR: palmer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/695935Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#505837}
-
Lei Zhang authored
- Always overwrites the destination, if it is a file. - Does not touch destination permissions when overwriting. - On POSIX, preserves and follows destinations that are symlinks. - On POSIX, file permissions for the destination is platform dependent. Then document these in the header, since these details may be important to the caller. Change-Id: Ibd47fa95aac29a35d798e5c19d1da1a64df63754 Reviewed-on: https://chromium-review.googlesource.com/686001 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Tom Anderson authored
The only functional changes are on RPM: * Removed zlib dependency. The package only provides libz.so, and none of our binaries link against that. * Added ca-certificates dependency. It is now available on all supported RPM-based distros. BUG=750947 R=thestig@chromium.org TEST=install on minimum supported distros Change-Id: I87555ed26e5fb44630b8fbfcaf049a21e093fa9c Reviewed-on: https://chromium-review.googlesource.com/691300Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#505835}
-
Justin Schuh authored
R=rsesek@chromium.org Change-Id: I32957da792c6a3ab6820edae373fdd9917328e1a Reviewed-on: https://chromium-review.googlesource.com/696036Reviewed-by:
-
sczs authored
Creates a ToolbarCoordinator which is now the public interface of ToolbarController for BVC. Makes ToolbarCoordinator the IncognitoViewControllerDelegate for NTP instead of BVC. Bug: Change-Id: Ie46c5bf50892b46aa04c370dbc9acf3328a26bcc Reviewed-on: https://chromium-review.googlesource.com/691048Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#505833}
-
Yuri Wiitala authored
In a soon-upcoming change, GLRenderer will want more fine-grained control over the read-back process. Therefore, this change splits the impl that reads-back RGBA textures as Y+U+V planes in system memory: It introduces a I420Converter, which is just the impl that converts RGBA textures into Y+U+V textures. Then, the existing ReadbackYUV retains its full functionality, but now uses I420Converter for the everything that happens before the read-back. Testing note: All new/changed code is implicitly tested by existing unit tests because ReadbackYUV depends on the new I420Converter. :) Bug: 760351 Change-Id: I9cea7f110b1eb415b8b7e72d66b24391447978d8 Reviewed-on: https://chromium-review.googlesource.com/693381 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#505832}
-
Elliot Glaysher authored
Bug: 769098, 756046 Change-Id: I134d37276c02e38f38e9d3677683912dbceb7b39 Reviewed-on: https://chromium-review.googlesource.com/688475 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
chrome://flagsJoy Ming authored
Add flag in chrome://flags that allows the turning on and off of downloads a foreground service for all versions of Android. Bug: 747563 Change-Id: I27a0495c93560f0a8915162228b9d51d5420e060 Reviewed-on: https://chromium-review.googlesource.com/679607 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505830}
-
Eric Willigers authored
The tests have flaked recently because transition end events were not received within a second of the expected time. We now allow 3 seconds (instead of 1) before the tests give up and report failure. Note that in the common case, the events are received almost immediately after the transitions complete, and the tests finish without waiting for the timeout. BUG=769879 Change-Id: I1b28cc0f1b9f29b0cb4b47f9a59b97af2213ebed Reviewed-on: https://chromium-review.googlesource.com/694702Reviewed-by:
Walter Korman <wkorman@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#505829}
-
Shubhie Panicker authored
Add usecounter for counting occurences of XHR within page dismissal (unload path) and histogram to see the distribution across callbacks (unload, pagehide etc) Bug: 764104 Change-Id: Ic7ea74c5b79e35cee3935e3697f539ea668980d0 Reviewed-on: https://chromium-review.googlesource.com/668140 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#505828}
-
Conley Owens authored
We currently have one `console.log` in bluetooth-helpers.js. This isn't strictly needed and it's also disallowed by the presubmit check for wpt/. This change also rejects unexpected messages from iframes in getHealthThermometerDeviceWithServicesDiscovered. BUG=509038 Change-Id: I06dceb20ada4b0123ed7a4af3e25641fc019a338 Reviewed-on: https://chromium-review.googlesource.com/691414Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#505827}
-
