- 25 May, 2018 40 commits
-
-
Hans Wennborg authored
This reverts commit 864136ef. Reason for revert: While it seems this did trigger the cdb failures in crbug.com/846313, it was not the root cause and reverting it didn't actually help. Original change's description: > Revert "Fixed SDK lookup for non C:\ Windows installation." > > This reverts commit 57fd44c7. > > Reason for revert: suspect for messing up symbols on Win7 bot > @ crbug.com/846313 > > Original change's description: > > Fixed SDK lookup for non C:\ Windows installation. > > > > Bug: None > > Change-Id: Ia0aa186d1d39b1beac8ce0152683f774ad5d2eaf > > Reviewed-on: https://chromium-review.googlesource.com/1066065 > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#561063} > > TBR=jochen@chromium.org,yura.yaroshevich@gmail.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 846313 > Change-Id: Id93a965aea5555961c539d47e05e79410894eff8 > Reviewed-on: https://chromium-review.googlesource.com/1072307 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561609} TBR=gab@chromium.org,jochen@chromium.org,yura.yaroshevich@gmail.com Bug: 846313 Change-Id: I9955a47bbe8a81a0dcf7befebfc422560f8a1cc4 Reviewed-on: https://chromium-review.googlesource.com/1073314Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561873}
-
Tim Schumann authored
Today, there's already a race when registering a preference through the mojo preference service: the asynchronous registration call might be slower than starting sync. As more services are being implemented, those scenarios are getting more likely -- especially as services could be started at arbitrary times. Before this path, the synced preferences implementation did not support this scenario. This patch changes the synced preference implementation to receive and persist remote data for preferences before they get registered. Currently, this only applies for a whitelisted set of preferences. More details about the approach can be found in the design doc linked from the crbug/840332. Bug: 840332 Change-Id: I90f046d7b59098a303e7b92350cc29e5de9cc244 Reviewed-on: https://chromium-review.googlesource.com/1064750 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561872}
-
Jeremy Roman authored
blink::ResetPluginCache, called by content/, currently tries to refresh the browser plugin cache as well, but content/ also blocks this from happening. We can simplify by simply not making this call in that case. Change-Id: Ib61db31ab03a481ea9b7c485df03af384e177637 Bug: 846722 Reviewed-on: https://chromium-review.googlesource.com/1072499 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561871}
-
Christos Froussios authored
When a credential is used for the first time, we upload a FIRST_USE crowdsourcing vote, voting the fields as USERNAME and PASSWORD, even if the use results in a new password value being saved. This was to be resilient against cases where the password manager saves the wrong password in the original form. However, it is semantically incorrect, both in the above case and also when applied to change-password forms. We change the vote so that we don't upload a vote for the password field. This does not apply to usernames, because a new username is treated as a new credential. In the case where we add a username to an old credential, we keep setting the KNOWN_VALUE flag, because this event only happens as a correction and doesn't say something different about the field. Also, the fact that the user accepted the prompt is a strong indication that the field contains a proper username. Bug: 840384 Change-Id: Iff20a022abc50a4dab2f32f46e13e33621eb6129 Reviewed-on: https://chromium-review.googlesource.com/1071523 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#561870}
-
Hans Wennborg authored
cdb is currently broken. Make the test pass by skipping the cdb invocation until it's fixed. TBR=mkwst Bug: 846313 Change-Id: I2db6460b72d4cf5e81b0c9e590ab10ea5b9241a0 Reviewed-on: https://chromium-review.googlesource.com/1072648 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#561869}
-
Olga Sharonova authored
This reverts commit 82e2a47a. Reason for revert: Suspected of causing OAuth2Test.SetInvalidTokenStatus failure in https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5838 Original change's description: > [signin] Remove usage of AuthErrorProvider from tests (2) > > Going forward the default API for interacting with authentication error > should be the token service rather than the SigninErrorController. > This CL updates tests to use the token service instead of > AuthErrorProvider to set authentication errors. > > Bug: 836212 > Change-Id: I9b5629bad7b17b6cab70978cc23bbc828bf62d61 > Reviewed-on: https://chromium-review.googlesource.com/1016904 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561830} TBR=stevenjb@chromium.org,droger@chromium.org,msarda@chromium.org Change-Id: I5fe286175add827a626413ea1bee442fbfd4f258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836212 Reviewed-on: https://chromium-review.googlesource.com/1073457Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561868}
-
Gabriel Charette authored
This is a reland of 20a5f39c Patch set 1 is the original change. Diff fixes the following compile error on official builders : ../../base/files/file_util_unittest.cc:3674:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] ::write(::fileno(output_file.get()), content.c_str(), content.length()); Original change's description: > [FileUtil] Test thread-safety of temp file APIs. > > Ruling out https://crbug.com/826408#c17 as the source of the issue. > > R=thestig@chromium.org > > Bug: 826408 > Change-Id: I00396084d674fa2f700eb917300280b6eed1684d > Reviewed-on: https://chromium-review.googlesource.com/1072030 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561666} TBR=thestig@chromium.org Bug: 826408 Change-Id: Ifa37f12e708357fe7e6ce7a2dd688eab1e0a2324 Reviewed-on: https://chromium-review.googlesource.com/1073090Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561867}
-
Xi Han authored
Currently, the ServiceManagerContext uses the BrowserThread::IO to start the ServiceManager. We want to create the ServiceManagerContext earlier and start the ServiceManager in the thread that hasn't prompted to BrowserThread::IO yet. In this CL, a task runner is explictly passed to the constructor of the ServiceManagerContext to remove the dependency of BrowserThread::IO. Bug: 729596 Change-Id: I948d6bbd7e5623dbc5c08552ba2b80505e403e67 Reviewed-on: https://chromium-review.googlesource.com/1055757 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#561866}
-
arthursonzogni authored
- Removes unused things like <div id="log"></div>. It probably made sense at some point, but no more after the semi-automatic conversion to a WPT test. - Use more meaningful names. - Group elements (iframes/embed/objects) by tests. Bug: 831155 Change-Id: I7bb36132bb3e6be0fc952f4d2d7c1edb847878c1 Reviewed-on: https://chromium-review.googlesource.com/1069089 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561865}
-
Morten Stenshorne authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I579692440fb153d7886e37482410e1c0ecde9e94 Reviewed-on: https://chromium-review.googlesource.com/1073285Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561864}
-
Ria Jiang authored
WebViewInteractiveTest.KeyboardFocusSimple flakily times out on some Windows test bots. Bug: 846695 Change-Id: Ia15a0244b2857d1b58d74c6f3dd86cc621f02105 Reviewed-on: https://chromium-review.googlesource.com/1073111Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561863}
-
jonross authored
A series of tests within RenderWidgetHostViewAuraTest and RenderWidgetHostViewAuraSurfaceSynchronizationTest are failing on Viz. However they are actually obsolete once Viz is the default. This disables them and adds a note for me to remove them once Viz is on by default TEST=RenderWidgetHostViewAuraTest, RenderWidgetHostViewAuraSurfaceSynchronizationTest Bug: 795400 Change-Id: Ia23cc1758b6010e475dd62a7bc51a62b78a65582 Reviewed-on: https://chromium-review.googlesource.com/1070312 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561862}
-
Daniel Bratell authored
In jumbo build experiments all the kFirstTag variables ended up in the same translation unit and prevented compilation. This patch retires those variables, and also renames an enum that had got a copy-paste name. Bug: 803406 Change-Id: I887d85a3632766845a7caede089d99ed73efba35 Reviewed-on: https://chromium-review.googlesource.com/1073308 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#561861}
-
Daniel Park authored
Bug: 843639 Change-Id: I16a97d38c35071aee6b5c94874b74f7e986f47f2 Reviewed-on: https://chromium-review.googlesource.com/1072038 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#561860}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 751354 Change-Id: I6d49e24d53cdde68e923c3bb693310a95d933ac8 Reviewed-on: https://chromium-review.googlesource.com/1070187 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561859}
-
Lily Houghton authored
This is a reland of 85765d50 Original change's description: > Convert Chromedriver tests to use the HttpServer class from the network service. > > This refactors the chromedriver unit tests, particularly those in net_util_unittest, > sync_websocket_unittest, and websocket_unittest, as well as the TestHttpServer class, > to use the network service's HttpServer class (instead of the one in net/). > > Bug: 821000 > Change-Id: Icc4479b656936f38e86d104004d1dd703d845dda > Reviewed-on: https://chromium-review.googlesource.com/1038544 > Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560310} Bug: 821000,2433 Change-Id: I6ec7ac84b988f90a93c86c6eeecfb2d7ee53bad5 Reviewed-on: https://chromium-review.googlesource.com/1070349Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561858}
-
James Cook authored
They pass now, probably thanks to the app list code moving into //ash. Bug: none Test: browser_tests --enable-features=Mash Change-Id: I10bbdce9f5eb8bc4235f086488733a78bbbb3942 Reviewed-on: https://chromium-review.googlesource.com/1072827Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561857}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5b8466d8. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." c42d28a2 "[css-contain] Disable paint containment in non-atomic inlines" 5b8466d8 "Fixed CSP directive value parsing accepted character range" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18557 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/i18n TBR=kereliuk No-Export: true Change-Id: I6d6e6899106e66e72bb3fe125ab6d3a54dcc0512 Reviewed-on: https://chromium-review.googlesource.com/1073388 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561856}
-
Guido Urdaneta authored
This is a reland of https://codereview.chromium.org/2258143002, originally authored by maxmorin@. This version contains minor additions, lint fixes and restricts functionality to just non-ChromeOS Linux. This CL adds the following AudioManagerPulse overrides in order to better support group IDs: * GetDefaultInputDeviceID() * GetDefaultOutputDeviceID() * GetAssociatedOutputDeviceID() The original CL was reverted due to regressions on ChromeOS with AudioManagerPulse. This CL keeps behavior of AudioManagerPulse on ChromeOS unmodified. Bug: 636300 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id48dc1477efd2fecd5ae111df22dfe2b744de6e0 Reviewed-on: https://chromium-review.googlesource.com/1072649 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561855}
-
Ricky Liang authored
The buffer_id is passed through Mojo as uint64, so we should refer to the buffer_id throughout the code consistently as uint64_t. BUG=832772 TBR=wuchengli Change-Id: Ib6f260c4242e8c68510903cefcc997bf7a6bbd4d Reviewed-on: https://chromium-review.googlesource.com/1073213Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561854}
-
Erik Språng authored
This is a first step just to get the allocation signal down into the VP8 encoder. Temporal layer handling will follow upcoming CLs. Bug: chromium:794608 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie0a120a7b906dc5218834e355d3acf8c4f24ac36 Reviewed-on: https://chromium-review.googlesource.com/1065898 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561853}
-
Olga Sharonova authored
Crashes/Fails. Bug:846693 NOTRY=true TBR=sky@chromium.org Change-Id: I73715824038690d32d0ae047430cbabdf79280a7 Reviewed-on: https://chromium-review.googlesource.com/1073454Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561852}
-
Gauthier Ambard authored
This CL removes the Close All Incognito Tabs action from the TabGrid popup menu in incognito, making it the same as the non-incognito. Bug: 846614 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib19301aa9582c7bb2eb94512c50082c40c6dc510 Reviewed-on: https://chromium-review.googlesource.com/1073150Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561851}
-
Fady Samuel authored
This reverts commit 6f4d713f. Reason for revert: This seems to have caused https://crbug.com/846691 Original change's description: > MacViews: Re-enable single ui::Compositor view > > Decide at initialization whether or not a RenderWidgetHostViewMac will > be displayed in its NSView or through a ui::Compositor. > > This fixes a bug whereby some windows (DevTools is a good example) > would, through the vagaries of initialization order, draw a single > frame to the NSView, which would then never go away, and cover up the > ui::Compositor's version of the content (which was then updating > correctly, though not visible). > > Bug: 840173, 845807 > Change-Id: If051d249956b10c9e56450ed1f58b9048d331562 > Reviewed-on: https://chromium-review.googlesource.com/1070764 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561717} TBR=ccameron@chromium.org,sdy@chromium.org Change-Id: Ic25ee96c567c3531d91ec5431f10d15d34bfee82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840173, 845807 Reviewed-on: https://chromium-review.googlesource.com/1073089Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561850}
-
Emily Hanley authored
NOTRY=true Bug: 840427 Change-Id: I3c1336cccc6e0af88aea9b7ad5e7d10a8cdd5b6f Reviewed-on: https://chromium-review.googlesource.com/1069659 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#561849}
-
Chris Hamilton authored
A follow-up CL will refactor existing consumers of WC::WasRecentlyAudible to use this API instead, before removing the relevant content API. More details in the bug. BUG=846374 Change-Id: I7a758b7fc4d01ca7e0a98676978d1de333829866 Reviewed-on: https://chromium-review.googlesource.com/1072748 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#561848}
-
Hajime Hoshi authored
Before this CL, null was passed to Mojo binding as a compositor task runner in offscreen canvas on worker thread as NonMainThreadTaskRunner:: CompositorTaskRunner() returns null. In this case, SingleThreadTaskRunner::Get() was used internally Mojo. This CL implements WorkerThreadScheduler::CompositorTaskRunner() with a new task type kWorkerThreadTaskQueueCompositor so that we can know the task runner's usage on UMA for task duration per task type. Bug: 841172 Change-Id: I8caf3244169300aed45eeab4fcd01999bc823976 Reviewed-on: https://chromium-review.googlesource.com/1073169Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561847}
-
Mark Pilgrim authored
Bug: 844934 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I480fe2d42be09e6b295f5e7f1e53548e1e912ede Reviewed-on: https://chromium-review.googlesource.com/1072048Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561846}
-
Mark Pilgrim authored
As part of the effort to bring the new Network Service online, we are deprecating URLFetcher in favor of SimpleURLLoader. Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit Bug: 844937 Change-Id: I4a00c42b481f10c03657aa52b9a3d197febdc6ed Reviewed-on: https://chromium-review.googlesource.com/1070110Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561845}
-
Matt Falkenhagen authored
This relands r561423 and r561793. Original code review: https://chromium-review.googlesource.com/1069956 Second code review: https://chromium-review.googlesource.com/1073037 This collided with the landing of the S13nSW virtual test suite. I'm relanding with an expectation for the S13nSW failure. Probably we're using NetworkService when S13nSW is on and NetworkService is off. Bug: 839982, 846545, 846637 Change-Id: Ib1c3122ee532cce56a040356433002a24edc5553 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR: nhiroki, kinuko, dcheng Reviewed-on: https://chromium-review.googlesource.com/1072991Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561844}
-
Olga Sharonova authored
Expectations for virtual/threaded/animations/responsive/zoom-responsive-transform-animation-002.html. Crashes/fails/times out (see the bug). NOTRY=true TBR=sky@chromium.org Bug: 846632 Change-Id: I8d5315ca84019ef980105ca9693fde0ec84b0fb3 Reviewed-on: https://chromium-review.googlesource.com/1072651Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561843}
-
Alexandr Ilin authored
TBR=bsheedy@chromium.org Bug: 846661 Change-Id: Idc30a69a9cea6ac7e39834fe5f0218c218a17797 Reviewed-on: https://chromium-review.googlesource.com/1073369Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561842}
-
Olga Sharonova authored
Failing flakily. NOTRY=true TBR=sky@chromium.org Bug: 846631 Change-Id: I5378035496d8b0009c5cc024d3feb68dcccc027a Reviewed-on: https://chromium-review.googlesource.com/1073448Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561841}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/34f5f28603eb..3543e21830b9 $ git log 34f5f2860..3543e2183 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 maruel Revert "[client] First local_caching improvement" 2018-05-22 maruel [client] First local_caching improvement 2018-05-18 maruel [client] Move named_cache into local_caching 2018-05-18 maruel [client] move DiskCache into local_caching 2018-05-18 maruel [client] Fix swarming trigger with secret bytes on Windows Created with: roll-dep src/tools/swarming_client R=qyearsley@chromium.org Change-Id: Iecce181fef85587704cd48ec5b7ce51b5f7d8d93 Reviewed-on: https://chromium-review.googlesource.com/1072320Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561840}
-
George Adams authored
This file is necessary for builds in which the gn args v8_use_external_startup_data and use_v8_context_snapshot are both set to true. There was aprevious change to include this in the headless component, but it was only generated for component builds. The commit sha for the previous change is 8e676c03. R=alexclarke@chromium.org, skyostil@chromium.org Bug: 829561 Change-Id: I34a6c8778d6cd7a8b9e635ab48d299163ddea936 Reviewed-on: https://chromium-review.googlesource.com/999013Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#561839}
-
Mikel Astiz authored
This is a partial revert for https://chromium.googlesource.com/chromium/src/+/87d0207fea94e8f64ca053c813b96e2ddcd3da27 Tabs not only get restored from tab entities (which is usually the case) but can also be restored directly when processing a header entity. For cases where a header references a tab that doesn't have a corresponding tab entity (e.g. was unsyncable), we need to simply skip the reasociation step. Bug: 846480 Change-Id: I5d534645a42e4e660bf2cd110a7a4ee0f57b9c25 Reviewed-on: https://chromium-review.googlesource.com/1073328 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#561838}
-
Ned Nguyen authored
** Perf bot health sheriff: if there are test cases in this benchmark that fails on windows, please disable individual failed test cases instead of revert this CL ** TBR=cbruni@chromium.org, hablich@chromium.org Change-Id: I20b8026608164107f13a6a62a73c812bef4ab12e Reviewed-on: https://chromium-review.googlesource.com/1072502 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#561837}
-
Olga Sharonova authored
(flaky). NOTRY=true TBR=sky@chromium.org Bug: 846656 Change-Id: I711631f169c28c525ed8ce97ae5799ca6a07adae Reviewed-on: https://chromium-review.googlesource.com/1073410Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561836}
-
Hajime Hoshi authored
This CL also removes MediaElementEventQueue::CancelEvent, which is not called anywhere. This is one of the steps to eliminate EventQueue. Bug: 846618 Change-Id: I6e67a84d7bbd5344a5758e58d1db7be0192ac53f Reviewed-on: https://chromium-review.googlesource.com/1072992Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561835}
-
Andy Paicu authored
Bug: 845961 Change-Id: Ifc9609058cd7cbd268785db46534e3ed09da6ce3 Reviewed-on: https://chromium-review.googlesource.com/1071510 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#561834}
-