- 16 Nov, 2020 15 commits
-
-
Darren Shen authored
Mostly adds = default and changes typedef to using. Change-Id: Ic9d8ab0caf10acf8b86e97a02d5dcd15764d3148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532023Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827667}
-
tby authored
Events are currently stored in this format: {"events":[{event1}, {event2}, {event3}], "keys":{...}} But we are about to create new categories of event, related to whether they are associated with the UMA client ID or not. This requires we store two separate event lists on-disk. This will look like: {"events":{ "independent":[{event1}, {event2}, {event3}], "associated":[....]}, "keys":{...}} This CL: - refactors the logic for getting the events list, creating GetEventsList. - adds logic to migrate from the old storage format to the new. Bug: 1148168 Change-Id: I1d828a4e44b2e483b908a53d5d47c241f3603b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532164 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#827666}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605458715-f00155bc52e72dc18d30745134240890a44f1534.profdata to chrome-linux-master-1605484714-0506bb900efd9e0694325713b333ba7d388746e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I41e24b5065afab4bddf3b5b108dfb36d4d1e44e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827665}
-
Minoru Chikamune authored
IntegrationTest.COMRegistration is failing on Win7 like below. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/86558 IntegrationTest.COMRegistration was added on the CL below. https://chromium-review.googlesource.com/c/chromium/src/+/2538267 TBR: ganesh@chromium.org, sorin@chromium.org Bug: 1149213, 1140562 Change-Id: Ibe95b8a2a5955adefdf1691e1cf68a350d656ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537821 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827664}
-
Shengsong Tan authored
This change add a new event for desktop window focus state change. With this change, ARC can have different behavior when Chrome window or ChromeOS desktop get activated. Fix the reverted change https://crrev.com/c/2519686 BUG=b:171450038 TEST=Active different window between Chrome/ARC and logcat events Change-Id: Ied6245028578b89abb1ae376b7b49919c5cebee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536578 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827663}
-
Fergus Dall authored
Currently we have: - IsAllowed which checks enterprise policy and nothing else - IsUIAllowed(_, false) which checks other aspects of eligibility - IsUIAllowed(_, true) which checks both These methods are confusingly named and IsUIAllowed is really doing two separate things. This has lead to the crash in the associated bug, when a query that was subject to change was used as if it were persistent. Change this interface to the following two methods: - CouldBeAllowed which checks persistent (within the lifetime of the process) aspects of eligibility - IsAllowedNow which determines if we are allowed to run crostini right now, with the understanding that this answer may change at any time. Bug: 1015345 Change-Id: Iab4263c2fcae57bd4ed6bcf6956fd6e7c1e016e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537450Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#827662}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605451535-a6af4ac0273470e6b457bdea723c0bedf776d930.profdata to chrome-win32-master-1605473970-18d5ebf07ab680b4396ec4f82e9b49e24c2d43e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I02669881506ed317dd1cf15dc026a569fc08d55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539436Reviewed-by:
-
Thanh Nguyen authored
This CL implements InvertedIndexSearch functions that are inherited from new Index interface. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I3a1439f9b43d9d52bbb6819308535aa28ef7fe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531078Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827660}
-
Minoru Chikamune authored
This reverts commit c0d403ae. Reason for revert: May be causing chromeos errors. Speculatively reverting based on error log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863577786188639024/+/steps/isolate_tests/0/stdout?format=raw > 0cf1ad3e42632633d1110de0b0a6e30ef2599740 boringssl_ssl_tests isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/browser_tests.isolate: failed to process: stat /b/s/w/ir/cache/builder/src/out/Release/gen/chrome/test/data/webui/cr_components/chromeos/cellular_setup/sim_detect_page_test.m.js: no such file or directory So this error is caused by sim_detect_page_test.m.js. Original change's description: > [CrOS Settings] Update sim-detect-page to be more generic > > Rename sim-detect-page to setup-loading-page and update UI to be used > for both psim and esim flows. > > Bug: 1093185 > Change-Id: Iaf8934a3423c1ce21d6115bc9ea28c9d972738b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535231 > Commit-Queue: Gordon Seto <gordonseto@google.com> > Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827473} TBR=khorimoto@chromium.org,azeemarshad@chromium.org,gordonseto@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093185 Change-Id: I48421a06df20aadd0913c1ee9bc3dc313f31097d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538858Reviewed-by:
-
John Palmer authored
Increasing delay also helps by making sure things aren't interrupted. FIXES: 1148100 Change-Id: Ie6e4f696a23ca00b67d88be28d9a5b91ffef3282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530955Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#827658}
-
Noel Gordon authored
Add launcher.launchFileManager() - move this part out of file_manager.js changes in CL:2500642 Add ready() handler to read load time data - move this part out of file_manager.js changes in CL:2500642 Add getVolumeManager() helper - to match this new helper, which was added in CL:2534551 for moving VolumeManager into JS modules Re-position the various background fake classes - move them so they are adjacent in the code Tbr: alex Bug: 1113981 Change-Id: Ia301098b5e0a357d69b7ee5e89560f7cc6b8210f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539255Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827657}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3c10ef3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I712ac2e9129b51be4dac8aeb36d4a8d1a7409115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539456Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827656}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605451535-67d2a4e0717e49940da54310411b235218dd38d3.profdata to chrome-win64-master-1605473970-858e020e397b6c69b02a6b98027a57d7f071f21b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3470cb66e313f4ba8a5eadb8d3e97a5159c76886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539435Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib9edd5ea68d49c368156a32387228f6bb8288edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539414Reviewed-by:
-
Johann Koenig authored
This reverts commit c7a07b61. Reason for revert: May be causing Win7 errors. Speculatively reverting based on change log: https://chromium.googlesource.com/chromium/src/+log/88b177aef..742f164dd0 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110238 content_browsertests failed because of: All/DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxFocus/uia All/DumpAccessibilityTreeTest.AccessibilityAriaTreeDiscontinuous/uia Original change's description: > Invalidate SelectionShouldFollowFocus elements during container focus > > Items in single selection containers that have accessibility focus > should get the selected state. Code to mirror focus to selection > exists, but the selected state must be refreshed. > > Replacing AXLayoutObject::SelectionShouldFollowFocus with a helper > method in ax_role_properties, ui::IsSelectRequiredOrImplicit and > including Role::kTreeItem [1] since the ARIA spec lists aria-selected > as a required state. > > Adding AXObject::IsSelectedFromFocusSupported (see AXLayoutObject impl) > which provides a mostly conclusive answer for whether an element can > support this behavior. > > During this investigation, I found there was a portion of the spec that > was not implemented, so I created a crbug [2] for that. "If any DOM > element in the widget is explicitly marked as selected, the user > agent MUST NOT convey implicit selection for the widget." > > Also created a crbug [3] for followup to consider including more > selectable roles for this behavior. Currently only roles that require > or have an implicit value for aria-selected allow this behavior. > It may be desirable to include roles columnheader, rowheader, gridcell > and row, but felt that would be out of scope for this CL. > > [1]: https://www.w3.org/TR/wai-aria-1.1/#treeitem > [2]: https://crbug.com/1143451 (Not allowed with explicit selection) > [3]: https://crbug.com/1143483 (Consider allowing more roles) > > AX-Relnotes:Notify the aria-selected state changed for items that > have their selected state follow focus, and enable this behavior for > role=treeitem elements inside single-selection containers. > > Bug: 1141579 > Change-Id: Idce80a91f41df859775eed59a922ac7c923d9f4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493000 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827487} TBR=dmazzoni@chromium.org,haraken@chromium.org,aleventhal@chromium.org,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1141579 Change-Id: Ibd959d5d6066bbe93aea4dffa3d4bc7cc6b35dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537820Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#827653}
-
- 15 Nov, 2020 25 commits
-
-
Darren Shen authored
Planning to do a lot of refactoring in this directory, so adding myself as OWNER to reduce review load. Change-Id: I27decd0dcdb1e59f76bacaa4949d88031e661062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536510Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3f1d1491a00..bf281d84688d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I841ccbea5d9c6c1d5c17648cf1dcb9ad0d48d24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539434Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827651}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605418474-decec100e7e463ed13c427107def6068c02b35a5.profdata to chrome-win64-master-1605451535-67d2a4e0717e49940da54310411b235218dd38d3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id418864f85eb97b47c4cc04d3c8d06f9171140ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539286Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/785beb334821..b3f1d1491a00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I5295b6ed8d4fec5acec192fd3857767f5fe7484b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539292Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 1148810 Change-Id: I12fa19bf5c87e9b97707b29e276ad1437e18b77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536462 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827648}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4a2e09d34f5ce91912c9fabf306a9e9f03690fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539355Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827647}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605438638-1b22bbd876cf64a7ba114abf81617cd2d8bef45b.profdata to chrome-linux-master-1605458715-f00155bc52e72dc18d30745134240890a44f1534.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2a6ceb611b7d484f39f1c411a9e14e7bd3c1b544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539282Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605429017-5e85ba156fabf475aad42d060ab2bf934b5ebf7f.profdata to chrome-win32-master-1605451535-a6af4ac0273470e6b457bdea723c0bedf776d930.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ife9fdfb411ab93840394c74fb97f2e039370b8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539278Reviewed-by:
-
Kartik Hegde authored
Some network diagnostics need to simply validate a successful TCP connection. Add a construction parameter to make the TLS upgrade optional. BUG=b/172994051 TEST=(1) unit_tests --gtest_filter=TlsProberWithFakeNetworkContextTest.* (2) unit_tests --gtest_filter=TlsProberWithRealNetworkContextTest.* Change-Id: I51a0f40ea5727cec8c84975fcacca64d245d2609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530460 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#827644}
-
Liquan (Max) Gu authored
This CL allows PaymentRequestSpec to provide the PaymentOptions that is saved in payment_request_spec. Bug: 1148936 Change-Id: I05451f4d76f759b6aad9b3c1c893901789e0f805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537058 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827643}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/V619U7DE_7WhVDObPrntwpd3LoaUlvh4GjVR_cJblOkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I0853162ae6e365d43481fd8a5585159d61eb4749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539241Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1ff5da2cbab7f7784b83e25bd1569a7f5e88a9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539163Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca62d830fc00..785beb334821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I7cfad7c8e7fe14aeb329e3066761f0a92644b6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539161Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605418474-391738c29c786fce86a2f5faaa9ff3cc11153bcd.profdata to chrome-win32-master-1605429017-5e85ba156fabf475aad42d060ab2bf934b5ebf7f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3573d8c1f365529307718b7c012c7a77a5901875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539162Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605418474-d40e0a66ac214c017c874665540974720359ae8b.profdata to chrome-linux-master-1605438638-1b22bbd876cf64a7ba114abf81617cd2d8bef45b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idd970dacf693524e1203feea9f15fbd129f5310b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539274Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a4cfc762b194..ac304ad84192 2020-11-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I351456c4390cc7208a81f4084befbef94e486bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539023Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605301167-f2e539f21f91663031225bb0d3160662a773cdbd.profdata to chrome-win32-master-1605418474-391738c29c786fce86a2f5faaa9ff3cc11153bcd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I498cb2f0c1c67ab1effc0d476a1b4039b35316dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539174Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605322732-f3f9a6c28d3c2189d459e96b0d723f5210a3cdc8.profdata to chrome-win64-master-1605418474-decec100e7e463ed13c427107def6068c02b35a5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib01b6d049aa59d879eba4542afd0d2460b01e1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539175Reviewed-by:
-
Nico Weber authored
-fsanitize-address-use-after-scopes is on by default, so stop explicitly passing it on non-mac. This is a no-op. Stop passing -fno-sanitize-address-use-after-scope on mac, to enable the feature there too. Bug: 708216,708707 Cq-Include-Trybots: luci.chromium.try:mac_chromium_asan_rel_ng Change-Id: I406ec8c80997291f7467b51c4f50d573ea90052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526804 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#827634}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0c317a23d428caff8ca1370b070162511b47391c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537066Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/43478ee6935f..a4cfc762b194 2020-11-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I625e0edf1cde0d42e663d5fee42f8d6d1848aeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538105Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605354041-d11b800f5d03c7441770fbdbf2620c29609745f4.profdata to chrome-linux-master-1605418474-d40e0a66ac214c017c874665540974720359ae8b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib5e806d4c046e06dfba7f908e5bf26d47e6436fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538106Reviewed-by:
-
Shakti Sahu authored
This CL implements share functionality. 1 - Videos will be shared from share button click through a share intent chooser. 2 - At startup, Chrome will save all the video share URLs in a shared preference. 3 - At the receipient end, LaunchIntentDispatcher will check through the saved shared pref to see if it is a video tutorial URL. If yes, a video player will be launched. Bug: 1117180 Change-Id: If169eab9053b2092532e4d48da8903bc06cf4813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437785 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#827630}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7106a5f7735..ca62d830fc00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106950 Tbr: Change-Id: I6768427daa540cf88808211be05afa4709ac299c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538104Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8b95281b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: creis@chromium.org, lukasza@chromium.org: external/wpt/fetch/corb NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ibd93fb0ecc88fbc2b4f497a69e21e2f28a29848d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538442Reviewed-by:
-
