GitLab

I'm putting all the '.h' files into public. We can refine the list as necessary
later.

I'm doing this as I would like to have private headers that other targets can't
include (well, except tests).

BUG=none
TEST=none

Change-Id: I84ab155a1449d969076dcd94feaa0150f3e9ad85
Reviewed-on: https://chromium-review.googlesource.com/1161498
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580581}

The related CLs on V8 side were not landed.

TBR=lushnikov@chromium.org

Bug: chromium:595206,v8:7753,v8:7858
Change-Id: I8e5bbf2f2e9d59a20ff79917671e910e76148700
Reviewed-on: https://chromium-review.googlesource.com/1162310Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580580}

chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly.

This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc
 will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work.

Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: I85d78d25b1905c68524e0636cec3006102d17749
Reviewed-on: https://chromium-review.googlesource.com/1161610Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580579}

Third party code will be blocked in the browser process.  We'll need
to host VR input outside the browser process.  To support that, we need
some IPC mechanism to get gamepad data over to the browser process where
the device/gamepad service is hosted.

For now, we'll host OpenVR gamepad data in the same place we host the
OculusRenderLoop.  This is not the final shipping location, but adding
an IPC mechanism moves us closer to the final architecture.

BUG=795510, 860821

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8385d1c4222df9636259743366f64eafbb40fa3a
Reviewed-on: https://chromium-review.googlesource.com/1153561
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580578}

BUG=870341
TEST=as in bug

Change-Id: Ia9ede9c30d95b9f569890eff242582129967dd11
Reviewed-on: https://chromium-review.googlesource.com/1161251Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580577}

Previously, if the last active frame in a renderer process was going
away, it was possible to send out a process shutdown request (see
RenderProcessHostImpl::ShutdownRequest()) prior to actually sending
the swapout ACK, and potentially even prior to finishing tasks posted
from the unload handler, such as postMessages.  This CL postpones the
process release until after the swapout ACK has been sent.  As part of
this, it slightly refactors process refcounting for swapped out
transitions to happen in RenderFrameImpl rather than RenderWidget.
This is because when the swapout ACK is sent from a PostTask, the
widget that had been swapped out might've been destroyed, but we still
want the process to be released.

Bug: 794625, 867274
Change-Id: I76b492461ce5a9317e71e184118ee02057143565
Reviewed-on: https://chromium-review.googlesource.com/1157530
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580576}

MediaRouter.Dial.CreateRoute - records result of a CreateRoute call.
MediaRouter.Dial.TerminateRoute - similarly for a TerminateRoute call.
MediaRouter.Dial.ParseMessage - records result of parsing a message
coming from the Cast SDK.
MediaRouter.Dial.FetchAppInfo - records reuslt of a app info request.
Note we already have metrics for device description.

Bug: 808720,798861
Change-Id: Ic48eba338298e7086fcab290f24ab490e5944ab3
Reviewed-on: https://chromium-review.googlesource.com/1153648Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580575}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/d62662686b22..9dfdc2758f26

$ git log d62662686..9dfdc2758 --date=short --no-merges --format='%ad %ae %s'
2018-08-02 dor1s [libFuzzer] Initial implementation of weighted mutation leveraging during runtime.
2018-08-02 kcc [libFuzzer] use absolute distance in addition to the hamming distance in value profiling; our A/B testing have (somewhat weak) indication that this provides an additional signal for corpus expansion

Created with:
  roll-dep src/third_party/libFuzzer/src

Bug: 854277
Change-Id: If7b083d5b3d983d7b8a2fe139a0f8a7494fea559
Reviewed-on: https://chromium-review.googlesource.com/1162074Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580574}

The USE_STORAGE category type can't be represented as a
ContentSettingsType, which would make the UI fall back to displaying
all categories.

Bug: 856110
Change-Id: I434742d9fd330e4ff78f4ce69655da67a050e310
Reviewed-on: https://chromium-review.googlesource.com/1162237Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580573}

A future change will move the calls to this function into the
individual subprocess implementations.

Also simplify the API by leaking the field trial list instead
of requiring the caller to keep it on the stack. This
is similar to what we do in the browser process (see
ChromeBrowserMainParts::SetupFieldTrials).

Bug: 855193
Change-Id: Idf5fbd18d8a6b6f5831d7d5ef63293c22d60d127
Reviewed-on: https://chromium-review.googlesource.com/1159740Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580572}

The point of the text indent is to align with the suggestions in the
dropdown. But if the location icon has text, it won't align anyway so
the indent is not useful and looks odd.

Bug: 859543

Change-Id: I355c81016a2691bcc237b108eec80318dccf1b50
Reviewed-on: https://chromium-review.googlesource.com/1159229Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580571}

AXWindowObjWrapper::OnWindowVisibilityChanged is using
AXAuraObjCache::GetInstance()->GetOrCreate() to look up itself in the
AXAuraObjCache. It's not clear to me what that will do during
views::Widget teardown. It's theoretically possible this will do
the "create" code path and end up with two AXWindowObjWrappers for
the same aura::Window.

Instead use |this| for the fired event rather than GetOrCreate().
I've manually verified with CHECK_EQ that they are the same object
both in ordinary usage and on the bots.

I noticed this while investigating a Widget close crash in the
keyboard shortcut viewer mojo app on Chrome OS.

Bug: 869608
Test: bots
Change-Id: Ifdba944e9ea9bca2c2572875ba212063ec7dd66d
Reviewed-on: https://chromium-review.googlesource.com/1161396Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580570}

Instead of twice. Right now the superclass also calls Hide().

This is a theoretical fix for an accessibility related crash during
mojo app window close.

Bug: 869608
Test: window close animations look fine, both for shortcut viewer and for mash browser windows
Change-Id: I9782f07d9084902b4a26aa29285ff2e20e16c6bb
Reviewed-on: https://chromium-review.googlesource.com/1161442Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580569}

By calling reloadCellsForItems at the cell indexPath, the cell
gets reconfigured and also redrawn since
[tableView reloadRowsAtIndexPaths:withRowAnimation:] is called.
This causes the cell height to adjust to the new content.

Bug: 869838
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iadd0a7f9a80d321015f654bd51dfeb084861f2cf
Reviewed-on: https://chromium-review.googlesource.com/1159328Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580568}

This reverts commit ae29b155.

Reason for revert: crbug.com/868190.

Original change's description:
> RELAND: vaapi: decode on client NativePixmaps
> 
> This CL relands crrev.com/c/1021675 that got reverted as predecessor
> to crrev.com/c/1104394 (but was otherwise innocent AFAIK). The said
> predecessor situation has been corrected by crrev.com/c/1117606 (that
> landed in ChromeOS 10840.0.0 [1])
> 
> [1] https://crosland.corp.google.com/log/10837.0.0..10840.0.0
> 
> TBR=dcastagna@chromium.org (same code as reviewed before)
> 
> Original CL description -----------------------------------------------
> vaapi: decode on client NativePixmaps
> 
> This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving
> a buffer copy and removing a costly blit (DownloadFromSurface) on the
> GPU Main thread.  Three groups of changes:
> 
> 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a
>  VaapiPicture with a VASurfaceID, we use those to decode onto and set a new
>  flag: |decode_using_client_picture_buffers_|
> 
> 2. When the decoder calls CreateVASurface(), instead of giving it the first
>  |available_va_surfaces_|, we need to figure out the first VASurfaceID in
>  this |available_va_surfaces_| such that the corresponding VaapiPicture in
>  |pictures_| is available (i.e. in |available_picture_buffers_|).
>  Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one
>  correspondence like on ToT.
> 
> 3. When we're ready to OutputPicture() to |client_|, instead of using the first
>  |available_picture_buffers_|, we find the corresponding one for the
>  passed |va_surface_id| (we could search all over |pictures_| but there's
>  always less |available_picture_buffers_|.
> 
> Some other notable developments:
> 
> - s/output_buffers_/available_picture_buffers_/
> - OutputPicture() loses a parameter.
> - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2
>  or the ImportBufferForPicture() path.
> - Pictures is made a base::small_map. (Originally from crrev.com/c/988512).
> 
> resolutions for a long time. No hickups, no dropped frames.
> 
> Bug: 822346, 717265
> Test: v_d_a_unittest vp8/vp9/h264 passing on eve, running crosvideo changing
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Ie1fb21a7a302476bceee3dd905278d53f13b1475
> Reviewed-on: https://chromium-review.googlesource.com/1021675
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/1147143
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577226}

TBR=mcasas@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346, 717265
Change-Id: I8b91c852d94061771fc0ff8caea6616c74f9454a
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1161621Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580567}

This removes everything related to panels in the shelf code.

Some more code should be deprecated/deleted after this CL. For
instance:

views::Widget::InitParams::TYPE_PANEL
aura::client::WINDOW_TYPE_PANEL
ash::kPanelAttachedKey
ui::mojom::WindowManager::kPanelAttached_Property
extensions::LAUNCH_CONTAINER_PANEL

Bug: 805612
Bug: 788033
Bug: 153447
Change-Id: I06a64ff44c3104a4eddb4e6f136b2e73abbebcff
Reviewed-on: https://chromium-review.googlesource.com/1141267
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580566}

This is a reland of 49040ae7

Original change's description:
> Changed committed-interstitials flag from switch to feature.
> 
> Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
> base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
> doing separate rampups for each kind of committed interstitial. Switch was
> changed to Feature so that it can be enabled via variations.
> 
> Bug: 755632
> Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
> Reviewed-on: https://chromium-review.googlesource.com/1118975
> Commit-Queue: Carlos IL <carlosil@chromium.org>
> Reviewed-by: Jialiu Lin <jialiul@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574621}

Bug: 755632
Change-Id: I9ef1fa141d9481537740569c4af6504998c619e2
Reviewed-on: https://chromium-review.googlesource.com/1138516Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580565}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e82ab695..0ecae0ae

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I04e133580b8174e113a62644bd80c5262b982b54
Reviewed-on: https://chromium-review.googlesource.com/1162067Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580564}

Regression was introduced by network screen refacoring at:
https://chromium.googlesource.com/chromium/src/+/1001fd375442428751b18f3fed991c77874b92eb

Bug: 862445, 870227
Test: DemoSetupTest
Change-Id: I993734fe3d62bd6903454208563e60cff1ba702e
Reviewed-on: https://chromium-review.googlesource.com/1157701
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580563}

This patch adds a way to create secondary LanguageModels in the
LanguageModelManager. This will allow using the GeoLanguageModel to
sort languages based on geographic location, as well as implement
metrics that compare the predictions of the different models.

BUG: 865500

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2e710ef74beaf6a3323a3b882e41c4ed47052a7d
Reviewed-on: https://chromium-review.googlesource.com/1142354Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580562}

This change should do nothing when the feature flag is not enabled.
When enabled, this displays text about the suggestions that would be surfaced
to a user once the feature is complete.

Details
- Introduced new AvailableOfflineContent Mojo interface
- Initial implementation for AvailableOfflineContent
- Provide available item list to neterr.js
- Display available items on net error page, though not in a user-friendly way.

Bug: 852872
Change-Id: I892e5bdf9ef8a2c80bbc91422f8005d12f88436b
Reviewed-on: https://chromium-review.googlesource.com/1156868
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580561}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
since this use doesn't appear to rely on the concurrency guarantees that
SERIAL_EXECUTOR provides.

Bug: 869907
Change-Id: Ib95ed2c1c4442f5ed8d2e7f74594c7a57aee1c3d
Reviewed-on: https://chromium-review.googlesource.com/1161087
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580560}

We might be changing the default execute(), so we want to make this an
explicit call to the SERIAL_EXECUTOR.

Bug: 869907
Change-Id: Ifd7cff98b7714b664fdc6cb30bc0d0f7b1a3be4a
Reviewed-on: https://chromium-review.googlesource.com/1162076
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580559}

This CL changes the background of SideSwipe, from the old MDC background
to the new color of the TabGrid.

Bug: 867973
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie4068224ea3dfb5e93a5220e705f0ded62d0a4ec
Reviewed-on: https://chromium-review.googlesource.com/1158825Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580558}

These are the Web App analogs of external extensions, described at
https://developer.chrome.com/apps/external_extensions

On start up, *.json files (often but not necessarily named
external_extensions.json) are scanned in a number of directories. Prior
to this CL, such .json files can install regular extensions (.crx files)
or, on Chrome OS, Android apps. New in this CL is being able to install
Web Apps (sometimes known as Progressive Web Apps or PWAs).

For example, the chrome::DIR_USER_EXTERNAL_EXTENSIONS path (defined in
chrome/common/chrome_paths.h) can correspond to file system directory
like "$HOME/.config/chromium/test-user/.config/chromium/External
Extensions". Placing a foo_bar.json file containing:

{
  "web_app_manifest_url": "https://www.chromestatus.com/static/manifest.json",
  "web_app_start_url": "https://www.chromestatus.com/features"
}

in that directory will install the Chrome Platform Status web app.

This is a manual roll-forward of
https://chromium-review.googlesource.com/c/chromium/src/+/1127214
after fixing the threading flakiness that lead to the roll-back.

Bug: 855281
Change-Id: Ifc0a7a0a923cfe932ed077a34ababf3dc7df2014
Reviewed-on: https://chromium-review.googlesource.com/1157704
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580557}

Renaming XRDeviceRuntimeSessionOptions to XRRuntimeSessionOptions to
to shorten the name, and because these options are passed to an
XRRuntime to get a session for a physical device.

Bug: 842025
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id3d344ba9e4f8d5acd13cdae326d479ab83e7b2e
Reviewed-on: https://chromium-review.googlesource.com/1161506Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580556}

This CL changes the icons for the collections entry of the popup menu
to have them more consistent with the other icons.

Bug: 847432
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If1caed157cc50cc9c55c7c61cd2a87403d0ea009
Reviewed-on: https://chromium-review.googlesource.com/1162227Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580555}

Send click event even when the targets of down and up
are different and across different interactive elements.

Bug: 869919
Change-Id: Ie90c2d7c7dbb1b873f2a0f8b8ef489ee951489fe
Reviewed-on: https://chromium-review.googlesource.com/1161164Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580554}

This is a reland of a445460b
because it was reverted by mistake.

TBR=mastiz@chromium.org

Original change's description:
> Reland "[Sync::USS] Bookmark sync conflict resolution"
>
> This is a reland of 553ec6da
>
> Original change's description:
> > [Sync::USS] Bookmark sync conflict resolution
> >
> > This patch addresses the problem of conflict in bookmarks upon
> > receiving a remote update for a node that has local changes.
> >
> > The general polic that is implemented is that server wins except in
> > case of deletion.
> >
> > Bug: 516866
> > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1
> > Reviewed-on: https://chromium-review.googlesource.com/1157006
> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580436}
>
> Bug: 516866
> Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e
> Reviewed-on: https://chromium-review.googlesource.com/1161861
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580496}

Bug: 516866
Change-Id: I285dfa50ae5374bc82840b6d140f99f7edddd552
Reviewed-on: https://chromium-review.googlesource.com/1162181
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580553}

There were two bugs:  When plugins weren't synchronously available, the
download checking code was different from when they were.

Also, when a download has an HTTP error status code, the navigation was
being aborted instead of passing along the error to the renderer to
display an error page.

Bug: 870475
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie113fab576b4cc8ea2ca444c261335bf183c60e2
Reviewed-on: https://chromium-review.googlesource.com/1161479
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580552}

Change-Id: I49aa8fc88149bd111969074ef4023d9dcd57edee
Reviewed-on: https://chromium-review.googlesource.com/1162231Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580551}

See intent to deprecate:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XpkevOngqUs

The deprecation will target M71.

Bug: 812767
Change-Id: Id4448a91047def16194a47efdacc152070dace82
Reviewed-on: https://chromium-review.googlesource.com/1157231Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580550}

All changes (except for the changes to AsyncTask itself) are entirely
generated with Android Studio's refactor mechanism and git cl format.

This is in an effort to reduce the unused surface of AsyncTask that
doesn't match the ideal future API. Ideally, we will move to something
very similiar to TaskScheduler, which has no concept of "Progress
updates", and forces the usages to call Bind for the parameters.

For parameters now, we use constructor arguments, which provides the
same concurrency guarantees that passing in params via Params would.
This is closer to the ideal because it supports any arbitrary
parameters, not just many of 1 type.

TBR=smaier  #For mechanical refactoring

Bug: 843745
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If25df5d7276e504983bdc71e6e07993cb044ed04
Reviewed-on: https://chromium-review.googlesource.com/1150692
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580549}

This use counter measures calls to the detect() methods provided by the
BarcodeDetector, FaceDetector and TextDetector classes. This is needed
by the Origin Trial infrastructure so that we can measure use of this
API in general rather than use of each detector type individually (which
is covered by the existing use counters).

Bug: 646035
Change-Id: Ic4c70b7e282b0569fad50f273aa9754b0bcb9bbf
Reviewed-on: https://chromium-review.googlesource.com/1161285Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580548}

https://skia.googlesource.com/skia.git/+log/da77c7f91f1d..7d0339950377


git log da77c7f91f1d..7d0339950377 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@7d0339950377

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ia3002e6b1e947b9bd0251fa1bf6d30f3118d18e6
Reviewed-on: https://chromium-review.googlesource.com/1162103Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580547}

If a touch target is not in the |owner_map| anymore, it's already been deleted;
fallback to INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS and DumpWithoutCrashing to
help debugging why |host| can be null in ProcessTouchEvent.

Bug: 814674
Change-Id: Ibf3faf1344f43760c4a60155316c193a78a61018
Reviewed-on: https://chromium-review.googlesource.com/1160795
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580546}

ProTip: start by looking at the pythonic_action() definition
in internal_rules.gni to review changes in this CL.

This CL tries to make "gn analyze" smarter by ensuring that
it knows about Python module dependencies, for any python
script under //build.

At the moment, these dependencies are computed by
build_utils.WriteDepFile() automatically (unless the
add_pydeps=False argument is passed). This adds all imported
module paths to the generated .d file written by the script.

Unfortunately, because this .d file is generated by the
actions, the corresponding Python sources are not part of
the target's inputs, known by GN at parse time, and thus do
not appear in "gn analyze" properly.

This CL tries to solve the problem by adding a new template
named "action_with_pydeps", which acts as "action", but also
expects a foo.pydeps file for every foo.py invoked through
the 'script' scope variable.

This '.pydeps' file is read directly at GN parse time and
added to the action's target inputs.

These .pydeps contain the path of each imported module, one
per line, and are generated with build/print_python_deps.py

Benchmarking shows no significant difference in the time
taken to perform a "gn gen out/Release" on a full Chrome
for Android checkout.

+ Add --inplace option to print_python_deps.py in order to
  make its usage more human-friendly (the new mode cannot
  become the default because PRESUBMIT.py depends on the
  current behaviour).

+ Remove some --depfile options on a few Python scripts that
  don't need it anymore (e.g. when their inputs and outputs
  are now fully known by GN at parse time).

+ Remove uses of compute_inputs_for_analyze in rules.gni and
  internal_rules.gni (as well as exec_script() calls to
  print_python_deps.py). Note that the variable itself is still
  needed for grit inputs, see tools/grit/grit_rule.gni for
  details).

BUG=NONE
R=agrieve@chromium.org

Change-Id: I8d7c07ab93b032fdc0c7f9dbeb2173767f52eeff
Reviewed-on: https://chromium-review.googlesource.com/1131190
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580545}

Prior to this CL, ARC icons were fixed size 48 and varied only at Chrome
scale factor. All other icons where taken by rescaling the base icon,
for example for shelf icon 48 was rescaled to 32. With new launcher
style we have more sizes in use, inluding sizes which are > 48.
This CL switchs to using custom size icon instead of fixed 48. This also
based on Android protocol that supports returning icons for requested
pixels size.

TEST=Manually + tests
BUG=b/112035954

Change-Id: If95965695ec647136586a8c203dd1254b02da5f4
Reviewed-on: https://chromium-review.googlesource.com/1154136Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#580544}

Bug: 864455
Change-Id: Ic3396019ae040845ff8938a894828e56db7db55f
Reviewed-on: https://chromium-review.googlesource.com/1156511
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580543}

We mistakingly were using UIImageRenderingModeAlwaysTemplate for the
new colored mic icon, stripping the color.
Use UIImageRenderingModeAlwaysOriginal to keep the colors from the png.

Bug: 868962
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5556cba4ef5e888c03d48d091f635bee3cfb95a4
Reviewed-on: https://chromium-review.googlesource.com/1162171Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580542}