- 10 Aug, 2020 40 commits
-
-
Etienne Pierre-doray authored
Best effort max tasks always acts like MayBlock. This is to prevent issue where many WILL_BLOCK BEST_EFFORT tasks increase the thread pool capacity, which is undesirable. This new behavior is similar to FixedMaxBestEffortTasks, but keeps the increase around to prevent deadlocks. https://uma.googleplex.com/p/chrome/variations/?sid=4a990d53992445c75cf9665227ab221c Bug: 1026785 Change-Id: I4be2f478c730cc75f8d358665edec72ad651902f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300343 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#796545}
-
Dana Fried authored
Due to cautious rollout of WebUI/tablet tabstrip and hover card preview images, we need more time with these metrics. Bug: 1112398 Change-Id: I97558bc5b715f3f8e401bb021feacec3721489c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343874Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#796544}
-
chrome://flagsMoe Ahmadi authored
Adds chrome://flags/#promo-browser-commands in order to facilitate testing the promo browser commands. For every new command, an option should be added to this flag. Selecting that option would replace the middle-slot promo on the NTP with a mocked promo and replaces the promo URL with command:<ID>. Bug: 1106421 Change-Id: I53e07d8fcdea057f43d9ff086c49a93565d79969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346834Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796543}
-
Kramer Ge authored
CommitOverlays is a more generic IPC that packages multiple overlay configurations for a frame before sending it to browser process. This replaces the CommitBuffer IPC. This CL merely adds CommitOverlays. It does not send multiple buffers using it. This is 3/? CL for overlay forwarding using wl_subsurface. Bug: 1063865 Change-Id: Id71d055bdb14b3d2e97cb2eef8811dca56323899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314665Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#796542}
-
Varun Khaneja authored
Bug: 1104919,1114674,1114498,1114447 Change-Id: I3f795b4084d6c8346a6a9c0ead9719e84be88ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347144 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#796541}
-
Sam Sebree authored
This change uses native_theme_base.cc and controls_refresh.cc to update the styling for the range native controls in dark mode. Bug: 1107287 Change-Id: Id176b010a0be12c192452b0cefcfb9166881ba3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342306 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796540}
-
Becca Hughes authored
We have our own product in Feedback for Kaleidoscope so we should use that for feedback. BUG=1111981 Change-Id: I107a8d9a50557e6e1ffcb308a94ba5760e1c1062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343633Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796539}
-
Fred Mello authored
https://docs.google.com/document/d/1WUuivgpuYFdDZqsfuz3wMgfZgOAcNH8Dpl07rjKmdNY Bug: 1112872 Change-Id: Iccfd03e67e5ac236234b3e612986c85b9137aba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346724 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796538}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea8be2120ee6..46a324a16c4b 2020-08-10 robertphillips@google.com Move GrSmallPathAtlasMgr to its own file and out-line 2020-08-10 johnstiles@google.com Update style guidance for [[fallthrough]]. 2020-08-10 robertphillips@google.com Clarify that the GrDirectContext uniquely holds the text atlas manager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: fmalita@google.com Change-Id: Ic7c0a29b43c2382688581f040b872832d01d14c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796537}
-
David Trainor authored
This has been failing on Android P bots. TBR: blundell@chromium.org Bug: 1114795 Change-Id: Id46c6175aa7f6742a37fd41e0cdc1d3b83cb996a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347164 Auto-Submit: David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#796536}
-
Darwin Huang authored
Update the section discussing auto, to use `` delimiter pairs, and be consistent with the comment style section below. Change-Id: Ib175db1b97a426c66dbc27bdbcce31f680783baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347304 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796535}
-
Filip Gorski authored
Change-Id: I1de39333d4dcdecf5266f5ce42907601ccc815f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346999Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#796534}
-
Tom Anderson authored
This fixes a regression after [1] in which I erroneously changed != to == in 2 places. This was causing a bug in setups that have high-resolution scrolling where the scroll distance would not get reset when switching to another app, scrolling, then switching back to Chrome. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2316436 R=nickdiego Bug: 1113903 Change-Id: I4a0adce22687ccc4a79986bf5d4d5bd8f71c66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346952 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#796533}
-
Liquan (Max) Gu authored
Change: * Encapsulate PRClient in CPRImpl. Before the change, PRImpl had to manage the lifespan of PRClient and CPRImpl. After the change, PRImpl only need to manage the lifespan of CPRImpl, as PRClient is no longer visible to PRImpl. * Clarify that PR#close can only be called by the renderer * Create CPRImpl#teardown to play the role of closing (should have called #close if not for the collision with the PR#close interface). * Clarify the usage of CPRImpl#teardown, BPR#close, PRImpl#close. Add mHasClosed/mHasTorndown for CPRImpl#teardown and PRImpl#close to make sure these methods can be called within themself without worrying deadloop. For example, while PRImpl#close calls CPRImpl#teardown, CPRImpl#teardown can call PRImpl#close back without causing deadloop. Acronym: PRClient = PaymentRequestClient CPRImpl = ComponentPaymentRequestImpl BPR = BrowserPaymentRequest PR = PaymentRequest Bug: 1102522 Change-Id: Ic6495f02593f9a1cfad9747e52e9dcf3a05b1018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343631 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796532}
-
Scott Violet authored
As it's flaky on windows as well. BUG=1099395 TEST=test only change TBR=hajimehoshi@chromium.org Change-Id: Ie3277c33c16ca1cb1a589934a8077f783d3e7c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346056Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796531}
-
Henrique Nakashima authored
Plain simple move since these classes have no dependencies. This is a step to modularize AsyncTabParamsManager to .tabmodel. Bug: 1112920 Change-Id: Ia9a6810c1eabf1a97c8baa06354df6faf7c51dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335912Reviewed-by:
-
Thiabaud Engelbrecht authored
For reference, the UNIT_TESTS batch can be run locally using: out/.../bin/run_chrome_public_test_apk -A Batch=UnitTests Bug: 989569 Change-Id: Icea283a01697c4fdade7039d8b4ef629af835655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346984Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#796529}
-
Yuly Novikov authored
on Nexus 5X. RetryOnFailure on both validating and passthrough CB. TBR=kbr Bug: 1043431, 914631 Change-Id: I615bb84874e46954d2db6945c0c6afdc1ee310cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346992Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796528}
-
Robert Ogden authored
See bug, but there's a slight regression in startup time for starting the probe which isn't actually that useful for the first nav anyways. Bug: 1113691 Change-Id: Idc50e39067bc54f5dc8263b89add6dc8b3cf1bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346739Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#796527}
-
Chong Gu authored
Logs are already handled via SystemLogReader. Bug: 1067356 Change-Id: Ide3a2d5545e1e8cdbd302be184612699ad149a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347051 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796526}
-
Stephanie Kim authored
Referenced 10.15 update CL https://chromium-review.googlesource.com/c/chromium/src/+/1776218 Bug: 1112846 Change-Id: Ie06190e48432caa75b55b69894a4384a3319580c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339702 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#796525}
-
Ben Mason authored
TBR=dullweber@chromium.org Bug: 1112409 Change-Id: Idf31c4a8d709ddc3f4f87cff63d63881f0198424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346853Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#796524}
-
Mario Bianucci authored
SetNeedsDisplay() was being called many times, when every other test limits it to a certain number of times. This test should only call it once, and doing so prevents it from running wildly and flaking on the single threaded versions. Bug: 1111302, 1112507 Change-Id: I2038c89e73b7b92b03133a4cf8487a9a54467fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343221Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796523}
-
Dan Sanders authored
This improves our alignment with the current draft spec, and exposes the APIs required to implement planar access. Bug: 1096717, 1096722, 897297 Change-Id: Ic9f33ce703e4492d61ad5784c849b8816a75b89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341836Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#796522}
-
Jeff Yoon authored
Appending linux as a supproted platform for the update pgo script. Adding the linux.pgo.txt with the latest profile information. Bug: 1105530 Change-Id: I63ec40b915970d9ad8a06aaaf594dcbf96dad109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347070 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#796521}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b27f3f1980fd..c92cc9537f56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112335,chromium:1112941 Tbr: sky@google.com,eirage@google.com Change-Id: I921deb41683d7f7ae19c02ba73fcb24648e2a7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346877Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796520}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I56741401e5e24da0fb37448c109ec507925c8be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346912Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#796519}
-
behdad authored
- ActivateDuration is removed as it is covered by CompositorLatency.Activation - BeginMainFrameIntervalCritical is removed as it is no longer useful Bug: 1039311 Change-Id: Ic2b31c0835a6956b4ead0cbf4c1bc75a19c74088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342576 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#796518}
-
Nicolás Peña Moreno authored
This CL improves crossiframe.html by waiting for the load event (so it knows the iframe is ready), and makes it faster by awaiting for both the main frame and iframe observers at the same time. It also improves the buffered-and-duration test by considering cases in which the first event does actually get buffered due to machine slowness. Bug: 1074048 Change-Id: Ieb356a4a4bbcfca8454e8a76334df70867b4f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343487Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#796517}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597060771-94a7300bd1819f6d10eaf4c394bfbc10cebf8f71.profdata to chrome-mac-master-1597082402-653f85831e858c9a0c668621a5e4055f49c06c11.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7d77310effe572ae55e7b5d836da5e437a47adc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347054Reviewed-by:
-
Kurt Catti-Schmidt (SCHMIDT) authored
This is the corresponding IA2 fix for the selection-iframe crash here: https://chromium-review.googlesource.com/c/chromium/src/+/2300266 The approach is different for IA2. Since IA2's setSelectionRanges requires actual nodes to be passed in, it doesn't make sense to move the selection range to different nodes than specified. Instead, this change simply returns E_INVALIDARG when two nodes are provided that exist in different trees. I generally don't like this approach, as it is reporting implementation limitations as a user-error, but I think it's the best approach for this particular scenario. A browser test was added that would crash without this fix in place. AX-Relnotes: n/a Bug: 1110522 Change-Id: Ifa8e9e7b43c52d611d0c77b134f5cb0ab3b86357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340291 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796515}
-
Jimmy Gong authored
- Introduce a "stopped" state when the printer is in an error state and is waiting for the user to fix the issue. - For example, if a user prints to a printer that is out of paper, the ongoing print job will now update to reflect that status. - Updated browser and unit tests to reflect this change. Screenshot (full view): https://screenshot.googleplex.com/YPR4R40jNeV Screenshot (collapsed view): https://screenshot.googleplex.com/A64F7TvHspR Bug: 1093527 Test: BrowserTest and UnitTest Change-Id: Ia72f23d67066d5640698163759ddf4151a59e07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342309 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#796514}
-
Sammie Quon authored
It will be between the IME pod and palette pod. Will add a simple test and place it on the correct shelf in a latter CL. Test: manual Change-Id: If67b781f558643aa42c501dddb8ebaba1017f445 Fixed: 1113938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342117 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796513}
-
Yicheng Li authored
The password and PIN views are used to receive password or PIN from the user. The relationship between the password and PIN views (both visually and functionally) should be the same as in lock screen. Because the in-session auth dialog uses white background, the password and PIN views are set to other colors to be visible. A follow-up change will query whether the user has PIN set up and hide the PIN view if there's no PIN. Bug: b:156258540 Change-Id: I63ab51839ce913ee61f159e3e56861dd9f4f735f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342364 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796512}
-
Ella Ge authored
This reverts commit 8f92c37d. Reason for revert: causing build failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15547? Original change's description: > Fix Role::kButton name invalidation when descendant text is modified > > This CL addresses a bug where Role::kButton, and possibly other roles > that derive their name from descendant contents, were not firing > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. > > ax_object_cache_impl.cc : > - When firing a text changed event, also fire a text changed event for > the first ancestor that derives its name from descendant contents. > This ensures the nodes are invalidated, send appropriate text changed > events, and the changes are serialized to the browser process AXTree. > > browser_accessibility_manager_win.cc : > - FireUiaTextContainerEvent made it possible to fire text events more > than once for a given text provider so it has been removed. > - Instead, populate a set |text_changed_events_| which contains the > text providers via |GetUiaTextPatternProvider| and fire the UIA text > events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents > - |text_selection_changed_events_| could also potentially end up with > the same double-event problem, so it uses GetUiaTextPatternProvider > now as well. > - Removing usage of std::unordered_set based on the guidance in > base/containers/README.md. In general these sets shouldn't grow large > enough to benefit from being unordered. > > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. > Bug: 1105262 > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796464} TBR=nektar@chromium.org,aleventhal@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com Change-Id: I0f08f5bccffe90464269207366411876f3d37d99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346996Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796511}
-
John Delaney authored
What: Re-lower conversion database sequence task priorirty. Why: The priority was raised to USER_VISIBLE on https://crrev.comc/2225739 in an attempt to resolve test timeouts seen with the feature enabled. This change did not fix the flakes, and the flakes were later addressed separately. This returns the priority to the intended value, as conversion operations work fine with delays. Bug: 1080764 Change-Id: I5f5907bd5e7711b0a6ed1db45db9f3713acf4765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340714Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796510}
-
Morten Stenshorne authored
The list of parameters was getting too long. Change-Id: Ia42d102b9333dc37deed7ea8450e4ff42abc3f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346385Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#796509}
-
Daniel Cheng authored
Currently, state synchronization between the browser and the renderer process is complicated and buggy for cross-process navigations. The renderer process is responsible for processing the commit IPC and then reporting success back up to the browser process, which then updates its state. However, it's unclear if this can lead to races. Instead, if it is possible to assume that one `CommitNavigation()` IPC from the browser always maps to one committed navigation in the renderer, the code can be simplified to remove multiphase navigation commits. This means the browser would be able to mark a provisional local frame as committed as soon as it sends a commit IPC to the renderer for that frame. As an initial step in this direction, this CL implements a renderer-side `CHECK()` that a request to commit a navigation from the browser always results in a committed navigation, with some initial exemptions for fallback content for embedded content, et cetera. However, this new `CHECK()` exposed some existing bugs in MHTMLx handling. The browser side navigation code does not know enough about an MHTML archive to determine if a commit will succeed or fail. Instead, the browser always assumes that a subframe navigation request will succeed and simply always calls `CommitNavigation()`. Unfortunately, the renderer silently ignores commit requests in subframes if the associated resource cannot be found in the MHTML archive, which triggers the new `CHECK()`. To fix this, committing a navigation to a non-existent MHTML resource will now simply commit a document constructed from an empty string with the text/html MIME type. This required updating the expectations for some existing MHTML tests that tested loading of non-existent MHTML resources. Before, the last committed URL would simply be empty, since the commit would silently be dropped. After, the last committed URL is now the URL of the non-existent resource. Finally, NavigationMhtmlBrowserTest.IframeAboutBlankNotFound exhibited a large number of complex interactions that still are not fully understood. It looks like the renderer now reports load completion *after* the about:blank fragment navigation completes, so update the test expectations accordingly... Bug: 999255 Change-Id: I2f9ac23b5668886b8b3bbbdcb7925f8784480c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335323 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#796508}
-
Yuly Novikov authored
TBR=kbr Bug: 1114780 Change-Id: Ifa3282c1a9391003eedd878f34ec0ff34da05835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346991Reviewed-by:
-
Rune Lillesveen authored
This is an alternative fix for issue 1104634 which should be equivalent to the behavior before the regression introduced in [1]. We now call UpdateActiveStyle() explicitly instead of relying on the UpdateActiveStyle() that was previously called via EnsureStyleResolver(). [1] https://crrev.com/dc63d9714044c5cc7825ed1d511d7810ba93a9a8 Bug: 1104634, 1113626 Change-Id: I4959ddf0a2efd237a04e29202d3432bbb7799eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346284Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#796506}
-
