- 27 Aug, 2019 40 commits
-
-
Piotr Pawliczek authored
The libipp is a new library to parse & build IPP frames. IPP = Internet Printing Protocol. BUG=chromium:902085 TEST=on local chrome build Change-Id: I2952870b332cc1ce456eb418bc1f8e5104fc6364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769161Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#690771}
-
Lambros Lambrou authored
In ClientSession, lossless-color defaulted to true. But the actual encoders defaulted this setting to false. Now that the lossless flags have been plumbed through to the encoders, the default setting has been changed from false to true. This CL restores the default setting to false, since lossless-color is not yet working for VP9. VP8 ignores the flags anyway, so is not affected. The command-line option is also removed. The lossless flags can be controlled via VideoControl messages if needed. Change-Id: I14637cdff74be5671aaa53ffd9f00b70302b55cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768879 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690770}
-
Tommy Steimel authored
While working on crrev.com/c/1771937 to split by profile, it was clear that MediaToolbarButtonController was going to have to be refactored to be an AudioFocusObserver and would essentially have to do the same tracking that MediaDialogController currently does. Instead of having this tracking in two places, I've instead refactored the two controllers into one. Bug: 992463 Change-Id: Ie424044e8ee678effe869a131347ba7869157624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772421Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#690769}
-
Becca Hughes authored
This crash is still appearing and I think |owner_| might be going away and cause the seg fault. This removes |owner_| from MediaNotificationBackground. BUG=994395 Change-Id: I59364ea14e9e7614728dac1e227133bcf76733c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772375Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#690768}
-
Vasiliy Telezhnikov authored
This CL fixes inconsistency between GMB (and hence ShareImage) format for video frame resources and TrasferableResource format. Bug: 988120 Change-Id: I77305a8bb5bcf1cefd6a5696d6f4b5e41e5311e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768936Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#690767}
-
Ioana Stefan authored
BackgroundTaskScheduler currently supports scheduling of one-off tasks and periodic tasks. The scheduling of tasks at exact moments in time will be introduced. This requires a new type of of information to be stored and a different flow and logic for scheduling. This will require AlarmManager, which will be added along the back-end logic in a future CL. This CL makes the changes related to the new information type. A new TimingInfo implementation is added, in order to store exact data. The TimingInfoVisitor implementations are updated. Changes are also done to the tests. The Design Doc for this change can be found here: https://docs.google.com/document/d/1o9BS5qwv10QVN3Df6W2m4QKjSo1DXdGIgLf8p2l0PYc/edit?usp=sharing. Bug: 970160 Change-Id: Ifd6cf89edeb2d9380b96bc095969d5875e8d8133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751190Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Ioana Stefan <ioanastefan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690766}
-
Himanshu Jaju authored
Updates the omnibox icon behaviour when sending SharingMessage Screenshot of text for translation : https://drive.google.com/file/d/1KmamVMMuhhX5skrxZvM1AhQshVK-ETxM/view?usp=sharing Video of animation : https://drive.google.com/file/d/1T9zrhBG-kMmZ6igkYKU-MybW9mjPlihh/view?usp=sharing Bug: 995694 Change-Id: I96af8098e70cd92867e1aa114f6617ec20b88581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765749 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#690765}
-
Steven Bennetts authored
The remaining instances of CrNetworkPolicyBehavior either use the 'Mojo' versions of the behavior, or are incorrect. This replaces them with CrNetworkPolicyBehaviorMojo. A follow-up could rename CrNetworkPolicyBehaviorMojo to just CrNetworkPolicyBehavior, but we should hold off until the mojo migration is complete before doing so. Bug: 853953 Change-Id: I9265eef9bde070d603ce6b2f88e6cc4d1b91fd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769596 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690764}
-
Jan Krcal authored
The test is disabled due to high flakiness. TBR: treib@chromium.org Bug: 997912 Change-Id: Ifa5e1cc89354163622a6a6ca593498c6fe3a6028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771974 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#690763}
-
Alex Turner authored
DoneHeadersAddToEntryComplete assumes that the previous result is OK. However, it may be ERR_CACHE_RACE in some situations, resulting in a crash. Converting to a CHECK would verify that this is the cause of some crashes observed in the wild. Bug: 959194 Change-Id: Ib989e85b5334667875e8669f442f32c274b0d23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773163Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#690762}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a7c5d0734c18..9d5b5c3f49f3 git log a7c5d0734c18..9d5b5c3f49f3 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 primiano@google.com Merge "Minor cleanups to build files" Created with: gclient setdep -r src/third_party/perfetto@9d5b5c3f49f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib8ecce1ec6b127865d68e4fcdfcd4e244db3adb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773276Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690761}
-
Joe Laughlin authored
startup BUG: 992003 Change-Id: Idac6ddfc0870fbe8f7a2bc7211b87b0ee5bb9c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741782 Commit-Queue: Joe Laughlin <joel@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#690760}
-
Sammie Quon authored
Fix issue with scrolling not working after rotating. Add keyboard shortcut to scroll - values will need to match webview keyboard values later on. Fix issue with flings not working on overview items. Fix issue with flings bouncing the grid occasionally. Test: manual, added tests Bug: 978112 Change-Id: I6ff805c321f3d59506e239a28f198211d94cde56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762575Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#690759}
-
David Bokan authored
These inject fling events directly into Blink. Since we've moved fling into the browser this is no longer how Chrome works. The tests that used this are all marked Skip so we'll remove these methods to avoid confusion. The (skipped) tests still using this API are: fast/events/touch/gesture/pad-gesture-cancel.html fast/events/touch/gesture/pad-gesture-fling.html fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html fast/events/wheel/mainthread-touchpad-fling-latching.html fast/events/wheel/wheel-fling-cancel.html Bug: 950314,857490 Change-Id: I7fe94e5654cc3d7c0769102989919d5a441d4f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773196 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690758}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3447e6b8f146..c74d7abaa6bd Created with: gclient setdep -r src-internal@c74d7abaa6bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I1abe9761818bca5b412243e2f4aa3cb88ef52a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773180Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690757}
-
Robbie Gibson authored
Bug: 996437 Change-Id: Ibc0331ad222e2cc3acb79915d3b85f9d3ab5af38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771969 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#690756}
-
Gayane Petrosyan authored
Bug: 997143 Change-Id: I2c2a7511e79d5fb0fbc72f8892a8541baf9c158c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772444Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#690755}
-
Lukasz Anforowicz authored
This has has the following benefits: - It forces us to consider data duplication across FrameNavigationEntry and PageState/ExplodedFrameState (e.g. url and referrer today). The CL makes the FrameNavigationEntry the authoratitative source of the information. - It is a prerequisite for persisting the |initiator_origin| of a navigation inside ExplodedFrameState (see also https://crrev.com/c/1679162). Because of the above, this CL changes the code so that: - Calls to NavigationEntryImpl::GetPageState *always* go through RecursivelyGenerateFrameState (before this CL this wasn't true for single-frame pages). - Calls to NavigationEntryImpl::SetPageState *always* go through RecursivelyGenerateFrameEntries (before this CL this wasn't true for single-frame pages). As a consequence of the changes above: - Tests can no longer use an arbitrary string as the PageState (although empty string as a PageState is still supported). - The call to NavigationEntryImpl::SetPageState always (not just for multi-frame pages) will drop old FrameNavigationEntries and create a new tree of FrameNavigationEntries. Bug: 976055 Change-Id: I132fffa26557a5903b8c3fbf703ca04808706e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737488 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690754}
-
Evan Stade authored
Bug: 819294 Change-Id: I8530e82029424d553703ee6f473372cc896c69aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772440Reviewed-by:
-
Daniel Clark authored
This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1757145, which was reverted due to Win7 failures of DumpAccessibilityTreeTest.AccessibilityArticle/uia. The issue is that I had not updated BrowserAccessibility::GetLocalizedStringForRoleDescription() to return a result for "article", as the Win10 native UIA implementation was already coming up with the correct value for <article>'s LocalizedControlType based on its Aria Role. However, appparently Win7's native UIA does not provide this value, so DumpAccessibilityTreeTest.AccessibilityArticle/uia -- which I had updated to dump the LocalizedControlType -- was failing on Win7. In the re-land I've updated BrowserAccessibility::GetLocalizedStringForRoleDescription() to handle <article> so that we no longer depend on the platform for providing the correct LocalizedControlType. Otherwise the change is the same as before. Original change description follows: Change ControlType of <article> from "Document" to "Group" per https://w3c.github.io/html-aam/#el-article Change LocalizedControlType of <figure> from "group" to "figure" per https://thepaciellogroup.github.io/AT-browser-tests/test-files/figure.html Bug: 994380 Change-Id: I00fb18edda6c3bf86804bc26bf82201e65fab06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769051Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690752}
-
Avi Drissman authored
BUG=990863 Change-Id: Iafa06776aac05a379eb1bb16753edba2c85b8481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769337 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690751}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c8f9cb45dde..f01008997555 git log 3c8f9cb45dde..f01008997555 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 michaelludwig@google.com Revert "gpu: Update GrGLCaps usage of fTextureRectangle with chromium." 2019-08-27 nihohit@gmail.com compile.sh: Use emar in order to bundle libraries. 2019-08-27 mtklein@google.com <ostream> -> <iosfwd> 2019-08-27 kjlubick@google.com [canvaskit] Add sundry APIs and tests 2019-08-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3c6b2e1613c8..57ad1e1287dd (8 commits) 2019-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 26bef937..31c682b2 (361 commits) 2019-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d6dc4b7e4533..605f863173b6 (4 commits) 2019-08-27 khushalsagar@chromium.org gpu: Update GrGLCaps usage of fTextureRectangle with chromium. Created with: gclient setdep -r src/third_party/skia@f01008997555 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: chromium:900706,chromium:None,chromium:None,chromium:None,chromium:900706 Change-Id: Ib2b9d444a4ba7fb5d694cbcf31995a6161567eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773178Reviewed-by:
-
Dave Tapuska authored
The feature long ago shipped in Chrome 67. The old code paths can be removed. BUG=680741 Change-Id: If837ffa2a524ece0867c0915e101df37b1af6520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768902Reviewed-by:
-
Vadym Doroshenko authored
This CL replaces PasswordFormManager->NewPasswordFormManager. The main difference is that a constructor of form managers are different: PasswordFormManager takes PasswordForm NewPasswordFormManager takes FormData (which is converted to PasswordForm inside NewPasswordFormManager during parsing). Bug: 949519 Change-Id: Ibd1ddda5f9a20495f00cea9cc2ceed6f7ba2a5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772876 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#690748}
-
Vasilii Sukhanov authored
TBR=sergeyu@chromium.org Bug: 997953 Change-Id: I6d8e98aefa6d37a556d295b9cbc115ef94572797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773259Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690747}
-
Kai Ninomiya authored
https://github.com/gpuweb/gpuweb/pull/389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690746}
-
Xiyuan Xia authored
Reflecting layer should clear its reference in the reflected layer when it is released. Otherwise, crash happens when it is referenced, e.g. when the reflected layer changes bounds. Bug: 997113 Change-Id: Ic745033f58da7dad167e23bfe5539fc97791be28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772300 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690745}
-
Vadym Doroshenko authored
Adding people that currently working on Autofill as owners for 3rd party libraries that are used in Autofill code. Change-Id: I1d965080082c092afa55b3d81d82d7e2075c7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771411Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#690744}
-
Vasilii Sukhanov authored
TBR=dpapad@chromium.org Bug: 997943 Change-Id: Ic023c2259022d11a965f4d96c414fdd37b0d96a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771973Reviewed-by:
-
Elly Fong-Jones authored
This change implements flag expiration, with the same goal but a very different method than the previous implementation (https://chromium-review.googlesource.com/c/chromium/src/+/1729449). This change preserves the flag-metadata.json file as the sole authoritative source for flag expiration data. During the build process, a new script (//tools/flags/generate_expired_list.py) generates a data structure from flag-metadata.json listing flags that are expired at or before the current milestone, with their expiration milestones. Logic in //chrome/browser/about_flags.cc and //chrome/browser/unexpire_flags.cc then conditionally hides these flags, depending on the state of the unexpire flags - see //doc/flag_expiry.md for details about those. Specifically, this change: 1) Renames //tools/flags/list-flags.py to list_flags.py to make it importable as a module; 2) Introduces //chrome/browser/expired_flags_list.h, which describes a data structure for representing expired flags; 3) Introduces //tools/flags/generate_expired_list.py, which takes as inputs //chrome/browser/flag-metadata.json and //chrome/VERSION and generates a C++ source file containing a data structure matching that in expired_flags_list.h; 4) Has the //chrome/browser build target depend on the generated file from step 3; 5) Re-introduces an unexpire flag as described in //doc/flag_expiry.md; 6) Adds logic to //chrome/browser/about_flags.cc to conditionally hide expired flags. This means that flag-metadata.json is the sole determinant of whether a flag is currently expired or not. Note that this change expires all flags whose expiration milestones were *M76* or earlier, not M78 (the current mstone); this is because the backlog of flags to expire is currently quite large. In M79, we will expire flags <= M78, then in M80, we will expire flags <= M80; after that, each milestone Mx will expire flags <= Mx. Also note that this change discards the notion of flag expiry depending on usage metrics - i.e., we will now expire *all* flags that expire before the target milestone, not just the N with the lowest usage. The lowest-usage design proved to be extremely manual to implement and very difficult for developers to predict the results of. Bug: 953690 Change-Id: I7389b667d1e032c795c137cafadf0e5e80fb82c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754762 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690742}
-
Becca Hughes authored
Remove the "enable playback at the lock screen" setting from the UI. The pref should remain since we use it for enterprise. BUG=997755 Change-Id: I65dcc2c613cde48907840d593ee7b8091f3fff8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771393Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#690741}
-
Marc Treib authored
In particular, this removes AutofillWalletMetadataSyncableService and AutofillWalletDataTypeController, which were unused after https://crrev.com/c/1771600. Bug: 853688 Change-Id: Ibb5ff3c2aa9acb5c44cce96bb9abfeaf844cbd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768775 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/30ab015fc908..4271afbc301e git log 30ab015fc908..4271afbc301e --date=short --no-merges --format='%ad %ae %s' 2019-08-27 yinwa@webrtc.org Fix the bug and reland "Make min video target bitrate configurable." Created with: gclient setdep -r src/third_party/webrtc@4271afbc301e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I7a40307e9952f86004454ba8235fc3a590ab1f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771195Reviewed-by:
-
Nicolás Peña Moreno authored
The onload-related tests were meant to test the performance timeline buffering behavior. But now that Event Timing is not exposed on the timeline, those tests don't really make much sense. Instead, a test is added to test that the timestamps corresponding to two 'consecutive' clickAndBlockMain() calls behave as one would expect. Bug: 987236 Change-Id: Icc798fe1e0684a52992a83ba4de931481e1ded2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766762Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#690738}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2697f1f03de1..76a93c3325f5 git log 2697f1f03de1..76a93c3325f5 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 svaisanen@nvidia.com Remove skipping of several tests on NVIDIA since they are now passing Created with: gclient setdep -r src/third_party/angle@76a93c3325f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I6c42ec144cb97a1129eec06e474d5aff096d64da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773177Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts RestrictedCookieManagerPtr to new Mojo types. It uses mojo::PendingRemote<RestrictedCookieManager> or mojo::Remote<RestrictedCookieManager> and uses Receiver instead of Binding. Bug: 955171, 978694 Change-Id: Icd8efb20d68449368a078c31337cc22e49c456ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767444 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#690736}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4d4513f..ede169e1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c271dcc186cab931e9aef21a2bd0417081ee9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772547Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690735}
-
Alan Cutter authored
It's not obvious that just entering "localhost" in the chrome://flags/#unsafely-treat-insecure-origin-as-secure input field won't do anything. This CL adds a small example showing the "http://" part is required. Bug: 995002 Change-Id: Ic08ef53e67d397086abbf734facb437ec0717a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771096Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#690734}
-
Jan Wilken Dörrie authored
This change fixes a bug in the leak detection feature where the encrypted username was not canonicalized. Bug: 986298 Change-Id: If01eb2ea7b87c24843c155dba91a2d81526fea91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771963 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is phase 1.4 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ rtc_rtp_receiver.cc|h are moved to renderer/platform/peerconnection, and web_rtc_rtp_source.h gets a factory method added so content can still access its functionality. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I5591f8aa79eea7f08c5c3460fc79212ab5fb4805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770240 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#690732}
-
