GitLab

BUG=622743

Review-Url: https://codereview.chromium.org/2810403003
Cr-Commit-Position: refs/heads/master@{#465645}

Somehow sometimes browser shutdown crashes on shutting down
the DB thread for these tests on mac.

BUG=712872

Review-Url: https://codereview.chromium.org/2820343003
Cr-Commit-Position: refs/heads/master@{#465644}

Only one target (somewhat questionably) still uses this, so just set
the include directory in that target directly.

BUG=401588
TBR=brettw

Review-Url: https://codereview.chromium.org/2826113002
Cr-Commit-Position: refs/heads/master@{#465643}

ResourcePrefetchPredictor tries to prefetch resources from a precache manifest
if there is no available prediction based on local history.
This CL also adds the check for the manifest age before save it to the database.

BUG=699115

Review-Url: https://codereview.chromium.org/2825693002
Cr-Commit-Position: refs/heads/master@{#465642}

It could happen that cryptohome service is not yet available
during login in ExistingUserController, especially for auto-launched
public sessions or ARC Kiosk. In that case mounting will fail and session
will exit.
It's safer to use CryptohomeClient::WaitForServiceToBeAvailable to ensure.

BUG=702045

Review-Url: https://codereview.chromium.org/2817933003
Cr-Commit-Position: refs/heads/master@{#465641}

We used to always create opaque DRM framebuffers.
After crrev.com/2790553002 we started allowing non-opaque fb.

GbmSurface, that was used in some tests, would allocate a BGRA
buffer and use it as primary plane. On some devices formats
with alpha are not supported on primary plane.

This CL makes sure that GbmSurface allocates RGBX buffers.

BUG=707108
TEST=video_decode_accelerator_unittest now passes.

Review-Url: https://codereview.chromium.org/2825933002
Cr-Commit-Position: refs/heads/master@{#465640}

Settings fingerprint list tests do not wait for the method to be called before procedding if the method has been called previously. Fix this by resetting the promise resolver each time the method is called, if it is called again later in the test.

TEST=browser_tests --gtest_filter="CrSettingsFingerprintListTest.*"
BUG=712880

Review-Url: https://codereview.chromium.org/2821133005
Cr-Commit-Position: refs/heads/master@{#465639}

The flake seems to be because of a race between the order of running main and impl
thread. Resources are always reclaimed after impl threads posts
DidCommitAndDrawFrame to the main thread so whether commit_count_ == 4 or 5
depends on whether we switch to main thread or keep running impl thread and
reclaim resources which triggers posting a task to the main thread to release the
mailbox. Even though the task for DidCommitAndDrawFrame is posted first, the task
for releasing mailbox is posted using a blocking task runner so it is run first.
In order to solve this issue, we decided to use
DidReceiveCompositorFrameAck instead of DidCommitAndDrawFrame because
all the resources are released before DidReceiveCompositorFrameAck is
called so the race between releasing resources and starting next commit
doesn't happen. In single-thread mode we used to call
DidReceiveCompositorFrameAck directly instead of PostTasking which
caused different behaviour from multi-thread mode. We decided to also
use PostTask for DidReceiveCompositorFrameAck in single thread mode and
use weak pointers to discard the ack if CompositorFrameSink is released
before ack is processed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
BUG=702868

Review-Url: https://codereview.chromium.org/2757373002
Cr-Commit-Position: refs/heads/master@{#465638}

BUG=702356

Review-Url: https://codereview.chromium.org/2832563002
Cr-Commit-Position: refs/heads/master@{#465637}

BUG=713138

Review-Url: https://codereview.chromium.org/2826713004
Cr-Commit-Position: refs/heads/master@{#465636}

Added INSETS_BUBBLE_TITLE metric to distinguish from INSETS_DIALOG_TITLE

BUG=711012
BUG=705907

Review-Url: https://codereview.chromium.org/2819633002
Cr-Commit-Position: refs/heads/master@{#465635}

For consistency, remove trailing dots from those captions that have
them.

BUG=none

Review-Url: https://codereview.chromium.org/2830443007
Cr-Commit-Position: refs/heads/master@{#465634}

Review-Url: https://codereview.chromium.org/2830563002
Cr-Commit-Position: refs/heads/master@{#465633}

This is a mechanical change.

This refactoring is needed for future work and it resolves an
issue with the UpdateClientTest::SendUninstallPing, where the test
is missing the RunThreads() call at the end.

This change makes the UpdateClient API consistent, since all
non-blocking APIs now take a callback parameter.

Review-Url: https://codereview.chromium.org/2831473002
Cr-Commit-Position: refs/heads/master@{#465632}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0bcfc3331d11..24e36dadf5b1

$ git log 0bcfc3331..24e36dadf --date=short --no-merges --format='%ad %ae %s'
2017-04-19 stani Fix error when running map_traces

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6f83224ce6fc1728c45143420d6468b1b1e2aa1d
Reviewed-on: https://chromium-review.googlesource.com/481114
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465631}

Test with  --force-tablet-mode=touch_view

BUG=712901

Review-Url: https://codereview.chromium.org/2832523002
Cr-Commit-Position: refs/heads/master@{#465630}

This change tentaively adds back the touch slop
region suppression in browser. This will cause
the touch pointerevents stop firing while the
touch point is moving within the slop region and
thus break a few tests.
But we would like to see whether it affects
our TouchToFirstScrollUpdateSwapBegin metric
or not.

BUG=704935

Review-Url: https://codereview.chromium.org/2816613003
Cr-Original-Commit-Position: refs/heads/master@{#465252}
Committed: https://chromium.googlesource.com/chromium/src/+/b8126037096ad1da5aa13af72af5a5580cf22263
Review-Url: https://codereview.chromium.org/2816613003
Cr-Commit-Position: refs/heads/master@{#465629}

BUG=707651

Review-Url: https://codereview.chromium.org/2825353002
Cr-Commit-Position: refs/heads/master@{#465628}

Add an Arguments::GetAll() function that returns all arguments as a
std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
slightly more performant than the alternative of using
Arguments::GetRemaining() since it doesn't require trying to convert
and avoids unnecessary calls.

Add a test for the new method.

Reverted due to a compile error, now fixed.

BUG=None

Review-Url: https://codereview.chromium.org/2822373002
Cr-Commit-Position: refs/heads/master@{#465627}

https://skia.googlesource.com/skia.git/+log/c86d377a4c59..3a3bc42b7d5b

$ git log c86d377a4..3a3bc42b7 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 egdaniel Check-in vulkan.h into third_party and use that instead of local sdk vulkan.h

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I7fb67ecb321a2bc0779aa792b05424dda402784e
Reviewed-on: https://chromium-review.googlesource.com/481800Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465626}

This method is a helper for __gCrWeb.fillPasswordForm. The only usage
outside of JavaScript is in password_controller_unittest.mm, which tests
explicitly the scenario of detecting password fields in nested iframes.
This change beefs up test cases in PasswordControllerTest so the nested
iframe case is tested using the public fillPasswordForm API.

BUG=614092
TESTED=Ran ios_chrome_unittests

Review-Url: https://codereview.chromium.org/2825123003
Cr-Commit-Position: refs/heads/master@{#465625}

Using dummy.package as a package name causes problems in Android Studio
2.3.

BUG=webrtc:7498, 700438

Review-Url: https://codereview.chromium.org/2827923002
Cr-Commit-Position: refs/heads/master@{#465624}

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

Introduce SessionIOS that store the information about a session
(e.g. a BrowserList) with a list of SessionWindowIOS objects and
change SessionServiceIOS to use SessionIOS in its API.

Add support for loading legacy saved session with a single root
object of type SessionWindowIOS by creating a SessionIOS on the
fly.

BUG=710848

Review-Url: https://codereview.chromium.org/2811593004
Cr-Commit-Position: refs/heads/master@{#465623}

Revert of DCHECK for execution context being unsuspended during v8 bindings callback. (patchset #2 id:20001 of https://codereview.chromium.org/2800093002/ )

Reason for revert:
Speculative revert because of
BUG=711196

Original issue's description:
> DCHECK for execution context being unsuspended during v8 bindings callback.
>
> To prevent loss of data, change silent failure when trying to run a v8 callback on a suspended execution context to a DCHECK.
>
> R=haraken@chromium.org
> CC=skyostil@chromium.org
>
> BUG=702218,702160
>
> Review-Url: https://codereview.chromium.org/2800093002
> Cr-Commit-Position: refs/heads/master@{#463869}
> Committed: https://chromium.googlesource.com/chromium/src/+/7e5e14e80e181ad914e09d9f607281f248ec49e6

TBR=haraken@chromium.org,altimin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=702218,702160

Review-Url: https://codereview.chromium.org/2825363002
Cr-Commit-Position: refs/heads/master@{#465622}

TBR=wychen@chromium.org,tedchoc@chromium.org
BUG=713094

Review-Url: https://codereview.chromium.org/2830673003
Cr-Commit-Position: refs/heads/master@{#465621}

BUG=713009

Review-Url: https://codereview.chromium.org/2829463004
Cr-Commit-Position: refs/heads/master@{#465620}

Revert of [scheduler] Move some task types to suspendable task runner. (patchset #1 id:1 of https://codereview.chromium.org/2808273003/ )

Reason for revert:
Reverting as suggested in
BUG=711196

Original issue's description:
> [scheduler] Move some task types to suspendable task runner.
>
> Move several safe-looking task types to suspendable task runner.
> More task types will be moved to suspendable task runner, but
> we'll start with this set and will monitor any problems
> (there were some perfbot failures when all task queues were
> moved to suspendable task runner).
>
> R=haraken@chromium.org
> CC=skyostil@chromium.org
> BUG=702160
>
> Review-Url: https://codereview.chromium.org/2808273003
> Cr-Commit-Position: refs/heads/master@{#464025}
> Committed: https://chromium.googlesource.com/chromium/src/+/78a049660074003b8e1e602b0e7783ca7f1f4ee0

TBR=haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=702160

Review-Url: https://codereview.chromium.org/2829643002
Cr-Commit-Position: refs/heads/master@{#465619}

Calls to navigator.vibrate will immediately return 'false' if user
hasn't tapped on the frame or any embedded frame yet.

The implementation is behind an experimental flag.

The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik

BUG=704650

Review-Url: https://codereview.chromium.org/2778693004
Cr-Commit-Position: refs/heads/master@{#465618}

git log --oneline --no-decorate 071c51e26..c7bf515d7
 c7bf515 Expose raw_headers (#113)
 662d5ed Disable E305 pyflakes lint
 6059a5e Remove a check from resolve_content() that is never hit. (#107)
 2ce4303 Use HTTPError correctly. (#106)
 8a981b7 Merge pull request #98 from w3c/six
 69298c6 Link to docs in README
 5e9f4c2 Import quote and unquote from six.
 b9b2eae Import parse_qs and urljoin from six.
 7311324 Import parse_qsl from six.
 5a3336d Import urlsplit from six.
 3157b3d Import urlunsplit from six.
 639329c Import Request from six.
 f1988dd Import urlopen from six.
 b7e6bb2 Import urlencode from six.
 411a415 Import HTTPError from six.

Commit c7bf515 ("Expose raw_headers") is required for some XMLHttpRequest
tests to pass.

Bug: 700434
Change-Id: Ief6d4d19c1cd40ea6107eec2d1998511aa8393c0
Reviewed-on: https://chromium-review.googlesource.com/481760Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#465617}

base/android/context_utils.* is being removed.

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094

Review-Url: https://codereview.chromium.org/2810863003
Cr-Commit-Position: refs/heads/master@{#465616}

app_custom_bindings.js checks for if 'app' is available, but doesn't
need to - if it's unavailable, the getter will never be added to the
chrome object, and the custom bindings will never be called.

BUG=None

Review-Url: https://codereview.chromium.org/2829453002
Cr-Commit-Position: refs/heads/master@{#465615}

Previously, only one sampling operation could be running and it was
generally used to profile the startup of the browser.  To make it more
useful, it can now run against any thread and multiple profilers can
execute in parallel.

Sampling will continue until the desired number of samples has been
collected, it is manually stopped, or the controlling object gets
destructed.

The SamplingThread is a singleton base::Thread that is self-managing.
- It is started (via GetOrCreateTaskRunnerForAdd) on the calling
  thread when work arrives.
- It stops (via ShutdownTask) on its own thread when it has been
  idle for 1 minute.
- DetachFromSequence is called after both of these to allow for
  accessing the API from different threads.
- thread_execution_state_lock_ is held when doing Thread API calls to
  ensure that access is sequenced.

The sampled thread is expected to live at least as long as the
thread controlling the sampling.

BUG=671716

Review-Url: https://codereview.chromium.org/2554123002
Cr-Commit-Position: refs/heads/master@{#465614}

This includes the load_server_info_time_to_srtt, enable_connection_racing and disable_disk_cache finch options.

BUG=707953

Review-Url: https://codereview.chromium.org/2820573004
Cr-Original-Commit-Position: refs/heads/master@{#465474}
Committed: https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f02f94d76d2dda
Review-Url: https://codereview.chromium.org/2820573004
Cr-Commit-Position: refs/heads/master@{#465613}

BUG=

Review-Url: https://codereview.chromium.org/2821203004
Cr-Commit-Position: refs/heads/master@{#465612}

Example output:
host: fr.m.wikipedia.org
last_visit_time: 2017-04-19 13:54:14
origins:
  origin: https://upload.wikimedia.org/
  number_of_hits: 3
  number_of_misses: 2
  consecutive_misses: 1
  average_position: 2.375000
  always_access_network: False
  accessed_network: True

  origin: https://fr.m.wikipedia.org/
  number_of_hits: 5
  number_of_misses: 0
  consecutive_misses: 0
  average_position: 1.000000
  always_access_network: False
  accessed_network: False

BUG=699080

Review-Url: https://codereview.chromium.org/2827043002
Cr-Commit-Position: refs/heads/master@{#465611}

It appears the original reason this bug was disabled does not reproduce
anymore; also fixed unrelated test bug (it's unrelated to the original
reason the test was disabled, because, originally, instantiation wasn't
working full stop because of differences in contexts. Test bug just
wasn't receiving data correctly.)

BUG=chromium:700788

Review-Url: https://codereview.chromium.org/2822193003
Cr-Commit-Position: refs/heads/master@{#465610}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d924131d..4f7d9852

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2826053002
Cr-Commit-Position: refs/heads/master@{#465609}

This way the initial bounds can be configured during construction as
with other windows.

BUG=708287
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2823853006
Cr-Commit-Position: refs/heads/master@{#465608}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cabc13146729..0bcfc3331d11

$ git log cabc13146..0bcfc3331 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 benm Add a new tracing agent / importer for android process data.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib9e3a120c30a85ca4f0a71ef27eb21e3a342cc61
Reviewed-on: https://chromium-review.googlesource.com/481602
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465607}

Using the newly created bundleid and mobileprovision, the search widget
can be integrated in the application alongside the current today widget.
When running on device after this check-in, it is necessary to install
the SearchTodayExtension mobileprovision.

BUG=622743, 682230

Review-Url: https://codereview.chromium.org/2814783003
Cr-Commit-Position: refs/heads/master@{#465606}