GitLab

If this change was responsible for this regression, it may also have been responsible for 

http://crbug.com/133762
http://crbug.com/138260
TEST=mac intl perf bot drops:
http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1
Review URL: https://chromiumcodereview.appspot.com/10837192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141751

Review URL: https://chromiumcodereview.appspot.com/10824253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151034 0039d316-1c4b-4281-b951-d872f2087c98

Mark ExtensionInstallUIBrowserTest.AppInstallConfirmation and AppInstallConfirmation_Incognito as flaky on Windows.

TBR=xiyuan@chromium.org
BUG=141854
Review URL: https://chromiumcodereview.appspot.com/10827278

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151033 0039d316-1c4b-4281-b951-d872f2087c98

from the application.ini file. 

This way we can display different names in the importer combobox,
depending on the Firefox flavour that is installed on the machine.

One such example is the Debian rebranding of Firefox, i.e. Iceweasel.

BUG=119279

Review URL: https://chromiumcodereview.appspot.com/10830098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151032 0039d316-1c4b-4281-b951-d872f2087c98

Includes a unit test to exercise this functionality.

BUG=138384
TEST=Ensure that Chrome makes an HTTP request to the Variations server when it receives an auto update.


Review URL: https://chromiumcodereview.appspot.com/10790116

TBR=stevet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141668
TEST=Debug menu, opening inspector works


Review URL: https://chromiumcodereview.appspot.com/10823263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151029 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rlarocque@chromium.org
BUG=141849
Review URL: https://chromiumcodereview.appspot.com/10828254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151025 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit of r145925

BUG=136828
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10702038


TBR=junov@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151024 0039d316-1c4b-4281-b951-d872f2087c98

Really ignore events for replacement content in the webnavigation api and discard a pending RVH if the primary one crashes

BUG=139117
TEST=no flakiness


Review URL: https://chromiumcodereview.appspot.com/10824241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130456
TEST=Check app shortcuts are removed when the app is uninstalled. Test extension uninstallation in general.


Review URL: https://chromiumcodereview.appspot.com/10837034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113688


Review URL: https://chromiumcodereview.appspot.com/10854079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151020 0039d316-1c4b-4281-b951-d872f2087c98

Concatenated strings are hard to localize. Menu items and button texts should be provided as a complete strings instead of a concatenation of two strings. 
Add UI strings for the permissions drop downs of the Website Settings UI that are easy to localize.


BUG=113688
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10855031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151019 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138063
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10823229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151017 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10825295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151015 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10826225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151014 0039d316-1c4b-4281-b951-d872f2087c98

Use the in-memory version for GDataFileSystemTest.


BUG=137945
TEST=unit_tests   --gtest_filter='GDataFileSystemTest*'

Review URL: https://chromiumcodereview.appspot.com/10830181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151013 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151010 0039d316-1c4b-4281-b951-d872f2087c98

* Remove static FromDocumentEntry from GDataEntry, GDataFile, GDataDirectory. Replace with InitFromDocumentEntry.
* Move common code from GDataFile::InitFromDocumentEntry and GDataDirectory::InitFromDocumentEntry to GDataEntry::InitFromDocumentEntry.
* Add GDataDirectoryService::FromDocumentEntry and use this everywhere.
* Make ctors of GDataFile, GDataDirectory private, so these must be created by GDataDirectoryService's CreateGDataFile and
CreateGDataDirectory. Make GDataEntry ctor protected.

BUG=141494
TEST=unit tests.
Review URL: https://chromiumcodereview.appspot.com/10854083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141157
TEST=unit tests on daisy.


Review URL: https://chromiumcodereview.appspot.com/10827223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151007 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151006 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10825292

TBR=yutak@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140106

Review URL: https://chromiumcodereview.appspot.com/10827246

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140508


Review URL: https://chromiumcodereview.appspot.com/10852017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151002 0039d316-1c4b-4281-b951-d872f2087c98

It is not failing anymore (the patch caused the failure is reverted).

BUG=136169

Review URL: https://chromiumcodereview.appspot.com/10830255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151001 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151000 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10837200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130138
TBR=brg@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10828248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150998 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150997 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10825292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134169
TEST=Manual test by dragging frameless window


Review URL: https://chromiumcodereview.appspot.com/10823195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150994 0039d316-1c4b-4281-b951-d872f2087c98

Add RegisterHandler() and UnregisterHandler(), which should be called before and after calls to UpdateRegisteredIds().  Use UnregisterHandler() on
shutdown instead of UpdateRegisteredIds(_, ObjectIdSet()).

Make SyncNotifierHelper non-thread-safe.  Fix test breakages that this revealed.  Also add GetAllRegisteredIds() instead of making it the return value of UpdateRegisteredIds().

Propagate UpdateRegisteredIds()/RegisterHandler()/UnregisterHandler() all
the way up to ProfileSyncService.

Make FakeSyncManager be created on the sync thread.

Clean up SyncBackendHost startup/shutdown behavior a bit.

BUG=140325


Review URL: https://chromiumcodereview.appspot.com/10824161

TBR=akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150992 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise we might be on a different context and that triggers invalid drawable
errors.

BUG=none
TEST=by hand, open an html5 video, reload it a bunch of times, close it,
TEST=check for no weird invalid drawable error messages.

Change-Id: Icc20efa35daf988edb1ecb2cb572e5b484719b35


Review URL: https://chromiumcodereview.appspot.com/10837199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150991 0039d316-1c4b-4281-b951-d872f2087c98

Add RegisterHandler() and UnregisterHandler(), which should be called before and after calls to UpdateRegisteredIds().  Use UnregisterHandler() on
shutdown instead of UpdateRegisteredIds(_, ObjectIdSet()).

Make SyncNotifierHelper non-thread-safe.  Fix test breakages that this revealed.  Also add GetAllRegisteredIds() instead of making it the return value of UpdateRegisteredIds().

Propagate UpdateRegisteredIds()/RegisterHandler()/UnregisterHandler() all
the way up to ProfileSyncService.

Make FakeSyncManager be created on the sync thread.

Clean up SyncBackendHost startup/shutdown behavior a bit.

BUG=140325


Review URL: https://chromiumcodereview.appspot.com/10824161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150990 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141207

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150664

Review URL: https://chromiumcodereview.appspot.com/10832207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141550


Review URL: https://chromiumcodereview.appspot.com/10825288

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10827267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150986 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150985 0039d316-1c4b-4281-b951-d872f2087c98