- 31 Jul, 2018 40 commits
-
-
Kyle Milka authored
Hide the Google Photos option for custom backgrounds as it will not be launched in M69. All service requests occur after clicking on the option, so simply hiding it is sufficient. Bug: 869230 Change-Id: I55ca201978323cd7031e618b6a9039b93a485130 Reviewed-on: https://chromium-review.googlesource.com/1155978Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#579309}
-
Peter Collingbourne authored
This relands commit 748ac91e. Includes workaround for LTO bug exposed by orderfile generation: add -Wl,-u,__cyg_profile_func_enter_bare to ldflags. A fix for the bug is under review: https://reviews.llvm.org/D50017 Original change's description: > Reland "build: Enable ThinLTO in official Android builds." > > This relands commit 1ba5d611. > > Fixes chromeos build issue by checking whether we have a secondary > toolchain before comparing it with the current toolchain. > > Original change's description: > > build: Enable ThinLTO in official Android builds. > > > > With this change we start building Chromium with ThinLTO when targeting > > Android. In 64-bit Monochrome builds, the 32-bit binary is also built > > with ThinLTO. This change is expected to reduce code size significantly > > (in local measurements it reduced the size of MonochromePublic.apk by 2.3MB) > > and is a prerequisite for enabling control flow integrity in official > > builds. > > > > Note that although this change enables ThinLTO, it does not enable > > the cross-TU optimizations normally associated with LTO. Enabling > > cross-TU optimizations is a separate project. > > > > On my local machine (a Lenovo P920) libmonochrome.so link times increase > > as follows: > > > > before after (first link) after (incremental links) > > 32-bit 18s 140s 50s > > 64-bit 13s 107s 41s > > > > All known blockers have now been fixed. This CL is likely to uncover > > unknown blockers. > > > > Bug: 469376 > > Change-Id: I8981e17abd50bc5ca00440e0d74dda878c911749 > > Reviewed-on: https://chromium-review.googlesource.com/1150870 > > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#578195} > > Bug: 469376, 868426 > Change-Id: Ie46ba0db0ac68130bc600415777de5c813b28ebd > Reviewed-on: https://chromium-review.googlesource.com/1153612 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578854} Bug: 469376, 867878 Change-Id: Iae4cc698b5955df5ae1970c71646fa05fca61109 Reviewed-on: https://chromium-review.googlesource.com/1155977Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579308}
-
Yoichi Osato authored
This patch introduces a DCHECK checking if DocumentMarker.endoffset is not over text length when adding each marker. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4f2681460d1de1aacf78b55d7bba454dfc557cf2 Reviewed-on: https://chromium-review.googlesource.com/1149763 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579307}
-
rbpotter authored
If the "No destinations" message was visible in the recent destinations list, the iron-list containing the destinations was pushed down and extended invisibly over the "Manage" link for the print destinations, preventing the link from working. Fix this by ensuring that the iron-lists are the correct height: height of the parent - height of parent's header line - height of "No destinations" message (if showing). Bug: 868274 Change-Id: Idf574923d69ae1c0ff1265efe62b9cc67b70af11 Reviewed-on: https://chromium-review.googlesource.com/1153430 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#579306}
-
Pavel Feldman authored
Change-Id: If11eab039bdc86257da197d9adbe6ff64764c627 Reviewed-on: https://chromium-review.googlesource.com/1154435Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579305}
-
Luciano Pacheco authored
Change icons for each team drive in the directory tree and on file list (RHS). Bug: 865993 Change-Id: If880279f9776ff70b33d13ec02aaeb5d4ce44290 Reviewed-on: https://chromium-review.googlesource.com/1155282Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#579304}
-
Esmael El-Moslimany authored
Bug: 809359 Change-Id: I8c04faa4761dc1d01cbb4ad1d2e77fda3c874c72 Reviewed-on: https://chromium-review.googlesource.com/1148948 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579303}
-
Patti authored
The default sort order of the All Sites page is by the amount of site engagement each site has. Retrieve the site engagement score for each origin in All Sites and sort the list by the max site engagement per domain (eTLD+1) group. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I421c41f3307a4e5b3ea35683bc4455dfc69ecd96 Reviewed-on: https://chromium-review.googlesource.com/1141667 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579302}
-
Alexey Baskakov authored
TBR=tapted@chromium.org Bug: 869241 Change-Id: I932f8c321839a21dda61285df3f8a5f5856ac9ea Reviewed-on: https://chromium-review.googlesource.com/1155278 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#579301}
-
Takuto Ikuta authored
This is mainly to pick up below change. https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1105680 Change-Id: I1369f416e81cd8582dfd847589b1996bb38e6064 Reviewed-on: https://chromium-review.googlesource.com/1154864Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#579300}
-
kristipark authored
Currently, the settings menu is only shown when custom backgrounds is enabled. Now it should also appear when custom links is enabled. Menu options for the respective features are hidden if the feature is disabled, and the "Restore default..." options are grayed out instead of hidden when there is nothing to restore. Bug: 868529, 868527 Change-Id: I383c7e6350e96f226ea39a9b1315cc274d03df51 Reviewed-on: https://chromium-review.googlesource.com/1154193 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579299}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ibfc1117d1c08fd3fd8a125a8dc2af9d159b4028b Reviewed-on: https://chromium-review.googlesource.com/1156066Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#579298}
-
Xiangjun Zhang authored
This CL adds implementation to connect the CastRemotingConnector with remoter when requested from Mirroring Service. Bug: 734672 Change-Id: I213b4f06bdbd7ad188969310da867bf939cdd0f2 Reviewed-on: https://chromium-review.googlesource.com/1144409 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579297}
-
Yoshifumi Inoue authored
Make SetSelectionToDragCaret() not to use FrameSelection::ComputeVisibileSelectionInDOMTreeDeprecated() This patch changes |SetSelectionToDragCaret()| to use |FrameSelection::ComputeVisibileSelectionInDOMTree| instead of deprecated version for improving code health. This is 2/3 of series of patches: 1. http://crrev.com/c/This patch 2. This patch 3. http://crrev.com/c/1153071 Bug: 698633 Change-Id: Ie51e4b8524c4429fb04a065cb13264e7277d2697 Reviewed-on: https://chromium-review.googlesource.com/1153070 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#579296}
-
Mathieu Perreault authored
It will be executed "when the page has finished parsing" which seems right for this script. Bug: 868432 Change-Id: Icb0fb03518aca785c7a3d8583bcbfaecd4cb1487 Reviewed-on: https://chromium-review.googlesource.com/1154365Reviewed-by:
-
Pavel Feldman authored
Change-Id: I2ec5bafdb4ce19336b0cc4279fdab24cfacc4b09 Reviewed-on: https://chromium-review.googlesource.com/1154431Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia2f39271db9f31ff6c462cb11ca65d436ed3018b Reviewed-on: https://chromium-review.googlesource.com/1155803Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579293}
-
Trent Apted authored
Bug: 867700, 860355 Change-Id: Ifcc4ada00bc459b8cd59a5c2b234af0ef3554c61 Reviewed-on: https://chromium-review.googlesource.com/1150015Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#579292}
-
Xi Cheng authored
Bug: 851163 Change-Id: I4321ca15bc02b38e510c885c8e3ceb31875d9e1c Reviewed-on: https://chromium-review.googlesource.com/1155965Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#579291}
-
Timothy Gu authored
HTMLDocumentParser::IsExecutingScript() is in fact identical to the "script nesting level is greater than 0" check in the current HTML Standard. The removed check originated from an older version of the HTML Standard that read: > If the Document has an active parser that isn't a script-created > parser, and the insertion point associated with that parser's input > stream is not undefined (that is, it does point to somewhere in the > input stream), then the method does nothing. but that was changed after [1]/[2] to the current text which covers strictly more cases. Indeed, in the current coverage report the removed check is never true [3]. The check is expected to stay in its current form in the upcoming document.open() overhaul. [1]: https://www.w3.org/Bugs/Public/show_bug.cgi?id=17869 [2]: https://github.com/whatwg/html/commit/7b0112bbfb4923e8f64b0fd1c66d14fbd526fc33 [3]: https://chromium-coverage.appspot.com/reports/577000/linux/chromium/src/third_party/blink/renderer/core/dom/document.cc.html#L3048 Bug: 866274 Change-Id: I5f4547ee62efe45a9831c003854279b3490a08f1 Reviewed-on: https://chromium-review.googlesource.com/1146202Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579290}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b438311bbf3..9093ff098254 git log 3b438311bbf3..9093ff098254 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9093ff098254 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ief39f09b81135eba58e03df834d472357792a3b8 Reviewed-on: https://chromium-review.googlesource.com/1155887Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579289}
-
Wei-Yin Chen (陳威尹) authored
Parameters |white_list| and |black_list| in FilterSourceFile() should be iterables, and it's fairly easy to wrongly pass a string instead. This checking caught _CheckCrbugLinksHaveHttps in unit tests. Bug: 869103 Change-Id: I1cd6d62c3fa2b1500d9d7b6b35794f40e35378af Reviewed-on: https://chromium-review.googlesource.com/1155379 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579288}
-
Nikhil Athreya authored
This change is part of the update to the chrome://power page. This commit adds a new process data collector that will eventually be integrated into chrome://power. Currently, for each process, it aggregates what type of process and it approximates the average CPU usage of that process across its lifetime for all processes in the system. This will eventually be used as part of a battery usage approximation metric. BUG: crbug.com/851767 TEST: Run unittests provided in the commit. Change-Id: If63289a827b530bca808626f9133c52276dc5d6f Reviewed-on: https://chromium-review.googlesource.com/1096408 Commit-Queue: Nikhil Athreya <nathreya@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#579287}
-
John Budorick authored
This reverts commit 7bfc1624. Reason for revert: tests appear to have mostly recovered; unclear why. Original change's description: > Drop the layout tests to experimental on Mac10.13 Tests. > > TBR=dpranke@chromium.org > > Bug: 868180 > Change-Id: Ic9cb48f82954f102f60dd3e1b9c29bcca209f3bb > Reviewed-on: https://chromium-review.googlesource.com/1152566 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578626} TBR=dpranke@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 868180 Change-Id: Ibb217f63bb5b834565fafac4cb7ad15543ba70bb Reviewed-on: https://chromium-review.googlesource.com/1155614Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Fixed some of the following issues: - E302 expected 2 blank lines, found 1 - E703 statement ends with a semicolon - E999 SyntaxError: invalid syntax Bug: None Change-Id: Ia4c9a2c81168395331f5d2135a7bba1eafcd3640 Reviewed-on: https://chromium-review.googlesource.com/1155625Reviewed-by:
-
Ramya Nagarajan authored
Bug: 868150 Change-Id: Ib0d3ea858fd1c51c34c2e0cdec0609f1a7f2d5d3 Reviewed-on: https://chromium-review.googlesource.com/1152447Reviewed-by:
-
bsheedy authored
Fixes a StrictMode violation caused by a setComponentEnabledSetting in MediaViewerUtils by wrapping the offending call in a context that allows disk reads and writes. Bug: 869217 Change-Id: Ide971ab817cc149df3c828b23a9b4bf4015ff711 Reviewed-on: https://chromium-review.googlesource.com/1155974Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579283}
-
bsheedy authored
Refactors the VR browser tests to match the newly refactored Java instrumentation tests. Main changes include: * Changing the *TestBase hierarchy to match the *TestFramework Java hierarchy. * Renaming functions that refer to "presentation" to instead refer to "session" * Add versions of functions that automatically use the return value of GetFirstTabWebContents instead of taking a WebContents reference. Follow-up CL(s) will do additional cleanup and update the documentation. Bug: 868143 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifa75c68eafddb9afe1d5f5dee955bd8689c55db7 Reviewed-on: https://chromium-review.googlesource.com/1155718Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579282}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d49fdae6. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22133 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Ieb00afc969b11febcf390776bc67c46cb0ad06f8 Reviewed-on: https://chromium-review.googlesource.com/1155934 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#579281}
-
Koji Ishii authored
Following bot results are included. 8458 8465 8466 8469 8473 8475 8488 8492 8494 8496 1 lines were removed and 7 lines were deflaked by consecutive results since 8447. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4cc7a150cc87dd0f259508fc5637d0b85cbc25c7 Reviewed-on: https://chromium-review.googlesource.com/1154241 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579280}
-
Jiajia Qin authored
This patch implements bindImageTexture API so that users can load/store image data in shader. Meanwhile, we adds all types of image unit for getUniform. With this, users can use getUniform to get the image unit's binding point in API side. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I22052ad4c15102ce73727a79dd4269302efadab2 Reviewed-on: https://chromium-review.googlesource.com/1152690Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#579279}
-
Peter Boström authored
This test has started to flake recently, disabling during investigation. Bug: chromium:868706 Tbr: tommycli@chromium.org Change-Id: Icb9767c98885c76dece2f4b39449bf6e04a6ddcb Reviewed-on: https://chromium-review.googlesource.com/1155993 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Moves the ownership of PendingAppManager up to WebAppProvider. PendingAppManager will be used by any client that wishes to install a WebApp. For now this is only WebAppPolicyManager and ScanForExternalApps. Bug: 864904 Change-Id: I0599c896accdd74ceabfc16bf403d4eec501c97e Reviewed-on: https://chromium-review.googlesource.com/1154744 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Patti authored
Currently, the All Sites list only includes sites with non-default content settings. Update it to include sites that use local storage (disk space) as well. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I722c659b551aaf5023bb82a7475151df39a092be Reviewed-on: https://chromium-review.googlesource.com/1137812Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#579276}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f7d4cd62a0b..946a162a5239 git log 9f7d4cd62a0b..946a162a5239 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@946a162a5239 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I83b10022c951b044d591aef781bf4f345686bccb Reviewed-on: https://chromium-review.googlesource.com/1155865Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579275}
-
Yue Cen authored
shadow effect. Bug: 835029 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I677cbf3a3e34a84afabb839a2e8adc61fb27c1bb Reviewed-on: https://chromium-review.googlesource.com/1139177 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#579274}
-
Han Leon authored
This CL is the 2nd step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. 1st step: https://chromium-review.googlesource.com/c/chromium/src/+/1134731 - Remove the typemapping of blink.mojom.FetchAPIResponse. The mojom struct blink.mojom.FetchAPIResponse describes a Response in terms of the concept from the Fetch spec, currently it's defined under blink/public/platform/modules/fetch/ and is used only by Cache Storage API implementation (by both Browser and Renderer code), as this struct meets the 2 conditions below, it should be fine to go into blink/public/mojom/: - it is expected to be used by both Browser and Renderer code. - it is expected to be passed over Mojo between Browser and Renderer (Blink). But, currently for Chromium Mojo binding variant it is typemapped to content::ServiceWorkerResponse being used in content/browser/cache_storage/, this blocks it being moved to blink/public/mojom/. So we need to remove this typemapping first, this removal also helps reduce 1 user of content::ServiceWorkerResponse. 2nd step: (This CL) Now we can just move blink.mojom.FetchAPIResponse into blink/public/mojom/fetch/, which makes the next steps possible. 3rd step: - Use blink.mojom.FetchAPIResponse to represent the response a service worker provides to FetchEvent#respondWith. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse in content/common/service_worker/service_worker_fetch_response_callback.mojom. Thus we can reduce another 1 user of content::ServiceWorkerResponse. More importantly, this makes it possible for us to move service_worker_fetch_response_callback.mojom into blink/public/mojom/service_worker/ in future. 4th step: - Use blink.mojom.FetchAPIResponse to represent responses to background fetches. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse defined in content/common/service_worker/service_worker.mojom. Thus we can reduce the last 1 user of content::ServiceWorkerResponse. 5th step: - Remove content::ServiceWorkerResponse and do any left cleanup. BUG=789854 Change-Id: I9afad29a89887369c211cb46bce5bc98df16064f Reviewed-on: https://chromium-review.googlesource.com/1149706 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579273}
-
Yuri Wiitala authored
Reduce thrash on content/browser/OWNERS and content/renderer/OWNERS for trivial adds/deletes from the BUILD.gn file. All of content/OWNERS, chrome/browser/OWNERS, and chrome/renderer/OWNERS already has this, so there is precedent. BUG=869232 Change-Id: I535294fd904da1739fa7abb95ce18da162eb42bb Reviewed-on: https://chromium-review.googlesource.com/1150815 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#579272}
-
David Black authored
Root cause of the crash was committing a query without first having pended a query. This can occur in a notifications flow or a device actions flow in which an interaction did not originate from the UI. We rely on pending/committing the query in the interaction model to clear the previous query from the UI. The fix, in this case, was just to pend an empty query so that we have something to commit. Bug: b:111923411 Change-Id: I53848f856375cf220538738634e7543a455c0dcc Reviewed-on: https://chromium-review.googlesource.com/1155153Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#579271}
-
Vlad Tsyrklevich authored
JPEGImageReader::AllocateSampleArray() can call the function pointer (*info_.mem->alloc_sarray) which can be set by the systems non-CFI enabled libjpeg DSO when chromium is built with use_system_libjpeg=true. Disable cfi-icall for that method. Bug: 866290 Change-Id: I6d9bbf08c514d6d5f48ad34c3802c63419ed1223 Reviewed-on: https://chromium-review.googlesource.com/1155927Reviewed-by:
-
