- 22 Nov, 2018 40 commits
-
-
Mathias Carlen authored
This patch introduces a cookie experiment which when enabled, sets a cookie to determine when a script may be executed on a site with modified state. The new logic is handled in the controller and controlled via an experiment parameter. In a follow up change this information will be hooked up to the script executor. Bug: 806868 Change-Id: I7a6354611646e36986208a70a09b376ad4e2f2c0 Reviewed-on: https://chromium-review.googlesource.com/c/1344099 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610446}
-
Vaclav Brozek authored
The libphonenumber routine used in autofill's ParsePhoneNumber expects input which is: * valid Unicode * avoids noncharacters [1] * avoids nonprintable ASCII This CL checks the input passed to libphonenumber for these criteria and aborts ParsePhoneNumber if they are not met. As a side effect, this also decreases log spam seen in autofill_phone_number_i18n_fuzzer, because libphonenumber has been complaining about interchange-invalid UTF8. [1] http://www.unicode.org/faq/private_use.html#nonchar1 Bug: 906817 Change-Id: I451272d2f838bd266ad3a043f556610b8007ae1a Reviewed-on: https://chromium-review.googlesource.com/c/1343004 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610445}
-
Christopher Grant authored
And, add GN best-practices link alongside. BUG= TBR=jochen@chromium.org Change-Id: I34641ad5693942d69a6f418c6dbf562ed7375095 Reviewed-on: https://chromium-review.googlesource.com/c/1348289 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610444}
-
Mikel Astiz authored
Analogous to https://chromium-review.googlesource.com/c/1329142 but with the subset of datatypes that are relevant on iOS. Bug: 870624 Change-Id: Id10165cd3baca9d0b17c451804b65c87cfa4e29e Reviewed-on: https://chromium-review.googlesource.com/c/1347273Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610443}
-
Randy Rossi authored
These IPC extension messages are identical between chrome/chromecast. Moving up to extensions/common Bug: 837773 Test: Deploy ChromeOs manually (tidus) Change-Id: I8884ea9726b69efb40c71614de11889bf01a2bb4 Reviewed-on: https://chromium-review.googlesource.com/c/1261976Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610442}
-
Sergio Villar Senin authored
Replaced the usage of SinginManager API by the correspondent IdentityManager API. Bug: 903860 Change-Id: I5f4df0e9956c4b4ae055f15b80fddac9009e61d0 Reviewed-on: https://chromium-review.googlesource.com/c/1347281Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#610441}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4bff78e57c54..2a7215287df2 git log 4bff78e57c54..2a7215287df2 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dc65c5bd8452..efe061bd4f9d (2 commits) 2018-11-22 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@2a7215287df2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I084304ed729d276eac390347e232af56d5b8bb82 Reviewed-on: https://chromium-review.googlesource.com/c/1348010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610440}
-
Michael Thiessen authored
Many (most?) mobile sites disable focus outlines, which means that spatial navigation gives no indication of which element is focused, making it unusable. When this new experimental flag is enabled, we prevent the site from overriding the useragent style for focus rings. This also has the side-effect of forcing an outline on spat-nav-focused option elements even when the new flag is not enabled. (Note that spat-nav itself is still behind a flag) Bug: 906640 Change-Id: I2e68b4ea898f5c504bd272895caeea91a2bfc757 Reviewed-on: https://chromium-review.googlesource.com/c/1344252Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#610439}
-
Marc Treib authored
plus a lot of now-dead code :) Many tests explicitly disabled the feature. Some of those could be adapted, some other simply don't apply anymore and were deleted. Bug: 905636, 905639 Change-Id: Ife7cf5227b929bab5221b856d85ba572f89e537e Reviewed-on: https://chromium-review.googlesource.com/c/1346308 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610438}
-
Jungshik Shin authored
Date-related wtf functions are for JavaScriptCore in WebKit. For the obvious reason, Blink does not need them except for parsing Date in HTTP header (last modified). For that, switch to ICU and use the same algorithm as specified in the latest Ecma 262 spec. The need for this CL was identified while working on https://chromium-review.googlesource.com/1111818 , but it hasn't been made a CL until now. Bug: None Change-Id: I69f04e13744fdc914f58fca6d0a88993173a58e4 Reviewed-on: https://chromium-review.googlesource.com/c/1103675Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610437}
-
Geoff Lang authored
This reverts commit a7291ad3. Reason for revert: assertion failures on GPU FYI bots. BUG=907898 Original change's description: > Move audio service to new service APIs > > Migrates audio service and related test code away from using deprecated > service APIs (ServiceContext, ServiceTest, etc) in favor of better ones. > > Bug: 891780,906239 > Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f > Reviewed-on: https://chromium-review.googlesource.com/c/1345548 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610373} TBR=kinuko@chromium.org,rockot@google.com,olka@chromium.org Change-Id: Ic96583fb5bbf549e5854276786afef4b7040dd70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891780, 906239 Reviewed-on: https://chromium-review.googlesource.com/c/1348252Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610436}
-
Jan Krcal authored
This CL makes sure we expire local sync metadata as soon as the last typed visit for a URL expires. As a result, we have a (more) consistent sets of data (URLs with non-expired typed visits as defined by bridge's GetData()) and metadata. Bug: 851869 Change-Id: I4f100ce8b4fc1281a0e7667e69db20f10ccea9c3 Reviewed-on: https://chromium-review.googlesource.com/c/1346398 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610435}
-
Mikel Astiz authored
HTTP status codes were accidentally mixed up with network error codes. The latter are negative numbers, and reproduced some DCHECK failures given that HTTP status codes cannot be negative. Bug: 774180 Change-Id: I7e09d02e0b63b2e9c49019c9a538c21ed34c7291 Reviewed-on: https://chromium-review.googlesource.com/c/1348090 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610434}
-
Robert Ogden authored
This preview shouldn't be triggered on sites where the user has blocked cookies because the X-Client-Data won't be sent for subresources. See bug for more details. Bug: 907550 Change-Id: I66883e629c4ca3cb0f3a283e3ff1dd052340655f Reviewed-on: https://chromium-review.googlesource.com/c/1347434Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#610433}
-
Vaclav Brozek authored
PasswordManager reports when it sees a form submitted but no PasswordFormManager associated to it. This CL adds the reporting also for a missing NewPasswordFormManager. Bug: 907794 Change-Id: Ibc7b28b0e777e8991311ec901c0c3fd0d28f0831 Reviewed-on: https://chromium-review.googlesource.com/c/1347288Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610432}
-
Keishi Hattori authored
Convert CSS*, Style* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: Ieb30ff735be5fd5b53ed5ab672c91a998f29bce7 Reviewed-on: https://chromium-review.googlesource.com/c/1333015 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610431}
-
Sylvain Defresne authored
The callback is only invoked once, so change the type from base::Callback (which is an alias for RepeatingCallback) to base::OnceCallback. Bug: none Change-Id: I88459dc79073fe890645aae5457678172d1bfc53 Reviewed-on: https://chromium-review.googlesource.com/c/1344142Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#610430}
-
Florin Malita authored
Convert the only client relying on the old API to the SkFont version. TBR= Bug: skia:2664 Change-Id: Ic4420a9e5d43dfc0edf6e4c23229be94e48c3e13 Reviewed-on: https://chromium-review.googlesource.com/c/1347309 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#610429}
-
Jan Krcal authored
The new name better fits to the other existing function UntrackEntityForStorageKey() and the updated comment makes it clear this should be only used when storage key is not available. Apart from the rename, the function now ignores if the provided client_tag_hash does not exist or is not tracked any more. Bug: NONE Change-Id: Ic68a7ab939fd17436740df3ca75389c1ed34f329 Reviewed-on: https://chromium-review.googlesource.com/c/1347287Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610428}
-
Ian Clelland authored
This brings the feature policy report format in line with the spec, and fixes the tests which were broken by WPT import. Bug: 907232 Change-Id: If9d9469956221c18a1aa72ee39debb1340efc01f Reviewed-on: https://chromium-review.googlesource.com/c/1338167 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610427}
-
Dave Tapuska authored
Ensure that we don't truncate a size_t to a uint32_t without checking ranges. BUG=879657 Change-Id: I52d06db4f87d88de367992fe7af7ed1feff08b93 Reviewed-on: https://chromium-review.googlesource.com/c/1347066Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610426}
-
Vasilii Sukhanov authored
The feature is not to be launched and the associated code is removed. The metrics collection should be running. Bug: 791541 Change-Id: I76a1a08a6dc8e2509f3f4be68a5c14fa611dc177 Reviewed-on: https://chromium-review.googlesource.com/c/1346406 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#610425}
-
Arthur Sonzogni authored
Update ServiceWorker CommitResponseBodyEmpty() so that it matches what is done in services/network/url_loader.cc. It consists of two things: 1) Reduce the default allocation size to 1. 2) Explicitly call producer_handle.reset(). No behavior change is expected. The memory saving is a priori irrelevant, but nice to have. In bug 905779, there is a crash when leaving this function, calling explicitly producer_handle.reset() early might update the crash location and give some hints about what is happening. Bug: 905779 Change-Id: I4ad937c61046d30f8163fc6e72fd80d6e5c447ea Reviewed-on: https://chromium-review.googlesource.com/c/1341515 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610424}
-
Clemens Arbesser authored
This CL just lays the groundwork needed to handle key-press events in the client and should not change current behavior. - Fixed bug where SetFormFieldValue action only handles the first KeyPress event and ignores all subsequent ones. - Added keycode field to SetFormFieldValueProto:Keypress protobuf to mirror the current proto on the backend. Bug: 806868 Change-Id: Ic9a06b60489e2ec6c15578f338e649883f46dcf3 Reviewed-on: https://chromium-review.googlesource.com/c/1348052 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610423}
-
Tibor Goldschwendt authored
Remove to save some binary size since this code is not usable by APKs. Bug: 899574 Change-Id: Ia0a857ac58185f3ee83f38bba27cfed8cc9d6b29 Reviewed-on: https://chromium-review.googlesource.com/c/1321160 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610422}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8b5d9d865088..af228ee761e1 git log 8b5d9d865088..af228ee761e1 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 aleloi@webrtc.org Disable flaky tests CallPerfTest.CaptureNtpTimeWithNetworkDelay on WIN. 2018-11-22 philipel@webrtc.org Remove SetChannelParameters function from API classes. 2018-11-22 aleloi@webrtc.org Disable GoogCcNetworkControllerTest.DetectsHighRateInSafeResetTrial 2018-11-22 srte@webrtc.org Adds trial to use link capacity estimate in Opus encoder. 2018-11-22 mbonadei@webrtc.org Move webrtc::CreatePeerConnectionFactory definition next to decl. 2018-11-22 nisse@webrtc.org Delete unused NetEq Rtcp stats. 2018-11-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6931f4c0..1500c78c (610209:610314) Created with: gclient setdep -r src/third_party/webrtc@af228ee761e1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8bf11185b4848c75f5afa2803966cbcc97bfc651 Reviewed-on: https://chromium-review.googlesource.com/c/1348012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610421}
-
Mustaq Ahmed authored
Bug: 802291 Change-Id: Ie754a7a47ffb2c45ddee3d504fc8159a7a6ec783 Reviewed-on: https://chromium-review.googlesource.com/c/1347509Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#610420}
-
Yi Su authored
support searching across multiple HTML Nodes. This CL introduces the Match class into find_in_page.js to replace the __gCrWeb.findInPage.spans, and all global functions that are used for highlighting selected match result. This CL improves the readability of the file, and is a fundamental part of supporting searching across multiple HTML nodes. Bug: 228585 Change-Id: I9bf74a27632002656445f8dd70d0aadd0503b78e Reviewed-on: https://chromium-review.googlesource.com/c/1347363Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610419}
-
Findit authored
This reverts commit fadba0e6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610399 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhZGJhMGU2OWUzMmExZWQwZmY0MjQxZmM2YTBhZGMyY2Q3NjEwZGYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/4725 Sample Failed Step: compile Original change's description: >
🤝 Return to verified origin when close button pressed. > > When a TWA leaves the verified origin, the Custom Tabs top bar is > displayed and the user can see a close button. This close button would > on a normal custom tab close the Activity. > > On Trusted Web Activities, this should return us to the verified > origin instead. > > Bug: 907535 > Change-Id: I9f652a3255afdd23072b32c44db5680172ea33f2 > Reviewed-on: https://chromium-review.googlesource.com/c/1346463 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610399} Change-Id: If37c325c51b92f414d1bab5fff65946954cfe754 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907535 Reviewed-on: https://chromium-review.googlesource.com/c/1348209 Cr-Commit-Position: refs/heads/master@{#610418} -
Mikel Astiz authored
As discussed in recent code reviews, let's emphasize the distinction between network errors and HTTP status codes. Bug: 774180 Change-Id: Id9e38f5a340c887519d15d137f41facfc1f9dadb Reviewed-on: https://chromium-review.googlesource.com/c/1348057 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610417}
-
Gabriel Charette authored
and follow-up on nits to https://chromium-review.googlesource.com/c/chromium/src/+/1261855 R=fdoray@chromium.org Change-Id: I2ca5305af71fa89e13be10e40779641362529a42 Reviewed-on: https://chromium-review.googlesource.com/c/1342770 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#610416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f406080c7dee..eec675da4cad Created with: gclient setdep -r src-internal@eec675da4cad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I157d7f1e212f90689f705193cd881d924b6016c0 Reviewed-on: https://chromium-review.googlesource.com/c/1348013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610415}
-
Yi Su authored
PasswordDetailItem can display an uneditable string as plain text("abc") or masked text("XXX"). This CL add the same functionality in TableViewTextItem to avoid creating another class like TableViewPasswordItem. This is a preparation work for migrating Settings from MDC to UIKit. Bug: 894791 Change-Id: I34538659d6879246c66e9aafd4d88cb8d7822f3c Reviewed-on: https://chromium-review.googlesource.com/c/1346151 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:Eric Noyau <noyau@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#610414}
-
Andrew Grieve authored
Ran into this on a local O device, where the OS had created a file: /data/user/0/org.chromium.chrome.tests/incremental-install-files/optimized-dexes/third_party.google-truth.google_truth_java.dex.jar.arm.flock Not sure why the file was created, but this change ignores it. Change-Id: I8233396e911bcee272abc514eecc7d9baa0a7ffa Reviewed-on: https://chromium-review.googlesource.com/c/1347573Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610413}
-
Stephane Zermatten authored
When an interrupt script is run, it can modify anything, which makes the main script with allow_interrupt=true hard to write. This change propose to reset some state automatically after an interrupt to make this easier. It recovers the status message and attempts to set a reasonable scroll position. It sets it to either the element WaitForDom was waiting for, for a successful WaitForDom. For an unsuccessful WaitForDom, it scrolls to the last element focused on (if it still exists.) Change-Id: Ie9c0022eebc10e0711c82d83b943e0de152af1fd Reviewed-on: https://chromium-review.googlesource.com/c/1346451 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610412}
-
Tibor Goldschwendt authored
We are hitting dex method limit. This XL fixes that. NOTRY=true # Bots got passed failing build step. NOTREECHECKS=true Bug: 907888 Change-Id: Ic45f54e761b77fef45dcfe79ae1d0ddc8fea1544 Reviewed-on: https://chromium-review.googlesource.com/c/1347788 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610411}
-
Mugdha Lakhani authored
When we allow access to active background fetches, BackgroundFetchRecords for the fetch can be accessed from multiple places. It simplifies matters if we return the same record for a request whenever it's accessed. This CL adds a (private) list of BackgroundFetchRecords to the BackgroundFetchRegistration object, and updates it every time match and matchAll() are called. The second change introduced here is to not immediately resolve responseReady() if the fetch is active and a response for the request isn't yet available. Once the fetch has completed, or there's a response available for the request, we resolve pending promises. We also make sure to return the same promise (resolved or unresolved) for a given record, every time responseReady is called. For a more detailed discussion, see the following doc: https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing Bug: 875201 Change-Id: I8cb386efd19086c0993ad2be2fb2691ad90597ec Reviewed-on: https://chromium-review.googlesource.com/c/1336151 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610410}
-
Manu Cornet authored
Currently, most gestures on the overflow shelf are completely ignored. This causes (among other things) the two bugs linked from this CL because gestures trying to reorder icons, or after a long press event, are ignored. The main reason for the special casing is that we don't want gestures on the overflow shelf to cause showing the app list, or to drag the shelf itself when it's an autohide shelf. However, ignoring all gestures is overkill. This CL handles gestures in a more fine grained way: * The app list cannot be shown by swiping up from the shelf when the overflow shelf is shown. The change here is that one could initially swipe up from the main shelf even when the overflow shelf was shown. Now the overflow shelf needs to be hidden first. The previous behavior could arguably be seen as a bug because one could get a full screen app list while the overflow menu was still being shown, which looked quite strange. * The shelf cannot be dragged up or down (in the case of an autohide shelf) when the overflow shelf is shown. Previously, one could drag the shelf while overflow was open (just not by performing the gesture on the overflow shelf itself). This resulted in behaviors where the whole "shelf + overflow" could be dragged up or down. Now, the overflow shelf will be dismissed first. One could argue either way, but I would consider the change a good change. * All other gestures are handled in the overflow shelf in the same way as the main shelf. Bug: 882991, 905121 Change-Id: I9269b9a0943f4aa39aa26d4d339cbbfa80b51135 Reviewed-on: https://chromium-review.googlesource.com/c/1343659 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO till 11/26) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#610409}
-
Andreas Haas authored
With https://crrev.com/c/1336130 we can see more clearly why crashes happen in `SetSystemPagesAccess`. This CL adds special handling for crashes we now know are OOM crashes. R=haraken@chromium.org Bug: v8:8238 Change-Id: Ia050ee5887834ab8d4c4a80ba6ecf4cc2a5e8e50 Reviewed-on: https://chromium-review.googlesource.com/c/1348051Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#610408}
-
Olivier Robin authored
This is a reland of d15dd85f Original change's description: > [Reland] Block resources in FormStructureBrowserTest. > > The files used for FormStructureBrowserTest are snapshots of real web > sites. They can have link to online resources but should not need them > for the test to pass. > But if the network is really bad, the page can wait for the resource > loading to finish and timeout. > Preventing the resource loading will make the test faster and more > robust. > > Bug: 896173 > Change-Id: I16b02e1d7defd4d950e6ee4cd21bd0133b9ac957 > Reviewed-on: https://chromium-review.googlesource.com/c/1346462 > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610366} Tbr: eugenebut@chromium.org Bug: 896173 Change-Id: I713942404ec5ab47fb653f4fc2c04214f66fa866 Reviewed-on: https://chromium-review.googlesource.com/c/1348032Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610407}
-