GitLab

https://bugs.webkit.org/show_bug.cgi?id=55995

Reviewed by James Robinson.

Source/WebCore:

Test: fast/forms/interactive-validation-select-crash.html

* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks):
  isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().

LayoutTests:

* fast/forms/interactive-validation-select-crash-expected.txt: Added.
* fast/forms/interactive-validation-select-crash.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@81088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=56159

Reviewed by Sam Weinig.

Add function for creating a WKImage from CGImage data.
* Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it. 
* Shared/API/c/cg/WKImageCG.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@81087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        Made JSWrapperObject and subclasses moving-GC-safe
        https://bugs.webkit.org/show_bug.cgi?id=56346
        
        SunSpider reports no change.

        * runtime/BooleanObject.cpp:
        (JSC::BooleanObject::BooleanObject):
        * runtime/DateInstance.cpp:
        (JSC::DateInstance::DateInstance): No more need for JSGlobalData, since
        we don't initialize the wrapped value in our constructor.

        * runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because
        we do not in fact override markChildren.

        * runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object
        no longer does so for us. Also added an ASSERT to catch a latent bug,
        where DatePrototype stomped on its base class's anonymous slot. Hard-coded
        anonymous slots are a plague on our code. This doesn't cause any problems
        in our existing code since the base class never reads the anonymous slot
        it declares, but it caused crashes when I tried to start using the slot
        in an initial version of this patch.

        * runtime/JSWrapperObject.h:
        (JSC::JSWrapperObject::JSWrapperObject):
        (JSC::JSWrapperObject::internalValue):
        (JSC::JSWrapperObject::setInternalValue): Resolved a problem where
        our internal value was stored in two places: an anonymous slot, and a
        data member which was not always visited during GC. Now, we only use the
        data member, and we always visit it. (Instead of relying on certain
        subclasses to set the OverridesMarkChildren bit, we set it ourselves.)

        * runtime/NumberObject.cpp:
        (JSC::NumberObject::NumberObject): No more need for JSGlobalData, since
        we don't initialize the wrapped value in our constructor.

        * runtime/NumberObject.h: Removed meaningless declaration.

        * runtime/StringObject.cpp:
        (JSC::StringObject::StringObject): No more need for JSGlobalData, since
        we don't initialize the wrapped value in our constructor.

        * runtime/StringObject.h: Don't set the OverridesMarkChildren flag because
        we do not in fact override markChildren.

        * runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object
        no longer does so for us. Also added an ASSERT to catch a latent bug,
        where DatePrototype stomped on its base class's anonymous slot. Hard-coded
        anonymous slots are a plague on our code.


git-svn-id: svn://svn.chromium.org/blink/trunk@81086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gavin Barraclough.

        Look-ahead assertions with back references don’t work as expected
        https://bugs.webkit.org/show_bug.cgi?id=56082

        Changed parentheses assertion processing to temporarily back out the 
        number of known characters after the assertion while processing the 
        assertion.  This was done so that assertions don't fail due to 
        checking the number of required characters as additional to the 
        rest of the express since assertions don't "consume" input.
        Added a byte code to uncheck characters to support the change.

        * yarr/YarrInterpreter.cpp:
        (JSC::Yarr::Interpreter::matchDisjunction):
        (JSC::Yarr::ByteCompiler::uncheckInput):
        (JSC::Yarr::ByteCompiler::emitDisjunction):
        * yarr/YarrInterpreter.h:
        (JSC::Yarr::ByteTerm::UncheckInput):
2011-03-14  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Look-ahead assertions with back references don’t work as expected
        https://bugs.webkit.org/show_bug.cgi?id=56082

        New tests to verify the corresponding changes.

        * fast/regex/assertion-expected.txt: Added.
        * fast/regex/assertion.html: Added.
        * fast/regex/script-tests/assertion.js: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@81085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        [Qt][WK2]Unbreak InjectedBundle on Qt
        https://bugs.webkit.org/show_bug.cgi?id=54109

        No code changes so no new tests.

        Revert the changes that were needed to use KURL
        in WebKitTestRunner.

        * Configurations/WebCore.xcconfig:
        * WebCore.exp.in:
2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Adam Roben.

        [Qt][WK2]Unbreak InjectedBundle on Qt
        https://bugs.webkit.org/show_bug.cgi?id=54109

        Add API's to WKURL and WKString to satisfy
        WebKitTestRunner's needs.

        * Shared/API/c/WKString.cpp:
        (WKStringIsEqualToUTF8CStringIgnoringCase):
        * Shared/API/c/WKString.h:
        * Shared/API/c/WKURL.cpp:
        (WKURLCopyHostName):
        (WKURLCopyScheme):
        * Shared/API/c/WKURL.h:
        * Shared/WebString.h:
        (WebKit::WebString::equalToUTF8StringIgnoringCase):
        * Shared/WebURL.h: Added OwnPtr<KURL> member to be able
        to lazily parse the URL and store the result.
        (WebKit::WebURL::host):
        (WebKit::WebURL::protocol):
        (WebKit::WebURL::parseURLIfNecessary):
        * win/WebKit2.def: Revert the symbol exports that were
        needed to use KURL in WebKitTestRunner.
2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Adam Roben.

        [Qt][WK2]Unbreak InjectedBundle on Qt
        https://bugs.webkit.org/show_bug.cgi?id=54109

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
        API's instead of KURL to analyze the URL.
        * WebKitTestRunner/StringFunctions.h:
        (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
        in the WebKitTestRunner project.
        (WTR::toWK): Use adoptWK.
        (WTR::operator<<): Added helper for printing a WKURL.
        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
        against WebCore.

git-svn-id: svn://svn.chromium.org/blink/trunk@81084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        Add WKViewSetScrollOffsetOnNextResize() to C API on Windows
        https://bugs.webkit.org/show_bug.cgi?id=56340

        * UIProcess/API/C/win/WKView.cpp:
        (WKViewSetScrollOffsetOnNextResize): Added.
        * UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize().
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size.
        (WebKit::WebView::setScrollOffsetOnNextResize): Added.
        * UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize().


git-svn-id: svn://svn.chromium.org/blink/trunk@81082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Laszlo Gombos.

        [Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
        https://bugs.webkit.org/show_bug.cgi?id=56133

        Add condition to not compile webkit internal math round functions on RVCT compiler versions
        from 3.0.0 because they are already defined in compiler math library.

        * wtf/MathExtras.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@81081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Adam Roben.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
by JSStringCreateWithCFString.
(LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
allocate.

git-svn-id: svn://svn.chromium.org/blink/trunk@81080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Geoffrey Garen & Oliver Hunt.

The JSC JIT presently generates code directly from the bytecode used by the interpreter.
This is not an optimal intermediate representation for JIT code generation, since it does
not capture liveness information of values, and provides little opportunity to perform
any static analysis for even primitive types. The JIT currently generates two code paths,
a fast path handling common cases, and a slower path handling less common operand types.
However the slow path jumps back into the fast path, meaning that information arising
from the earlier type checks cannot be propagated to later operations.

This patch adds:
    * a dataflow intermediate representation capable of describing a single basic block
      of operations,
    * a mechanism to convert a simple, single-block bytecode functions to the new IR,
    * and a JIT code generator capable of generating code from this representation.

The JIT generates two code paths, with the slower path not reentering the fast path
mid-block, allowing speculative optimizations to be made on the hot path, with type
information arising from these speculative decisions able to be propagated through the
dataflow. Code generation of both speculative and non-speculative paths exploits the type
and liveness information represented in the dataflow graph to attempt to avoid redundant
boxing and type-checking of values, and to remove unnecessary spills of temporary values
to the RegisterFile.

The dataflow JIT currently can only support a subset of bytecode operations, limited to
arithmetic, bit-ops, and basic property access. Functions that cannot be compiled by the
dataflow JIT will be run using the existing JIT. The coverage of the dataflow JIT will be
expanded to include, control-flow, function calls, and then the long-tail of remaining
bytecode instructions. The JIT presently only support JSVALUE64, and as a consequence of
this only supports x86-64.

The status of the dataflow JIT is currently work-in-progress. Limitations of the present
JIT code generation may cause performance regressions, particularly:
    * the policy to only generate arithmetic code on the speculative path using integer
      instructions, never using floating point.
    * the policy to only generate arithmetic code on the non-speculative path using
      floating point instructions, never using integer.
    * always generating JSValue adds on the non-speculative path as a call out to a
      C-function, never handling this in JIT code.
    * always assuming by-Value property accesses on the speculative path to be array
      accesses.
    * generating all by-Value property accesses from the non-speculative path as a call
      out to a C-function.
    * generating all by-Indentifer property accesses as a call out to a C-function.
Due to these regressions, the code is landed in a state where it is disabled in most
cases by the ENABLE_DFG_JIT_RESTRICTIONS guard in Platform.h. As these regressions are
addressed, the JIT will be allowed to trigger in more cases.

* JavaScriptCore.xcodeproj/project.pbxproj:
    - Added new files to Xcode project.
* dfg: Added.
    - Added directory for new code.
* dfg/DFGByteCodeParser.cpp: Added.
* dfg/DFGByteCodeParser.h: Added.
    - Contruct a DFG::Graph representation from a bytecode CodeBlock.
* dfg/DFGGenerationInfo.h: Added.
    - Track type & register information for VirtualRegisters during JIT code generation.
* dfg/DFGGraph.cpp: Added.
* dfg/DFGGraph.h: Added.
    - Dataflow graph intermediate representation for code generation.
* dfg/DFGJITCodeGenerator.cpp: Added.
* dfg/DFGJITCodeGenerator.h: Added.
    - Base class for SpeculativeJIT & NonSpeculativeJIT to share common functionality.
* dfg/DFGJITCompiler.cpp: Added.
* dfg/DFGJITCompiler.h: Added.
    - Class responsible for driving code generation of speculativeJIT & non-speculative
      code paths from the dataflow graph.
* dfg/DFGNonSpeculativeJIT.cpp: Added.
* dfg/DFGNonSpeculativeJIT.h: Added.
    - Used to generate the non-speculative code path, this make no assumptions
      about operand types.
* dfg/DFGOperations.cpp: Added.
* dfg/DFGOperations.h: Added.
    - Helper functions called from the JIT generated code.
* dfg/DFGRegisterBank.h: Added.
    - Used to track contents of physical registers during JIT code generation.
* dfg/DFGSpeculativeJIT.cpp: Added.
* dfg/DFGSpeculativeJIT.h: Added.
    - Used to generate the speculative code path, this make assumptions about
      operand types to enable optimization.
* runtime/Executable.cpp:
    - Add code to attempt to use the DFG JIT to compile a function, with fallback
      to the existing JIT.
* wtf/Platform.h:
    - Added compile guards to enable the DFG JIT.



git-svn-id: svn://svn.chromium.org/blink/trunk@81079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
        https://bugs.webkit.org/show_bug.cgi?id=56321

        * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
        to the list of exceptions for WebKit2 C API headers.

git-svn-id: svn://svn.chromium.org/blink/trunk@81077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Update GTK+ pixel results after r81053.

        * platform/gtk/editing/selection/drag-select-1-expected.checksum:
        * platform/gtk/editing/selection/drag-select-1-expected.png:
        * platform/gtk/editing/selection/fake-drag-expected.checksum: Added.
        * platform/gtk/editing/selection/fake-drag-expected.png: Added.
        * platform/gtk/editing/selection/inline-closest-leaf-child-expected.checksum: Added.
        * platform/gtk/editing/selection/inline-closest-leaf-child-expected.png: Added.
        * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
        * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
        * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
        * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@81076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously they were being shown in a deterministic but surprising order based on
lexicographically sorting the build offsets (-1, -10, -2, -3...).

Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
callback.

git-svn-id: svn://svn.chromium.org/blink/trunk@81075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

the correct slices - i386/x86_64/ppc for SnowLeopard and i386/x86_64/ppc/ppc64 for Leopard.

Rubber-stamped by Mark Rowe.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: svn://svn.chromium.org/blink/trunk@81074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Mac pixel rebaselines for r81053.

        * platform/mac/editing/selection/drag-select-1-expected.checksum:
        * platform/mac/editing/selection/drag-select-1-expected.png:
        * platform/mac/editing/selection/fake-drag-expected.checksum:
        * platform/mac/editing/selection/fake-drag-expected.png:
        * platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum:
        * platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
        * platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
        * platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
        * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
        * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
        * platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
        * platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
        * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
        * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:


git-svn-id: svn://svn.chromium.org/blink/trunk@81072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        Removed more cases of DeprecatedPtr (exception, SmallStrings)
        https://bugs.webkit.org/show_bug.cgi?id=56332

        * runtime/Identifier.cpp:
        (JSC::Identifier::add):
        (JSC::Identifier::addSlowCase): Use a variable instead of a hard-coded
        constant, to make this code less brittle.

        * runtime/JSGlobalData.h: Use HeapRoot instead of DeprecatedPtr because
        this reference is owned and managed directly by the heap.

        * runtime/JSString.cpp:
        (JSC::JSString::substringFromRope):
        * runtime/JSString.h:
        (JSC::jsSingleCharacterString):
        (JSC::jsSingleCharacterSubstring):
        (JSC::jsString):
        (JSC::jsStringWithFinalizer):
        (JSC::jsSubstring):
        (JSC::jsOwnedString): Use a variable instead of a hard-coded
        constant, to make this code less brittle.

        * runtime/SmallStrings.cpp:
        (JSC::SmallStringsStorage::rep):
        (JSC::SmallStringsStorage::SmallStringsStorage):
        (JSC::SmallStrings::SmallStrings):
        (JSC::SmallStrings::markChildren):
        (JSC::SmallStrings::clear):
        (JSC::SmallStrings::count): Use a variable instead of a hard-coded
        constant, to make this code less brittle.

        * runtime/SmallStrings.h:
        (JSC::SmallStrings::singleCharacterString): Use HeapRoot instead of
        DeprecatedPtr because these references are owned and managed directly by
        the heap.
        
        Stop using FixedArray because we only want a very limited set
        of classes to be able to use HeapRoot. (Replaced with manual ASSERTs.)

        * runtime/WriteBarrier.h:
        (JSC::operator==):
        (JSC::WriteBarrier::WriteBarrier):
        (JSC::HeapRoot::HeapRoot):
        (JSC::HeapRoot::operator=): Added HeapRoot, which is allowed to set
        without write barrier because we assume all HeapRoots are scanned during
        all GC passes.


git-svn-id: svn://svn.chromium.org/blink/trunk@81071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium-win/editing/selection/drag-select-1-expected.checksum:
* platform/chromium-win/editing/selection/drag-select-1-expected.png:
* platform/chromium-win/editing/selection/drag-select-1-expected.txt:
* platform/chromium-win/editing/selection/fake-drag-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Compilation fails with --3d-canvas
        https://bugs.webkit.org/show_bug.cgi?id=55964

        * WebCore.pro:
        * platform/graphics/qt/Extensions3DQt.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@81069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
analyze

Reviewed by David Kilzer and Joe Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(#url-prompt): Made this a bit taller to make room for the list of builds.

(#recent-builds-loading-indicator):
(#recent-builds-list):
Added styles for the build list and loading indicator.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
it. This will unescape it.
(LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
(LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
(LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
(LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
prompt UI.
(LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
now also used when a recent build is clicked.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
(RecentBuildsLoader): Store the callback.
(RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
builder. Find the revision number, leak count, and results URL for each one. Pass the
resulting info to our callback.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
(range): Added this helper function to return an array containing the integers [0, n).

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.

git-svn-id: svn://svn.chromium.org/blink/trunk@81068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@81067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        GTK rebaselines or r81053.

        * platform/gtk/editing/selection/drag-select-1-expected.txt:
        * platform/gtk/editing/selection/fake-drag-expected.txt:
        * platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@81066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/9126635>
        
Reviewed by Adam Roben and Gavin Barraclough.

Source/JavaScriptCore: 

Give StringConcatenate the ability to deal with const UChar*'s as a String type to append.

* wtf/text/StringConcatenate.h:

Source/WebCore: 

Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
so it can be used from both WebCore and WebKit2.
        
Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
of paths matching the passed in pattern.

* WebCore.vcproj/WebCore.vcproj:
* platform/win/FileSystemWin.cpp:
(WebCore::listDirectory): Call through to PathWalker.
* platform/win/PathWalker.cpp: Added.
(WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument
    for the pattern to pass to the Windows File APIs.
(WebCore::PathWalker::~PathWalker): Moved from WebKit2.
(WebCore::PathWalker::isValid): Ditto.
(WebCore::PathWalker::data): Ditto.
(WebCore::PathWalker::step): Ditto.
* platform/win/PathWalker.h: Added.

Source/WebKit2: 

Move PathWalker down into WebCore, and call the PathWalker in WebCore
(that now has a second argument, the pattern to take).

* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::pluginPathsInDirectory):



git-svn-id: svn://svn.chromium.org/blink/trunk@81065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For r81053, we have
   editing/selection/drag-select-1.html, editing/selection/fake-drag.html, svg/custom/mouse-move-on-svg-container-standalone.svg,
   svg/custom/mouse-move-on-svg-container.xhtml, svg/custom/mouse-move-on-svg-root-standalone.svg, svg/custom/mouse-move-on-svg-root.xhtml

For r81049, we have
   fast/table/overflowHidden.html, fast/table/relative-position-containment.html, fast/table/relative-position-offsets.html, fast/table/relative-position-stacking.html

* platform/chromium-linux/editing/selection/drag-select-1-expected.checksum:
* platform/chromium-linux/editing/selection/drag-select-1-expected.png:
* platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Added.
* platform/chromium-linux/editing/selection/fake-drag-expected.txt: Added.
* platform/chromium-linux/fast/table/relative-position-containment-expected.checksum: Added.
* platform/chromium-linux/fast/table/relative-position-containment-expected.png: Added.
* platform/chromium-linux/fast/table/relative-position-offsets-expected.checksum: Added.
* platform/chromium-linux/fast/table/relative-position-offsets-expected.png: Added.
* platform/chromium-linux/fast/table/relative-position-stacking-expected.checksum: Added.
* platform/chromium-linux/fast/table/relative-position-stacking-expected.png: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
* platform/chromium-win/fast/table/overflowHidden-expected.txt:
* platform/chromium-win/fast/table/relative-position-containment-expected.checksum: Added.
* platform/chromium-win/fast/table/relative-position-containment-expected.png: Added.
* platform/chromium-win/fast/table/relative-position-containment-expected.txt: Added.
* platform/chromium-win/fast/table/relative-position-offsets-expected.checksum: Added.
* platform/chromium-win/fast/table/relative-position-offsets-expected.png: Added.
* platform/chromium-win/fast/table/relative-position-offsets-expected.txt: Added.
* platform/chromium-win/fast/table/relative-position-stacking-expected.checksum: Added.
* platform/chromium-win/fast/table/relative-position-stacking-expected.png: Added.
* platform/chromium-win/fast/table/relative-position-stacking-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Removed redundant baselines from Windows port so that rebaselines done in r81059 take effect.

        * platform/win/svg/custom/mouse-move-on-svg-container-expected.txt: Removed.
        * platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed.
        * platform/win/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
        * platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@81063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-1-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-10-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-2-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-3-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-4-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-5-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-6-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-7-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-8-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-9-expected.txt: Added.
* platform/mac/fast/html/details-no-summary1-expected.txt: Added.
* platform/mac/fast/html/details-no-summary2-expected.txt: Added.
* platform/mac/fast/html/details-no-summary3-expected.txt: Added.
* platform/mac/fast/html/details-no-summary4-expected.txt: Added.
* platform/mac/fast/html/details-open-javascript-expected.txt: Added.
* platform/mac/fast/html/details-open1-expected.txt: Added.
* platform/mac/fast/html/details-open2-expected.txt: Added.
* platform/mac/fast/html/details-open3-expected.txt: Added.
* platform/mac/fast/html/details-open4-expected.txt: Added.
* platform/mac/fast/html/details-open5-expected.txt: Added.
* platform/mac/fast/html/details-open6-expected.txt: Added.
* platform/mac/fast/html/details-position-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/mac/fast/html/details-writing-mode-expected.txt: Added.
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Qt rebaselines for r81053.

        * platform/qt/editing/selection/drag-select-1-expected.txt:
        * platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
        * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
        * platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
        * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@81061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Try to fix the EFL build-bustage that their EWS bot did not see, but their core-builder did.  (sigh)

* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):



git-svn-id: svn://svn.chromium.org/blink/trunk@81060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Mac rebaselines for r81053.

        * platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
        * platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
        * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
        * platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
        * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@81059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"

Reviewed by Anders Carlsson.

../WebCore: 

Remove HistoryItem::icon():
* history/HistoryItem.cpp:
* history/HistoryItem.h:
* WebCore.exp.in:

* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::defaultIcon):

../WebKit/efl: 

* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get): Use IconDatabase directly.

../WebKit/mac: 

* History/WebHistoryItem.mm:
(-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.

../WebKit/qt: 

* Api/qwebhistory.cpp:
(QWebHistoryItem::icon): Use IconDatabase directly.



git-svn-id: svn://svn.chromium.org/blink/trunk@81058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Timer-based events should inherit the user gesture state of their
        originating event in certain cases.
        https://bugs.webkit.org/show_bug.cgi?id=55104

        * fast/events/popup-blocking-timers-expected.txt: Added.
        * fast/events/popup-blocking-timers.html: Added.
2011-03-14  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Timer-based events should inherit the user gesture state of their
        originating event in certain cases.
        https://bugs.webkit.org/show_bug.cgi?id=55104

        If a timer is installed by a gesture-originated event and will fire
        within one second, the timer-initiated event should behave as if it
        were also initiated by a user gesture. Multi-shot timers should only
        get this behavior on their first execution. Nested timers should not
        get this behavior. This makes us compatible with Gecko when handling
        popups and file chooser dialogs created from timer events.

        Test: fast/events/popup-blocking-timers.html

        * page/DOMTimer.cpp:
        (WebCore::timeoutId): Create a helper function so that m_timeoutId can
        be initialized in the data member initialization list.
        (WebCore::shouldForwardUserGesture): Ditto, but for
        m_shouldForwardUserGesture.
        (WebCore::DOMTimer::DOMTimer): Move initialization of data members from
        the ctor body to the data member initialization list. Also rename the
        argument 'timeout' to 'interval'.
        (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its
        state based on the value of m_shouldForwardUserGesture.
        (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was
        renamed to m_originalInterval.
        * page/DOMTimer.h: Add m_shouldForwardUserGesture and rename
        m_originalTimeout to m_originalInterval.


git-svn-id: svn://svn.chromium.org/blink/trunk@81057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ryosuke Niwa.

        Deleting content directly following a button inserts an unnecessary placeholder
        https://bugs.webkit.org/show_bug.cgi?id=56053

        Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed.

        * editing/deleting/delete-inserts-br-after-button-expected.txt: Added.
        * editing/deleting/delete-inserts-br-after-button.html: Added.
2011-03-09  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Deleting content directly following a button inserts an unnecessary placeholder
        https://bugs.webkit.org/show_bug.cgi?id=56053

        Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
        enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
        DeleteSelectionCommand treating them as blockflow.

        Test: editing/deleting/delete-inserts-br-after-button.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs):


git-svn-id: svn://svn.chromium.org/blink/trunk@81056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Dan Bernstein.

REGRESSION: <a><img align=top></a> Clickable area too large
        
Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.

Source/WebCore: 

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):

LayoutTests: 

* fast/inline/inline-position-top-align-expected.txt: Added.
* fast/inline/inline-position-top-align.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@81055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
        https://bugs.webkit.org/show_bug.cgi?id=52845

        The lastCommitTime() value in CACFLayerTreeHost was returning as the time
        the render previous to this one happened. That often made it seem like
        animations started more in the past than they did, breaking many animations.
        The startAnimations() call actually fires from a CACF callback after all the
        WebKit content has been rendered. So sending currentTime as the start time
        to the animations is close enough for proper synchronization.

        * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
        (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):


git-svn-id: svn://svn.chromium.org/blink/trunk@81054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        Selection uses first mousemove's localRect instead of that of mousedown
        https://bugs.webkit.org/show_bug.cgi?id=56213

        Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
        using the mouse coordinates of the mousedown event that started the drag.

        Test: editing/selection/drag-select-rapidly.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):
2011-03-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Selection uses first mousemove's localRect instead of that of mousedown
        https://bugs.webkit.org/show_bug.cgi?id=56213

        Added a test to ensure the selection start is computed using the mouse coordinates passed down
        to the corresponding mousedown event instead of that of the first mousemove event.

        The test is co-authored by Evan Martin.

        * editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
        * editing/selection/anchor-focus3-expected.txt: Ditto.
        * editing/selection/drag-select-rapidly-expected.txt: Added.
        * editing/selection/drag-select-rapidly.html: Added.
        * platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
        * platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
        * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.


git-svn-id: svn://svn.chromium.org/blink/trunk@81053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

except for the typical minor font differences.

* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@81052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.

Tools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions): Remove duplicate entries.

git-svn-id: svn://svn.chromium.org/blink/trunk@81051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Timothy Hatcher.

* Configurations/Base.xcconfig: Disable the generation of debugging symbols when
building the Debug configuration on Leopard. This should cut the size of the object
files that the linker needs to process by over 85%. This will hopefully allow them
to fit in to the 32-bit address space of the Leopard linker.

git-svn-id: svn://svn.chromium.org/blink/trunk@81050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Reviewed by Beth Dakin.

Add support for relative positioning to table cells.   Back out the code that hacked around the lack of support
for offsetLeft, and add new tests to demonstrate that relative positioning works.

Source/WebCore: 

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRelPositioned):
* rendering/RenderTableCell.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests: 

* fast/table/relative-position-containment.html: Added.
* fast/table/relative-position-offsets.html: Added.
* fast/table/relative-position-stacking.html: Added.
* platform/mac/fast/table/overflowHidden-expected.txt:
* platform/mac/fast/table/relative-position-containment-expected.checksum: Added.
* platform/mac/fast/table/relative-position-containment-expected.png: Added.
* platform/mac/fast/table/relative-position-containment-expected.txt: Added.
* platform/mac/fast/table/relative-position-offsets-expected.checksum: Added.
* platform/mac/fast/table/relative-position-offsets-expected.png: Added.
* platform/mac/fast/table/relative-position-offsets-expected.txt: Added.
* platform/mac/fast/table/relative-position-stacking-expected.checksum: Added.
* platform/mac/fast/table/relative-position-stacking-expected.png: Added.
* platform/mac/fast/table/relative-position-stacking-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@81049 bbb929c8-8fbe-4397-9dbb-9b2b20218538