- 26 Oct, 2018 40 commits
-
-
Kelvin Jiang authored
Add a placeholder page to show an activity log for an extension, hidden behind the "enable-extension-activity-logging" command line flag, and accessible via chrome://extensions/?id=<extension_id>. If the flag is disabled and a user navigates to the page, redirect to the extensions details page. Bug: 898309 Change-Id: Ib0f50487c323e8c07d6fddcd57df3b8e5477cfc6 Reviewed-on: https://chromium-review.googlesource.com/c/1295296Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603176}
-
Dominic Mazzoni authored
This reverts commit 0e8f7da5. Reason for revert: still failing on bots, for example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75295 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/35731 Original change's description: > Enable http/tests/webaudio/autoplay-crossorigin.html > > This test can be enabled again. > > BUG=841933 > > Change-Id: I8729daf0584da308f089502f0730ae398befb022 > Reviewed-on: https://chromium-review.googlesource.com/c/1299550 > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603107} TBR=lukasza@chromium.org,beccahughes@chromium.org Change-Id: Icb53758085810a468770f4492ac43ed1639b140f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841933 Reviewed-on: https://chromium-review.googlesource.com/c/1302678Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603175}
-
Robbie McElrath authored
This test was reenabled in crrev.com/c/1299550, and is breaking the Mojo Windows and Mojo Linux fyi try bots. Bug: 841933 Change-Id: I1bfb367a3145e55ed06d966d821f9e596069d7a3 Reviewed-on: https://chromium-review.googlesource.com/c/1302325 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603174}
-
Jeremy Roman authored
Bug: 670615 Change-Id: Ifd560c15fe8440d6501935753afb5f6eff6cd176 Reviewed-on: https://chromium-review.googlesource.com/c/1299735 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#603173}
-
Geoff Lang authored
BUG=882580 Change-Id: I1a065f608bdd709e74b4bbe83eb744bea5fcc9d2 Reviewed-on: https://chromium-review.googlesource.com/c/1302095Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603172}
-
Nico Weber authored
mini_installer.exe embeds chrome.7z, and chrome.7z contains timestamps of all files in the archive. To make chrome.7z more deterministic, give all files in it deterministic timestamps. Bug: 330260 Change-Id: Ia251dd38177acbebdde288b86826986f441b2d4d Reviewed-on: https://chromium-review.googlesource.com/c/1302393Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#603171}
-
Roger Tawa authored
Bug: 899239 Change-Id: I17dea00048fb3224dcfb17381ba6a1d5db689793 Reviewed-on: https://chromium-review.googlesource.com/c/1301839 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603170}
-
Xiaocheng Hu authored
Don't create VisiblePosition and VisibleSelection in FrameSelection::SelectFrameElementInParentIfFullySelected() This patch refactors the function's selection setting and validation part, so that: - It stops the problematic pattern of creating VisibleSelection before focusing parent frame, which may invalidate the VS - It no longer creates VisiblePosition and VisibleSelection for creating the selection. This is because for a frame owner element, the range [before_node, after_node] is already a canonicalized range, on which creating VP or VS is unnecessary. Bug: 657237, 897983 Change-Id: I5b046047071a4af7454cc1bfef52a457fe49d9c2 Reviewed-on: https://chromium-review.googlesource.com/c/1298179Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#603169}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07d9342e84c2..1ef5883ceab7 Created with: gclient setdep -r src-internal@1ef5883ceab7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia52f63ade549cf9dfe8b5267bda6487ce0ff4d9b Reviewed-on: https://chromium-review.googlesource.com/c/1302213Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603168}
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I6e561ba5f0e92758fb2922bd8e41c4feb70f2203 Reviewed-on: https://chromium-review.googlesource.com/c/1301696Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#603167}
-
Dominic Mazzoni authored
TBR=katie@chromium.org NOTRY=true Bug: 862710 Change-Id: I6d49841747cdd900570f97e128b647dc15060d04 Reviewed-on: https://chromium-review.googlesource.com/c/1302674Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603166}
-
Khushal authored
The transfer buffer allocation on the client and GURL allocation on the service was showing up in profiles. Avoid that by caching the last active URL on the client and only send an update if it changes. Also hook this up for GPU raster. R=vmiura@chromium.org Bug: 894200 Change-Id: If9519f3203a9f53ac16ccbeba685b239339aa5cc Reviewed-on: https://chromium-review.googlesource.com/c/1298642Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#603165}
-
Sam Maier authored
This also suppresses issues brought up by the checks that aren't easily fixable. Timing without change on chrome_java: real 0m3.142s user 0m7.278s sys 0m0.563s Timing with change on chrome_java: real 0m3.429s user 0m8.035s sys 0m0.687s TBR=trivial third_party changes Bug: 898251, 874854 Change-Id: Ifcb10f260e80a542ab26a470bb53426e1404e9f0 Reviewed-on: https://chromium-review.googlesource.com/c/1297233 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603164}
-
Etienne Bergeron authored
This category was not useful. It's adding a trace event for each top-level post-task, which is about doubling the size of a trace. Let remove it. R=oysteine@chromium.org Change-Id: I271f5314179e7ae6299835c36a0f92a6506eae08 Reviewed-on: https://chromium-review.googlesource.com/c/1301838Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603163}
-
David Quiroz Marin authored
Currently there is no way to know if a CanvasImageSource comes from an HTML Image Element, so this CL adds another function to the base class to differentiate SVGs from Image Elements. Change-Id: I3978171ba199f372ec685d446215bdfdc83eaa9f Reviewed-on: https://chromium-review.googlesource.com/c/1301967Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603162}
-
kylechar authored
There are only ever a couple observers so base::flat_set should have less overhead that std::unordered_set, especially given how frequently it's copied. Change-Id: Ib800e3461dbbb902041584ce8c4325eec4a91694 Reviewed-on: https://chromium-review.googlesource.com/c/1301965 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603161}
-
Zach Stein authored
Bug: chromium:875740 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iec6efad4b3d92877288fd29450f11ac008b26d27 Reviewed-on: https://chromium-review.googlesource.com/c/1280551Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Zach Stein <zstein@google.com> Cr-Commit-Position: refs/heads/master@{#603160}
-
Dominic Mazzoni authored
This reverts commit f144f4a9. Breaks compile on "Linux Chromium OS ASan LSan": https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/41713 ../../ui/views/accessibility/ax_virtual_view.cc:2396: error: undefined reference to 'ui::AXPlatformNodeBase::GetData() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTreeData() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetIndexInParent() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetReverseRelations(ax::mojom::IntAttribute, int)' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetReverseRelations(ax::mojom::IntListAttribute, int)' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTableRowCount() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTableColCount() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetColHeaderNodeIds() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetColHeaderNodeIds(int) const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetRowHeaderNodeIds() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetRowHeaderNodeIds(int) const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetCellId(int, int) const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTableCellIndex() const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::CellIndexToId(int) const' obj/ui/views/libviews.a(obj/ui/views/views/ax_virtual_view.o):ax_virtual_view.cc:vtable for views::AXVirtualView: error: undefined reference to 'ui::AXPlatformNodeDelegateBase::GetTargetForNativeAccessibilityEvent()' clang: error: linker command failed with exit code 1 (use -v to see invocation) [15380/16841] LINK ./app_list_unittests Original change's description: > Reland "Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants" > > This is a reland of cb9c3091 > > TBR=afakhry@chromium.org,dmazzoni@chromium.org,sky@chromium.org > > Original change's description: > > Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants > > > > Also renamed some methods to make interface more consistent. > > In preparation for more changes in AXVirtualView. > > R=dmazzoni@chromium.org, aleventhal@chromium.org > > > > Change-Id: Ib417493794cc16536e20c3ce72dc8b00ba8568a9 > > Reviewed-on: https://chromium-review.googlesource.com/c/1296621 > > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602876} > > Change-Id: I08aa777df2ce4a7fc93e30e00ef4aced623fdd6e > Reviewed-on: https://chromium-review.googlesource.com/c/1301796 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603148} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,sky@chromium.org,afakhry@chromium.org,nektar@chromium.org,aleventhal@chromium.org Change-Id: Ie75dec553acb4ea618665de25f5729f1feb51e12 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1302499Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603159}
-
Findit authored
This reverts commit 4fcaee53. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603116 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGZjYWVlNTMxMzliMGFmYjAwM2ZmMWJhMTNiOTAyYTZhM2YyYTMxNQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/6030 Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6 Sample Flaky Test: media/controls/overflow-menu-toggle-class-for-animation.html Original change's description: > [Media Controls] Added animation to overflow menu > > Toggle "closed" class when open/close menu to achieve transition animation. > This CL only has opening animation. > > TODO: Add close animation; Add wave like animation to label when opening menu. > > Bug: 814507 > > Change-Id: I2a036297741f34905fe868c7ea0a99e9ea91cea3 > Reviewed-on: https://chromium-review.googlesource.com/c/1286949 > Commit-Queue: Jazz Xu <jazzhsu@google.com> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603116} Change-Id: Ia9b6c5e419ec201f6ac328a1de049c65528f6dc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814507, 899335 Reviewed-on: https://chromium-review.googlesource.com/c/1302577 Cr-Commit-Position: refs/heads/master@{#603158}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2769cd540c1e..fdee701fa8e4 git log 2769cd540c1e..fdee701fa8e4 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 terelius@webrtc.org Add parser and unittests for new RTC event log format. 2018-10-26 srte@webrtc.org Makes critsect_.Leave() more visible in PacedSender. 2018-10-26 danilchap@webrtc.org Remove deprecated deregistration functions in RtcpTransceiver 2018-10-26 magjed@webrtc.org Add support to adapt video without preserving aspect ratio 2018-10-26 mbonadei@webrtc.org Simplify api/DEPS presubmit check. 2018-10-26 nisse@webrtc.org Use MediaTransportInterface, for audio streams. Created with: gclient setdep -r src/third_party/webrtc@fdee701fa8e4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea2b43bd9ecc0702cb7d4302d89378b45b34fa64 Reviewed-on: https://chromium-review.googlesource.com/c/1301876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603157}
-
Daniel Bratell authored
gn check by default only works on those targets that are listed in check_targets, and since we can't whitelist all of //third_party, every sub-folder has to be individually listed. Some were listed before but this adds another two hundred. 5-10% of the folders are still excluded because they have one or more internal check problems. Specifically third_party/blink is not included yet. Working on it. Bug: 898837 Change-Id: Ia2a2cc14c00ecfdb956eb553664efe46356dedc3 Reviewed-on: https://chromium-review.googlesource.com/c/1299086Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603156}
-
Peter Kotwicz authored
BUG=None Change-Id: Ie52659e0042e608e045dd2ffb89ca370c964e6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1298428Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603155}
-
Shawn Gallea authored
Moved ash files under is_chromeos for eventual non-ChromeOS compilation. Bug: 896710 Test: Built on ChromeOS. Change-Id: Ic03a4b6ce9edab2ce5b5d0c50f2cce46bd96ae50 Reviewed-on: https://chromium-review.googlesource.com/c/1291778Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#603154}
-
Clark DuVall authored
TBR=jam@chromium.org Bug: 827531 Change-Id: I1d104ee55e7ff56e62eb30d54301696230ef9784 Reviewed-on: https://chromium-review.googlesource.com/c/1302103Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603153}
-
Dominic Mazzoni authored
Also, address documentation feedback from a previous change: http://crrev.com/c/1195658 Bug: 862710 TBR=katie@chromium.org NOTRY=true Change-Id: I19f8456ab13719973f5c83c4b849574b92fc2ac4 Reviewed-on: https://chromium-review.googlesource.com/c/1302573Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603152}
-
Xi Han authored
SetDefaultCookiePolicyToBlock() should be called before any url request. Call it it in the early startup. Bug: 899276 Change-Id: Idf747013cd19d057506d7e0314a2d8c64c413c29 Reviewed-on: https://chromium-review.googlesource.com/c/1301842Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603151}
-
Peter Boström authored
This class is superseded by MdTextButton and was only used in views example files. Bug: None Change-Id: Ic8740ff51e87bea5e753467ca017db181db76c30 Reviewed-on: https://chromium-review.googlesource.com/c/1298639Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#603150}
-
Peter Kotwicz authored
This CL removes the |callingActivityComponentName| parameter from HostBrowserLaunchParams#createForIntent() because the parameter is redundant. The component can be retrieved from the intent. BUG=817263 Change-Id: I0040625ae1c5a780c795c425d8e74e2c3155597a Reviewed-on: https://chromium-review.googlesource.com/c/1298421Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603149}
-
Nektarios Paisios authored
This is a reland of cb9c3091 TBR=afakhry@chromium.org,dmazzoni@chromium.org,sky@chromium.org Original change's description: > Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants > > Also renamed some methods to make interface more consistent. > In preparation for more changes in AXVirtualView. > R=dmazzoni@chromium.org, aleventhal@chromium.org > > Change-Id: Ib417493794cc16536e20c3ce72dc8b00ba8568a9 > Reviewed-on: https://chromium-review.googlesource.com/c/1296621 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602876} Change-Id: I08aa777df2ce4a7fc93e30e00ef4aced623fdd6e Reviewed-on: https://chromium-review.googlesource.com/c/1301796 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#603148}
-
Jesse McKenna authored
TaskScheduler: Delegate insertion of Sequences by Scheduler(Parallel|Sequenced)TaskRunner to TaskScheduler Bug: 889029 Change-Id: I06e871a56204ae64b14fe75e58e77ba4a757e5ac Reviewed-on: https://chromium-review.googlesource.com/c/1294471 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#603147}
-
Shawn Gallea authored
Added a sample fullscreen client. The client demonstrates usage of the Wayland Fullscreen Shell protocol. Does not run without server-side fullscreen shell implementation. Bug: 896710 Test: Compiled client on ChromeOS and verified it still builds. Change-Id: I681e864c739faafee07b257fd4c15c49929859cc Reviewed-on: https://chromium-review.googlesource.com/c/1281424 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#603146}
-
Gabriel Marin authored
Makes the default and max release delays equal to the older values used in Chromium, to reduce memory use. BUG=724399,b:118386135 Change-Id: I651d5542c541b7e0e3a44b16b6c5800a4f7f9e1e Reviewed-on: https://chromium-review.googlesource.com/c/1298339Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#603145}
-
Jeremy Roman authored
There can only be four (as evidenced by the GLint array it is populated from). Change-Id: I1bcbf4197c520bcdc02d553d1fb3c3f7bf9b428b Reviewed-on: https://chromium-review.googlesource.com/c/1301956Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603144}
-
kylechar authored
There is a global CommandBufferTaskExecutor that gets created if an instance isn't provided. This task executor picks up the current command line to create GpuPreferences on first use, which caused problems where depending on what test ran first the GpuPreferences would be different and later tests would fail. Don't use the global task executor in gl_tests. Move and rename InProcessGpuThreadHolder so that each test which needs it can instantiate the object itself. Also enable GLInProcessCommandBufferTest.CreateImage again. Bug: 897456 Change-Id: Icdc307bd68453fdc2b898a9765a3f903b21fdfe8 Reviewed-on: https://chromium-review.googlesource.com/c/1298214 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603143}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/262cfc4a..a4f6a37d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1191e908b4a8462202a3dd87d079b216cb0d8c20 Reviewed-on: https://chromium-review.googlesource.com/c/1301961Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603142}
-
David Benjamin authored
After https://codereview.chromium.org/1476173006, it should work in pure-Java setups too. Bug: none Change-Id: If6daf5346029a83ccfc73f7893587434533c5d40 Reviewed-on: https://chromium-review.googlesource.com/c/1299610Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#603141}
-
Xing Liu authored
This is a reland of b859fdbb Reason for reland: Link to a wrong crbug. Original change's description: > Download home v2: Increase thumbnail cache size. > > On Android we use an in-memory thumbnail cache to improve view recycling > performance and use a disk cache to avoid costly backend operations like > decoding images, videos etc. > > For download home v2, the thumbnail size is much larger than the old > download home, thus we need to tweak the size of cache. 90% percentile > of users have around 15 media thumbnails. The size of bitmap varies from > under 1MB to around 5MB. The disk cache uses PNG to compress, the > compression rate is around 1/3. > > This CL does the following: > > 1. The size of the thumbnail for high dpi devices are scaled down to > mdpi, which can save memory/disk. > > 2. For in-memory cache size, download home v2 uses 15MB for high end > devices. In-memory cache size is now passed in from owner of > ThumbnailProviderImpl. > > 3. Disk cache size is increased. This should be shared by multiple > owners of ThumbnailProviderImpl, or the owner with smaller disk cache > size may remove files unexpectedly used by other owners. > > Bug: 87292 > Change-Id: If7cb700a60a8d119bca136b1a7d1fe7feb787d8b > Reviewed-on: https://chromium-review.googlesource.com/c/1296546 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602957} TBR=dtrainor@chromium.org,qinmin@chromium.org Bug: 872925 Change-Id: Ida007e9255b033a48e259a214bf89431b25daafd Reviewed-on: https://chromium-review.googlesource.com/c/1300684 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603140}
-
Xiaocheng Hu authored
The class creates VisiblePosition to be passed to EndOfSentence(), but EndOfSentence() doesn't require input position to be canonical. ColdModeSpellCheckRequester doesn't require the EndOfSentence() output to be canonical, either. Hence, this patch changes ColdModeSpellCheckRequester to use the non- canonical variant of EndOfSentence(). Bug: 657237 Change-Id: I96df36bb49c150f12ba037729221b8bcdaa9c09a Reviewed-on: https://chromium-review.googlesource.com/c/1298482Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#603139}
-
Sahel Sharify authored
Bug: 766357 Change-Id: Ibff868e5eabd019e02a3b7b225b26d78f1b9578a Reviewed-on: https://chromium-review.googlesource.com/c/1299695Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603138}
-
Clark DuVall authored
This field was only being used in tests. Bug: 721403 Change-Id: I58d0bb526827c54a706d4bf16b42efebf9ea2f81 Reviewed-on: https://chromium-review.googlesource.com/c/1301962Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603137}
-