GitLab

DOM CodeString comes from scancode, so SendInput should use scancode instead of
virtual-key if the key is associated with a DOM CodeString.
With this change, test cases in https://codereview.chromium.org/2922773002/
should pass.

A KeyboardEventCodeInteractiveTest is also added to ensure KeyboardEvent.code
can be correctly set by using ui_test_utils::SendKeyPressSync().
KeyboardEventCodeInteractiveTest starts a web page to record all the
KeyboardEvent.code it received, sends several key presses through
ui_test_utils::SendKeyPressSync() and verifies whether the record is expected.

BUG=680809

Review-Url: https://codereview.chromium.org/2939283002
Cr-Commit-Position: refs/heads/master@{#481671}

This CL adds @autoreleasepool to ios/chrome/app/chrome_exe_main.mm, and
serves as a parent CL of https://codereview.chromium.org/2887413002/
so that ios/chrome/app:main can be converted to ARC.

Bug: 624363
Change-Id: Ibe55897f1869643deee85723c97b0062146b01d0
Reviewed-on: https://chromium-review.googlesource.com/540701
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481670}

After https://chromium-review.googlesource.com/521162 the API is quite
closely aligned with the standard, although the rendering bits still are
not.

Enabling it will make it easier to test, and might shake out compat
problems in the wild earlier.

Bug: 383813
Change-Id: I0c9add3bdc77f689deeafb207022e5c9fea1e3bd
Reviewed-on: https://chromium-review.googlesource.com/544303
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481669}

This patch sets RenderViewTest's initial size to be 400x300 instead of
0x0 so scrolling can work. This is in preparation for a future patch
that asserts scroll layers have non-zero dimensions.

The following test changes were required:
1) RenderViewTest.MacTestCmdUp: removed a TODO hack that made the document
non-empty for scrolling.
2) PasswordGenerationAgentTest.FillTest previously used a gesture to focus
an initial element but this gesture event failed because the window size
was empty. This patch removes the gesture event so the test still has no
initial focused element.
3) RenderViewImplTest.NavigateSubframe no longer wraps "hello world".
4) RenderFrameImplTest.FrameResize has been changed so it does change the
viewport instead of leaving it with a 0,0 size, and a new test proves it.

Bug: 723263
Change-Id: Ie1d56dcbf09ddf6250011a8a59e6c07fafd60346
Reviewed-on: https://chromium-review.googlesource.com/541982Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481668}

Changes:
This is basically a refactor of code to support more than one wallpaper
prominent color extracting.
(1) group LumaRange and SaturationRange to ColorProfile, and a vector
of color_profiles are passed as parameter for calculation.
(2) updated UMA for Ash.Wallpaper.ColorExtractionResult to enumeration.

R=xdai@chromium.org, bruthig@chromium.org, estade@chromium.org,
danakj@chromium.org, isherman@chromium.org, jamescook@chromium.org
BUG=734761
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2943333003
Cr-Commit-Position: refs/heads/master@{#481667}

ERR_IPC_WITH_NO_RELEVANT_LOAD and ERR_IPC_FROM_BAD_URL_SCHEME are
errors that help to understand when we receive messages from a
render process that aren't expected in the browser process.

Historically, we only tracked main frames, so it made sense to
log these on all IPCs.

As of https://codereview.chromium.org/2859393002, we receive
IPCs from both main and child frames.

It is valid and expected to receive these IPCs from a child
frame when we aren't tracking a main frame, as render tracking
policy is purely per frame and has no awareness of the main
frame's URL etc.

Thus, we update the code that logs these errors to only do so
for messages received from main frames.

Bug: 736075
Change-Id: Ifc7f2dd758fc244de8e7098a3c553f8bb2ad05ee
Reviewed-on: https://chromium-review.googlesource.com/545016Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481666}

This checks to see if an editable address item in the UI is complete. If it
is not then the address editor will be shown. If it is complete the address
will be selected whether its for billing or shipping.

Address fields incomplete: http://imgur.com/a/1hEVK
Filling out first card: http://imgur.com/a/Eupai
Second card leads to editor: http://imgur.com/a/OFNHi

Bug: 602666
Change-Id: Ic9c1e731b6c989b289cde4e47ed36543df734a20
Reviewed-on: https://chromium-review.googlesource.com/534673
Commit-Queue: Randall Raymond <rayraymond@google.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481665}

BUG=None
TEST=Ran trybots.

Change-Id: I629a44b1dc0f58118a6526e1047e7bb31ec1d82e
Reviewed-on: https://chromium-review.googlesource.com/544721Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481664}

CompositorProxy is a used by CompositorWorker which is being superseded by
AnimationWorklet. Given that AnimationWorklet is not going to use
CompositorProxy we are removing it and other related classes.

This also means removing tests that where mainly associated with  CompsitorProxy
functionality.


Bug: 686897, 619042
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7fa749c83e74fa65e8271d2111ebc9ae2e872ebb
Reviewed-on: https://chromium-review.googlesource.com/527455
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481663}

The previous format was unspecified, untested, and using the older
category_filters format. This is incompatible with the newer included/excluded
categories format.

The new format is the same as the TraceConfig format. This CL also adds tests.

BUG=chromium:735124

Review-Url: https://codereview.chromium.org/2948033004
Cr-Commit-Position: refs/heads/master@{#481662}

This reverts commit 31c39d8d.

Reason for revert: Trying again.

Original change's description:
> Revert "Add new gn arg for Linux builds on chromium.perf"
> 
> This reverts commit b81f0267.
> 
> Reason for revert: Might have totally broken the builder.
> 
> Original change's description:
> > Add new gn arg for Linux builds on chromium.perf
> > 
> > It appears there's a way to disable using the gnome keyring
> > service on linux, which has been causing our bots issues. Try setting
> > this gn arg to see what happens.
> > 
> > Bug: 732463
> > Change-Id: Iaa1ff400e506ae6245346741d4bcdeaaa695fd4f
> > Reviewed-on: https://chromium-review.googlesource.com/542015
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#481143}
> 
> TBR=dpranke@chromium.org,kbr@chromium.org,nednguyen@google.com,martiniss@chromium.org
> 
> Change-Id: I96533c8eb48da571ff289834a478f9b896dc414a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 732463
> Reviewed-on: https://chromium-review.googlesource.com/543537
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481213}

TBR=dpranke@chromium.org,kbr@chromium.org,nednguyen@google.com,martiniss@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 732463
Change-Id: I0cf5ee9662adaffcc629832d19c8fcbab0b0c834
Reviewed-on: https://chromium-review.googlesource.com/544686Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481661}

1. Provide interfaces in app_list::SearchResult to set price and rating
for instant and play store apps based on specs.
2. Change the layouts of SearchResultTileItemListView and
SearchResultTileItemView to show price and rating properly based on
specs.

Specifications:
https://screenshot.googleplex.com/AFQ5HnrMYch
https://screenshot.googleplex.com/0opcNunaJrZ

The screenshot: https://screenshot.googleplex.com/Kv0xzOVZLqs

BUG=734841

Review-Url: https://codereview.chromium.org/2949733002
Cr-Commit-Position: refs/heads/master@{#481660}

We should not create a HistogramTester while stopping the ServiceWorker.

Bug: 735814
Change-Id: Ie3d8197b90605162d78d219c130028e7fbb321fb
Reviewed-on: https://chromium-review.googlesource.com/544359Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481659}

Setting the openerTabId param of any tab to its own tab id via
chrome.tabs API should not be allowed. For example, if tab 1 opened
tab 2, tab 2's openerTabId value should not be allowed to be 2.

This can lead to crashes, for example, when if openerTabId equals the
tab's id and the tab is closed.

This patch prevents the aforementioned from occurring and throws a
console error to inform the developer.

Bug: 709961
Change-Id: I8513091b11088447477f4709ec605b78dafe7b0a
Reviewed-on: https://chromium-review.googlesource.com/544224
Commit-Queue: catmullings <catmullings@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481658}

BUG=706832
TEST=Remove -Wno-shift-negative-values from Chrome OS build.
TEST=Build Chrome for Chrome OS, no warnings/errors.

Change-Id: Icb4f50452d87a8b2dc680752a2bb965f31c33639
Reviewed-on: https://chromium-review.googlesource.com/544198Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481657}

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968

Review-Url: https://codereview.chromium.org/2891843002
Cr-Commit-Position: refs/heads/master@{#481656}

This is the first CL to migrate the touch event
paths to pointerevents.

BUG=625841

Review-Url: https://codereview.chromium.org/2860663006
Cr-Commit-Position: refs/heads/master@{#481655}

Bug: 689520
Change-Id: I7434993ce90e2433f1f19becf6aaefd6fa2dffec
Reviewed-on: https://chromium-review.googlesource.com/535622Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481654}

ash to Chrome, this will enables using DevTools in Window and Linux
platform.

BUG=711343

Review-Url: https://codereview.chromium.org/2887003003
Cr-Commit-Position: refs/heads/master@{#481653}

BUG=490942
R=skobes@chromium.org
TEST=WebFrameTest with RLS enabled

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I00f1d395242dec104f5a5897daec025d52dc60e8
Reviewed-on: https://chromium-review.googlesource.com/526798
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481652}

This reverts commit 927047b0. The
workaround still appears to be necessary on iPhones running iOS
10.3.2. We'll keep the workaround until we hear back from Apple
on our Radar bug report.

BUG=711367

Review-Url: https://codereview.chromium.org/2952273002
Cr-Commit-Position: refs/heads/master@{#481651}

This patch makes it possible to specify arbitrary payload to the RTree.
This in turn allows us to not store a side vector into which to index
(for cases like discardable images), and allows us to store paint
offsets for paint op buffers.

R=enne@chromium.org, danakj@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icd1176d0610a0049210510551d26556c6e23ded1
Reviewed-on: https://chromium-review.googlesource.com/544025
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481650}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a857866b281f..33a6a6490c5e

$ git log a857866b2..33a6a6490 --date=short --no-merges --format='%ad %ae %s'
2017-06-22 eakuefner [Telemetry] Move discover to common/py_utils

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Icf89801fb36cb11bc92435a1ca36a557bdc299a7
Reviewed-on: https://chromium-review.googlesource.com/544797
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481649}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/46fa3ae6..b068de4b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2950383002
Cr-Commit-Position: refs/heads/master@{#481648}

This allows the video renderer to grow its frame queue beyond the minimum value of
four frames that we use today. This provides additional headroom to avoid glitches
when the system comes under load.

Nominally this should improve the rebuffering rates seen by Chrome and YouTube by
giving less capable systems more headroom for issues during decoding. This will
be enabled by experiment so we can compare and contrast how modifying buffering
levels affects rebuffering.

Capacity size is chosen based on the time to decode a frame and the expected playout
time of the minimum buffer. In a perfect world with absolute future knowledge we want
to have a buffer of (sum(decode_duration) - sum(frame_duration)) / frame_duration. We
don't know the duration though, so the best we can do is make an estimate based
on how long it would take to play out our minimum buffer; 4 frames normally.

In order to avoid wasting memory, we do not grow capacity if it's impossible for the
decoder to keep up in real time (average decode duration > frame duration), if
there's any memory pressure, if the playback has been ongoing for < 7s, or if the
video is not in the foreground.

BUG=648710, 734813
TEST=new unittests added.

Change-Id: If6c84dd8e77fd9d043037434926e452286e50429
Reviewed-on: https://chromium-review.googlesource.com/525135
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohan Wang (OOO June 21-22) <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481647}

BrowserThread::FILE is deprecated in favor of the post_task API.

BUG=689520

Change-Id: Icb1709e8616d96a404cb92fe38d281eeb1d8c31b
Reviewed-on: https://chromium-review.googlesource.com/545082Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481646}

This was meant to be included with
https://chromium-review.googlesource.com/c/532318 but was mistakenly
excluded.

TBR=liberato@chromium.org

Change-Id: Iaa432a6f7a392389ba0007e82665f4f3ba9f9b2c
Reviewed-on: https://chromium-review.googlesource.com/544620
Commit-Queue: Chris Watkins <watk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481645}

BUG=none
TEST=none

Change-Id: Icc332b6c8df90fe79adbeb63657ebf5aef769845
Reviewed-on: https://chromium-review.googlesource.com/544435Reviewed-by: Xiaohan Wang (OOO June 21-22) <xhwang@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481644}

BUG=734873
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2948113004
Cr-Commit-Position: refs/heads/master@{#481643}

TBR=michaelbai,lpromero

Bug: 667892
Change-Id: I2b80343e844134e0cec9213fd10effed1a505056
Reviewed-on: https://chromium-review.googlesource.com/541722
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481642}

BUG=734762

Review-Url: https://codereview.chromium.org/2951183002
Cr-Commit-Position: refs/heads/master@{#481641}

In doing so, fix the error mapping in openssl_ssl_util.cc. An SSL
connection may fail due to errors in other modules as well (notably the
RSA parser lives in libcrypto). Map any unknown error to
ERR_SSL_PROTOCOL_ERROR, rather than ERR_FAILED and continue to
report the error info.

Bug: 735616
Change-Id: Icb587e66987ddd9d5445d30d456de1c029cda21a
Reviewed-on: https://chromium-review.googlesource.com/540536
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481640}

Follow-up to crrev.com/2911573002. There was a regression with a later
refactor of the ink drop code, and this fixes that.

BUG=652510

Review-Url: https://codereview.chromium.org/2939043005
Cr-Original-Commit-Position: refs/heads/master@{#480958}
Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b395bb60842273f
Review-Url: https://codereview.chromium.org/2939043005
Cr-Commit-Position: refs/heads/master@{#481639}

In general GetStorageUsage only returns usage as it is on disk, which
means it only returns committed data. But the same API is also used to
figure out which origins have localstorage data in general, so make sure
to always include all origins that haven't been committed to disk yet as
well. In the old code this worked automatically since opening
localstorage would cause an empty sqlite database to be created for that
origin.

Bug: 735040
Change-Id: Idc5410f30404c8ba6d5110416cb019d5d4c415ea
Reviewed-on: https://chromium-review.googlesource.com/541498
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481638}

Migrate call sites to TestRunner.loadModule. Very few tests need to directly
load multiple lazy modules.

BUG=667560

Review-Url: https://codereview.chromium.org/2948183002
Cr-Commit-Position: refs/heads/master@{#481637}

This change introduces the animation for creating a new tab from the
tab switcher. A previously unused code path through StackLayout has
been replaced by the logic for this animation. The primary additions
are as follows:

- New tab slides up in 300ms.
- Existing tabs in stack move to top of screen.
  - Landscape mode excludes this animation.

BUG=731294

Change-Id: Iedb542f08eb75bbb50f33eee4bf5e113d4d05c56
Reviewed-on: https://chromium-review.googlesource.com/541917
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481636}

BUG=chromedriver:1852

Review-Url: https://codereview.chromium.org/2950353003
Cr-Commit-Position: refs/heads/master@{#481635}

Per https://chromium-review.googlesource.com/c/544176/6/base%252Fobserver_list_unittest.cc#444

Bug: 735603
Change-Id: I842500d93704793c0d805667a95f3100c17c75bc
Reviewed-on: https://chromium-review.googlesource.com/544781Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481634}

https://pdfium.googlesource.com/pdfium.git/+log/9a25eded6f4a..7726a581626b

$ git log 9a25eded6..7726a5816 --date=short --no-merges --format='%ad %ae %s'
2017-06-22 palmer Add a |gGeneralPartitionAllocator| and use it in the |FX_*Alloc| wrappers.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I9324a223ffe921ec90f2507899f08463bd6c9b93
Reviewed-on: https://chromium-review.googlesource.com/544619
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481633}

The idea here is that for the Chrome Recovery component, there is 
a payload that must be run to repair the Omaha updater, when the 
updater is broken. This payload is an EXE file, which is enclosed in
a CRX container. The signing keys for this CRX must be injected in the 
code, so that we the test code can work.

Bug: 687231
Change-Id: I0b6b894da4a2ca65e2a157d88d7167a10051a860
Reviewed-on: https://chromium-review.googlesource.com/542095Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481632}