GitLab

Lack of this caused us to use a non-lazy attribute, which is much slower.
Notably access to the "WebGLRenderingContext" global in Window regressed when
it was conditionally exposed on Worker (for OffscreenCanvas).

To avoid further code duplication, this CL moves this behavior into a bit on
V8DOMConfiguration::AttributeConfiguration, and makes the bindings generator
use that for attributes both lazy and not.

Bug: 870959
Change-Id: If8d68ef452b384479202d79be9defe2ecac72993
Reviewed-on: https://chromium-review.googlesource.com/1167955Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582172}

Relanding after initial patch skipped CQ by accident
https://chromium-review.googlesource.com/c/chromium/src/+/1169536
https://chromium-review.googlesource.com/c/chromium/src/+/1169786

Specifics:
      +585,064 bytes normalized apk size
            +3 zip entries file count
       +33,268 bytes main lib size
      +375,392 bytes main dex size
InstallSize:
      +209,672 bytes APK size
 +1,726,255.68 bytes Estimated installed size
InstallBreakdown (+1,726,927.68 bytes):
        +1,553 bytes Non-compiled Android resources size
       +33,268 bytes Native code size
          +181 bytes Package metadata size
 +1,677,401.68 bytes Java code size
       +14,524 bytes Compiled Android resources size
Dex:
        +1,866 entries fields
        +2,565 entries methods
          +605 entries types
        +1,268 entries strings

TBR=fgorski@chromiun.org

Change-Id: Ie837ccdafdd545e765c43e5549e238504bfb7830
Reviewed-on: https://chromium-review.googlesource.com/1170225Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582171}

TBR=ksakamoto@chromium.org
NOTRY=true

Bug: 676612
Change-Id: Ia70720a2d00c4c7560736db33d8bbe7b418a87e5
Reviewed-on: https://chromium-review.googlesource.com/1170593Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#582170}

Bug: 873016
Change-Id: If8ee78b9e739aaad0403964948534c3305b26580
Reviewed-on: https://chromium-review.googlesource.com/1170383Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582169}

There are 2 problems with function PasswordFormManager::UpdatePendingAndGetOldKey
1.It has pretty complicated and confusing logic in updating password_element,
username_element and submit_element. Now these variables have no meaning for
filling or saving. So it doesn't make sense to update password store records
because of them (moreover username and password elements are part of the key).
So this code may be removed.

2.This function is doing 2 independent actions, update *elements and finds which
other elements needed to be updated.

Now the time to throw away garbage, since this code will be copied to
NewPasswordFormManager. This CL removes item 1 and because of 2, the function is
renamed to FindOtherCredentialsToUpdate.

Bug: 831123
Change-Id: Ided9f7fe3156fc5c7384cc4278d7d61b416a77a6
Reviewed-on: https://chromium-review.googlesource.com/1169164
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582168}

https://skia.googlesource.com/skia.git/+log/5b5d84cc1f37..93ce79dba4d9


git log 5b5d84cc1f37..93ce79dba4d9 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 mtklein@google.com drop SkTextBlob alignas(void*), align in Builder manually


Created with:
  gclient setdep -r src/third_party/skia@93ce79dba4d9

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I22642fc86fb27a559620d0ff6cf5dd47ce4ee5b3
Reviewed-on: https://chromium-review.googlesource.com/1169941Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582167}

Use CompletionOnceCallback instead of CompletionCallback, and
CancelableCompletionOnceCallback instead of CancelableCompletionCallback
in //content/browser/appcache.

I originally landed this CL at https://crrev.com/c/1163933.  However,
that was during Gerrit outage.  The "submit to CQ" button had been
replaced by a "submit" button.  After I realized that I have
inadvertently skipped the CQ, I manually reverted the change at
https://crrev.com/c/1169442 and submitted that, again, skipping the CQ.

As part of the remediation of the Gerrit outage, all the above CLs have
been erased from git history.  But before that, they were reverted in
reverse order to trigger e-mails to CL authors:
https://crrev.com/c/1169442 (revert of original CL) got reverted
(original CL relanded) at https://crrev.com/c/1169867; then
https://crrev.com/c/1163933 (original CL) got reverted at
https://crrev.com/c/1169867.

Before that, still during the outage, I uploaded
https://crrev.com/c/1169307 and enqueued it to the CQ.  This landed
after the tree was re-opened.

Then it was thought that https://crrev.com/c/1169867, the revert,
originally happened because there was a problem with the original CL, so
they reverted its revert, https://crrev.com/c/1169867, which was a
reland, at https://crrev.com/c/1169929.

Now that the dust settled, the original CL is ready to be relanded
again.  Here is goes.

TBR=kinuko@chromium.org

Bug: 807724
Change-Id: Ie128adba22500c590cb04c5f5a6deed0e4b9cf6b
Reviewed-on: https://chromium-review.googlesource.com/1170583Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582166}

After https://chromium-review.googlesource.com/c/chromium/src/+/1140674
the GetSecureVerboseText function doesn't return text anymore. This
function is used for visual display. In order to continue getting data
for accessibility purposes, duplicate the function with modifications
to continue returning relevant info.
Additionally, fix iOS omnibox accessibility to 1) use this new function
and 2) update a11y when label (generally site url) changes even if
security state does not.

Bug: 869398
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibf60a354d5f81b9a5d52aaec10d3ef5277be93bd
Reviewed-on: https://chromium-review.googlesource.com/1161913
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582165}

TBR=nednguyen@chromium.org

Bug: 859514
Change-Id: I5aa3aa1ca04eb69ddf3d9d28713df353f4f68b10
Reviewed-on: https://chromium-review.googlesource.com/1169440
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582164}

Bug: 869997
Change-Id: I867cb67d5fc3e4e4a7b3343053c6f38123c3e776
Reviewed-on: https://chromium-review.googlesource.com/1162154Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582163}

This is a reland of 7dae0f63

The original CL caused flakiness because, in production code,
WebRtcEventLogManager is torn down during Chrome shutdown, after
all threads other the the UI thread have quit. For unit tests, this
was not the case, and so the tests hit some use-after-destruction.
This was fixed by making the tests stop the non-UI threads before
tearing down WebRtcEventLogManager.

Original change's description:
> Support dynamic refresh of WebRtcEventLogCollectionAllowed policy
>
> Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed:
> 1. If the policy was disabled before, and becomes enabled,
>    subsequent calls to StartRemoteLogging() will succeed (barring
>    unrelated issues), even for peer connections created while the
>    policy was disabled.
> 2. If the policy was enabled before, and becomes disabled:
>    a. Peer connections associated with the profile reject
>       calls to StartRemoteLogging().
>    b. Active logs (associated with the profile) are stopped,
>       and those log files deleted.
>    c. Pending log files (associated with the profile) are deleted.
>    d. If a log file associated with the relevant profile is
>       currently being uploaded, the upload will be cancelled,
>       and the file deleted.
>
> Bug: 775415
> Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f
> Reviewed-on: https://chromium-review.googlesource.com/1162168
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Elad Alon <eladalon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581167}

TBR=guidou@chromium.org

Bug: 775415
Change-Id: Ie6070a8843012580c9a6c069f65c01b8d63525ff
Reviewed-on: https://chromium-review.googlesource.com/1168962
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582162}

Originally reviewed: https://chromium-review.googlesource.com/c/chromium/src/+/1168546
Reverted due to the great Gerrit tree closure of 2018:
https://chromium-review.googlesource.com/c/chromium/src/+/1169793

TBR=thakis@chromium.org

Update Linux Viz telemetry timeouts

We occassionally see telemetry_unittests_viz and telemetry_perf_unittests_viz
timeout on the FYI Linux Viz bot.

The logs point to no specific test taking longer than on a normal run. Nor of
any test hanging. The bot also reports 22/22 done on the shard, and browser
teardown, but never compiles the final success tally.

We would like to speculatively increase the timeouts here to see if that
stabilizes the bot.

TEST=telemetry_unittests_viz and telemetry_perf_unittests_viz

Bug: 871751
Change-Id: I4a3da0e45e5006673a5a3967e9e33d602d38794e
Reviewed-on: https://chromium-review.googlesource.com/1168546Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1170092Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582161}

Add tools/perf/contrib/cros_benchmarks/data/*.fetchts to .gitignore as well

Change-Id: Iac45358363d3c5e9f7399a035f7ab315006175c0
Reviewed-on: https://chromium-review.googlesource.com/1170159
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582160}

UI::KeyEvent character event constructor defaulted to
have DomCode as NONE which resulted in an empty DOM code.
This cl makes DomCode an argument in the constructor and
populates the DomCode when known.

Bug: 870337
Change-Id: I8c87bb5ba451238dfe06f88d52c6f28912d61c46
Reviewed-on: https://chromium-review.googlesource.com/1162427Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Mustafa Çamurcu <camurcu@google.com>
Cr-Commit-Position: refs/heads/master@{#582159}

This CL changes the uploaded autofilltype (i.e. vote) field to be repeating instead of a single required field per uploaded field.

Background: The autofill upload proto has a repeated "Field" attribute that has a single required autofilltype field. Autofill can send multiple votes for a given field (if a field matches the users full address as well as address line 1, for example). Prior to this CL, clients would send multiple "Field" entries (repeating all attached metadata) in the event of multiple votes. Clients also send multiple "Field" entries if there are fields having the same signature (address line 1,2, sharing the same field name/id, for example, is not uncommon). The recipient of these votes is not able to tell these 2 cases apart (multiple votes for a single field vs votes for multiple fields with the same signature).

With this CL, clients will upload exactly one "Field" entry per logical field in the form. In this way all type votes for a field will be consolsidated to a single Field entry. It will also consolidate (instead of repeating) any additional metadata send about the field into that single entry for the field.

Bug: 850606
Change-Id: I73acea17f755b6ebe37f11c9e72e02f9bf1c5484
Reviewed-on: https://chromium-review.googlesource.com/1142485
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582158}

This reuses the idea applied to the Save Card bubble to override the
title view with a custom view containing the Google Pay logo, the
separator, and the label. To make it more reusable, this CL introduces
a new views::View subclass to represent that title container.

In the new dialog, it's common to get multiline titles, which was not
properly handled by the custom implementation we had before. This CL
fixes the issue by using a GridLayout.

We also needed to replace DialogDelegateView with
BubbleDialogDelegateView as a base class of CardUnmaskPromptViews,
because the former doesn't expose the BubbleFrameView, needed to
override the title view.

Screenshots in the bug (see comment #1).

Bug: 870451
Change-Id: I3cf33ff0fff4c34657d1febd1fd2eaf422ed4ccc
Reviewed-on: https://chromium-review.googlesource.com/1170131
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582157}

This CL updates the AutofillSmallFormSupport fieldtrial config to match
the feature permutation planned to go the beta/stable for password
manager small form support.

Bug: 824834
Change-Id: Ic58ac339f5dc8004c0e6a3b7f7eedc6207db2736
Reviewed-on: https://chromium-review.googlesource.com/1169975Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582156}

Bug: 869526
Change-Id: Iacf585f600d12461dbd62171f0936e50f78d6057
Reviewed-on: https://chromium-review.googlesource.com/1170097
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582155}

We add billable service field in the GetUploadDetailRequest context. In order to do that, we pass the billable service number when we call the GetUploadDetail().

Add unittests to verify the request content.

Bug: 852904
Change-Id: I104c193ee5c94d17f5af1b873f1ee71ad391dcf0
Reviewed-on: https://chromium-review.googlesource.com/1164173
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#582154}

This CL fixes the following two unit tests:

- PersonalDataManagerTest.DeleteDisusedAdddresses_DoNothingWhenDisabled
- PersonalDataManagerTest.DeleteDisusedCreditCards_DoNothingWhenDisabled

Both tests expected that the deletion feature was disabled by default
in the context of the test; the tests now explicitly disable the
deletion feature.

This CL also ensures that the deletion related Autofill Prefs are
registered for autofill-related sync unittests. The prefs need to have
been properly registered if the deletion feature is enabled when those
tests are run.

Bug: 734151
Change-Id: Iec6585536c5e563d81d8404f717438832e65ebdb
Reviewed-on: https://chromium-review.googlesource.com/1169423
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582153}

This CL adds a call to RunAllTasksUntilIdle() between the 2 description changes
in TwoClientPrintersSyncTest.ConflictResolution. This mimics what was
done prior to https://chromium-review.googlesource.com/c/chromium/src/+/890000
and should eliminate flakiness.

Bug: 810408
Change-Id: I52b7bc3a0ac76b4b2ddb0881b60ff137ba93e2c8
Reviewed-on: https://chromium-review.googlesource.com/1165800Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582152}

Using wpt-import in Chromium f2f75f32.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22583

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org:
  external/wpt/compat
  external/wpt/fullscreen
jsbell@chromium.org:
  external/wpt/storage
kozyatinskiy@chromium.org:
  external/wpt/console

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I5abd8b46c4e13639f2caeceee1d6b7d2d18c8636
Reviewed-on: https://chromium-review.googlesource.com/1170581
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582151}

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates UrlFetcherDownloader away from URLFetcher.

Note that UrlFetcherDownloader makes use of URLFetcher's "progress
update" hook, in order to track fetch progresses. It turns out the
progress values were not being used in production at all:

UrlFetcherDownloader::OnURLFetchDownloadProgress used to instantiate
a CrxDownloader::Result object, and pass it all the way to
Component::StateDownloadingDiff::DownloadComplete and
Component::StateDownloading::DownloadComplete. There, |result|
parameter was being ignored in both methods.

Given SimpleURLLoader's lack of ability to hook to a progress update
callback at the time of doing this migration, and that the progress values
were not being used in production code anyways, this CL replaces
URLFetcher's progress upload hook by SimpleURLLoader's "response started"
hook, to indicate that the load has been triggered, and update
Component's status accordingly.

Hence, references to |CrxDownloader::Result::downloaded_bytes| and
|CrxDownloader::Result::total_bytes| were removed from CrxDownloaderTest.*
(components/update_client/crx_downloader_unittest.cc).

On the other hand, references to CrxDownloader::DownloadMetrics::downloaded_bytes
and |CrxDownloader::DownloadMetrics::total_bytes| remain unchanged
(update_client::BuildDownloadCompleteEventElement uses them).

Bug:844972,871211

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I50410b46576263aec9a9a4b648a8a627f4832702
Reviewed-on: https://chromium-review.googlesource.com/1160725Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#582150}

The new class AlwaysOnVpnManager listens to changes in the
Always-on VPN preferences, and forwards any changes to shill
to configure the network correctly.

BUG=b:72861260
BUG=873123
TEST=unit tests

Change-Id: I287f52c7326645085e98d9bd59fd94fd9a692f5e
Reviewed-on: https://chromium-review.googlesource.com/1052508
Commit-Queue: Philipp Weiß <phweiss@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582149}

Change-Id: I28c5211f2a2c3334837cba02d4a051174c84e095
Reviewed-on: https://chromium-review.googlesource.com/1170701Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582148}

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I33754c69ca14bdbcee8d5948190ce18a05c6853d
Reviewed-on: https://chromium-review.googlesource.com/1170824
Commit-Queue: Eric Noyau <noyau@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582147}

The bug has been fixed back in April - let's remove the test
expectations (the tests are passing when run 20 times on my local
machine).

Bug: 582245
Change-Id: I122d61b4d7e177a1346cd2b0aa2540c997ba504a
Reviewed-on: https://chromium-review.googlesource.com/1169944
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582146}

https://skia.googlesource.com/skia.git/+log/bc6f9c9a8c6b..5b5d84cc1f37


git log bc6f9c9a8c6b..5b5d84cc1f37 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 robertphillips@google.com Cache the command buffer objects
2018-08-10 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 468484201532..9b6a3f926032 (5 commits)
2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-09 mtklein@google.com remove SkColorSpaceXform fast path
2018-08-09 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-09 mtklein@google.com port most SkAtomic<T> to std::atomic<T>
2018-08-09 jcgregorio@google.com Fix typo in docs.


Created with:
  gclient setdep -r src/third_party/skia@5b5d84cc1f37

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I2497b2cdbd520117266ec8179b87d2bfaa1cd727
Reviewed-on: https://chromium-review.googlesource.com/1169936Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582145}

DOM GC slices in devtools performance pane broke when we renamed the events.
This CL
- reenables DOM GC slices
- reduce DOM GC to only the atomic phase, in line with V8 GC
- enable IncrementalMarking* slices by default

Bug: None
Change-Id: Ib5261ab6069d017b65b78de72315e95cc242b9d3
Reviewed-on: https://chromium-review.googlesource.com/1154863
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582144}

Since usage was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1165835
remove it from the bindings generation.

BUG=861735

Change-Id: I20159b179f208d5cd35bdf3b9be4df7fa59082c0
Reviewed-on: https://chromium-review.googlesource.com/1167467
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582143}

This CL adds will remove slots for HeapCollections that are destrcuted by mutator when Incremental Marking.
When each HeapCollection are destructed, RemoveSlot is called and destructed slots are removed from the registry in HeapCompact.

Bug: 864425
Change-Id: I09e7fcbe22cfd97fe5108249aed602de67c97066
Reviewed-on: https://chromium-review.googlesource.com/1150003
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582142}

This reverts commit 1186c664.

Reason for revert: Temporary reverting to investigate micro benchmark regression.

No-try: true
Bug: chromium:872581

Original change's description:
> [bindings,heap] Prepare PerIsolateData for holding different heap tracer
>
> - Prepare V8PerIsolateData for holding V8HeapController.
> - Harden existing tests to swap in the expected visitor/controller. This way it
>   is possible to test ScriptWrappableVisitor while already running on a different
>   embedder heap tracer.
>
> Change-Id: I169de233a4dd9886d153e7d97ca63e7caee0d809
> Bug: chromium:843903
> Reviewed-on: https://chromium-review.googlesource.com/1160656
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580892}

TBR=haraken@chromium.org,mlippautz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:843903
Change-Id: I75383f8b0fd825fdaf04202df3cc6a2ac312bb9b
Reviewed-on: https://chromium-review.googlesource.com/1170743
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582141}

Also add WPT that check
- calling updateUI works
- calling updateUI more than once throws an exception

Change-Id: I4b8e1847a09fd84a087d4f4af996ccf19c9f212b
Reviewed-on: https://chromium-review.googlesource.com/1159073
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582140}

OOF elements with inline container that were not direct descendants
of container did not have their inline container set correctly.
This caused Google SERP page to display a menu incorrectly.

Test

Bug: 867307
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iefc78785d296c87d7fc1f34abe3980c0783d6818
Reviewed-on: https://chromium-review.googlesource.com/1165953
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582139}

Define SnapshotFileCallback as a OnceCallback<> instead of a Callback<>.
While this CL does not directly touch any net::CompletionCallbacks, it
is a prerequisite for transitioning to net::CompletionOnceCallbacks in
//storage/browser/fileapi.

Bug: 807724

This exact CL has been reviewed and approved at
https://crrev.com/c/1165828.  However, due to a bug in Gerrit, I
inadvertently submitted that CL skipping the CQ.  See
https://crbug.com/872722.  Then I reverted that CL at
https://crrev.com/c/1169344.

In the aftermath of Gerrit issue, the original CL was automatically
reverted at https://crrev.com/c/1169845 to give the author (me) a
heads up that it needs to be relanded.  Before that, of course, the
revert was automatically reverted (that is, the original CL relanded)
at https://crrev.com/c/1169868 for the same reason.

Now that the outage is over, I can reland this CL properly,
using the CQ.  Original reviewer is TBR'd.

TBR=tzik@chromium.org

Change-Id: I1a6fdfb53e0d38e8fd1d6618a4a79f52dcf4739b
Reviewed-on: https://chromium-review.googlesource.com/1169308
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582138}

Use CompletionOnceCallback instead of CompletionCallback everywhere in
//net, except for TestCompletionCallback that still has consumers
outside //net.

Bug: 807724
Change-Id: Iec756bd8cc40acbeecacfe0e5c3eee949325afb6
Reviewed-on: https://chromium-review.googlesource.com/1167462
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582137}

The NewAccount actions and histograms are split into 3 subcases:
- NewAccountPreDice: used on desktop pre-Dice
- NewAccountNoExistingAccount: adding an account when Chrome has no account
- NewAccountExistingAccount: adding an account when Chrome already has account(s).

Bug: 859142, 855754
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifcf077341b00c70d07fcb8d2cf863384bb9b985e
Reviewed-on: https://chromium-review.googlesource.com/1133388
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582136}

GMBVFPool counts as unsupported those VideoFrames backed by DmaBufs,
because it only checks HasTextures().  This CL adds a new method
VideoFrame::HasDmaBufs() and uses it to avoid logging those VFrames.

V4L2* creates these VideoFrames calling WrapExternalDmabufs().

Bug: 864145
Change-Id: I340f1f8c2cbbb53de0bed13cc69f868c63b097bd
Reviewed-on: https://chromium-review.googlesource.com/1169823
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582135}

To ensure that all entries in rendering_desktop.json and
rendering_mobile.json have consistently named wprgo files, rename
existing recordings. In cases where the .wprgo.sha1 file is not used
anywhere else, simply rename to rendering_desktop_*.wprgo.sha1 and make
copy for rendering_mobile if needed (or only rendering_mobile). If the .wprgo.sha1
file is used elsewhere (ex.tough_path_rendering_cases), create a new copy for
rendering_desktop and rendering_mobile. Numbering is kept consistent between
rendering_mobile and rendering_desktop. Ex. rendering_desktop_002.wprgo.sha1 and
rendering_mobile_002.wprgo.sha1 both contain what was previously in
tough_filters_cases_002.wprgo.sha1

Bug: 872551
Change-Id: Iaf542df5fed27d6ed3254e44461ec0e4af93e891
Reviewed-on: https://chromium-review.googlesource.com/1169424Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#582134}

If the storage partitions are not fully initialized, the delegate factory
will enter an infinite loop when trying to create an instance of
BackgroundFetchDelegateImpl.

This changes moves the service initialization logic from the constructor
to a lazy accessor function, which is guaranteed to be called after the IO
thread is up and running. This means all Storage Partitions will have
been loaded.

This behavior can be triggered when creating a
BackgroundFetchDelegateImpl in incognito mode.

Bug: 766082
Change-Id: I320e146634792e16a61514620639ece38b022349
Reviewed-on: https://chromium-review.googlesource.com/1167842
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582133}