- 11 Jan, 2021 40 commits
-
-
Evan Stade authored
This componentizes SiteEngagementService and dependent code, which is needed for AppBannerManager. Bug: 1147274 Change-Id: Ib740aac1f2e353d84722c53ec50f9e33ae193e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613397 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#842171}
-
Thomas Tellier authored
Bug: 1003885 Change-Id: Iaaf0d34234e7b922e5e68be4e8c35d19aa4deb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622174 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#842170}
-
Joon Ahn authored
Bug: 1125150 Test: browser_test --gtest_filter=Diagnostics* Change-Id: I3787e7a67259ebafadd78a42957de36aa5ce7186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606192 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842169}
-
dpapad authored
The API was previously callback-based, instead of Promise-based. Callback-based APIs are more tedious to use. As a concrete example, the PDFExtensionJSTest.ParamsParser tests were incorrectly not waiting for any of the callbacks to execute before declaring the test successful. In the process also - Changed Navigator#navigate() to return a Promise, instead of firing a 'navigate-for-testing' event. - Fixed incorrect type annotation for OpenPdfParams#viewPosition. Bug: None Change-Id: Ib14b6499d3c661bb62c21c1836324ceecf1494ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618219 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842168}
-
Clark DuVall authored
I noticed most of the exceptions when loading the vr module have logs from SplitCompatAppComponentFactory, which means the chrome ClassLoader is messed up in the ClassLoader cache. When the vr module is loaded, it uses the wrong chrome ClassLoader as the vr ClassLoader parent, which ends up causing a ClassCastException. This CL detects that case and creates a fresh ClassLoader with the correct parent. I tested this locally by faking the situation where the chrome ClassLoader is incorrect, and this loads the vr module and other DFMs which depend on chrome (e.g. image_editor) without crashing. Bug: 1146745 Change-Id: I5960fa2817604a13b90d80b10517b3b416c46013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620939Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842167}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610365490-2d34930da692ba60039f1162f9ee976fe2d1462a.profdata to chrome-linux-master-1610387594-52fbb832db018eba5e89364d93d0a6bfe8f2e511.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a55de7957ffd03a68a353cf51670b55597ace87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622792Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842166}
-
Elaine Chien authored
Developers will specify whether their features have beta approval. ChromeBeta will only showcase features on the Beta channel if they have Beta approval Note: We are renaming ChromeLabs to ChromeBeta Bug: 1145666 Change-Id: Iee576ecf0a52d075559b605cfecae5733d539425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613557 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#842165}
-
David Tseng authored
R=akihiroota@chromium.org Bug: none Test: existing editing tests for word feedback. Added new unit-test-like suite for intent_handler character and line speech. Change-Id: If32425cd35ea6504841fef8c7d3eb6245b609c3e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618558 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#842164}
-
Regan Hsu authored
Using the gn args in the reported failing build link and repeating the test 100 times results in no errors. Fixed: 1121139 Change-Id: Idce10ed5f31d60fcc3ecacf6dd49a2c6a624321b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614850Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842163}
-
Karandeep Bhatia authored
This manifest key was never completely implemented and there are no plans to do so as well. Remove the key and associated code. TODO: Also remove this key from https://developer.chrome.com/docs/extensions/mv2/manifest/. BUG=135628, 1164954 Change-Id: Ia6b11e04f68ca80ea4c91fe1d7a67266f14743b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621972Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#842162}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2779617a..271bd524 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id563e934501fe9b95c0f6d62f0014363e0c89fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622573Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842161}
-
Peter Kasting authored
Bug: 1159562 Change-Id: Iab73f6f6cdacb1bf8cddd69c17e6117511d3acc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618980 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#842160}
-
Alexander Timin authored
EQT calculation was removed and this perftest is a dead code now. R=shaseley@chromium.org Change-Id: I243c0785f2befea9eee399f1264270b7628071d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542162 Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#842159}
-
Tommy Li authored
Currently, prepopulated engines don't outrank other autogenerated engines, and that was a contributory factory in the bug linked below that clobbered users' default search engines on Canary. This CL fixes that problem, and adds a test that fails before this CL, and passes afterwards. (To prevent this condition from regressing.) After this CL there will be more follow-on work to make sure we never remove prepopulated engines during any deduplication. This CL also incidentally improves some naming consistency among our unit tests. Bug: 1164024 Change-Id: I6f90668abad02ae53adfbd0c8c739e07247a4a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617865 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#842158}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c600e47812c8..49d291065fee 2021-01-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 29d2d6a2 to 193bb22c (106 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Id622b05b4ddf25a7b61d711314d8d8226c1b2916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622493Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842157}
-
Gauthier Ambard authored
This CL adds support for passing PreviewProvider to the WebState delegate. Bug: 1140387 Change-Id: I4c4a2665e26875be9d262d884aa96d3cef205af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587027 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#842156}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eddc7d0df5d1..fff8e7632e28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I884eec40b1fdd915c39415326c2fdebaf96bf130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842155}
-
Michael Crouse authored
Bug: 1165080,1165079 Change-Id: Iedec5e75af5ab69bcaf444af96bef4e654b70ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622420 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842154}
-
Chris Cunningham authored
API and motivations described here: https://github.com/WICG/web-codecs/issues/98 Spec PR here: https://github.com/WICG/web-codecs/pull/120 Bug: 1141707 Test: new layout tests Change-Id: I3a0f3cbc2bb64a86dcefdc454d6b03e72d3f36bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622421Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#842153}
-
Mustafa Emre Acer authored
This CL excludes disables HTTPS upgrades for IP addresses and adds tests for non-unique hostnames. Bug: 1141691 Change-Id: Ib697d254abb32c375e0eda40b0f22fe521175f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616978 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#842152}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/009667d5f97c..6a59d064a975 2021-01-11 srisser@google.com Add VK_EXT_host_query_reset If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia8b9b0f5be439dab27f780f1e070f8a0ac89beb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622496Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842151}
-
David Bienvenu authored
This test is very flaky, I believe because it relies on global state, instead of explicitly setting up the LabInfo used to populate the labs button. For example, if there were no current labs in SetUpLabs, the test would fail. So this CL explicitly sets up the LabInfo for the labs button. It's a bit messy that it requires a change to the production code, but I didn't see any other way of plumbing that information through to the model. Bug: 956719 Change-Id: I8078c211e37fc1eeff50a44043eca760cdc4850a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618656Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842150}
-
Hiroshige Hayashizaki authored
According to the spec after https://github.com/WICG/import-maps/pull/242. Bug: 848607 Change-Id: I21e2d494c75ddf9187d2a8d8b63bc59bccd9beb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618680Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#842149}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37e61b19a2f6..d0ccd38b2dfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harrisonsean@google.com,yiyix@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harrisonsean@google.com,yiyix@google.com Change-Id: Ia5dae18bdc6c1cfcee08b64f23dc516c93ec41b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842148}
-
Yulun Wu authored
Bug: 1139478 Change-Id: I33044e77fde2cc33eeee4395c4129788449aca36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618839Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842147}
-
Tanmoy Mollik authored
Method OnUnconsentedPrimaryAccountChanged is deprecated. So this cl changes these calls to OnPrimaryAccountChanged(). Bug: 1158855 Change-Id: I9c2e83df1149747b284358888b6b54f9d8253c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622374Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842146}
-
Caroline Rising authored
Update title and description for read later flag on Desktop to be clearer for use in Chrome Labs. Also update flag title for read later flag on Android. Bug: 1109316 Change-Id: Ibefd60b80f3338df0985e6f60b65f2b2a19eace1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574657 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842145}
-
Ryan Sturm authored
This CL adds a few extra checks (cache, post, link clicked) to prevent a few edge cases that may come up based on search provider implementation. Bug: 1164773 Change-Id: I1b740e46b4d1fac5e49f3e50aa4f0c85f54bcf51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620402 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#842144}
-
Austin Eng authored
This is the correct behavior instead of rejecting the Promise. Bug: 852089 Change-Id: I847ff4103084be35696705af8bb06bb1ecb701a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617499Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#842143}
-
Claude van der Merwe authored
Bug: 1162307 Change-Id: Ia52ba4e2866832c22243b1b001b4cfe88921f440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616355Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#842142}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/12607ec3c98d..43761d2e076c 2021-01-11 yuhengh@chromium.org Reland "Add ability to modify trace config in a story" 2021-01-11 dproy@chromium.org [tracing] Fix DOCUMENTATION_URLS reserved name in html If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1006795,chromium:1164464 Tbr: sadrul@google.com Change-Id: I488034d0f27a489502b580cfc85ef3847dd83f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622500Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842141}
-
Xianzhu Wang authored
This reverts commit 49dd6b58. Reason for revert: The scale of the devtool override frame size seems incorrect, causing crbug.com/1164610. Original change's description: > Cleanup for LayoutView overflow clips > > 1. Move the code checking requirement of overflow clip for printing > from PaintPropertyTreeBuilder into LocalFrame::ClipsContent(). > > 2. Combine LocalFrameView::ClipPaintRect() into > LayoutView::ViewRect(), so that all code paths calling ViewRect() > (e.g. LayoutView::OverflowClipRect()) can be dev tool viewport > overriding aware. This means that the overriding viewport is > reflected in the paint property tree, and > CompositedLayerMapping::RecomputeInterestRect() no longer needs to > apply the viewport clip separately. > > Change-Id: Ib743a891e4d4fc0749ff799a04ed0f09757e9f5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613388 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841701} Bug: 1164610 TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18249c79339935b381ae3a05984d5f139d5194a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622514Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#842140}
-
Siyu An authored
Feature is 100% in Stable. Remove branch logic in Bling. Desktop and Clank will follow. Bug: 1082013 Change-Id: If2523c34dc2bf1acd1adb0b69910a093d5db2e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601042Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#842139}
-
Sergei Glazunov authored
Currently, we can't use BackupRefPtr in renderers anyway due to severe performance regressions. Therefore, add an option to disable the allocator support for the per-allocation reference count slot and save memory. In order to do so, as soon as we can detect whether the current process is a renderer, create a new partition with the desired set of flags and replace the "temporary" one in the allocator shim. Previously made allocations will keep using the old partition. Bug: 1073933 Change-Id: Icb0d9359953c3b9b0cdc0c4ced113b4eca7a5c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449981Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sergei Glazunov <glazunov@google.com> Cr-Commit-Position: refs/heads/master@{#842138}
-
Alexander Timin authored
Together with removing the frontend code in crrev.com/c/2617780, remove the code emitting the old-style flow events for devtools and remove the category. R=caseq@chromium.org,eseckler@chromium.org CC=yangguo@chromium.org BUG=1164298 Change-Id: I929c09d8aef5fb07ff64b0aa5960126111f433ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617939Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842137}
-
Nico Weber authored
Bug: 1149587 Change-Id: I1765b8eed3508ad95729d440a8dfc7e608dfd92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621673 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#842136}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610365490-38da34638c6d32dc406b66a62fb936835a861238.profdata to chrome-win32-master-1610376073-6f28b769fbc009549335371d81a980da57e0e846.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I76fc43021ba21e2b0c1b41d9e0ea8f6d794b7b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842135}
-
Azeem Arshad authored
This CL adds a GetEIDQRCode method in Euicc interface that returns a qrcode image representing the EID of the Euicc. Bug: 1093185 Change-Id: I6dabd595dfb9fd0ba7a8841aed0fe272e62152f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611992Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842134}
-
Jeffrey Young authored
AmbientPhotoController and AmbientPhotoCache are only necessary when a user is logged in and ambient mode is enabled. Construct them at that time, and destruct them if ambient mode is disabled. Schedule fetching backup images when AmbientPhotoController is constructed, rather than in OnFirstSessionStarted. BUG=b:176094707 TEST=ash_unittests --gtest_filter="AmbientControllerTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Id87bb16e6d4cc14074dd9bdb352fb5795d0f8915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605744 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842133}
-
Jeroen Dhollander authored
This is a reland of c307ddb3 This was reverted because its parent CL was temporary reverted. Nothing is different in this reland. Original change's description: > Move |AudioInputHost| to |AssistantManagerServiceImpl| > > The main goal is to ensure we can create |AudioInputHost| independently > of |PlatformApiImpl|. > > This CL also makes |AudioInputHost| virtual so it can be faked during > the unittests of |AssistantManagerServiceImpl|. > > Bug: b/171748795 > Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Ic41ff343b28dae801b0c5f4c8c6417267270d8a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610047 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841226} Bug: b/171748795 Change-Id: Id0f9054a9876f07ec9b0c8d3fac5babc018ef1e9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618769Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842132}
-