GitLab

This reverts commit 96256bfe, returning
the webview build to using Chrome's copy of ICU.

BUG=409851
NOTRY=true

Review URL: https://codereview.chromium.org/661983002

Cr-Commit-Position: refs/heads/master@{#300092}

Basic functionality for android's server and tests. Isolated from GCD code.

New button in the debugging activity causes equivalent result with previous one (tunnels a real DevTools socket to a fake one) but uses android service for that (2 ways of tasting may help in bug triaging). It lets test service life cycle and UI (foreground notification).

BUG=383418
TEST=DevToolsBridgeServerTest, new button in debugging activity for manual testing

Review URL: https://codereview.chromium.org/540383002

Cr-Commit-Position: refs/heads/master@{#300091}

BUG=355073

Review URL: https://codereview.chromium.org/653393002

Cr-Commit-Position: refs/heads/master@{#300090}

Reason for revert:
regresses BSS size (doubles it).

also, no try for a roll??

Original issue's description:
> Roll WebRTC 7390:7447.
>
> NOTRY=true
> BUG=N/A
>
> Committed: https://crrev.com/45b1f8d30351657be732e73cf1975f4a8a06fae6
> Cr-Commit-Position: refs/heads/master@{#299695}

TBR=mikhal@chromium.org,hellner@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=N/A

Review URL: https://codereview.chromium.org/641203005

Cr-Commit-Position: refs/heads/master@{#300089}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6693a48..2e49896

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/661043002

Cr-Commit-Position: refs/heads/master@{#300088}

Up until now, HttpResponseHeaders::IsKeepAlive() only looked at the
first value of the Connection header. Since for a WebSocket response a
header like

Connection: Upgrade, close

is valid we should check other values past the first value.

BUG=371759
TEST=net_unittests

Review URL: https://codereview.chromium.org/640213002

Cr-Commit-Position: refs/heads/master@{#300087}

BUG=423025

Review URL: https://codereview.chromium.org/656803002

Cr-Commit-Position: refs/heads/master@{#300086}

BUG=417463

Review URL: https://codereview.chromium.org/652103003

Cr-Commit-Position: refs/heads/master@{#300085}

To help guide development and track performance improvements in specific areas this new metric will compile the top-10 slowest tasks across all the pages in a page-set.

Part of the scheduling effort is to move long-running tasks into 'idle' periods or refactor them to make them more nibble-able. Knowing which tasks we need to concentrate on is the first step in this.

It is hoped that this code will also be built-on to create a metric to find out which long-running tasks most frequently block high priority tasks (e.g. Does GC often block user input being processed?) so we can move them out of the way.

BUG=421434

Review URL: https://codereview.chromium.org/636203002

Cr-Commit-Position: refs/heads/master@{#300084}

This writes CSV, with each line containing one value + metadata.
Essentially, this is a de-normalized output of the test results which
makes it easier to use for some kinds of analysis, and particularly
with "pivot tables" in common spreadsheet programs.

Use with: --output-format=csv-pivot-table

BUG=

Review URL: https://codereview.chromium.org/631213003

Cr-Commit-Position: refs/heads/master@{#300083}

The name is misleading, as e.g. a request for a top-level resource in a
new window won't have the flag set, even if it was triggered by a user
gesture

The flag is exposed via the webvia API, so we can't just rip it out.

BUG=420649
R=mkosiba@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/650043002

Cr-Commit-Position: refs/heads/master@{#300082}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d1c56f0..6693a48

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/660133006

Cr-Commit-Position: refs/heads/master@{#300081}

Install libstdc++:amd64 to be used by 64bit goma inside 32bit env.

BUG=https://code.google.com/p/chromium/issues/detail?id=409482

Review URL: https://codereview.chromium.org/647193004

Cr-Commit-Position: refs/heads/master@{#300080}

LayoutTest is here: https://codereview.chromium.org/663723002

BUG=424464
TEST=http/tests/serviceworker/registration.html

Review URL: https://codereview.chromium.org/660973002

Cr-Commit-Position: refs/heads/master@{#300079}

Saw failing media_unittests. Introduced by me in
https://codereview.chromium.org/649023002/
(surprised it landed in the first place :/  )

BUG=

Review URL: https://codereview.chromium.org/660003002

Cr-Commit-Position: refs/heads/master@{#300078}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a32005..d1c56f0

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/658253003

Cr-Commit-Position: refs/heads/master@{#300077}

Cr-Commit-Position: refs/heads/master@{#300076}

This CL is to build base/ for nacl_helper_nonsfi.
The library is similar to base_nacl, but slightly different:
- For rand_util, rand_util_posix should be used, instead of
  rand_util_nacl, because nacl_helper_nonsfi will be running under
  Linux directly.
- MessageLoopForIO should be based on MessagePumpLibevent rather than
  MessagePumpDefault, to support IPC.
- GetKnownDeadTerminationStatus, GetTerminationStatus,
  UnixDomainSocket::SendMsg and RecvMsg are included, as these are used
  to implement nacl_helper_nonsfi binary.
- GLIB is not supported. It is unnecessary for nacl_helper_nonsfi.
Note that this library is not used yet from any binary, because this CL
is just a preparation, but the library is built actually.

BUG=358465
TEST=Ran trybot. Implement nacl_helper_nonsfi on top of this CL, and made sure
it is working.

Review URL: https://codereview.chromium.org/659513004

Cr-Commit-Position: refs/heads/master@{#300075}

BUG=
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/660993002

Cr-Commit-Position: refs/heads/master@{#300074}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e33da08..4a32005

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/665563003

Cr-Commit-Position: refs/heads/master@{#300073}

This CL fixes an issue where AppListSyncableService would free the model
before the ModelPrefUpdater that was observing it.

BUG=423124

Review URL: https://codereview.chromium.org/661913002

Cr-Commit-Position: refs/heads/master@{#300072}

Before they were part of the interface, which should be clean and simple.
Moreover, this CL lets pass the list of changes via ProvidedFileSystemObserver
which will be required soon in the Service class.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=248427

Review URL: https://codereview.chromium.org/663713002

Cr-Commit-Position: refs/heads/master@{#300071}

Adds support for colored frames for chrome apps which use the
chrome.app.window.create API to create windows.

BUG=371642

Review URL: https://codereview.chromium.org/664443002

Cr-Commit-Position: refs/heads/master@{#300070}

The following Blink CL will make 'windows-1252' the canonical name
for 'ISO-8859-1', 'US-ASCII' and 'windows-1252'. All three will be
treated synonymously per the WHATWG Encoding spec.

   https://codereview.chromium.org/655083002/

We have some test results with 'ISO-8859-1'. Change them to use
windows-1252 and disable them before landing the above Blink CL.

For PrefsTabHelperBrowserTest.WebPrefs, I made the test more robust
by setting 'windows-1251' (not '1252') as the default charset in
the Test Preference file.

Once the Blink CL is landed and rolled, we'll re-enable the disabled
tests as a part of the following Cr CL:
  https://codereview.chromium.org/649413002/ ,
which rolls ICU 52 to the latest revision (the other side of
ISO-8859-1 to windows-1252 transition).

TBR=jochen,rdsmith,mnissler,jsbell
BUG=412053
TEST=browser_tests the following tests (before and after the Blink roll)
    BrowserEncodingTest.TestEncodingAutoDetect
    BrowserEncodingTest.TestOverrideEncoding
    EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping
    SavePageBrowserTest.FileNameFromPageTitle
    SavePageBrowserTest.SaveCompleteHTML
    PrefsTabHelperBrowserTest.WebPrefs

Review URL: https://codereview.chromium.org/643993004

Cr-Commit-Position: refs/heads/master@{#300069}

This CL refactors the logic to fit all the folder
dropping logic in CalculateFolderDropTarget().

BUG=419642

Review URL: https://codereview.chromium.org/614213004

Cr-Commit-Position: refs/heads/master@{#300068}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/95ffa59..e33da08

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/648293008

Cr-Commit-Position: refs/heads/master@{#300067}

Sometimes, [NSColor controlColor] returns "white". With no alpha. This
causes a failed CHECK().

This should be covered by NativeThemeMacTest.SystemColorsExist, but
AppKit doesn't cooperate there. In native_theme_unittests,
native_theme->GetSystemColor(kColorId_UnfocusedBorderColor) always gives
0xffe8e8e8. However, in the same Chrome process [NSColor controlColor]
can return both 0x??ffffff and 0xffe8e8e8 when opening up the
toolkit-views task manager.

This is probably an AppKit bug, but we shouldn't trust AppKit to give us
alpha channels anyway. So, this CL adds handling for single-component
system colors.

BUG=424040, 379086

Review URL: https://codereview.chromium.org/658033002

Cr-Commit-Position: refs/heads/master@{#300066}

TEST=./build_tools/build_sdk.py --tar
TEST=trybot
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3851

Review URL: https://codereview.chromium.org/619763005

Cr-Commit-Position: refs/heads/master@{#300065}

We don't need to wrap the data with WebThreadSafeData here. Just use a
pair of const char* and size_t.

This is Chromium side CL

Blink side CL: https://codereview.chromium.org/611923002/

R=yhirano,jam
BUG=417093

Review URL: https://codereview.chromium.org/610333002

Cr-Commit-Position: refs/heads/master@{#300064}

Platform-specific implementations now have their own derived classes.
This allows some cleanup of platform-specific hackery in clipboard.h,
and paves the way for adding a fake clipboard implementation in the
future for testing.

BUG=319285

Review URL: https://codereview.chromium.org/658963003

Cr-Commit-Position: refs/heads/master@{#300063}

This patch passes proper data instead of fake one to Notify(). Also, child
changes are now passed as a scoped_ptr and a reference to avoid unnecessary
copies.

Note, that end to end browser tests will come once notifications are wired to
chrome.fileManagerPrivate.

TEST=Tested manually.
BUG=248427

Review URL: https://codereview.chromium.org/656393002

Cr-Commit-Position: refs/heads/master@{#300062}

BUG=N/A
TEST=N/A

Review URL: https://codereview.chromium.org/654823002

Cr-Commit-Position: refs/heads/master@{#300061}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/660093004

Cr-Commit-Position: refs/heads/master@{#300060}

* pass --site-per-process and --gtest_filter as separate arguments (this was breaking the windows bot)
* use wildcards for better readability
* fix syntax by removing the extra "-" from the list of failing tests
* remove a test that we've recently fixed from the list

BUG=417518

Review URL: https://codereview.chromium.org/660133003

Cr-Commit-Position: refs/heads/master@{#300059}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/513e6f3..95ffa59

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/663703002

Cr-Commit-Position: refs/heads/master@{#300058}

BUG=414675

Review URL: https://codereview.chromium.org/660093003

Cr-Commit-Position: refs/heads/master@{#300057}

But.. first make some tests fail.

DesktopNativeWidgetNoPaintAfterCloseTest currently passes but it
shouldn't. WidgetTests DesktopNativeWidgetNoPaintAfterHideTest and
TestWindowVisibilityAfterHide were also passing, but
NativeWidgetMac::Hide() is a no-op, so that shouldn't be the case.

This CL (first) makes them all fail on Mac. To do this,
BridgedNativeWidget needs to call Widget::OnNativeWidgetPaint() rather
than painting the RootView directly. And TestWindowVisibilityAfterHide
must show the widget.

DesktopNativeWidgetNoPaintAfterCloseTest was then fixed by skipping a
paint when the window is not visible, as toolkit-views expects. However,
Cocoa paints the window before changing -[NSWindow isVisible]. To fix,
intercept -[NSWindow orderWindow:relativeTo:]. We need to do this anyway
to send Widget::OnNativeWidgetVisibilityChanged(), but that's left for a
follow-up.

BUG=378134

Review URL: https://codereview.chromium.org/654393002

Cr-Commit-Position: refs/heads/master@{#300056}

Some of the forward declarations and #includes are not necessary.
Hence, removing them.

Review URL: https://codereview.chromium.org/655433004

Cr-Commit-Position: refs/heads/master@{#300055}

Trivial file renaming...

BUG=359244
TEST=content_shell && content_unittests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/642813006

Cr-Commit-Position: refs/heads/master@{#300054}

Review URL: https://codereview.chromium.org/645043003

Cr-Commit-Position: refs/heads/master@{#300053}