- 18 Feb, 2020 40 commits
-
-
nancy authored
Also modify ChromeLauncherController::LaunchApp to use AppService to launch apps, and remove LaunchApp function from LauncherControllerHelper. BUG=1016159 Change-Id: Idf863b32fa703c2f03e79042525bec14cc15fec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056892Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742382}
-
Hesen Zhang authored
- Add a debug option flag to show update notification right away. - Also enable helpful/unhelpful buttons. Change-Id: I878e337e9a2bf8aed1859553ab9a2fc29ec4de2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049044Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742381}
-
Kurt Horimoto authored
Bug: 1030357 Change-Id: I1debca25f15b7b3ee4e8f8e51da7c4f43a949006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040920 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#742380}
-
Nicolas Arciniega authored
This change moves out ConfiguredProxyResolutionService::Request into its own file and renames it to ProxyResolutionRequest. This will be necessary later on when we create a second version of the ConfiguredProxyResolutionService under a base ProxyResolutionService that relies completely on system APIs. In that second version, we will also want to track the status of a proxy resolution request. This change is intended to introduce zero functional changes. It is a pure refactor change. Bug: 1032820 Change-Id: I1f6192dc13289bb703ad2ea5ed3065e67c928fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045147 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#742379}
-
Ben Joyce authored
These proguard rules match the old android support libraries. They should match the new AndroidX libraries. I think we could get a bug similar to crbug/1052855 without this change. Per yfriedman suggestion, keep both rules for now, then remove later. Bug: 896775 Change-Id: I9b38e20683e1fcf78224acef732c9342717b73d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063255 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#742378}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3d47a2e..0b2347be Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I501feaadaf548149ac6059e4b1c48d2f165884be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062032Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742377}
-
Charlene Yan authored
Bug: 1047750 Change-Id: Id526464fe3dc5062105e969ac0885b62549eaa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062904 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#742376}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/18c617989b21..1282babe6621 git log 18c617989b21..1282babe6621 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 daniel.l@hpcnt.com Fix tests in RTCMetalVideoView. 2020-02-18 trevor.axiom@gmail.com Reland "Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."""" 2020-02-18 minyue@webrtc.org Pass absolute capture time from WebRtcVoiceEngine to ACM. 2020-02-18 danilchap@webrtc.org Allow sending DependencyDescriptor rtp header extension in call 2020-02-18 danilchap@webrtc.org Replace DataSize and DataRate factories with newer versions 2020-02-18 saza@webrtc.org Add aecdump experiment strings for injected custom processors 2020-02-18 fabianbergmark@google.com Support passing the ADM to the ADMWrapper. 2020-02-18 handellm@webrtc.org Ship GenericDescriptor00 by default. 2020-02-18 philipel@webrtc.org Save custom parameters provided by the SdpVideoFormat when requesting an encoder switch. 2020-02-18 danilchap@webrtc.org in call RtpVideoSenderTests rely on simulated time 2020-02-18 eshr@google.com Remove ResourceAdaptationModule::OnMaybeEncodeFrame 2020-02-18 oseg@google.com Use absl::c_any_of instead of a manual for-loop to finding an active encoding 2020-02-18 asapersson@webrtc.org StreamSynchronizationTest: rename and make some variables const. 2020-02-17 phoglund@google.com Reland "Whitespace change to kick bots" Created with: gclient setdep -r src/third_party/webrtc@1282babe6621 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452,chromium:396091 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I81fead694a0daaa580a2379adfdb61af5e91f67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742375}
-
Robert Liao authored
This reverts commit b6fe8aaa. Original change's description: > Revert "Reland "Remove Deprecated ScopedBstr to BSTR Implicit Conversion Operator"" > > This reverts commit abb98639. > > Reason for revert: Breaks on Chrome Branded Builds > https://ci.chromium.org/p/chrome/builders/ci/win64-builder-perf/155240 > > [5963/14947] CXX obj/chrome/browser/browser/browser_dm_token_storage_win.obj > FAILED: obj/chrome/browser/browser/browser_dm_token_storage_win.obj > c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) > ../../chrome/browser/policy/browser_dm_token_storage_win.cc(89,39): error: no viable conversion from 'base::win::ScopedBstr' to 'BSTR' (aka 'wchar_t *') > hr = app_bundle->createInstalledApp(base::win::ScopedBstr(app_guid)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > gen\google_update/google_update_idl.h(3500,29): note: passing argument to parameter 'app_id' here > /* [in] */ BSTR app_id) = 0; > ^ > > Original change's description: > > Reland "Remove Deprecated ScopedBstr to BSTR Implicit Conversion Operator" > > > > This is a reland of afb89420 > > > > Original change's description: > > > Remove Deprecated ScopedBstr to BSTR Implicit Conversion Operator > > > > > > BUG=1034666 > > > > > > Change-Id: I678af5925603de6f983e3d12da6832c0661f293c > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042194 > > > Auto-Submit: Robert Liao <robliao@chromium.org> > > > Commit-Queue: Will Harris <wfh@chromium.org> > > > Reviewed-by: Will Harris <wfh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#739275} > > > > Relanding http://crbug.com/739275 > > > > Bug: 1034666 > > TBR: wfh@chromium.org > > Change-Id: I62a2d46993f107b18f758fec01af1828c48a3656 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043859 > > Reviewed-by: Robert Liao <robliao@chromium.org> > > Commit-Queue: Robert Liao <robliao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#739534} > > TBR=robliao@chromium.org,wfh@chromium.org > > Change-Id: Ie50ca4b64bdd258637c5ba93c484196187624d67 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1034666 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044767 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739569} TBR=robliao@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034666 Change-Id: I4691946e642b973e55562ceabb33189defa8b688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049030 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742374}
-
Christopher Thompson authored
SimplifyHttpsIndicator has been default enabled for a while, and the flag expired in M-76. This removes the feature and flag, and the logic for the disabled path. This also simplifies how the display and accessibility text are generated now that there are fewer edge cases to handle, removing the SecureChipText struct in favor of separating the logic of GetSecureDisplayText() and GetSecureAccessibilityText(). Accessibility text now defaults to the display text, except for specific hard-coded exceptions (i.e., SECURE and EV_SECURE states won't have display text, so GetSecureAccessibilityText() specifies their accessibility text). Change-Id: Ifd8002f0e8383c25ff905c0c94c90f499acaa654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057730 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#742373}
-
Kurt Horimoto authored
When VoiceOver is enabled, triggering the voice search UI begins reading the accessibility elements on the screen. There is not a good way to check when VoiceOver has stopped speaking, so voice search cannot simply wait for VoiceOver to stop before recording. Moreover, removing the accessibility features for the other views in the voice search UI is also not a solution, as VoiceOver users would be stuck on the voice search screen. The long-term solution to this issue is to update the voice search feature to ignore audio that is emitted from the device, but this fix is not yet built. Instead, this CL disables voice search while VoiceOver is enabled. Visually-impaired users can still use other iOS accessibility features to dictate queries into the omnibox, so this does not negatively affect the ability of these users to search. VoiceSearchAvailability was created to implement this feature. It is an observable helper object that uses VoiceOver notifications and VoiceSearchProvider::IsVoiceSearchEnabled() to determine whether voice search should be enabled. The NTP and keyboard accessory view were updated to use VoiceSearchAvailability to optionally disable the microphone button. Bug: 998524 Change-Id: I8789a9a05542bdc659f8d98d0f1c90de3dc3ecb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005903 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742372}
-
Thomas Lukaszewicz authored
Removed the use of NativeTheme::GetInstanceForNativeUI() from SendTabToSelfBubbleDeviceButton. This change allows the button icon to track native theme changes through it's Widget's NativeTheme. Bug: None Change-Id: I45bb71e50c9158360534a59593be0079d88be9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044058 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742371}
-
Matt Mueller authored
Bug: 846909, 1045732 Change-Id: Ia7a8251effb8bb27c52b378bbc91c301ace1fb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042437Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#742370}
-
Lijin Shen authored
1. create one_off_colors.xml exclusively for one-off colors 2. update presubmit warning description Bug: 775198 Change-Id: I9129c32ea58e4d35543d7f6cc152252048c1a685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057448 Commit-Queue: Lijin Shen <lazzzis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#742369}
-
tby authored
We're ready to launch this, so let's enable the flag. Bug: 959679 Change-Id: I265b4969ff65897dc634bda3a95cae2705be5f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056193Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Adrienne Walker authored
The unit test is not testing anything (it both early outs on copying files and also uses the same source and destination directory when checking if files have been copied). This is also very deprecated. Rather than keeping this working[*] and updating the test to not be broken, instead remove this functionality that is incredibly deprecated. A followup will be to remove the functions in IndexedDBContext that this is the only user of. [*] alternate approach: https://chromium-review.googlesource.com/c/chromium/src/+/2020533 Bug: 747589, 1015214, 302577 Change-Id: I7ac05f966c02be39fcd05788b1e562efae214825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048032Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#742367}
-
Carlos IL authored
This reverts commit 562af1be. Reason for revert: Failing test was disabled since it should run with autoupgrades disabled, will investigate and fix why InitAndDisableFeatures is not doing that separately Original change's description: > Revert "Enable passive mixed content warning by default" > > This reverts commit 0a37869a. > > Reason for revert: Causing failure of DidChangeVisibleSecurityStateTestWithAutoupgradesDisabled.DidChangeVisibleSecurityStateObserver in browser_tests on linux-chromeos-chrome > Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3194 > > Original change's description: > > Enable passive mixed content warning by default > > > > Sets the feature to enabled by default and removes the config from > > fieldtrial_testing_config.json in preparation for launch. > > > > Bug: 1025276 > > Change-Id: Iffcdd2153491de25b7038a609776255bbdacf2ac > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053024 > > Commit-Queue: Carlos IL <carlosil@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Emily Stark <estark@chromium.org> > > Auto-Submit: Carlos IL <carlosil@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741506} > > TBR=rkaplow@chromium.org,estark@chromium.org,carlosil@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1025276 > Change-Id: I20e9dc38d83036c7b17d91de24c23ebae3049de9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058970 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741860} TBR=rkaplow@chromium.org,estark@chromium.org,bsep@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025276 Change-Id: I9e2043fc150b9225bc32537b0cee669f1836802a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062671 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#742366}
-
Robbie McElrath authored
//aw/test:libstandalonelibwebviewchromium and //aw/browser/gfx:gfx depend on //aw/public headers but don't explicitly declare the dependency. See the comments in crrev.com/c/1764341 for more context. Test: autoninja -C out/aw webview_instrumentation_apk Test: gn check out/aw Bug: 934152 Change-Id: I0d437f7a6dc34a3ff42b3daf9ed7d41bab8a1c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055692 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742365}
-
Ionel Popescu authored
Currently when an user changes the system accent color on Mac, that color is going to be used as the focus ring. This CL changes the used focus ring color by taking just the RGB values from the accent color. A custom alpha value of 128 is used in order to avoid having a color too light which affects accessibility. Bug: 1051391 Change-Id: I8416739ca42ef8deeeca5faf932d6dd9e0fed26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057865Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742364}
-
Yuwei Huang authored
Per discussion in crrev.com/c/2055362, it's generally not safe to use gRPC outside Chrome Remote Desktop, especially in Chrome. This CL adds a note to the BUILD.gn file to encourage people to discuss this with Chrome security team before they decide to use gRPC. Change-Id: I9218059a977d5aea785cd70621f7ab2c428ecc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062920 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#742363}
-
rbpotter authored
This is in preparation for porting these tests to Polymer 3. Bug: 1026426 Change-Id: I16aa1e85c882431b99a4bbd95393b62a216542a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056576Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#742362}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01663f71bc87..f0fc1c09255f Created with: gclient setdep -r src-internal@f0fc1c09255f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094,chromium:1052560 Tbr: jbudorick@google.com Change-Id: Idc3d191bd21ce90be82f0085d9a0531bcf56c115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062762Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742361}
-
Thomas Lukaszewicz authored
Removed the use of NativeTheme::GetInstanceForNativeUI() from CastDialogSinkButton. Fixed the dialog issue icon such that it's color now tracks the current NativeTheme of it's widget. Bug: None Change-Id: Idfa416ad449b6038804087e4dd518ebdb52724bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044631 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Peter Boström authored
This adds the reverse of SetEnabledTextColors(). It also makes ResetColorsFromNativeTheme private instead of protected as it was currently misused and no other call sites. Adds a simple test for SetEnabledTextColors(). Bug: None Change-Id: I0b4a15733e4913c809dd5d91cd0c5821370f824d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057625 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Alex Danilo authored
Changes the width of the search box to expand the containing search wrapper to 288px. The value used in the CSS calc property 60px is the sum of 48px for the search button plus 12px margin to the right of the search input field cancel button. Note, the width of the search button margins may be reduced in a future CL subject to visual evaluation. Bug: 992823 Change-Id: I372df330a5bb446c3430dcd85c0582bd3a3d9b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060401 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742358}
-
Christopher Cameron authored
This allows us to remove the color conversion render pass, and use a lower-bit depth format. Bug: 1037954 Change-Id: I6810b1105d47c3690d371f92700182ef4f13e7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060664 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Andrew Xu authored
ScrollableShelfView::GetTargetScreenBoundsOfItemIcon assumes that shelf is horizontally aligned. This CL generalizes this function for side- aligned shelf. Bug: 1053705 Change-Id: I56c6a9a6a6bc7e102cb9c479574f1ca44eb0947e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063410Reviewed-by:
-
Ben Pastene authored
GN-gen is spitting out a warning on simple chrome builds with: The variable "needs_gomacc_path_arg" was set as a build argument but never appeared in a declare_args() block in any buildfile. This fixes that. Bug: 1011928 Change-Id: I75038e0e004889672e2cc24f7cedb76465cb55ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063252 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#742355}
-
Xianzhu Wang authored
Most of them failed because of the recent form rendering changes. Change-Id: I27d3c0628215488eb1c8a1c6fc2aa4c47f21a040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063409Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742354}
-
Ryan Hansberry authored
Change-Id: I76cf803cdf5ac839c8d6145a837e7f2c021a7573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048363 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#742353}
-
Thomas Lukaszewicz authored
Updated HoverButton code such that it will responsively update its own and its children's layouts. This is in contrast to its original behaviour in which layout was set based on the preferred sizes of it's children at construction time. This helps towards having HoverButtons with icons that update to match the color of the Widget's current theme provider. Such changes could incur changes in the icon's preferred size and could result in incorrect behavior in the old code. Also cleaned up unnecessary and unused code and fixed broken logic. Bug: None Change-Id: I502c32ea673d8f680f38a45ce2940e155872dd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045145 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Daniele Castagna authored
Chrome on ChromeOS uses triple buffering by default, keeping up to 2 buffers in flight while one is displayed. This CL adds a flag in chrome://flags that limits to 1 the number of pending frames, effectively reducing compositing to double-buffering. This can be useful for experimenting on devices where we want to minimize latency at the cost of more dropped frames. Bug: 1010457 Change-Id: I0cddb4c1831d5b909ee3c0193d42f3903e10d03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059709 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742351}
-
Bettina authored
Bug: 1048832 Change-Id: I7f3f398413b6339e35760fc8efec97b9e19b7601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037845 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742350}
-
danakj authored
As per https://chromium-review.googlesource.com/c/chromium/src/+/2044632/2/content/public/renderer/render_view.h#33 TBR=creis@chromium.org Bug: 419087 Change-Id: I525cba9080c2fe9eabf3ff14f5c30efcc2564281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062915Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742349}
-
Sean McAllister authored
Change-Id: I374fd452155ff8e9db96908f40ca98030fb12c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062921Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#742348}
-
Peter Kasting authored
* Remove using:: statements * Implement ButtonSeparatorView atop views::Separator. This changes from a 1 px line to a 1 DIP line; that complies with the current (MD Refresh) spec. Bug: none Change-Id: I7acedbb31bb9cd3fc5342449258efafe471ac976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048911 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#742347}
-
Alex Danilo authored
Sets the height of the search box wrapper to 40px and ensures the contained buttons and input field are vertically centered. Bug: 992823 Change-Id: I1bcd5e38e1268e1a382ff28304c447e2988fed6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060400 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Jeffrey Cohen authored
Bug: 1024586 Change-Id: Ia0661b281b84f9fcda8aa3a4936a4d4b780d00c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062923 Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742345}
-
Alex Leung authored
Bug: b/149422033 Change-Id: I56af3e77eeec9496027e231424efab8f530c03f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063033Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#742344}
-
manukh authored
This is behind a DisplayOwner param of the OmniboxDocumentProvider feature. Change-Id: Id66289c0b011838ceee8b129c1d2881f5466effe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929774 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#742343}
-
