- 16 Dec, 2020 40 commits
-
-
Noel Gordon authored
Followup to CL:2585261. Use idiomatic import of print function: import it from the __future__. Bug: 1113981 Change-Id: Ib5f7b87c193c9a9de60d25f9e82a4a6e0ff55bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593848Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#837393}
-
Sinan Sahin authored
This CL will be followed up by another one cleaning up the logging statements once the fix is confirmed. Bug: 1153706 Change-Id: I2c7feb4b4d94cfd4051df6e64d4564f5a26be16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594263Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#837392}
-
Marijn Kruisselbrink authored
This collapses white space, limits the length of descriptions to 64 characters, and on windows strips out '*' characters to ensure the windows dialog itself will still include the true extension. This last behavior is triggered by the `keep_extension_visible` flag that was added in https://crrev.com/c/2582842 to fix a similar problem on Mac. Tested: Verified that the extension is shown in the pickers shown by https://fsa-tests.glitch.me/accepts.html Bug: 1137247 Change-Id: Ife2344589427dbc1055234026601642113b6a791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586958 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837391}
-
David Stevens authored
This reverts commit 9641413f. Reason for revert: The optimization caused a number of flickering bugs related to overlays. The benefits of the optimization are small compared to the complexity, so it should be removed. This revert leaves SurfaceAggregator::Aggregate's target_damage parameter intact, as it is used by the delegated ink trail. Original change's description: > Reland "viz: Re-enable ignore_undamaged on platforms using GL buffer > queue" > > Previously the CL (crrev.com/c/2179763) got reverted since it enabled > the optimization in cases where it shouldn't have. > In particular, the optimization was enabled for SkiaOutputSurface where > only_invalidates_damage_rect used to be false and overlays are not > supported. > The diff between http://crrev.com/c/2205886/1..2 fixes that, > avoiding removing only_invalidates_damage_rect and fixing the logic > to enable the optimization in display.cc. > > Original CL description: > "SurfaceAggregator has an option to output only the quads that > intersect the damage rect computed by SA itself. > > This optimization was disabled on devices with HW overlays or where > the renderer might expand the damage, since SA would not know the > final damage rect. > > This CL re-enables the optimization on devices where we can estimate > a bounding rect of the renderer expanded damage. > > This is achieved by asking to the renderer for a bounding rect that > represents the maximum area that can be expanded. > SurfaceAggregator will aggregate the boundingrect union the damage. > > The damage on the root render pass will be unchanged, so that HW > overlays damage computation won't be affected." > > > Bug: 1077210, 1082947 > Test: viz_unittest (new test and Display tests) > Change-Id: Ib660320b03c0146c62e208332fa6eaa19632c84d > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/src/+/2205886 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769741} BUG=b:175087584,1156536,b:171728387,1143580 TEST=Open Play Movies preview from fullscreen Play Store in ARCVM TEST=Verify shelf doesn't flicker when playing YouTube videos in ARCVM Change-Id: I17beb6ebe9482f90c0f9c32c34cb9c7f280dc785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592271Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#837390}
-
Rakib M. Hasan authored
This tester will run skew tests on an Android Oreo emulator. Bug: 1114563 Change-Id: I2cc2eb6af62fe29cefe857c5191dc7e326c99057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594283Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#837389}
-
Xiyuan Xia authored
Fix AnimationThroughputReporter leaks its AnimationTracker when the underlying layer is released before the reporter. In such case, AnimationTracker holds a ref count of LayerAnimator so that that the animator and the animation sequences are kept around even if the underlying layer is released. And the animations will never run in such case and the tracker is leaked. The CL fixes the issue by observing LayerDestroyed to clean up. Also rename IsTrackingAnimation -> HasAnimationsToTrack to better reflect its meaning that returning a true means there will be animations to be tracked but does not mean it is tracking them right now. Bug: 1158510 Change-Id: I98980522a9b6866b0f635a512d0fbb6987eb2c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590646 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#837388}
-
Sadrul Habib Chowdhury authored
Add the 'benchmark' category to the trace-event that reports the FirstContentfulPaint event, so that the trace gets included for all benchmarks (without all benchmarks having to enable all traces of 'loading' category). BUG=1158862 Change-Id: Id1bd528f735de625002a1210ab75896faaece99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593479 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#837387}
-
Sean Gilhuly authored
Bug: 1159126 Change-Id: Iecc57ca0fa587e2d24f48c2a726e1b12dd5c232c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593937 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#837386}
-
Darren Shen authored
CFI issues were fixed for DecoderEngine in: https://chromium-review.googlesource.com/c/chromium/src/+/2537444 But they were never fixed for SystemEngine. Apply the same fixes there. Unfortunately this makes the tests are bit more complicated because the new 'entry points' structure doesn't directly allow stateful mocks. Use a workaround involving global variables. Bug: b/174442293 Change-Id: I9439dffc7296d1dc60c60c132789346ff52c05e5 Fixed: b/174442293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592527Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#837385}
-
Mustafa Camurcu authored
Related cl: https://chromium-review.googlesource.com/c/chromium/src/+/2494061 Bug= b:171066921 Test= None Change-Id: Id8ab83fc91e4ef6af5f68f42bb7254e43e5ac28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586188Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Mustafa Camurcu <camurcu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837384}
-
Evan Stade authored
s/web-apps-platform-team/pwa-dev as the former is deprecated: https://groups.google.com/a/chromium.org/g/web-apps-platform-team/about Bug: none Change-Id: Ibc034891f5c59104b5a50d24be95d1e49ea2e61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567182 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#837383}
-
Erik Chen authored
This CL stores whether the banner has already been shown as a local pref. If it has been shown, then it is not shown again. Bug: 1144321 Change-Id: I5dd97d6e4263c308bd14d90a480cf6cdeb7e7611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593282Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837382}
-
Darren Shen authored
Bug: b/174588692 Change-Id: I37c08ef6977cacd50045209a867048bdbc2d2f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583666Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#837381}
-
Tim Volodine authored
Extend expiration milestone for the Spellcheck.Android.Available histogram. Also add second owners line with a group mailing list. BUG=975927 Change-Id: I50862684088672a74137b8483f29ee2754e7df96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589935 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#837380}
-
Javier Fernández García-Boente authored
This CL add the logic, for both Legacy and LayoutNG, for handling trailing ideographic spaces when the white-space CSS property is set to 'break-spaces' value. The CSS Text specification states [1] that we must prevent handing or collapsing the advance width of any space, including other space separator like ideographic spaces, hence the overflowing spaces must wrap to the next line. However, the spec also states in the description of the 'break-spaces' value [2] that breaking opportunities exists 'after' any space; hence, breaking before the first ideographic space of the sequence is not allowed, so it may overflow in that case. [1] https://drafts.csswg.org/css-text-3/#white-space-phase-2 [2] https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Bug: 1155633 Change-Id: Id34f05cb3457516fcb20a4731606425ec943a255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584854 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837379}
-
Hiroki Kumazaki authored
It calculate [text area with font size less than 12] / [total text area size] ratio and send it as a double. Bug: 1113750 Change-Id: I943c853fb4c8f83bfc38156b1c46d7bef9ec8168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463099Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Hiroki Kumazaki <kumagi@google.com> Cr-Commit-Position: refs/heads/master@{#837378}
-
Yaron Friedman authored
BUG=783819 Change-Id: I403274b7afc4a34bc978a5717b05bccc22464973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593874 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#837377}
-
Sophie Chang authored
This is a reland of e2eec62f Original change's description: > Remove pre-initialization OptimizationGuideKeyedService logic > > In practice, this doesn't happen at all and cannot happen at all after > the incognito CL goes in > > Change-Id: I0daf1c4cbb189840913ee4a368dda437e07efaca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587396 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836699} Change-Id: I7f9cb3fe9d8f16dd5da3dbadf7b65c687d63ddb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594117Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837376}
-
Meilin Wang authored
Adds histogram: * Nearby.Connections.Bluetooth.ClassicMedium.ConnectToService.Duration to record the time spent when establishing a bluetooth service connection. Bug: b/163064897 Change-Id: I8ee6027109972923403f58e2b4914930bda77659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588304 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#837375}
-
Donn Denman authored
Extends two flags to M90 and one debug flag till 99 (since it's an ongoing tool to allow users to debug issues through a flag flip). Change-Id: Id4c6ab7d94b96382d70a3953d2a91c17f170528c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594318 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#837374}
-
danakj authored
Ensure that SkImageRep is always constructed with a valid bitmap. Instead of constructing an invalid SkImageRep then throwing it away when initializing an SkImage, we add an SkImage::CreateFromBitmap() that will just return a null SkImage directly if the bitmap is null/uninitialized. ImageSkia was creating a null ImageSkiaRep when searching for a representation in order to force use of the nearest one, but it also uses a boolean value to do the same, so stop making a null ImageSkiaRep. Then disallow null/empty ImageSkiaRep and also disallow their transport over mojo. Remove a few tests that were creating invalid ImageSkiaReps to test that they work - as they are no longer valid. Have ImageSkia constructed from ImageSkiaOperations check for the ImageSkiaRep that they get from their inner (non-null!) ImageSkia, as that can still return a null ImageSkiaRep. In that case, the resulting ImageSkiaRep must also be null. And we can do that without trying to perform operations on the (invalid, null) bitmap inside the null ImageSkiaRep. R=sky@chromium.org Bug: 1155258 Change-Id: Id7953743ca31804fa3d987677bb8c4962919fd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572896 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#837373}
-
Joel Riley authored
+ Change stop icon to X + Updated some strings + Added subtitle description to navigation control setting. AX-Relnotes: N/A Bug: 1140216 Change-Id: I039f77008b374bfb12bdec77622957201dfea505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594307Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#837372}
-
Ben Kelly authored
This CL makes a number of improvements: * It removes the http/https specific assumption that pathnames always consist of at least a leading slash. * Resolve relative pathnames for both patterns and URL input. This is only done if the baseURL is a standard URL with a pathname containing slashes. * Canonicalizes URL input values. * Validates pattern values are ASCII, but does not perform any encoding or canonicalization yet. Bug: 1141510 Change-Id: I6db1afe77f6dd1d15ccb2e96a51412a31257efba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579989 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837371}
-
Shakti Sahu authored
Bug: 1159099 Change-Id: I0db628ff4ceb763b3d2d32309d90e37570961149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594172Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837370}
-
Mason Freed authored
See comments in the bug, but without this code, text nodes that are direct children of <template> are broken up into individual characters. TBR=masonfreed@chromium.org Fixed: 1070669 Change-Id: I2e5cdb14e5e938118c0b26241d2d5242ea617f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593153Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#837369}
-
Jeroen Dhollander authored
All access to the Libassistant classes is being moved inside the |LibassistantService| mojom classes, so we need to update the unittests to fake the |LibassistantService| class, instead of the Libassistant classes. This CL introduces a |LibassistantServiceHost| which launches/stops the Mojom service. This CL also introduces fake objects, and updates the |AssistantManagerServiceImpl| unittests to use these fakes. Bug: b/171748795 Change-Id: I4742f0c28050f0bce5c11a4d946ec35b3aab449d Tests: chromeos_unittests --gtest_filter="Assistant*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569920 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837368}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c47b951ecbcb..f32fbb51e8a1 2020-12-15 m.maiya@samsung.com Add EXT_shader_framebuffer_fetch_non_coherent entry points 2020-12-15 m.maiya@samsung.com Vulkan: Add the tests for EXT_clip_cull_distance 2020-12-15 timvp@google.com Vulkan: flushCommandsAndEndRenderPass during glFenceSync() 2020-12-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c16dc7107fd3 to fa44979d90aa (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ib3a7f645466a7bd9b9d3189dcfed4fb9ff763621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837367}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6fc34eb..24e738a6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8837dc0a0f815c43204d705ef40ee2931f389c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593521Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837366}
-
Sophie Chang authored
Will re-enable when I can figure out the hint cache being used by both profiles that only happens on the linux-64-rel bot Bug: 1158777 Change-Id: I5d6e521342fc83e7ab00af0fdb44fe3592a98e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594218 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#837365}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e8d5d52b21b8..4fa506cee933 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com,btolsch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1119395,chromium:1154371,chromium:1157953,chromium:1158394,chromium:783819 Tbr: aboxhall@google.com,btolsch@google.com Change-Id: Ib1795cae8af9dcedbd5fd2bec00c9ebff65dfc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593526Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837364}
-
Trevor Perrier authored
This CL updates three different language lists: - l10n_util::kAcceptLanguageList - added: - as (supported on Android) - rw (supported by Translate) - chr, kok, tn, wo (UI languages for Windows) All of these added languages have ICU support for localization of display names. - translate_language_list::kDefaultSupportedLanguages - added: rw - added: hmn and jv since this were already in l10n_util - CLD3LanguageCode enum: - added languages to match l10n_util. Bug: 1156544 Change-Id: I21c272ee92b4991088623ad81bc55f7db8edceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583026Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#837363}
-
Yulun Wu authored
Bug: 1134433 Change-Id: Ie49947cc0b75f4f8f9688b0db2e40f5edb4b791a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594268Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837362}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e520ce0. With Chromium commits locally applied on WPT: 977bb671 "Reland "Use skia.mojom.BitmapN32 in Detection mojoms"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ida0d1c41669d345fabfbc93388dc88d254c798b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592138Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837361}
-
Xida Chen authored
This CL implements the interpolation logic for composited background color animation. As a result, its associated layout test passes. Bug: 1153668 Change-Id: Ibefe0d440d6966dbbd408ee1b011d0b8e6609050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585838Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837360}
-
John Abd-El-Malek authored
Bug: 1153694 Change-Id: I7fa491aeff00e22757e0aeeb0464cea114deece2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594277Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#837359}
-
Sonny Sasaka authored
Battery reporting via HFP is now consolidated into BlueZ, so there is no need to listen to CRAS directly. BUG=b:172361090,b:166543531 Change-Id: Id0f54323790a5788e09441a32a9a4be77a3d8bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593821Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#837358}
-
Findit authored
This reverts commit 4a67dcea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 837301 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhNjdkY2VhZDFkOTRmMDU1ODMxMzU5YjgxZjZiZjZlZTVmY2RlYjIM Sample Failed Build: https://ci.chromium.org/b/8860806375392401232 Sample Failed Step: compile Original change's description: > Use new vulkan-deps repo for all Vulkan dependencies. > > This replaces several grouped dependencies with one meta-repo. > > Bug: angleproject:5390 > Bug: 1153258 > Change-Id: Ifd7a8d5b2903d141d9029fe803c981bdffdedda3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590264 > Reviewed-by: dsinclair <dsinclair@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837301} Change-Id: Ifafd9ffe155db577b0afed54721fcc38b3c43fae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593594 Cr-Commit-Position: refs/heads/master@{#837357}
-
Patrick To authored
When an offscreen canvas doesn't have a placeholder canvas (such as when new OffscreenCanvas(width, height) is called to create an offscreen canvas in javascript), the corresponding C++ object is OffscreenCanvas, not HTMLCanvasElement. This change obtains the XRSystem object from the OffscreenCanvas so that MakeXrCompatible can be called on it. Bug: 1154424 Change-Id: I4fb1c7005a8c3a41cc4ddcd457c81c4bec4464ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578710Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837356}
-
Gavin Williams authored
Record Scan app entry point for launching from Setting and the Launcher. Remove the |kBrowser| enum as we aren't able to track when the app is opened from the Omnibox. |kBrowser| is safe to remove because the ScanAppEntryPoint histogram has not recorded any entries yet. Bug: 1059779 Change-Id: I2be9cc0e519a40f11e3838efaf5b30309267de7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577607 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#837355}
-
Nick Burris authored
* Make ExternalAuthUtils provide its own instance instead of callers having to use AppHooks. A follow up patch will remove the ExternalAuthUtils instance from AppHooks. * This is patch 3/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. Change-Id: I6527d93dbce453626aa0c02f7093d7686f67266a Bug: 1154371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587430 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#837354}
-