- 21 Nov, 2018 40 commits
-
-
Jan Krcal authored
This CL allow propagating is_from_expiration bool to TypedURLSyncBridge. It is important for keeping sync data (in history DB) with sync metadata consistent. This bool will be used in a follow-up CL. Bug: 851869 Change-Id: I96bec4ecc86f9357a82b7abf4ca7ee8320ef998d Reviewed-on: https://chromium-review.googlesource.com/c/1343005 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609995}
-
Finnur Thorarinsson authored
This provides support for the Contacts Picker API, https://github.com/beverloo/contact-api https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/brKChSa9_d0 allowing contact details to be shared with a web page. A skeleton select() function is implemented (returns a DOMException). BUG: 860467 Change-Id: I7cf4c147271179c0f59a7cd455d88b1b570c9891 Reviewed-on: https://chromium-review.googlesource.com/c/1326501 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609994}
-
Guido Urdaneta authored
This is intended to make it easier to detect if an RTCPeerConnection is used together with getUserMedia() or getDisplayMedia() for real-time audio/video. Bug: 906029 Change-Id: I440fc93567bd9a490047c2bcf3bf5641a4ff3dfa Reviewed-on: https://chromium-review.googlesource.com/c/1344101Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#609993}
-
Javier Ernesto Flores Robles authored
Bug: 878388 Change-Id: I1326cc2cc851efcb8ec4e873f0c6aa62710d30cf Reviewed-on: https://chromium-review.googlesource.com/c/1344056Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#609992}
-
Benoît Lizé authored
On Windows, malloc() (in Chrome) never returns nullptr, instead triggering an OOM. Explicitly using UncheckedMalloc() to get nullptr in case of allocation failure. Bug: 905777 Change-Id: I56bf677710b606cc6ca69073f4cc2d34c4ef19dd Reviewed-on: https://chromium-review.googlesource.com/c/1344064Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#609991}
-
Rakina Zata Amni authored
Some CE default styles might not have RuleSets, this CL adds some null checks. Bug: 895512 Change-Id: I02e0f5070c36c72e8d03ed950d96783506f05c5a Reviewed-on: https://chromium-review.googlesource.com/c/1343585 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609990}
-
Risan authored
Since we are exposing /storage instead of /var/run/arc/media/removable inside ARC++ container, we should also request scan through /storage so that MediaScanner is not confused. BUG=b:69078137 TEST=Manually verified. Google Photos doesn't show duplicate device anymore (before, it shows one for /storage and one for /var/run/arc/media/removable). Change-Id: I93e9f029068110983d6033348acb9f2e85fd5f89 Reviewed-on: https://chromium-review.googlesource.com/c/1329820Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609989}
-
David Staessens authored
- Fixed build failure of win_rel target. - Made tests chromeos-only for now. > This reverts commit 493db4b2. > Reason for revert: Compile error on win-rel builder. > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/6451 > Original change's description: > > media/gpu/test: Initial version of the Test Video player. > > > > The test video player is created to improve the way VDA (video decode > > accelerator) tests are created, and to allow more control of the test flow. > > > > This is an early prototype, that only supports playing a video from start to > > finish. More complex tests and their required functionality will be added soon. > > > > TEST=ran new VDA tests on eve and kevin > > > > BUG=879065 > > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: Ida7396e7294c0e367417c352284e4a601daa0cba > > Reviewed-on: https://chromium-review.googlesource.com/c/1179484 > > Commit-Queue: David Staessens <dstaessens@chromium.org> BUG=879065 Change-Id: Ibc17303776b2378470b50da88948bc6907732411 Reviewed-on: https://chromium-review.googlesource.com/c/1345670 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609988}
-
Jan Lamecki authored
Bug: internal b/112463440. Change-Id: I6c652d45c1e5b6343f04932a9afe0b9731546207 Reviewed-on: https://chromium-review.googlesource.com/c/1344059 Commit-Queue: Jan Lamecki <jachor@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609987}
-
Morten Stenshorne authored
Bug: 769508 Change-Id: I32e58b403f2f0e279091b7209aedaa69c4e9b5cb Reviewed-on: https://chromium-review.googlesource.com/c/1345010Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#609986}
-
Christian Dullweber authored
MediaLicense deletion was added in crrev.com/c/1213242 but due to a confusion about the purpose of SiteDataDeleteHelper, it didn't work correctly. This CL correctly implements MediaLicense deletion when a site is reset from Settings > SiteSettings > AllSites > [Site]. Tested manually by adding a LOG statement to OriginMatcher in website_preference_bridge.cc and testing that offline content stored from https://shaka-player-demo.appspot.com/demo/ triggers the LOG statement when resetting a site. Bug: 883701 Change-Id: I28b93c44daea757084dc5b6e667a2d36bc00b70f Reviewed-on: https://chromium-review.googlesource.com/c/1337623Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#609985}
-
Carlos Caballero authored
BUG=901345 Change-Id: I90afa3439fedc68032ab69158d2ecfae2ba52884 Reviewed-on: https://chromium-review.googlesource.com/c/1343088 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609984}
-
Noel Gordon authored
To prepare for closure compilation of this unit_test file, clean-up to make upcoming closure changes easier to understand. - update and fix obvious closure @type errors, etc - remove '|undefined' from variables new-ed in Setup() - define undefined variables, remove unused variables - importer.SyncFileEntryProvider is not defined in Files app, nor in the code-base or the web: remove it. No change in test behavior, no new tests. Bug: 905934 Change-Id: Idab68cc2257286e2278cdce361a84fc2176c51cc Reviewed-on: https://chromium-review.googlesource.com/c/1345690 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609983}
-
Anders Hartvoll Ruud authored
It will soon be necessary to add more flags to CSSParserLocalContext in order to parse custom properties via the CustomProperty class. Those flags are not interesting to non-custom call sites, so it's more convenient if CSSParserLocalContext is a class with reasonable defaults that can be overridden. Change-Id: I078d8faa4cbce5de8db24b60e0817625d7deae5f Reviewed-on: https://chromium-review.googlesource.com/c/1341914 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=898958 R=pkasting@chromium.org Change-Id: Ib5790e607c4b0d500e39cfea7dd240596dee27ca Reviewed-on: https://chromium-review.googlesource.com/c/1333372 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#609981}
-
Javier Ernesto Flores Robles authored
Only fill credit cards on HTTPS, and passwords on HTTPS and password fields. Show an alert to the user otherwise. Bug: 905652, 878388, 845472 Change-Id: I51e0f07757dc4f7f1e002b88b83a2d2eeea071b5 Reviewed-on: https://chromium-review.googlesource.com/c/1340259 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609980}
-
Vaclav Brozek authored
Autofill's ParsePhoneNumber parses strings to extract valid phone numbers. This is a considerable effort (including regex matching) and a potential attack surface for malicious inputs. Phone numbers are not arbitrarily long, so exceedingly large inputs for ParsePhoneNumber signal an error or an attack. They are also expensive to parse. Thus, this CL introduces an upper bound on the input length, and the parser will refuse inputs exceeding this bound. As a side effect, the autofill_phone_number_i18n_fuzzer will stop timing out on large inputs. The CL also wraps the phone number unittest in the anonymous namespace: This is to prevent potential name clashes for the newly introduced GenerateTooLongString helper method, but is in general a good thing to do in unittests, which are never meant to be exported beyond their own file. Bug: 901675 Change-Id: Ie3b069f846288ccd7f11fbce98c54669a55f980f Reviewed-on: https://chromium-review.googlesource.com/c/1343007 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#609979}
-
Sam McNally authored
Rapidly clicking on the new folder button in the files app acting as a save-as dialog can cause multiple flows through that process (from pressing the button through to completing the rename) to run concurrently. This can cause some strange effects: - reporting that the directory already exists, despite the name intending to be unique; - getting stuck a state renaming a newly-created directory that hasn't been rendered into the file list, causing the app to be effectively unresponsive. Avoid these problems by disallowing execution of the new-folder command while another is in progress. Bug: 632270 Change-Id: I48eb43197403bf85ac78e42a6361c972499b008c Reviewed-on: https://chromium-review.googlesource.com/c/1345687Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609978}
-
Alex Clarke authored
The TimeDomain introduced by http://crrev.com/c/1324391 needs to know if the current RunLoop should quit when idle because if so it needs to stop advancing mock time. We do this by plumbing a flag through to MaybeFastForwardToNextTask. Bug: 863341, 891670 Change-Id: I71d8240fa5c6e7088cafacba57a31ec15abfe695 Reviewed-on: https://chromium-review.googlesource.com/c/1337336 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609977}
-
DongJun Kim authored
This CL has 2 changes as below - Change DOMWindowEventHandlers to WindowEventHandlers. - Makes WindowEventHandlers a static-only class by [1] [1] https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/bindings/IDLExtendedAttributes.md#ImplementedAs_i_m_s_a Bug: none Change-Id: Iac78712e3567ffb4f43d1f1c493719f7d1613f65 Reviewed-on: https://chromium-review.googlesource.com/c/1343595 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609976}
-
Rayan Kanso authored
ChromeOS was creating multiple BackgroundFetchDelegate clients, and overwriting the client initiating the fetches. The fix was to check that we are not overwriting the client. This fixes our problems in the short term, and a longer term fix is planned in crbug.com/907075. The fix works on ChromeOS head, as well as 71 (tested via manually merging the change). Bug: 907038 Change-Id: Ic1d5bc9f55b22359aa592c71f49d8ab5ed90de5e Reviewed-on: https://chromium-review.googlesource.com/c/1344030 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
https://chromium-review.googlesource.com/c/1312234Nico Weber authored
This is a reland of c5612605 Original change's description: > Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234 > > Bug: 875037 > Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1339339 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608783} TBR=hans Bug: 875037 Change-Id: Iac24d9ec462cd4d5720d78a52b7f867be3ab2ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1344198 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609974}
-
Robert Ogden authored
Also refactors GetSessionKeyFromRequestHeaders to be static and return a bool to indicate success, setting a passed pointer to the parsed session key. This is needed to support Lite Page Redirect pingbacks, in order to get the DRP session id and page id that were used on a navigation. Bug: 864665 Change-Id: Iefa1d6e39b58a0b71dbc1976ef1a0a2ba4712e73 Reviewed-on: https://chromium-review.googlesource.com/c/1345424 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609973}
-
jdoerrie authored
As a follow up to r609674 this change adds NavigateToManagePasswordsPage to PasswordManagerClient in order to remove the dependency on ChromeAutofillClient. In addition, this change inlines password_manager_util::UserTriggeredShowAllSavedPasswordsFromContextMenu Bug: 904821 Change-Id: Ib66e5c20e8babcf84de3e07a0c031cf9e700e43d Reviewed-on: https://chromium-review.googlesource.com/c/1344031 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609972}
-
Anders Hartvoll Ruud authored
TBR=lukasza@chromium.org Bug: 907402 Change-Id: I939381e79f68c912b70207c9412b42d65e74f3a3 Reviewed-on: https://chromium-review.googlesource.com/c/1345077Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#609971}
-
Joel Hockey authored
MockEntry.deleteRecursively added to help debugging in browser. Bug: 571355 Change-Id: I74422501b0e69380d8d5ff05c796ef1d42c68992 Reviewed-on: https://chromium-review.googlesource.com/c/1345951 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e47ac15d93b8..a85a4b01ee72 git log e47ac15d93b8..a85a4b01ee72 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 jbudorick@chromium.org Don't fetch flash when fetching android_internal. (reland) 2018-11-21 tandrii@chromium.org git cl: remove Rietveld implementation entirely. 2018-11-21 tandrii@chromium.org git cl: remove Rietveld import and things it depends on. 2018-11-21 tandrii@chromium.org git cl: get rid of Rietveld's upload.py import. 2018-11-20 vadimsh@chromium.org Revert "[vpython] Roll to pick up user differentiation of cached envs." 2018-11-20 iannucci@chromium.org [vpython] Roll to pick up user differentiation of cached envs. 2018-11-20 jbudorick@chromium.org Revert "Don't fetch flash when fetching android_internal." 2018-11-20 abenner@google.com Enable python formatting by default if yapf file provided 2018-11-20 jbudorick@chromium.org Don't fetch flash when fetching android_internal. Created with: gclient setdep -r src/third_party/depot_tools@a85a4b01ee72 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278,chromium:869227,chromium:869227,chromium:856278,chromium:846432,chromium:856278 TBR=agable@chromium.org Change-Id: Ifc45e8c4dda5ca7c283310fc840910250a778ffd Reviewed-on: https://chromium-review.googlesource.com/c/1345394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609969}
-
Adrienne Walker authored
Debug builds of Android were crashing because of misaligned read/writes of float variables in PaintOpWriter::WriteSimple and the accompanying reader. Fix this by rounding up all WriteSimples to align the size they write to 4 bytes. This is just a spot fix, but fixes most of the alignment issues on a few checked pages. If we wanted to move to DCHECKing the alignment, this would probably need more work. This continues to avoid calling AlignMemory in Write/ReadSimple, as that appears to cause about 30% slowdown in serializing/deserializing speed in the cc_perftests --gtest_filter=PaintOp* tests. Bug: 905665 Change-Id: Ib6db27d7cafe22b40b96f841dc2df54c1b6a4f1c Reviewed-on: https://chromium-review.googlesource.com/c/1343565 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#609968}
-
Eric Seckler authored
Fragment may not have immediately attached during activity creation, so wait for it to attach in test. TBR=twellington@chromium.org Bug: 907224 Change-Id: I4fa6a9b9478b0d0e34579e5712da3822ebb6e8ec Reviewed-on: https://chromium-review.googlesource.com/c/1345435Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#609967}
-
Anders Hartvoll Ruud authored
TBR=cmumford@chromium.org,jam@chromium.org Bug: 905423 Change-Id: I2572c956ac4ef4fcc0553cd595fb93679b79ca12 Reviewed-on: https://chromium-review.googlesource.com/c/1345513Reviewed-by:
-
Vaclav Brozek authored
There was a discussion about whether Chrome should avoid filling on load if a form has some new-password fields, or if the condition should be "has no current-password fields". The PasswordForm.FillOnLoad metric supported a team decision on that. The decision was to go with the new condition (for the new parser). Therefore the metric is now marked as obsolete and no longer collected. Bug: 895781 Change-Id: I3a153bf706abe12a5621b0a209cb53b6604ce875 Reviewed-on: https://chromium-review.googlesource.com/c/1341540 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#609965}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. While I'm here, also - update a comment in GetSyncUsernameIfSyncingPasswords to be more specific, since the semantics here are a bit weird, and - remove a CanSyncFeatureStart check from ShouldAffiliationBasedMatchingBeActive since it's redundant with the check for IsSyncFeatureActive which is strictly stronger. Bug: 884159 Change-Id: Ibbb9a82a2d89520e1a349e29a1050cd84dd52ea5 Reviewed-on: https://chromium-review.googlesource.com/c/1344096Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609964}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d11507507daa..fd17a12ec7ac git log d11507507daa..fd17a12ec7ac --date=short --no-merges --format='%ad %ae %s' 2018-11-20 benjhayden@chromium.org Add alerts-controls for v2spa 2018-11-20 mlippautz@chromium.org vinn: Roll Mac d8 to 7.0.276.40 2018-11-20 mlippautz@chromium.org vinn: Roll Linux d8 to 7.0.276.40 Created with: gclient setdep -r src/third_party/catapult@fd17a12ec7ac The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If62503fef89ea0409ba690729cee0a6da769e6db Reviewed-on: https://chromium-review.googlesource.com/c/1345770Reviewed-by:
-
Mohamed Amir Yosef authored
This CL converts SyncerError to a class. This is in preparation for a later patch that would add more data to the SyncerError class. Bug: 897049 Change-Id: Ie44fa2f65e92ee9ad9733cdd9586a8c7095befb4 Reviewed-on: https://chromium-review.googlesource.com/c/1344098 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609962}
-
Danan S authored
Bug: 904564 Change-Id: I653438bf5244bc98bcb742d9d986b4ea2bd4b40a Reviewed-on: https://chromium-review.googlesource.com/c/1334563 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609961}
-
Carlos Caballero authored
Replace all the state checking and tracking code with the new and shiny OperationsController. Bug: 901345 Change-Id: I8023e78ebfee679fd565de465e810dbb9c6ee2ec Reviewed-on: https://chromium-review.googlesource.com/c/1341525 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Christopher Cameron authored
When using RemoteMacViews, for a given widget, the widget's NSWindow and content NSView exist in the app shim process, while the tree of AXPlatformNodeCocoas exists in the browser process. In the browser process, the widget's NSWindow and content NSView are represented by NSAccessibilityRemoteUIElements in views::BridgedNativeWidgetHostImpl. Update AXPlatformNodeDelegateMac::GetParent and GetNSWindow to retrieve these values from views::BridgedNativeWidgetHostImpl. In AXPlatformNodeDelegate, replace the method GetTopLevelWidget with the method GetNSWindow and call this method in -[AXPlatformNodeCocoa AXWindow]. Replace all subclass implementations except for AXPlatformNodeDelegateMac with NOTREACHED. Bug: 900846 Change-Id: Ia0d26c4d118391ce66cc1e080ca3b62fb228aa8c Reviewed-on: https://chromium-review.googlesource.com/c/1338722 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609959}
-
Alexey Baskakov authored
- Use WebAppIconDownloader in WebAppDataRetriever. - Extract InstallFinalizer interface: WebAppInstallFinalizer is a BMO implementation. BookmarkAppInstallFinalizer will use extensions and CrxInstaller. Bug: 901226 Change-Id: Ie865bfd4facfc6f890ab92d5d6451a37a34979ea Reviewed-on: https://chromium-review.googlesource.com/c/1343410Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#609958}
-
Olivier Robin authored
Cannot reproduce failure. Tentatively reenable. Bug: 796082 Change-Id: I5ec7a55a723f91bb8a76e3f872abfe06eb7693c1 Reviewed-on: https://chromium-review.googlesource.com/c/1338080Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609957}
-
Rune Lillesveen authored
NeedsLayoutTreeUpdateForNode() is true if an ancestor returns true for NeedsAdjacentStyleRecalc(). For getComputedStyle we may start out with a tree where we don't need a full style/layout-tree update, but matching selectors as part of EnsureComputedStyle() up the ancestor chain may cause those flags to be set if we match adjacent selectors which were not previously matched. We need to ignore those flags for the sanity check in EnsureComputedStyle. This may be the situation in which the DCHECK triggers for 900138 as well. Bug: 906830, 900138 Change-Id: I51927fdb9f4bc44e3612628cf9b9710d26e2d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1344130Reviewed-by:
-
