GitLab

This is a revert of crrev.com/c/2451571, which added short-term logging
to propagate resource blocks caused by extensions to the Fetch API
surface and expanded the TrustTokens.FetchFailedReason enum to include
this case.

Now that we've finished the investigation for which we added this
instrumentation, we can clean up the logging changes. This is the first
of two cleanup CLs; the next CL will remove the remaining
FetchFailedReason logging in FetchManager.

Bug: 1133944
Change-Id: I24ddbf366eb288f4b3c7cd1dbd3cc324918bc644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561742Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831921}

Sometimes cursorPosition computed based on mUrlBarEditingTextProvider
would be larger than the size of textWithoutAutocomplete given to
onTextChanged(). This happened when typing really fast on a slow device,
in Debug builds.

To ensure this situation doesn't trip a DCHECK within
AutocompleteControllerAndroid, use the up-to-date value of
mUrlBarEditingTextProvider's text when passing a computed cursor position.

Bug: 1142817
Change-Id: Id6ef48d561461fd711cbc9a4abab8851b8406a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503693Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Maciej Pawlowski <m.pawlowski@eyeo.com>
Cr-Commit-Position: refs/heads/master@{#831920}

https://swiftshader.googlesource.com/SwiftShader.git/+log/9dff6a3bb595..7cbb98085a26

2020-11-30 bclayton@google.com SpirvShaderDebugger: Fix crash when attempting to display nullptrs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I1e4920746a2b6151dbce8a3604c7e81d47e1ae0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565101Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831919}

Bug: 1023510
Change-Id: Iaa28b3b7eb61add4708a94fdca86e1def919c35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545878Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831918}

libxshmfence has two implementations (futex and pthread), It depends on
the build environment and build flags in build time. The Xserver and X
clients must use the same implementation to work. So we cannot put
libxshmfence in //thrid_party/ and link it in statically. Chrome has to
use system provided libxshmfence.so which is used by the Xserver to
work.

Bug: 1153156
Change-Id: I0c9f9f6d716fa7cd5fc389f887618adc9eea206f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563871Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831917}

Fix bug found by the "bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I3420b6c260b9fa94847b9b63df0438a9bce0b1c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556838
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831916}

conformance/extensions/s3tc-and-rgtc.html is persistently failing on
NVidia Shield on GPU FYI. Suppress the test.

Bug: 1153676
Change-Id: Ia7fb0cc2779c3fffd58bf081349e32c55fccc560
TBR: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564056Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831915}

Added DIR_METADATA files to a batch of subfolders in //components/a… and //components/b... , also removed duplicated metadata from OWNERS files

Bug: 1113033
Change-Id: I167e955eb480a5ef21bd482f588640dd5ad1323c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560063Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#831914}

|TryEncoding()| invokes |base::UTF16ToCodepage()|,
|net::EscapeQueryParamValue()|, and |net::EscapePath()|. All 3 create
strings of 3 times the length of the input. This is suspected to be
causing about 50 crashes per month.

Invocations to |TryEncoding()| that have resulted in crashes have
originated from different sources; e.g. omnibox & autocomplete,
extensions, and on startup.

This CL truncates the input string to 1,000,000 chars.

Bug: 1137686
Change-Id: I16e997666c07611d24472bcbee99893138e9c5e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559284
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831913}

Bug: 1141727
Change-Id: I763275bb48fd368cbb7ce7bfe5f9979c81201042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560835
Auto-Submit: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831912}

Avoid crashing if favicon is loaded after dialog is dismissed.
Hide permissions section if site settings are not available.
Also show JS in permissions section if non-default.

Tbr: eokoyomon@chromium.org
Bug: 1153619, 1153623
Change-Id: I6c65f197abdfc97a1d1c7478ac91d259fc9f735a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563670Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831911}

These histograms gave an approximate idea of the latency between when a
task is posted and when the ThreadPool starts executing it. However,
they were imperfect:

- If the task is posted just before the system sleeps, it may run
  after the system wakes up from sleep, resulting in a long latency
  being reported.
- The task is more likely to be posted just after the system wakes
  up from sleep.
- The task can be posted in a background renderer. The latency will
  be high because the process priority is low. We have no way to
  distinguish this case.
- The task can be posted when the user is not actively using
  Chrome. The latency will be low because there are no other tasks.
  We have no way to distinguish this case.

Fixed: 1089861
Change-Id: Ibc4c8dc6c4e2ce38e69e7ccfd9ddcda0218dd20a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526173
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831910}

This is a reland of 4f35dbaf

Original change's description:
> mac: Update LSMinimumSystemVersion from 10.10 to 10.11
>
> Bug: 1148931
> Change-Id: Ic0cdded0c1c4821689486cacd5790fce82c40c87
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537057
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827937}

Bug: 1148931
Change-Id: Iffeecf8cde404f389f5b868000ef18e58598caac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551317Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831909}

Small code improvements after spending a bit of time looking at the
class functionality.

Bug: none
Change-Id: I60109c1c8a13e59219f728449926899ddcc686c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563377Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831908}

Test is flakey on all platforms, but causing Mac10.11 Builder to fail.

TBR=rogerta@chromium.org

Bug: 1153702

Change-Id: Ie3088761021783e2c8d84bfda29dd8bfea1525e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564215Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831907}

Generate DIR_METADATA files and remove metadata from OWNERS files for
//components/search...

Bug: 1113033
Change-Id: Iecba1f8b63600b3be28eb9884ee492286ce0fafd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560822Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#831906}

This is a reland of 6a91223c
It was reverted because of test flakiness which caused by
race condition while entering pin.

Original change's description:
> PinSetupScreen: Cover screen by user action metrics.
>
>
> Bug: 1134354
> Change-Id: Ib18683e1b442af48bf180305e60258a28bce8439
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546003
> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#831359}

Bug: 1134354
Change-Id: I6df9f46c9aec51d70d19324fdaa87e8e255ad4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562384Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#831905}

Bug: 896689
Change-Id: I137748f61115fdef07519a10017411ca592799fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564858
Auto-Submit: Christoph Schwering <schwering@google.com>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#831904}

In current implementation, if a snapped window with a transient child
window gets unsnapped from splitview, it was not removed from
SplitViewDivider's observed transient window list, which may cause crash
later.

Bug: 1140115
Change-Id: I7f3b6b76a3e4a3f6b8605a19e4671b4c11fd29e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553151Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831903}

FilePathWatcher::Watch(bool) is going away. No functional changes.

BUG=1147071
This CL was uploaded by git cl split.

R=tommycli@chromium.org

Change-Id: I763198654ce1410bbff030223d28f982e6f3a132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550791
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831902}

Bug: 1145769,1145768,1071344
Change-Id: I5005d7db18d8fd7393e301da6854a7269d3b9727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560524
Auto-Submit: Joey Scarr <jsca@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831901}

This reverts commit 158b87d2.

Reason for revert: Fix for crbug.com/1148995 which caused a crash in the old overlay path has landed.

Original change's description:
> Revert "gpu: Disable SurfaceControl on Samsung devices running Q."
>
> This reverts commit c8c22806.
>
> Reason for revert: crbug.com/1144660
>
> Original change's description:
> > gpu: Disable SurfaceControl on Samsung devices running Q.
> >
> > A platform bug can result in transaction acks getting dropped which
> > stalls all rendering. A fix for this will be released in an R update
> > soon so this changes disables using this API in Q.
> >
> > This also reverts an earlier workaround which was added for samsung dex
> > mode since its not necessary after this change.
> >
> > TBR=skyostil@chromium.org
> >
> > Bug: 1131081
> > Change-Id: I8d053f160fd8ad5bf6ce47d5e6e295c322bace69
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491401
> > Commit-Queue: Khushal <khushalsagar@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> > Auto-Submit: Khushal <khushalsagar@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#820511}
>
> TBR=nyquist@chromium.org,boliu@chromium.org,khushalsagar@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1131081
> Change-Id: I55a3a9e8329b062ffbd506650fd7aca483172908
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538417
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827533}

TBR=nyquist@chromium.org,boliu@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1131081
Change-Id: I3f40ae5ee1142d061aa2e4ae18d22b9019a28878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564943Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831900}

Change-Id: I53d62db14db0ff6908726c9fc9e61492f9cb1276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561751
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831899}

https://skia.googlesource.com/skia.git/+log/ca92424e21e5..dc75a97b8010

2020-11-30 johnstiles@google.com Add global struct definitions to SkSL.
2020-11-30 johnstiles@google.com Add unit test for function dead-stripping.
2020-11-30 johnstiles@google.com Add support for enums in Metal code generator.
2020-11-30 johnstiles@google.com Migrate dedicated SPIR-V tests to golden outputs.
2020-11-30 johnstiles@google.com Remove ^^ operator from Metal codegen.
2020-11-30 reed@google.com Don't force linear when extracting miplevel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: westont@google.com
Change-Id: I391278da0c5cf319fa049d447f354c5ec1c5dbc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565100Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831898}

We are deprecating CanAttemptOwnership by cryptohome.

BUG=b:172775884
TEST=build ok.
TEST=check chrome://cryptohome

Change-Id: I416c07132f623847f68fe942f6976fc44e918f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565054
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831897}

It has no call sites.

Change-Id: I3cc17005be3c4408c14cdf00ecf9f748ea78c0dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561753
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831896}

Fixes autotest dry run to print both the build and test run command,
instead of just the build command.

Change-Id: I8bbccacb2e8360f3a9066c4a02de5867d79542b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565590
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831895}

This CL updated WebView functor to v3 which includes support for
SurfaceControl.

Bug: 1039876
Change-Id: Ifcc6f1f7b37809b790b06c068a4875fb0f822ff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562790
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831894}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03097b03496d..dd3be2e78615

2020-11-30 jacktfranklin@chromium.org Enforce const enum via ESLint rule.
2020-11-30 jacktfranklin@chromium.org Update all enums to be const enums
2020-11-30 andoli@chromium.org Migrate elements/ extensions of type 'action'
2020-11-30 mathias@chromium.org [Dark Mode]: migrate accessibility/AnimationScreenshotPopover
2020-11-30 tvanderlippe@chromium.org Use import.meta.url in heap_snapshot_worker
2020-11-30 raphael.kubo.da.costa@intel.com Sensors: Fix Device Orientation Euler angle calculation and allowed ranges.
2020-11-30 mathias@chromium.org Remove custom setImmediate implementation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1050549,chromium:1130536,chromium:1134103,chromium:1137281,chromium:1152736
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7d6b093f145362bbfd539db18eb5f8f154d98e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565102Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831893}

Bug: 1152807
Test: None
Change-Id: Ia929ab78d7e6298a59db385599bcb9a9530296f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563712Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Andres Medina <medinaandres@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831892}

Bug: 1153686
Change-Id: I5fab024017bdbcc48ac6fcfa3f5f1e459e3aa36c
TBR: mthiesse@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565650Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831891}

This flag can be useful outside of content/browser/accessibility, and it's sort of nice to not replicate its logic over different modules.

Bug: 1133330
Change-Id: I7752a1f23f5387b4e3e529ae9747ebca08640e07
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547211
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831890}

This patch lists some common causes of flakes in GTests, and links to
examples that might be helpful. Credit for the examples goes to the
security architecture team plus an example of my own.

Bug: 1127370
Change-Id: Ied695425ebab5935ef54094972fdbc1bfa9f187d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559271Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831889}

Tests with back/forward navigations including an error page from the
same host are failing with the new error page workflow.
This CL is fixing them and adding todo to revist once WebKit has
shipped.

Bug: 1153261
Change-Id: I7160431842511b67f9605929318968d6b2eac49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565238
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831888}

Non primary off-the-record profiles can in exceptional cases open a
browser windows (see OTRProfileID::AllowsBrowserWindows). NTP handling
is updated to cover these cases.

Bug: 1149654
Change-Id: I7a8b46acdee4524506350043801fccde0b06dfd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552403Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831887}

Change-Id: Ia6054d29de7d3142aeac62197691dcfde93d62fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564385Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831886}

Change-Id: I4af66010d708a1170af19a6d1e268527f31bbfe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561271
Auto-Submit: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831885}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ed30bc3ed29..efc444306186

2020-11-30 morg@google.com Remove grunt-arc-r from critical in RVC PFQ
2020-11-30 chrome-bot@chromium.org Update config settings by config-updater.
2020-11-30 bhanumaiya@chromium.org config: Add Guybrush, Majolica and Mancomb
2020-11-29 chrome-bot@chromium.org Update config settings by config-updater.
2020-11-27 yyanagisawa@google.com Revert "omit python2 to run goma_ctl."
2020-11-27 sidereal@google.com chromite: Remove code for generating guest_images.tar
2020-11-27 chrome-bot@chromium.org Update config settings by config-updater.
2020-11-27 chrome-bot@chromium.org Update config settings by config-updater.
2020-11-26 vapier@chromium.org cbuildbot: do not bootstrap when using main & master
2020-11-25 saklein@chromium.org controller/sysroot: Fix result path usage.
2020-11-25 vapier@chromium.org cbuildbot: update tot logic to consider main & master equivalent
2020-11-25 yyanagisawa@chromium.org omit python2 to run goma_ctl.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I36caeb5c394bec6a3469a04ebf9f2dc916e1842b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565392Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831884}

ToolbarViewWithExtensionsToolbarMenuTest is updated to cover ephemeral
Guest profiles.

Please see go/ephemeral-guest-profiles for more context.

Bug: 1125474
Change-Id: Ia6c47a255d82d29c32ba57b0b2aef4e0f9c3ea13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490041
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831883}

At r819219 a large part of cr_dialog.html code was duplicated between
CrOS/non-CrOS builds unnecessarily.

Bug: 1007433
Change-Id: Ia7de207202cdbd39f0b8d8671cd809249da36081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565184
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831882}