- 16 Apr, 2020 40 commits
-
-
Robert Liao authored
Change-Id: Ib66426dadaaa68800c818d00457ebafe73d0e4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153572 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#759763}
-
Mugdha Lakhani authored
SiteSettingsHelper is implemented in //chrome. This removes the dependency of PageInfoController on this class so it can be componentized. Bug: 1052375 Change-Id: I0a80f93d0314a2202e4f3c77a55731759516caf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152368 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759762}
-
Ian Prest authored
Skia takes a precision value when generating strokes as an optimization. When rendering, we pass a value derived from the scale-factor in the CTM, but when hit-testing we were passing a hard-coded value. This worked reasonably well for solid strokes at moderate scales. However, at sufficiently high scales and especially for dashed strokes, the stroke generated for hit-testing was noticeably different from the rendered stroke. This change passes the CTM through to the hit-testing code, so that we can use the same high precision for hit testing as rendering. Bug: 964614 Change-Id: I8dfcb3ade86b9e7b63c7415baab5814ac2286ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112955Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759761}
-
Koji Ishii authored
This patch sipmlifies |IsFirstForNode| for |NGInlineItemResult| by using all information in it. This was originally addded in r754815 <crrev.com/c/2111158>. Bug: 1043787 Change-Id: I3acccd6fd7f53f7eeff955025397216680565850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152336 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#759760}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dff792591fb9..efdff53176d6 git log dff792591fb9..efdff53176d6 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 terelius@webrtc.org Limit BWE drops from probes to 85% of the throughput estimate. 2020-04-16 sprang@webrtc.org Limits size of payload padding packets to 2x target size. 2020-04-16 hta@webrtc.org Remove deprecated ssl_identity methods 2020-04-16 srte@webrtc.org Cleanup: Removes unused BBR congestion controller. 2020-04-16 eshr@google.com Unify AdaptationReason and AdaptReason enums. Created with: gclient setdep -r src/third_party/webrtc@efdff53176d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I245585f978fde779110c27f1a69d100c251c073b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759759}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6cb05cce..e42feaad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I45946d253d33bb23140a18a0a73dbf8f5c926839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153266Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759758}
-
Brian Sheedy authored
Disables VrBrowserWebInputEditingTest#testFullscreenVideoControls on P due to it failing 100% of the time. TBR=alcooper@chromium.org Bug: 1071466 Change-Id: Ibc96c1a726f7b021f52e69942a4992f1e9b58c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153336Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759757}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/514232c46d65..7b1ae2b1188f git log 514232c46d65..7b1ae2b1188f --date=short --first-parent --format='%ad %ae %s' 2020-04-16 digit@google.com Fuchsia: Add LLVM 10.0 configuration headers. 2020-04-16 amaiorano@google.com CMake: fix PowerVR_Examples build 2020-04-16 amaiorano@google.com Don't fail build if Vulkan headers are different 2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader) when CMAKE_BUILD_TYPE is set in parent project 2020-04-16 amaiorano@google.com CMake: make submodule initialization work for add_subdirectory(SwiftShader) 2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader) 2020-04-16 amaiorano@google.com CMake: use directory variables consistently 2020-04-16 amaiorano@google.com CMake: make root compile options and link libraries private Created with: gclient setdep -r src/third_party/swiftshader@7b1ae2b1188f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ice2f0ff32ef588cfdade96462b891429b40ddf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152876Reviewed-by:
-
Maggie Chen authored
After completing DxDiag, DX12/Vulkan and DevicePerfInfo requests, the info-collection GPU process will shut down atomically. Before this CL, the info-collection GPU process always goes through the slow non-atomic shutdown procedure, which causes a crash when an exception is raised during shutdown. Bug: 1045920 Change-Id: I4dc3041fc940301735e248a52184749be0ef2e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151829Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759755}
-
Brian Sheedy authored
Removes the chrome-gold@ service account from android-kitkat-arm-rel-swarming and android-marshmallow-arm64-rel-swarming, which run tests on chromium-swarm-dev. This is a temporary fix to prevent task triggering from failing while a -dev version of chrome-gold@ is created. Bug: 1071301 Change-Id: I6b532f0c32f3f34f7852ff7e1b23552b7664a8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152782 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#759754}
-
Tibor Goldschwendt authored
Before, the left (almost) semi circle was a bit narrower than the right one. This regressed because the semi circle width was expressed in absolute units and didn't adapt to changes of the overall theme icon size. This CL changes the semi circle width to percentages and thus makes it robust to future theme icon size changes. Fixed: 1070588 Change-Id: I5eab8a2ebce1646a5f4f54e2c3191c3b3751c757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152773 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759753}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66792cf7d6a9..7339a08855d5 Created with: gclient setdep -r src-internal@7339a08855d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069072 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: Iddee3e058c1d62483722a1b6e8b365d33245dce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152875Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759752}
-
Wenbin Zhang authored
[benchmarking] disable the flaky test system_health.memory_desktop/browse:social:tumblr_infinite_scroll:2018 The test has been flaky and will be disabled for now. Bug: chromium:1068684 Change-Id: I2ad1ffe7554d626b1ce998b4a3e259ef971dcd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153308 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#759751}
-
Victor Hugo Vianna Silva authored
Previously every user of PasswordManagerClient::TriggerReauthForAccount had to retrieve the primary account id to pass it to the API. This is now done internally in the new helper class and the client API is renamed accordingly. Bug: 1070944 Change-Id: If19d5ccdd26c84961a2a90f56ace6b30e370098c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151869 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759750}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7027d3e67c45..9bd480acdcad git log 7027d3e67c45..9bd480acdcad --date=short --first-parent --format='%ad %ae %s' 2020-04-16 hjd@google.com ui: Fix map/parseInt bug 2020-04-16 hjd@google.com Merge "Combine async slices in a single track" Created with: gclient setdep -r src/third_party/perfetto@9bd480acdcad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I17fdf4516e7485fb8762d5885d0bf900076ba7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152881Reviewed-by:
-
Ayu Ishii authored
This change adds browser side check for opaque origins. Related to CL: https://crrev.com/c/2137926/2 Change-Id: Idc1be35b44012b46f9df706392bb0d10aef38b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142773Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#759748}
-
Elly Fong-Jones authored
This dialog's Accept method could return false under two circumstances: if the dialog's app info had not yet been loaded, or if the accept button was disabled. When the accept button is disabled there's no way to hit the Accept() code path, so one of these was dead. For the other, this dialog now disables the accept button when the app info is not available. Bug: 1011446 Change-Id: Ic6dd8bdd6fd2bba2c092004c0dde5f98bf98ea54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151309 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Lei Zhang authored
Test all the possible enum ColorModel values. Bug: 1069537 Change-Id: Ie4fe38a0d97eeea14ad36644fe661936788042de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150979 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#759746}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc5e10322119..cca5c49d45e0 git log fc5e10322119..cca5c49d45e0 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 estaab@google.com Add timestamp info to presubmit logs for easier debugging. Created with: gclient setdep -r src/third_party/depot_tools@cca5c49d45e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iba6653edef157cc7ccdcf806f0808c0ffbccdf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152882Reviewed-by:
-
Devlin Cronin authored
Bug: None Change-Id: I5d7c3aee3fe228c709c0bcbbffe3070333542fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151527Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759744}
-
Kevin Babbitt authored
AccessibilityHitTestingBrowserTest.*WithPinchZoom are still flaking after landing https://crrev.com/c/2140198. This CL adds more logging on failure to help identify the problem. Bug: 1069850, 1070647 Change-Id: I258b17e9b08614cfb5faf4d686f20994230a95a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149905Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759743}
-
Ben Pastene authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/14245e8100e9..de5575dc8a09 git log 14245e8100e9..de5575dc8a09 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 vapier@chromium.org cbuildbot: switch to python3 only via virtualenv wrapper [reland] 2020-04-16 cjmcdonald@chromium.org pytest: Remove 'passes_when_run_alone' marker 2020-04-16 cjmcdonald@chromium.org pytest: Mark all tests that leak processes & skip them 2020-04-16 cjmcdonald@chromium.org pytest: Add autouse fixture to assert that tests don't leak processes 2020-04-16 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-16 uekawa@google.com cros_mark_android_as_stable: Update GIT_COMMIT_MESSAGE to pass lint. 2020-04-16 morg@google.com Add Android arm64 support for cbuildbot_run 2020-04-16 lamontjones@chromium.org toolchain_util: recipes benchmark afdo profile creation 2020-04-16 lamontjones@chromium.org api: freshen python bindings. 2020-04-16 vapier@chromium.org config_lib: delete unused CQ/PreCQ constants 2020-04-15 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-15 navil@google.com Support a dry run of payload generation. 2020-04-15 andrewlamb@chromium.org Revert "Add Android arm64 support for cbuildbot_run" 2020-04-15 bpastene@chromium.org Reland: device: Don't assume '--device=localhost' means VM. Created with: gclient setdep -r src/third_party/chromite@de5575dc8a09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Change-Id: I59e7e9c15606bbc183f5809f0090a3938fe15efe Tbr: chrome-os-gardeners@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152867 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Kurt Horimoto authored
InfobarUIDelegate will not be necessary once we move to the overlay- based implementation. The only functionality needed from the UI delegate necessary with overlays is the InfobarType. This CL adds InfoBarIOS::infobar_type() to access this type, as well as a constructor that does not take an InfobarUIDelegate. This CL also updates the password infobar to be created with this new constructor if the overlay feature is enabled. Bug: 1033228 Change-Id: I3080bc2e5bb9e2e3db23dfe437ada90b70bb1661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150125 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#759741}
-
Brian Salomon authored
Bug: skia:10139 Change-Id: I1cb9b0a79fdce8104db5c9249c364a1f14b0b1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151332 Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#759740}
-
Nicolás Peña Moreno authored
This CL changes the SyntaxErrors to TypeErrors when 'type' and 'entryTypes' are both present or not present. It also adds a UseCounter for when 'entryTypes' is present and 'buffered', the only other member in the dictionary, is also present. Currently this causes a console warning whereas it should instead also throw a TypeError, so once this mistake is proved to be very infrequent, we can proceed to change it to TypeError. See related PR: https://github.com/w3c/performance-timeline/pull/164 Change-Id: Ic9399bf54895e3723b0ca2e513161a7e0638b681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144686 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#759739}
-
Brandon Jones authored
Bug: 1070819 Change-Id: Ia7d32b68864cea37788bc086520e51a0f828c7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149892Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
As the code uses types from CoreImage (CIFilter, CIImage, ...), it needs to declare a dependency. Currently the build works because this dependency comes from Firebase SDK, but it will become required once Firebase is provided through the internal framework. Bug: 1049042 Change-Id: Ib5cda246ab82b7492c6462564006230862dcd019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153068 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759737}
-
Evan Stade authored
1. Split notification text into two lines, meaning the URL is actually readable without expanding notification. 2. String change: use "A site is using your camera" instead of "Accessing video input" 3. Unify incognito and normal strings. Incognito was "A site is accessing video input" whereas normal was "Accessing video input". Now they're both the same. 4. Use "tap" more consistently. Sometimes we were using "touch" and sometimes "tap". 5. Use grit placeholders instead of manually appending string elements (pre-N). 6. Move android only strings into android only strings file. 7. Make screen capture consistent with other types in terms of formatting (place url at end of second line of text instead of at start of first line of text). See screenshots on bug. UX: meggynwatkins@ Bug: 1067409 Change-Id: I58e531eae2f037bf6faabd5bbb49658c657c732b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138776 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#759736}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames inline-flex-editing-with-updating-text-crash.html Bug: 1063749 Change-Id: I62ca5c5f28b14b6258eec90ce029289a70e7c14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152135Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759735}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0c450d5b58f..77750704ab85 git log a0c450d5b58f..77750704ab85 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 tvanderlippe@chromium.org Rename e2e test files Created with: gclient setdep -r src/third_party/devtools-frontend/src@77750704ab85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071369 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5d52107ef049f74a7402e993fa4061c7fd19407f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152866Reviewed-by:
-
Etienne Pierre-doray authored
The event is useful in tracing. Now that we're looking at jank using sampling profiler, we need similar annotation for stack samples. Change-Id: I6987dcb7da856f4a2099479d16c3ca37fd9e113a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144775Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#759733}
-
Xianzhu Wang authored
To highlight layers that can't use LCD-text. Only layers containing text will be highlighted. The visualization helps us find which layers can be candidate of improving LCD-text. Bug: 642885 Change-Id: I7c4c24c1d0e63ce016bef1bffbfe135ea1afe0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147930 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Steve Kobes authored
Bug: 1053510 Change-Id: I221a5ab7c4ea2eec9b951d8512a39de7edf119fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151838Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759731}
-
Dan Harrington authored
Will be used for action upload. Bug: 1044139 Change-Id: I9dedc4148cc2f14e76fafdd357b3fd4460f8a3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151342Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#759730}
-
kylechar authored
GpuChannelManager::RemoveChannel() removes the map entry for a GpuChannel and destroys the GpuChannel at the same time. This is problematic because the GpuChannel destructor can trigger context loss which leads back to GpuChannelManager::LoseAllContexts(). That will iterate over |gpu_channels_| in the middle of removing an element. Fix by removing the map entry first and then deleting the GpuChannel object. This is already done in DestroyAllChannels() for the same reason. Bug: 1067642 Change-Id: I5ccba54151686726b24af97a06c0bd7bf7f06d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152767Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#759729}
-
Yusuke Sato authored
Now code in Chromium is the master, and the one in platform2 is just a mirror. BUG=None TEST=No real code change Change-Id: Ic29f281f1b95e057403f335e53d43dbc5606450d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151842Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759728}
-
Sebastien Lalancette authored
For now, the triggering of the alert still goes through BVC. This will change in a following CL, where triggering the alert will all be done under ActivityServiceLegacyCoordinator' scope. Bug: 1068606 Change-Id: Id27f298d1c71dd02c6f1c38cd8b370697b09dfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151106 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759727}
-
Xianzhu Wang authored
This reverts commit fc46d7d7. Reason for revert: Fixed telemetry_perf_unittests. Original change's description: > Revert "Collect reasons of disallowing LCD text" > > This reverts commit b79724f8. > > Reason for revert: Causing flaky failures in Mac10.14 Tests bot. > > First failure here: > https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3374 > > > telemetry_perf_unittests on (none) GPU on Mac failed because of: > measurements.rasterize_and_record_micro_unittest.RasterizeAndRecordMicroUnitTest.testRasterizeAndRecordMicro > > > > Original change's description: > > Collect reasons of disallowing LCD text > > > > (TBR for passive change in tools/perf/measurements/rasterize_and_record_micro.py.) > > TBR=wangxianzhu@chromium.org > > R=pdr@chromium.org > > > > Bug: 642885 > > Change-Id: Ia5c8313ea9e34139e06ff11fcc5d751ff0768c75 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149914 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#759474} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: Ic25a88c23e6f504461d3100fbf3bc8f8429c81f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 642885 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151450 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759562} TBR=wangxianzhu@chromium.org,pdr@chromium.org,guidou@chromium.org Change-Id: Ica3073d071e43b76f763012a2bc6c8403c0695a0 Bug: 642885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152771Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759726}
-
Devlin Cronin authored
Introduce a common views::test::WidgetVisibleWaiter helper class to enable tests to easily wait for a given widget to become visible, and use it in place of places that had similar functionality. Bug: None Change-Id: I4fda7baeef12ae33f47a47393a58396f917b65e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151343Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759725}
-
Mei Liang authored
Because TabContextObserver listens to TabModel changing events to invalidate TabSuggestion, closing the selected tabs before running the TabSuggestionFeedback callback results in using a null TabSuggestion for the callback. This CL addresses the null usage by running the callback before closing the selected tabs. Change-Id: I5f827d7cc6fb8d684f436b6dc30681086bc81aa7 Bug: 1063821, 1061991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147878Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759724}
-
