GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4e644f5..82b33db

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/975353004

Cr-Commit-Position: refs/heads/master@{#319154}

Test coverage is provided by native_app_window_cocoa_browsertest.mm
which now uses whichever implementation of NativeAppWindow is
instantiated.

Added a new sources list to minimize having to change BUILD.gn when
more files are added.

BUG=459877

Review URL: https://codereview.chromium.org/975043003

Cr-Commit-Position: refs/heads/master@{#319153}

This patch uses the unified JNI_OnLoad mechanism introduced in
http://crbug.com/447393 in mojo network service.

BUG=447393

Review URL: https://codereview.chromium.org/977843003

Cr-Commit-Position: refs/heads/master@{#319152}

BUG=464020

Review URL: https://codereview.chromium.org/968193006

Cr-Commit-Position: refs/heads/master@{#319151}

Review URL: https://codereview.chromium.org/921793004

Cr-Commit-Position: refs/heads/master@{#319150}

WebRTC 8573:8602
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/c9dfd1c..f30d5ec

Libjingle 8571:8600
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3b22f07..8fe2b96

TBR=sergeyu@chromium.org,magjed@chromium.org

Review URL: https://codereview.chromium.org/970513005

Cr-Commit-Position: refs/heads/master@{#319149}

ui::OzoneGpuTestHelper needs to be uninstantiated in TearDown() since it
creates a base::Thread which wants to register with the AtExitManager.
However the AtExitManager runs out of scope before the
testing::Environment.

BUG=447798
TEST=compile and run ./video_decode_accelerator_unittest (I had
https://codereview.chromium.org/938873002/ applied as well to make sure
tests succeed)

Review URL: https://codereview.chromium.org/949183004

Cr-Commit-Position: refs/heads/master@{#319148}

content_app_browser and content_app_child are designed to be used for Windows DLL, for android  we build browser and child process in same shared library, content_app_both should be used in Android.

BUG=464008
TBR=jochen

Review URL: https://codereview.chromium.org/970413002

Cr-Commit-Position: refs/heads/master@{#319147}

Take |draw_rect|'s coordinates and |BitmapData|'s point into
consideration in |FakeContentClientLayerClient| paint into DisplayList.

R=ajuma
BUG=

Review URL: https://codereview.chromium.org/984443002

Cr-Commit-Position: refs/heads/master@{#319146}

WebMediaKeySystemConfiguration is changing to use enums for
initDataTypes and sessionTypes, so update WebEncryptedMediaClientImpl
to use the enums.

BUG=418239
TEST=EME tests still pass

Review URL: https://codereview.chromium.org/979463002

Cr-Commit-Position: refs/heads/master@{#319145}

R=kalman@chromium.org
BUG=354046
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/977763002

Cr-Commit-Position: refs/heads/master@{#319144}

BUG=417532

Review URL: https://codereview.chromium.org/970943003

Cr-Commit-Position: refs/heads/master@{#319143}

EventFromNative() returns null when given a system defined event, so filter them
out when monitoring the event stream.
When running the experimental MacViews browser, I was seeing an event
with type=SysDefined subtype=7 (apparently it means that a mouse button
state has changed).

BUG=425229

Review URL: https://codereview.chromium.org/981693002

Cr-Commit-Position: refs/heads/master@{#319142}

For the select few times an overriding "operator new" is needed for a
GC class, provide the GC_PLUGIN_IGNORE() escape hatch for these. The
responsibility that the "new"'s allocation will be on the Oilpan heap,
rests with the implementor of the class.

R=haraken
BUG=443854

Review URL: https://codereview.chromium.org/975393002

Cr-Commit-Position: refs/heads/master@{#319141}

Make discarding the first result possible through Benchmark.ValueCanBeAddedPredicate (add a "is_first_result" arg to it).

The main motivation here is to eliminate special cases for PageTest methods/attributes in user_story_runner.Run.

BUG=440101

Review URL: https://codereview.chromium.org/962793004

Cr-Commit-Position: refs/heads/master@{#319140}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/235b088..ceac7ed

TBR=samli@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/980533003

Cr-Commit-Position: refs/heads/master@{#319139}

This CL adds CaptivePortalAuthenticationIgnoresProxy policy.

BUG=456839
TEST=manual

Review URL: https://codereview.chromium.org/818433003

Cr-Commit-Position: refs/heads/master@{#319138}

This was generated using the following command line:

$ tools/sort_sources.py tools/gn/gn.gyp

BUG=None
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/977603002

Cr-Commit-Position: refs/heads/master@{#319137}

It doesn't build in gyp configurations, either:
https://code.google.com/p/chromium/codesearch#chromium/src/build/all.gyp&l=342

TBR=brettw@chromium.org
BUG=464031

Review URL: https://codereview.chromium.org/979973002

Cr-Commit-Position: refs/heads/master@{#319136}

This CL adds google maps page to telemetry, and runs a synthetic drag
gesture on the page. This helps testing of maps page in telemetry to
track the performance on desktop chrome.

BUG=457148

Review URL: https://codereview.chromium.org/955653003

Cr-Commit-Position: refs/heads/master@{#319135}

186: Fixed bug 437524. There are paragraphs in policy description now.

BUG=chromium:464048
BUG=chromium:437524

Review URL: https://codereview.chromium.org/977623003

Cr-Commit-Position: refs/heads/master@{#319134}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b841060..4e644f5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/977163002

Cr-Commit-Position: refs/heads/master@{#319133}

This pulls in the following Native Client changes:

fad54f5: (bradnelson@google.com) Enable jecxz in 32-bit mode as jrcxz is allowed in 64-bit mode.
a482c21: (stichnot@chromium.org) Make sure toolchain_build_pnacl.py installs pnacl-sz.
0810cf2: (dschuff@chromium.org) Update newlib revision for x86 compilers
dac9220: (jvoung@chromium.org) Update libcxx known failures for "unexpected passes" after merge.

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/f4113241ff6535697cbb8646aa0436f332c16779..dac922075e8f2e020b3538133d619c02a5a0e4fa

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/963983004

Cr-Commit-Position: refs/heads/master@{#319132}

This adds pixel tests for checkerboard quads to verify we're able to
draw them, and another test where the quad is scaled.

R=enne, vmpstr
BUG=169624

Review URL: https://codereview.chromium.org/973223002

Cr-Commit-Position: refs/heads/master@{#319131}

This allows Precise builders using LLVM_FORCE_HEAD_REVISION to build
LLVM and Clang even though their system gcc and cmake are too old.

BUG=452726
NOTRY=true

Review URL: https://codereview.chromium.org/980633003

Cr-Commit-Position: refs/heads/master@{#319130}

Move the JNI registration to OnJNIOnLoadRegisterJNI.
Remove ChromeMainDelegateAndroid::RegisterApplicationNativeMethods()

TBR=jochen

BUG=447393

Review URL: https://codereview.chromium.org/970243003

Cr-Commit-Position: refs/heads/master@{#319129}

update unit tests.

The IPC perf tests do a lot of allocations which can, with large block
sizes, harm their performance. The high allocation counts also make
their performance very dependent on the quirks of the Windows heap, as
it applies undocumented heuristics to decide when to decommit memory
and when to save it for later.

And, doing unnecessary allocations is generally always a bad thing.

So, this change adds StringPiece support to PickleIterator (reading)
and Pickle (writing). The StringPiece function now handles all strings
when writing, but must be requested explicitly when reading.

ipc_mojo_perftests does more allocations than ipc_perftests. This
removes one message-sized allocation from both tests.

The unit tests were updated so that WriteString and WriteString16 are
exercised with both string objects and char/char16 arrays (no
allocations required!). Reading into StringPiece and StringPiece16 is
also tested and the tests were verified with:
out\Release\base_unittests --gtest_filter=PickleTest.*

The main performance test command line used was:

out\Release\ipc_mojo_perftests --gtest_filter=MojoChannelPerfTest.ChannelPingPong

Typical test results on HP Z620 (Windows 8.1) with thread affinity and
high-performance power settings prior to this change:
IPC_Channel_Perf_50000x_12      1140.01 ms
IPC_Channel_Perf_50000x_144     1182.55 ms
IPC_Channel_Perf_50000x_1728    1266.42 ms
IPC_Channel_Perf_12000x_20736   1289.19 ms
IPC_Channel_Perf_1000x_248832   584.619 ms

Typical test results with same settings but using base::StringPiece:
IPC_Channel_Perf_50000x_12      1123.33 ms
IPC_Channel_Perf_50000x_144     1164.53 ms
IPC_Channel_Perf_50000x_1728    1242.99 ms
IPC_Channel_Perf_12000x_20736   1186.84 ms
IPC_Channel_Perf_1000x_248832   496.469 ms

Modest improvement with small buffers, but significant speedup with large buffers.

Typical test results with large-blocks only prior to this change:
IPC_Channel_Perf_1000x_248832   1211.33 ms
IPC_Channel_Perf_1000x_248832   961.404 ms
IPC_Channel_Perf_1000x_248832   600.911 ms
IPC_Channel_Perf_1000x_248832   468.356 ms
IPC_Channel_Perf_1000x_248832   430.859 ms
IPC_Channel_Perf_1000x_248832   425.147 ms

Typical test results with large-blocks only (base::StringPiece):
IPC_Channel_Perf_1000x_248832   909.571 ms
IPC_Channel_Perf_1000x_248832   731.435 ms
IPC_Channel_Perf_1000x_248832   493.697 ms
IPC_Channel_Perf_1000x_248832   417.966 ms
IPC_Channel_Perf_1000x_248832   397.377 ms
IPC_Channel_Perf_1000x_248832   397.725 ms

Note that it takes a while for the Windows heap to 'realize' that it
should hang on to some of the large blocks which is why performance
increases over multiple runs.

Chrome will not immediately be affected because StringPiece reading has
to be explicitly selected. Note that the effect on ipc_perftests is
more variable due to the odd Windows heap heuristics.

Reliable results require setting the power plan to high-performance.
On Linux this is done with this command:
sudo cpupower frequency-set --governor performance

The ipc_perftests command-line is:
out/Release/ipc_perftests --gtest_filter=IPCChannelPerfTest.ChannelPingPong

Typical before/after Linux results for ipc_perftests are:
IPC_Channel_Perf_50000x_12      465.271 ms
IPC_Channel_Perf_50000x_144     480.224 ms
IPC_Channel_Perf_50000x_1728    510.871 ms
IPC_Channel_Perf_12000x_20736   318.016 ms
IPC_Channel_Perf_1000x_248832   309.325 ms

IPC_Channel_Perf_50000x_12      459.245 ms
IPC_Channel_Perf_50000x_144     479.347 ms
IPC_Channel_Perf_50000x_1728    506.57  ms
IPC_Channel_Perf_12000x_20736   289.583 ms
IPC_Channel_Perf_1000x_248832   255.083 ms

Before after Linux results for ipc_mojo_perftests:
IPC_Channel_Perf_50000x_12      670.727 ms
IPC_Channel_Perf_50000x_144     713.6   ms
IPC_Channel_Perf_50000x_1728    808.157 ms
IPC_Channel_Perf_12000x_20736   464.221 ms
IPC_Channel_Perf_1000x_248832   365.258 ms

IPC_Channel_Perf_50000x_12      653.12  ms
IPC_Channel_Perf_50000x_144     697.418 ms
IPC_Channel_Perf_50000x_1728    772.575 ms
IPC_Channel_Perf_12000x_20736   446.315 ms
IPC_Channel_Perf_1000x_248832   348.38  ms

So, consistent improvements on Linux.

Review URL: https://codereview.chromium.org/927183002

Cr-Commit-Position: refs/heads/master@{#319128}

The public method on the Error exception allows anyone with access to the
exception to append debugging information.

BUG=460625

Review URL: https://codereview.chromium.org/965063002

Cr-Commit-Position: refs/heads/master@{#319127}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9ff21de5..721fdb56

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/974333003

Cr-Commit-Position: refs/heads/master@{#319126}

Revert of Profile_Metrics integration with Keystone (patchset #20 id:530001 of https://codereview.chromium.org/593243002/)

Reason for revert:
crbug.com/463900. Mac crashed, like, all the time.

Original issue's description:
> Profile_Metrics integration with Keystone
>
> Chromium side of the implementation of tracking profile stats (number of profiles, number of signed in profiles) through the Omaha channel for Mac. Design doc: https://docs.google.com/a/google.com/document/d/15Ou8VCYNCZvke8Bw9bF3vYqD67voJBPyx_GBR8ONcCw/edit?disco=AAAAAKU7Zzg (Googler Only)
>
> BUG=409895
>
> Committed: https://crrev.com/0bcaa8e521eae39a81b4754f8b4ac9de1f0463d5
> Cr-Commit-Position: refs/heads/master@{#318729}

TBR=bcwhite@chromium.org,borisv@chromium.org,mark@chromium.org,grt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=409895

Review URL: https://codereview.chromium.org/974423002

Cr-Commit-Position: refs/heads/master@{#319125}

This reverts commit d87b7836.

Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src

Revert "MacViews: Unify web contents modal dialog types"

speculatively reverting this to solve browser CPM

BUG=463776

This reverts commit 5f1263bb.

Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src

Revert "Handle unsucessful JsonPrefStore initialization in SupervisedUserSettingsService."

this may be casuing an increase in rendererexit code.

BUG=463646

This reverts commit 0197d5df.

Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src

This is causing a huge amounts of renderer crashes because of RESULT_CODE_KILLED_BAD_MESSAGE.  Reverting this from master.

Revert "<webview>: Removed ResolveURL"

This reverts commit c2fc6144.

Cr-Commit-Position: refs/heads/master@{#319124}

BUG=440857

Review URL: https://codereview.chromium.org/963683006

Cr-Commit-Position: refs/heads/master@{#319123}

BUG=423481

Review URL: https://codereview.chromium.org/962863002

Cr-Commit-Position: refs/heads/master@{#319122}

Added a layer for Supervised Users in the HostContentSettingsMap.
As this only needs functionality to block the entire content setting
(for now), it is similar to the existing OverrideProvider.
Reorganized the common code between the two providers.
Updated the helper methods in PrefServiceBridge to check the
HostContentSettingsMap instead of Preferences when checking whether it
is managed by the custodian.

BUG=455646
BUG=455640

Review URL: https://codereview.chromium.org/902833003

Cr-Commit-Position: refs/heads/master@{#319121}

This change makes the DataReductionProxyInterceptor intercept redirects
as well as responses. This will cause clients on captive portal networks
that cause redirect loops when trying to use Data Saver bypass
immediately instead of waiting for 21 redirects.

BUG=460346

Review URL: https://codereview.chromium.org/958163004

Cr-Commit-Position: refs/heads/master@{#319120}

Otherwise, on Windows when 'All' is built the no-op build is broken --
no files are included in the .lib so none is generated, which means on
subsequent builds ninja always reruns that step.

This is currently breaking win_chromium_compile_dbg_ng trybots.

R=pasko@chromium.org, thakis@chromium.org
BUG=424562

Review URL: https://codereview.chromium.org/981623002

Cr-Commit-Position: refs/heads/master@{#319119}

WebRtcBrowserTest.CallAndModifyStream
RenderFrameHostImplBrowserTest.IsFocused_AtLoad
RenderFrameHostImplBrowserTest.IsFocused_Widget

BUG=464029,464033
TBR=mlamouri@chromium.org,phoglund@chromium.org

Review URL: https://codereview.chromium.org/977183002

Cr-Commit-Position: refs/heads/master@{#319118}

Refactor the way options are passed to ChildThreadImpl to make the
call sites easier to read and to make it easier to add a task runner
parameter later.

BUG=444764

Review URL: https://codereview.chromium.org/974933002

Cr-Commit-Position: refs/heads/master@{#319117}

BUG=464019
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/977853003

Cr-Commit-Position: refs/heads/master@{#319116}

This moves the Lollipop-specific code in BatteryStatusManager into a
separate method and annotates it with @TargetApi(LOLLIPOP) so appease
Android lint.

BUG=411461

Review URL: https://codereview.chromium.org/975963003

Cr-Commit-Position: refs/heads/master@{#319115}