- 12 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e21911cc1c77..aa7048b18b2f 2020-10-12 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from 2d8a12dca47a to f6bc2a9be76e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ibfc9b0d665a2c4d76a4624c2739ff4aee966f75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465562Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816068}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18d648b5376b..80292b0234ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1113941 Tbr: ortuno@google.com Change-Id: I386d26630c2210b6134a8593aee31cd341a0e769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465231Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816067}
-
Takashi Sakamoto authored
MTECheckedPtr requires 16-bytes aligned size when initializing or uninitializing tags. PartitionBucket<thread_safe> uses GetNewPartitionTag. The method should be public. Bug: 1092288 Change-Id: If238b881af351ec89b6b89ba6283dfc0830272e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348233 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#816066}
-
Ramin Halavati authored
WebApps popout is disabled for Guest sessions. Same restriction is added for ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ic6bde4313a5107f165eb00ac5d8c0e3ff1c9496f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461383Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#816065}
-
Ben Reich authored
Test that JS code coverage of a JS IFFE injected in a WebContents gets collected by DevToolsListener and stored in a ScopedTempDir. Test: browser_tests --gtest_filter="*DevToolsListener*" Bug: 1113941 Change-Id: I8f04f2e704d677823ffa154272605798b7046f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461602 Commit-Queue: Ben Reich <benreich@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816064}
-
Maggie Cai authored
Currently when we tab through the action bar we cannot focus on the sharesheet button. This CL fixes this issue and also add a test for this bug. The issue with the original implementation is because we disable the command when we are waiting for feedback from the C++ api, however when we tab through the action bar, the canExecute() is called and we cannot focus on the sharesheet button while tabing because the command is still disabled at the time. Changing the code to keep the command enable if the event target is action bar. This should be safe because in this event, there should be no change to the selected entry so if the button is visible at the time, it should be safe to be enabled. BUG=1136334, 1097623 Change-Id: I285bb7fe71322c05ae660fb02917126e7491b17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460854Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816063}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I53d0108dddfe307146a3e7e6544e1c4cdf5b1340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465230Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 0716d3fb. Reason for revert: New test is failing on Mac10.14 Tests First run that failed after test landed: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9213 ../../components/ukm/test_ukm_recorder.cc:156: Failure Expected equality of these values: expected_value Which is: 1 *metric Which is: 2 for metric:ThrottlingResult Stack trace: 0 browser_tests 0x0000000112ff5118 ukm::TestUkmRecorder::ExpectEntryMetric(ukm::mojom::UkmEntry const*, base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, long long) + 456 1 browser_tests 0x0000000106c92b55 (anonymous namespace)::LiteVideoBrowserTest_StopsThrottlingOnPlaybackSeek_Test::RunTestOnMainThread() + 2245 2 browser_tests 0x000000010d15c71d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 717 Original change's description: > LiteVideo: Stop throttling on playback seek events > > This plumbs the playback seek event from renderer to browser and uses it > to stop litevideo throttling. The seek updates to browser are throttled > for performance reasons. > > Subsequent CL will change this to stop throttling only after k seek > events (finchable), and record this in UKM. > > Bug: 1134672 > Change-Id: Idd88819e8ae50ffbc215197a437bf87d6fa9a36a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453801 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815787} TBR=dalecurtis@chromium.org,kinuko@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1134672 Change-Id: Ibf18e6a98dddad7d8bee8bd70ce1716d5668f180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462992Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#816061}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2ced51b9cda5..06e3f9cc6739 2020-10-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If6c2b012b5d3c4cf3cc4fddf91174479cc059f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465228Reviewed-by:
-
Nicholas Hollingum authored
This change allows GuestOsApps to be visible in the shelf/launcher, and associates its windows with those items. The behaviour is only partially completed, the current items will be finished in a forthcoming CL: - Support launching the apps from the launcher/pinned shelf items - Have context-menus for our shelf/launcher items. Bug: b/162562622 Change-Id: I7456fb8173cf1964663709fc015ba9cc9b79df12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454952 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#816059}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3345e5fdc5c4..68bd685a7643 2020-10-12 syoussefi@chromium.org Reland: "4 Vulkan content defined CLs." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I721ba60cba3b4ba56b362e032d72aba2b08660b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462073Reviewed-by:
-
Ramin Halavati authored
Taskbar decordator update is triggered for ephemeral Guest profiles similar to old Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I543b8966cbcf79e080ad2d537c0b4cd4455754ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460901Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#816057}
-
Kenichi Ishibashi authored
Before this CL, DeleteAndStartOver related tests are defined in ServiceWorkerResourceStorageDiskTest class. The class depends on in-memory representation of ServiceWorkerRegistration, but these tests don't necessary depend on ServiceWorkerRegistration. This CL (re)introduces ServiceWorkerStorageDiskTest class to host these tests. The class stores a service worker registration to perform DeleteAndStartOver related checks. This is a preparation to remove in-memory representations from service_worker_storage_unittest.cc Bug: 1016064 Change-Id: I53e094c97e761bf0fa6ea1efbda19edc3dd0daaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464516Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816056}
-
Keishi Hattori authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL/0 won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for more details. Bug: 1080832 Change-Id: I8534ad5e03624700692521a76413acf0e020adae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462965 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d71dc2d25b8b..2531de9926d1 2020-10-12 fmalita@chromium.org [svg] Add svg_tool If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ibf8eafc73c8770ee3bd9752f5438477fb6cb2056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465246Reviewed-by:
-
Bao-Duy Tran authored
Also, remove unused features from related Mock. Bug: 1134465 Change-Id: Ieba5fea1d0c97cfc5ca76f395a2e3ac7769e670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442393Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#816053}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07e1ccb91ca5..18d648b5376b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com Change-Id: Ibf31cfb29abdc0b4d087173bd03b1a42f7c20a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465226Reviewed-by:
-
Trevor Perrier authored
This CL logs the installed languages before and after SplitCompat.installActivity. This will help in understanding when different language packs become available. Bug: 1128698 Change-Id: I52d2efbcc870f1b76b766896fd0d22c0d720031f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461696Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#816051}
-
Kenichi Ishibashi authored
This CL removes some direct use of ServiceWorker{Storage,Database} from service_worker_storage_unittest.cc by exposing getters of uncommitted/purgeable/purging resource ids. The motivation of the removal of direct use is: * Some tests checks whether resources are uncommitted/purgeable/purging in various situations. * These tests depend on in-memory representations like ServiceWorkerRegistration. * These tests will be moved to service_worker_registry_unittest.cc because _storage_unittest.cc will be moved to the Storage Service where we can't depend on in-memory representations. * There is no access to ServiceWorker{Storage,Database} from service_worker_registry_unittest.cc because these are behind a mojo interface. Bug: 1016064 Change-Id: I1104cd10226941aacc11a4cd9228a81e94ee5d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460531 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816050}
-
Kuo Jen Wei authored
Parse profile/level codec information from codec name suffix and pass the profile/level down to VEA encoder. Bug: b/166378013 Test: ./blink_unittests Test: third_party/blink/tools/run_web_tests.py -t Default "fast/mediarecorder\*" Test: Pass 'video/x-matroska;codecs=avc1.640028,pcm' to MediaRecorder and verify it can generate high profile video on kodama. Change-Id: Ia87a8b2e634aa19e30baa51934e9e5f2d9dce543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413669 Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#816049}
-
Chinglin Yu authored
This improves the stability of ProfileProviderRealCollectionTest suite running on VM: * Increase the default collection duration. Default colleciton duration is doubled to 2 sec. Jankiness collection duration is increased from 0.5 sec. to 1.5 sec. * Create a thread that spins the CPU during profile collection. This ensures that the CPU cycles counter will move forward to trigger perf collection. Also improves error logging: on collection failure, log collection failure reasons recorded in the UMA metric. Bug: 1132045 Test: Run profile_provider_unittest on crosvm Change-Id: I600ace7500144398bb7ed56ed80a75fcb1df1907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449509 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#816048}
-
Charles Zhao authored
FileTasksNotifier::NotifyObservers. It's there only because the util::GetMyFilesFolderForProfile(profile) returns a different result than profile.GetPath().Append("MyFiles") for TestingProfile in unit tests. This fix basically using util::GetMyFilesFolderForProfile(profile) in both the lib and unit tests. util::GetMyFilesFolderForProfile(profile_).DirName() is used to make it also compatible with drive path in browser_tests, like /b/s/w/itMnZ3yB/.org.chromium.Chromium.skZUsj/user_data/user/drive/v2/root/Beautiful Bug: 1077163 Change-Id: I0a2cc3531929b29c0a4ef254d9db02dd4b789bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211583Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#816047}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I554caf2bb0df03c8bfe2e58ab007c67a81e8bcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465087Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816046}
-
Hirokazu Honda authored
Bug: None Test: None Change-Id: I679ee4f63d096c8d541853abad79ddc8c19617ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460406 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Joel Hockey authored
Currently any exceptions thrown in an async test function are not caught and the test will fail as a timeout. Added fix for GalleryJsTest.ImageViewTest which was throwing exceptions with undeclared metrics.record... functions. TBR=fukino@chromium.org Change-Id: I40ed5ff91a35ffd9a1c399d4d8405554e3fab911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459136 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL checks if GetAssociatedFrameWidget() is valid before GetStringAtPoint() since |blink_frame_widget_| from RenderWidgetHostImpl could be unbound at some point. So, like other methods in RenderWidgetHostImpl, TextInputClientMac::GetStringAtPoint() also check GetAssociatedFrameWidget() is valid. Bug: 1136471 Change-Id: Ia5a17e9ebf14bd0e3743b6236ddde0c08f0e4969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462921Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#816043}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d63a04e5f42..07e1ccb91ca5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126301 Tbr: ortuno@google.com Change-Id: I1727c08b01cbeb07b47e17a464fd94517851daf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465189Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602435952-75122ea47c8d583e550984a2ddfd8905dcd7dc7e.profdata to chrome-linux-master-1602460024-2af6533fe6c4354707f21413721100fe04991470.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7c73377799b05a1995dc2892f2c387f5da3dc083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465224Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602404911-8cb8d6b30ff4f5b6db561477b948fce92627a6e3.profdata to chrome-win32-master-1602435952-232be9ce3683aa917ade383918bb42eb3e64b0d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I74103bf60c200c430f3e09d1e7efd49a7c30efa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465322Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602435952-82a873ec16bc2a6b1b42a86c3a99be7dfd799bfc.profdata to chrome-mac-master-1602460024-4b69636ab7ebaae5b3fa848321845968d50cbe86.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9bd4e4629006658bcf62a5549acd7d553bcf7319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465223Reviewed-by:
-
Kenichi Ishibashi authored
This function is used by unittests which depend on in-memory representations like ServiceWorkerVersion. Expose it as a mojo test helper function so that these tests can be moved out service_worker_storage_unittest.cc. This CL doesn't move any tests. Subsequent CLs will move these tests. Bug: 1016064 Change-Id: Icc33be2dc0ddc186237cdd8ff731a11b678bfdc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462942 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
James Vecore authored
This is a temporary change to support scan response data in BLE advertisements for Nearby Share. Once the final API lands in bluez upstream we will need to revert this change (tracked here: https://crbug.com/1136920). This allows a map of byte (BLE type) to byte array (payload) to be supplied as the scan response for a BLE advertisement. Currently only a single type 0x16 is allowed in the map by bluez. The corresponding bluez change is here: https://crrev.com/c/2458306. A follow up CL will supply the scan response for Nearby Share. Bug: 1135699 Change-Id: I3e2c8098a7cfca2025f0c7cd5c6b631156e77de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459250 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#816037}
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: Iec97a98c8e86f1171495cca437a25d0422c947f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462892 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Eric Willigers authored
Various chrome/ files were needlessly including chrome_features.h and scoped_feature_list.h Bug: 1137231 Change-Id: I0587040f9a119c7f797713fb5265ba9675c96422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463033 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: Ieaa79c8ae89f96c164d5ac0995f9dadb3ed151ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462956 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
[Context] This is a part of an effort to achieve MBI. We want to avoid per-thread task runner as much as possible. [Previous code] ThrottlingURLLoader::url_loader_ was using per-thread default task runner because task_runner was not specified for BindNewPipeAndPassReceiver. [What this CL does] Use the given task runner for ThrottlingURLLoader::url_loader_ instead of per-thread task runner Bug: 1105403 Change-Id: I7da84124ac5f7adfea5327f3b976f8e45cb5d547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463262Reviewed-by:
-
Minoru Chikamune authored
[Context] This is a part of an effort to achieve MBI. We want to avoid per-thread task runner as much as possible. [Previous code] AssociatedInterfaceProvider::proxy_ was using per-thread default task runner because task_runner was not specified. [What this CL does] Use the given task runner for AssociatedInterfaceProvider::proxy_ instead of per-thread task runner. Bug: 1105403 Change-Id: I1dae802f85f0a9c55e5979ee24297d291a43cd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462967Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66780b765bde..1d63a04e5f42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com Change-Id: I0b3211f80e406ec6700ee7c6445e7d7377bed678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465382Reviewed-by:
-
Eric Willigers authored
Various apps and web applications files were needlessly including chrome_features.h and scoped_feature_list.h Bug: 1137231 Change-Id: Ie7f2988623b5a3ab146ec37115a869d56a629ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463271 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#816030}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602435952-822a73fed63e487694819102d0cc422571aed79f.profdata to chrome-win64-master-1602448744-d06fc1e3f11f340d5ab319c12d5a6fb4491c2b6c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8064278ac44cae1a028cc06832aa3831e70efa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465186Reviewed-by:
-
