- 14 Feb, 2020 23 commits
-
-
Dominic Mazzoni authored
I made these categories of histograms expire never, for now (understanding that this may be done automatically at some point): * Core histograms that track usage of an important accessibility feature * Histograms that track a system setting that's important for accessibility In both of those cases, we look at long-term trends of those histograms to see how usage is growing and to determine how many users might be affected by potential changes. We shouldn't let those expire. I left alone any accessibility histograms that are tied to a smaller option or experiment. Many of those should expire after a while. Bug: 1045994, 1045992, 1041514, 1036908, 1036905, 1036904, 1036902, 1006995 Change-Id: I2104ebf2df81f0ac4d090f87ea2dfca06ad4c92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036484Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#741285}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3ebc4f9..4deaf25c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibc7c56472829512d29736ffe1abe036fc3c80e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054567Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741284}
-
Collin Baker authored
Bug: 1043374 Change-Id: I02be554b2346ff53b226fc783db565e3e02c37bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045031 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#741283}
-
Olivier Li authored
There is nothing wrong with having coverage in those files but for some reason my crrev.com/2046404 change that includes them breaks angle_unittests by making code coverage tooling add some output to stderr of one of their binaries. Until the problem of the stderr output is resolved I need a way to pass CQ. Here I'm adding the files I think are causing the problem to see if my cl will pass CQ after. Bug: 1051561 Change-Id: I14c4b195bda151bbddc57fdd573b2c93c2a59b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054527 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741282}
-
Eric Willigers authored
The HostedAppPWAOnlyTestWithAutoupgradesDisabled tests have been moved to PWAMixedContentBrowserTestWithAutoupgradesDisabled as they no longer depended on the extensions-based implementation. Note that the HostedAppTestWithAutoupgradesDisabled and HostedAppPWAOnlyTestWithAutoupgradesDisabled tests in hosted_app_browsertest.cc have not been run recently, as there was no INSTANTIATE_TEST_SUITE_P entry for these tests. Some mixed content now loads with warnings (due to security changes that occurred while the tests were not enabled). Previously landed as https://chromium-review.googlesource.com/c/chromium/src/+/2049407 and reverted due to linux-chromeos-chrome failures. Bug: 1026808 Change-Id: I4328328da72001d9005abe3792d8a30e02d684b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054604 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#741281}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04a7136fd704..6a950951c780 Created with: gclient setdep -r src-internal@6a950951c780 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044252 Tbr: jbudorick@google.com Change-Id: Ic27f3c35aae0fd86baee534a9b092e1dbb8ba23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055768Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741280}
-
Austin Tankiang authored
ThumbnailLoader generates thumbnails for drive files from the file if the file is cached locally. Bug: 1043068 Change-Id: Ib8f3f795923316fff37cdef7eebf3004c5b3e43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049409Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#741279}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e90568eeef90..f9f999f5a2eb git log e90568eeef90..f9f999f5a2eb --date=short --first-parent --format='%ad %ae %s' 2020-02-13 jonahr@google.com Implement HostMappedForeignMemory DeviceMemory Created with: gclient setdep -r src/third_party/swiftshader@f9f999f5a2eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1965434 Tbr: swiftshader-team+autoroll@google.com Change-Id: I5f8df80eb8b139a1de7991252541a3f0ddeae517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055493Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741278}
-
Kent Tamura authored
According to https://html.spec.whatwg.org/C/#face-submission-value, the initial value should be null, not an empty string. Bug: 1051292 Bug: https://github.com/whatwg/html/issues/5263 Change-Id: Ifa92aaca47bfce1e51aa0fd3dc9ebb9ab9b15d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050148Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#741277}
-
Eugene But authored
Metadata in additional information which can help to find steps to reproduce the crash. This CL adds the following metadata: For DidStartNavigation event: - navigation-id (this allows to match corresponding DidFinishNavigation, which has different set of metadata) - #ntp (this allows to ignore noise like Opening NTP Tab, but still keep useful information like going back to NTP) - #renderer-user (indicates that user interacted with the page causing a navigation) - #renderer-script (indicates client side redirect) For DidFinishNavigation event: - navigation-id (this allows to match corresponding DidStartNavigation, which has different set of metadata) - #download (indicates download navigation) For PageLoaded event: - #ntp (this allows to ignore noise like Opening NTP Tab, but still keep useful information like going back to NTP) - #success/#failure (converted existing ": Success"/": Failure" strings for consistency) Bug: 1046223 Change-Id: I0f5586ab182d81c6157ad2a40180200e4ee82c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045205 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#741276}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b28e57e72580..0618cbc98994 git log b28e57e72580..0618cbc98994 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 peah@webrtc.org AEC3: Avoid heap-allocations in sums of the values in nested vectors 2020-02-13 philipel@webrtc.org Added java interface VideoEncoderFactory.VideoEncoderSelector and implemented VideoEncoderSelectorWrapper. 2020-02-13 kthelgason@webrtc.org Update RTCEncodedImage to not use deprecated mutable_data call. 2020-02-13 oseg@google.com Use webrtc::DataRate when referring to bitrates 2020-02-13 minyue@webrtc.org Add AbsoluteCaptureTimeReceiver to audio ChannelReceive. 2020-02-13 sprang@webrtc.org Refactors UlpFec and FlexFec to use a common interface. 2020-02-13 alessiob@webrtc.org iSAC unit test: test encode/decode via API wrapper 2020-02-13 alessiob@webrtc.org iSAC fixed point: fix int overflows 2020-02-13 kron@webrtc.org Populate sdp_fmtp_line and channels of RTCCodecStats Created with: gclient setdep -r src/third_party/webrtc@0618cbc98994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052086 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieb593888521ca005aef66414b5b2166888ecec9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055375Reviewed-by:
-
Brian Ho authored
This CL hooks up all of the previous work on Ozone-based SharedImages with the WebGPU pipeline by setting the interop factory to SharedImageBackingFactoryOzone on Chrome OS. The only valid usage right now is for shared images to be used with WebGPU and GLRenderer as only ProduceDawn and ProduceGLTexture are implemented in the shared image. Bug: 1023997,996470 Change-Id: I95f27e9b9d161aeb198839f316917a6e1eb48a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912831Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#741274}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55f040bcb943..475def0059a2 git log 55f040bcb943..475def0059a2 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 bryct@amazon.com Update Skia build instructions in build.md 2020-02-13 fmalita@chromium.org Undo suspect gn format 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 mtklein@google.com move clamp until just before store 2020-02-13 mtklein@google.com skvm support for 888x, 1010102, 101010x 2020-02-13 egdaniel@google.com Remove all remaining uses of origin getter on proxy. 2020-02-13 benjaminwagner@google.com [infra] Pin iOS tasks to old libimobiledevice 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 robertphillips@google.com Revert "Carve some helper functions off of GPUSink" 2020-02-13 egdaniel@google.com Store render target dirty msaa rect in real dst space. 2020-02-13 kjlubick@google.com Remove chromecast jobs 2020-02-13 robertphillips@google.com Carve some helper functions off of GPUSink 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 robertphillips@google.com Add createBackendFormat and createFBO0 helper methods to SkSurfaceCharacterization 2020-02-13 fmalita@chromium.org [skottie] Refactor keyframe encoding 2020-02-13 bsalomon@google.com Update texel_subset_* GMs. 2020-02-13 robertphillips@google.com Add makeNotCurrent to TestContext 2020-02-13 reed@google.com threshold rtshader 2020-02-13 mtklein@google.com more sophisticated opacity in SkImageShader 2020-02-13 mtklein@google.com relax asserts to what we'd clamp to 2020-02-13 mtklein@google.com extend opacity tests in SkVM blits 2020-02-13 brianosman@google.com Harden runtime shader/colorfilter CreateProc against bad child counts 2020-02-13 bungeman@google.com Skip degenerate contours in glyphs. 2020-02-13 mtklein@google.com more MSAN dbg->rel cycling Created with: gclient setdep -r src/third_party/skia@475def0059a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I1b0cf5a13907290ad4abb2eacbb24b057d1011db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055374Reviewed-by:
-
Xing Liu authored
Download.InterruptedReason is a core metric used in download dashboard. Bug: 1037486 Change-Id: If33a8802509561607c1e84be4e5094ec35f45cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048910Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741272}
-
Tao Bai authored
This make the DEPS clear. Bug: 1042048 Change-Id: Ia66d2158080f9f63856adb1dca583733a9d246b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055594Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#741271}
-
Anand K. Mistry authored
Changes: - Update to new-style MOCK_METHOD - Add constants for active directory auth - Remove unused test fixture member variables - Rename kMountPath to the more appropriate kShareUrl This is to prepare for additional unit tests for mounting using SmbFs. Bug: 939235 Change-Id: I848ca10e04ed9646faa6f1df9b8b62eaeb1636be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055904Reviewed-by:
-
nancy authored
This is the follow up based on CL:2050217 review comments. BUG=1051066 Change-Id: I22011a7bfded29ad0b976a648a8429be40484ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053664Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741269}
-
Piotr Bialecki authored
Mostly mechanical change: - move maps that track plane state to a separate ArCorePlaneManager class - make some of the helpers shared between arcore_impl.cc and arcore_plane_manager.cc (scoped arcore objects, conversions from ARCore entities to mojo for cases where ArSession* is needed) - instead of passing mojo's `const TypePtr&` around, pass `const Type&` Step 1/N - preparing from creating anchors from hit test results since plane state will need to be tracked independently from plane detection feature - hit test feature will also need to be aware of the planes. Change-Id: Ic4cc008ce4466e85fe65b3901a4848ebb03d6dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055587Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741268}
-
Manu Cornet authored
Bug: 1050383c Change-Id: I3f6e1478366ec772d751c2cc6cd967a8b66ba9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055804 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741267}
-
Ted Meyer authored
Allows MediaError to be passed through mojo IPC calls. Bug: 1043289 Change-Id: I4bfe3abcf68cad38fdbe5d81d9e77a3e90acd1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023952 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741266}
-
Noel Gordon authored
The directory-tree/splitter-bar has no border in files-ng. Remove it. Bug: 992819, 1002790 Change-Id: Id85c3c1d6649e54275d05ea713a93f1c8af703f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055944Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Alex Danilo authored
Bug: 992823 Change-Id: I7de99801293d1fe2b25ba8e5a7f072f6f5014e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053647 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
Make sure history navigation actually started before pausing the virtual time, as LocalFrameClient::NavigateBackForward() may cancel the navigation. Bug: b/149431317 Change-Id: Ie5ff73d3bc6bc042d381e9f496aea6c8c4c9243a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055559 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#741263}
-
- 13 Feb, 2020 17 commits
-
-
Avery Musbach authored
You shall not be able to end overview by pressing the overview button with one finger, while dragging the split view divider with another finger. It causes a DCHECK failure. Test: manual Change-Id: Ie48e19a9fe9a21e45313e16cc5a353adb9eada64 Fixed: 1052163 Bug: 1052163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055886 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#741262}
-
Alex Danilo authored
Bug: 992823 Change-Id: I5ef0685d012e02080d72c00a98b6be444de8ac26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053466 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Peng Huang authored
BeginWriteSkia() call is not cheap, moving it out of the criticl code path can improve DrawToSwapUs metric about 700us for poster circle page. Bug: None Change-Id: Ib905694983703b2ffff2f4deadf777546c4bae23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053292Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741260}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/951c1df3ce7d..07a952baa2fe git log 951c1df3ce7d..07a952baa2fe --date=short --first-parent --format='%ad %ae %s' 2020-02-13 thestig@chromium.org Remove spurious calls to GetPDFPage(). 2020-02-13 thestig@chromium.org Assert CPDFSDK_Annot::GetPageView() never returns nullptr. 2020-02-13 thestig@chromium.org Delete unneeded cruft from fpdfsdk/cpdfsdk_annot.h. 2020-02-13 tsepez@chromium.org No need to buffer CSS comments 2020-02-13 thestig@chromium.org Use UnownedPtr in |CPDFSDK_InteractiveForm::m_Map|. 2020-02-13 thestig@chromium.org Convert IPDFSDK_AnnotHandler::NewAnnot() to return std::unique_ptr. 2020-02-13 thestig@chromium.org Remove a redundant call to GetRadioButtonAppStream(). Created with: gclient setdep -r src/third_party/pdfium@07a952baa2fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ib0edf10a5e093b5498c9af9567d02fd11647df46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055488Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ee86e5a4697..ca1907e58b82 git log 9ee86e5a4697..ca1907e58b82 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 ehmaldonado@chromium.org Revert "gerrit-util: Fix GCE check from behind proxy." Created with: gclient setdep -r src/third_party/depot_tools@ca1907e58b82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050380 Tbr: agable@chromium.org Change-Id: I71c79073915baa8fe677964a312c474c6b7d3f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055369Reviewed-by:
-
Jinsuk Kim authored
This CL adds new metric EphemeralTab.OpenInNewTab/NavigateLink. Also make sure the UI for the feature OpenInNewTab won't appear if it cannot be activated. Bug: 1046619 Change-Id: Id42dba33f5f5fb28304fdfda0fcd77d93bb79221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045692Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#741257}
-
Chris Blume authored
Right now, users of PaintImage need to do some roundabout work to determine if a PaintImage is sRGB or not. This CL makes it just a tad friendlier to do that work. Bug: 955158 Change-Id: Iac22e880463b812988db72c281ffaa5c529e2726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055416Reviewed-by:
-
Steven Bennetts authored
This addresses a minor issues related to IP config (see bug) and includes some cleanup to improve type checking. Bug: 1051905 Change-Id: I1eec648b814ba64fdd044d9adfb1587b4ebcd8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055403Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741255}
-
Christian Biesinger authored
The CSSWG has approved a resolution to update the spec; these tests match that resolution: https://github.com/w3c/csswg-drafts/issues/4531 R=vmpstr@chromium.org Bug: 991096 Change-Id: I021e5fb2b14eb5049cf7077e06c79810fd60e622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055740Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741254}
-
Rayan Kanso authored
Currently the minimum size matches the ideal size. Make the minimum size in px equal to half the the ideal size. Change-Id: Ib5a68f5e0073ced276afa095ded61ce7c264573d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055103 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Darwin Huang authored
- Split Raw Clipboard functionality out into a separate mojo interface. - Check this new interface for permission in the browser process. - Adjust Clipboard API plumbing to pass ExecutionContext instead of clipboard hosts. Raw/Unsanitized clipboard access has significantly higher security and privacy implications than sanitized clipboard access. A separate mojo interface this distinction clear, and makes it easier to check for this permission in the browser process, in case of compromised renderers invalidating the renderer-side check. Bug: 897289, 1034023 Change-Id: I68b4781ccb3e29d38c344f2b2c1919c7d674e052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016200 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741252}
-
Joey Arhar authored
This reverts commit 07d811aa. The change this reverts fixed http://crbug.com/773680 which was intended to fire change events for detached radio and checkbox input elements when using input.dispatchEvent(new MouseEvent('click')), but also caused input.click() to fire change events. Although these may seem to be the same thing, firefox actually fires change events on input.dispatchEvent but not input.click(). WebKit, and chrome before the patch this reverts fire change events in neither of these cases. I will file an html spec issue to address this compat issue. For now, it seems important to stop firing these change events because it is getting more attention than the lack of change events. Bug: 773680, 1051482 Change-Id: Ia8217d34bf9a20c50ce008630e748a7dbda52c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055590Reviewed-by:
-
Isabella Scalzi authored
Bug: 803259 Change-Id: I990bad26b03e290a04da305933dc0d223502ea4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055943 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Avery Musbach authored
OverviewWindowDragController::ActivateDraggedWindow relies on the fact that kMinimumDragDistanceDp is less than or equal to kWindowMargin. If either or both constants were modified so that this condition is not met, then there would be an obscure bug where you drag an overview item from a display where split view mode is active, and you drag to another display but by a distance of less than kMinimumDragDistanceDp. Then the window would be snapped on the destination display, but the check for snappability would be with respect to the source display, and so you could trigger a DCHECK failure by snapping a window on a display where it is not snappable. Bug: 961170 Change-Id: I0fbf16b50ae2cb5dbd9a5dbefd8317cc9f1e9a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055349 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
Brian Salomon authored
Bug: 1052146 Change-Id: I5cd71b39de03ab1b7c0e303080f9ab81cecd4b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055557 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#741248}
-
Xianzhu Wang authored
PaintChunk::bounds includes bounds non-drawable display items. Add PaintChunk::drawable_bounds to include drawable display items only, and use it in paint chunk raster invalidation. This is a preparation for crbug.com/937573 which will create more non-drawable display items, to avoid unnecessary raster invalidation. Bug: 937573 Change-Id: Ib54ff89fff091fae1701e636808043b8cbfffe69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052254Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741247}
-
Andrew Xu authored
There are two issues in the current code: (1) ScrollableShelfView::GetTargetScreenBoundsOfItemIcon is used to calculate the target bounds of the animation. However, that function assumes that shelf is horizontally aligned. (2) ScrollableShelfView::drag_icon_ is created when moving an icon to a different shelf page. There is an edge case that the user drags an icon from AppListView and meanwhile drags it to a different page. In this case, |drag_icon_| is created but never destructed. This CL fixes the above two issues. Bug:1052123 Change-Id: I463bb5a672ed309ee674618c36ae743711927739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053150Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741246}
-
