- 17 Apr, 2020 25 commits
-
-
John Z Wu authored
Token fetches by the client may fail for any number of reasons. The errors should be categorized and returned to //ios/web_view for internal handling. Bug: 780937 Change-Id: I84e15d8f43ad8ca1fca8f9be41d82fad0cae6421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153337 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#759896}
-
My Nguyen authored
AssistiveWindowControllerImpl is not called directly but called through ImeAssistiveWindowHandlerInterface so its overridden methods do not need to be public. Also remove extra comment and variable. No-Bug: Clean Up Change-Id: I51e9df427d937c12e26d0b2fed63f16619bdbfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153176Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759895}
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/3d3ac5e6f58a..c906d361bd62 $ git log 3d3ac5e6f..c906d361b --date=short --no-merges --format='%ad %ae %s' 2020-04-15 huangdarwin Fix a case when a pointer might be used after being freed in the ALTER TABLE code. Fix for [4722bdab08cb1]. 2020-04-14 huangdarwin In the event of a semantic error in an aggregate query, early-out the resetAccumulator() function to prevent problems due to incomplete or incorrect initialization of the AggInfo object. Fix for ticket [af4556bb5c285c08]. Created with: roll-dep src/third_party/sqlite/src Bug: 1070012 Change-Id: Ib6b8271a20064a846d6be69ba022cff57b4b5730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153576 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759894}
-
Devlin Cronin authored
Remove the permission warning for externally connectable sites. This warning previously indicated that an extension could "Communicate with cooperating websites", and was shown when an extension specified "externally_connectable" in the manifest with any "matches" (i.e., websites). This allowed websites to message extensions via runtime.sendMessage() and runtime.connect(). This wasn't very useful. Any extension can communicate with cooperating websites without this capability, e.g. by being specified in the cooperating sites' ACAO, and just making an ordinary CORS request. This requires no permissions, because it is a normal web capability. (There are also other ways extensions can communicate, e.g. through web_accessible_resources). Remove the warning. Bug: 469602 Change-Id: I8663125f268b4e031a0a83c4dd0fd886cc2a6457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148249Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759893}
-
David Black authored
Opening of Assistant search results is delegated to the Assistant Controller as it knows how to handle Assistant deep links. Known issue: - Launcher eagerly closes when opening search results. We will need to do a follow up CL to make this behavior conditional since more often than not Assistant search results will need to open in-Launcher embedded Assistant UI. Bug: b:146673437 Change-Id: Ifc0e3bd5bde0ecb574ef9469d3e55968ad51fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153343 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#759892}
-
dpapad authored
Migrating everything in that folder, except search_engines_browser_proxy.html/js which is still used by CrOS Settings and therefore still has to be generated at build time. Bug: 1069258 Change-Id: Ifd48616cdc4a8d2075b115c9e47511e69945cdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151891 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759891}
-
Ayu Ishii authored
Bug: 1070609 Change-Id: I5953f73eae729a314fa41927df22020a3ba60236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135018Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#759890}
-
Sophie Chang authored
Bug: 1054519 Change-Id: If6d80ceee4d01b95a8bfca7dc7f894afee14c097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153577 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#759889}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8116c488ae96..f93cc8bda48d git log 8116c488ae96..f93cc8bda48d --date=short --first-parent --format='%ad %ae %s' 2020-04-16 timvp@google.com Vulkan: Skip failing BlendIntegerTest tests 2020-04-16 jmadill@chromium.org Vulkan: Make staged clears store aspect mask. 2020-04-16 jmadill@chromium.org Vulkan: Forward RenderBuffer/Surface dirty messages. 2020-04-16 jmadill@chromium.org Pass binding enum to Framebuffer::syncState. Created with: gclient setdep -r src/third_party/angle@f93cc8bda48d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Iaa5400fed809de24535aa1d3a5c46e599aca2ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153877Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759888}
-
Mike Wasserman authored
Bug: 994889 Change-Id: I9aa8225c2508b7390914ec220a840de329520ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152776 Auto-Submit: Michael Wasserman <msw@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#759887}
-
Reilly Grant authored
These tests use BluetoothTest to create a platform-specific fake adapter. Since FidoBleDiscovery uses BluetoothAdapterFactory to get the BluetoothAdapter SetAdapterForTesting() must be called to register this fake adapter with the factory so that the tests use the right one. Bug: 1071677 Change-Id: I3cc53f39bbd492a0901e334cea0308c65fde4b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153938Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759886}
-
Devlin Cronin authored
Bug: 1060749 Change-Id: I3abf19298f0ec871b8e26e442569e0cfdeff4386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153928Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759885}
-
David Roger authored
In some rare cases (such as a network request hanging), the user is able to start a new signin flow while one is already in progress. This causes the policy manager to crash, as it doesn't support multiple flows. Beside this crash, this would also result in bad user experience, since both signin flow would trigger (possibly conflicting) dialogs. This CL keeps track of the current signin flow and cancels any existing flow when a new one starts. Fixed: 1061459 Change-Id: I5cda95fab6b7b5a6f75372685a0d5c9ae02a59a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115617 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759884}
-
dpapad authored
Bug: 1069258 Change-Id: If45a412efd3194aef806e2e3084cd0bc31667bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152995 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759883}
-
Johann authored
Change-Id: I6ac521afd6daa88556801e23ca3d7668e628f6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152133Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#759882}
-
Joao Victor Almeida authored
There are some definitions of ClampToRange functions within Blink avoiding the usage of base::ClampToRange. But there are already dependencies from Blink to base/numerics and to other clamping functions in base so it doesn't appear to be any particular reason to exclude this from the allowed dependencies. Bug: 1071230 Change-Id: I2c99eddafe79020490d3dcf722aab5c1dce56140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153757Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759881}
-
Johann authored
Artifacts can be removed after the clang prebuilt is updated. Change-Id: I473c22843445745a39d1fc648a7bbcc336631b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152329Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#759880}
-
Natalie Chouinard authored
This is a first step towards modularizing SettingsLauncher. See go/clank-modularize-settings-launcher for full details. Bug: 1054193 Change-Id: Ib073e60aacce51ff7948621fc35c3bf2d6d68988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149885Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759879}
-
Bugs Nash authored
Bug: 1071320 Change-Id: Idb3a0fb5e1f6bba1a37ae22c785c1a1a56625b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151771Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#759878}
-
Meredith Lane authored
This reverts commit 0fbb4553. Reason for revert: Broke the chromeos-amd64-generic-rel build: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/41896? Original change's description: > [cros search service] Remove mojom and async API > > This cl removes all mojo and async APIs without moving files or > changing file names (which will be done in later cls). > > Bug: 1064424,1018613 > Change-Id: Ie92967aa37723e31557487aeb96bc9eed3458b39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151376 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759848} TBR=dcheng@chromium.org,blundell@chromium.org,jiameng@chromium.org Change-Id: Ica10760e53a1a95a0e25cd4b8c6370043e0adec1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064424, 1018613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153172Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#759877}
-
Sammie Quon authored
This will allow us to skip restoring external display bounds when heading to ACTIVE session, and instead restore on Display added during a lock state. Test: added test, manual Bug: 1033263 Change-Id: I4bb91fc7db6f7423ce8280465e783cfc4f468dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134570 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#759876}
-
Liquan (Max) Gu authored
Before: * The security icon on the toolbar did not have content description, i.e, when the accessibility assistant did not speak when users focused the security icon. * The mediator uses static methods from these classes that make it hard to test: - SecurityStatusIcon - SecurityStateModel - PageInfoController After: * The security icon has a content description. The description is the same as the one used on custom tab toolbar. * The static methods are invoked from the coordinator Change: * Add content description to security icon. * Move the classes with static methods out of the mediator to make it testable. Bug: 1067659 Change-Id: Icd21f0578492e9b9b595cd06909049839c6eed85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140956 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759875}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0145e0512c2..800a89ae20a4 Created with: gclient setdep -r src-internal@800a89ae20a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: Ibb330577d38e25778f15fea64e6425045a8bdee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153865Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759874}
-
Adenilson Cavalcanti authored
Document the optional compression strategies supported by zlib_bench. Bug: 798943 Change-Id: Ic4e1a89163bef087d424467710a016edf5bad242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152780Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759873}
-
Scott Violet authored
At the time OnNavigationStarted() is called it's not safe to call Navigate(). This patch delays the navigate until it is safe (when NavigationThrottleImpl::WillStartRequest() is called). BUG=1070569 TEST=NavigationBrowserTest.NavigateFromRendererInitiatedNavigation Change-Id: Ia110bb94e64d6551c9db302ae41b735ad5a8a5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153758Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#759872}
-
- 16 Apr, 2020 15 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a8817db1767d..6af2de8b2aa5 git log a8817db1767d..6af2de8b2aa5 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 thestig@chromium.org Use FT_LOAD_PEDANTIC in CFX_GlyphCache::RenderGlyph(). 2020-04-16 dhoss@chromium.org Change implementation of CPDF_FormField::IsItemSelected() 2020-04-16 dhoss@chromium.org Add unit tests for CPDF_FormField::IsItemSelected() 2020-04-16 bravi@microsoft.com Added URI Action handling public API and its test cases 2020-04-16 nigi@chromium.org Fix embedder test FPDFFormFillEmbedderTest.BUG_1281 for Skia. 2020-04-16 dhoss@chromium.org Capture existing multi-select list box behavior with more tests Created with: gclient setdep -r src/third_party/pdfium@6af2de8b2aa5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063609,chromium:994500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I468d30ad3ca5077a15c9835f3bc5ba22487264e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153876Reviewed-by:
-
Sujie Zhu authored
Add sub-histogram Autofill.FormEvents.CreditCard.WithServerNickname to log form events when any server nickname is available and calculate the CTR and suggestion selection rate to see whether having a server nickname available make it easier for users to select the card they want and submit the form. Note that we will compare selection rate only for the same group of users who have server nicknames, which means for the Control group we will also log to CreditCard.WithServerNickname if the user has any masked server cards with a nickname, but we won’t display the nickname in the UI. For Enabled group, we will log and show nickname when nickname is available. We will compare the Experimental and Control group’s selection rate from this CreditCard.WithServerNickname. Add a boolean to credit_card_form_event_logger to represent whether user has any server nicknames, and put nickname logging in the OnLog() by which all related form events can be additionally logged to specialized sub-histograms. Metrics design (googlers only): https://docs.google.com/document/d/1SfrBduc3gJrouT4zLmQHWtUPtcE-9JbkBGLHYgFLTFc/edit?ts=5e50549a#heading=h.olagc6jelr42 Bug: 1059087 Change-Id: Ia82172c6d7673cbb5744b0d6fc43ab8968d8c036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150028 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#759870}
-
Luciano Pacheco authored
Follow up work from CL:2126340. Fix #include problems pointed by "git cl lint". Bug: 1064822 Change-Id: Ia393c4f82601007e198d37ae9a7fcb1aae915bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148980 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#759869}
-
Daniel Clark authored
Since the ColorPicker's resize event listener is registered asynchronously during another event callback, it is possible for it to be registered too late to catch the resize event fired as a result of the resizeWindow() call in initializeColorPicker(). The resize event listener is responsible for setting the initial focus on the ColorWell, so when it's missed focus remains outside of the popup. This change moves the addEventListener to occur synchronously during the ColorPicker constructor so that it will never attach too late. There's no test because I couldn't get this to repro in a test environment. I've only seen it occur reliably in full Chrome (not content_shell) with Narrator running, presumably because generating the AX tree changes up the timing enough to expose the issue. Change-Id: I752d86b3d9bf3c1462afd1705b8ce15aee28ef76 Bug: 1026183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148158Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759868}
-
Devlin Cronin authored
Move views-related extension_action_test_helper* files from chrome/browser/ui/views/toolbar to chrome/browser/ui/views/extensions. They make more sense there. Bug: None Change-Id: I5f8a6c95bdda72a910f9645dc5f3946f0e148bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153703 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#759867}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9bd480acdcad..0aa745498c75 git log 9bd480acdcad..0aa745498c75 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 gijosh@google.com Fix bazel build win: Correct which isspace override is used Created with: gclient setdep -r src/third_party/perfetto@0aa745498c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2565f2ca7bdd8ec5f045a1928ab04aff17df190b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153874Reviewed-by:
-
Wenyu Fu authored
Getting Xml vector drawables on K- devices would cause failure. Using AppCompatResources instead. Bug: 1071414 Change-Id: Ide48b1f0e968e4c36e7038257e9e8f59376ae7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153688 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759865}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6415dcad7a71..4479a822c03f git log 6415dcad7a71..4479a822c03f --date=short --first-parent --format='%ad %ae %s' 2020-04-16 deadbeef@webrtc.org Remove deprecated SSLIdentity methods that return raw pointers. 2020-04-16 sprang@webrtc.org Makes dynamic pacer select paddig target based on rate. Created with: gclient setdep -r src/third_party/webrtc@4479a822c03f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I20c784d96c6fb5e848028ca582fc39ff6b0438b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153870Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cbe06ba1. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 6726f965 "Added the 'light-estimation' XR feature descriptor" 5dd1d8e7 "SVG: Increase hit-testing precision on strokes" 665c5c60 "[css-flexbox] Move mainAxisExtent-crash.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I566146493a4dc13dc8863a6a61cc108e058bd1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153269Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759863}
-
Noam Rosenthal authored
Change-Id: I29ec0ba9262d4a41e7b6fc51c3c546c41670cc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144277Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#759862}
-
Jinsuk Kim authored
The previous CL was broken due to a bug not updating the currently active tab ahead of triggering the init-web-contents observer manually. This CL ensures the active tab is updated first. The actual diff showing the bug fix is https://chromium-review.googlesource.com/c/chromium/src/+/2151377/1..2 TBR for WebContentsUtils as there's no change in that class. TBR=dtrainor@chromium.org Bug: 1070516, 1067524, 1070542, 1067524 This reverts commit dc423f43. Change-Id: I8cdbe210256d49483e39ccf2f7060af0a23b1487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151377Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7d3bcd17..a3564739 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0f53cd21b8f1ba4c47970546096f4982944f17cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153270Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759860}
-
Rahul Arakeri authored
This CL adds a base::Feature kElasticOverscrollWin to toggle elastic overscroll on Windows. Note that Mac will not be affected by the state of this flag as overscroll on Mac should always be on. Bug: 1071469 Change-Id: Idb20ce606d372eac17a67768a64171616c82c084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149291Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759859}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I95a739ee4dea283263106a64bed873c01f0ea60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147167Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759858}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c117a70b3913..22486ab1cdb8 git log c117a70b3913..22486ab1cdb8 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 btolsch@chromium.org Add windows path for gmtime 2020-04-16 btolsch@chromium.org Read all available CastMessages in CastSocket Created with: gclient setdep -r src/third_party/openscreen/src@22486ab1cdb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050913 Tbr: jophba@chromium.org Change-Id: I0872025ae099bad61343a3418a2230414c1c2601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153643Reviewed-by:
-
