- 01 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b11a9129408b..efb716af67f6 2020-12-01 tvanderlippe@chromium.org Update linter packages 2020-12-01 jacktfranklin@chromium.org Fix missing DEP to CSS files from unit tests 2020-12-01 jacktfranklin@chromium.org [Dark Mode]: migrate CSS files with no colors 2020-12-01 jacktfranklin@chromium.org [Dark Mode]: components/jsUtils.css 2020-12-01 alcastano@google.com Display CSP Violations in a new tab drawer 2020-12-01 andoli@chromium.org Migrate ui/ActionRegistration.js to .ts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1137837,chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4a0f44e1c983796ea926d6dfdb2c9478f9eea367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832455}
-
Thomas Guilbert authored
Issue crbug.com/454029 was closed as won't fix, and it seems like the VideoEncodeAccelerator callbacks won't be removed for now. This CL converts them into their proper {Once|Repeating} callback forms. These are the last callbacks that need to be converted in media/cast, and media/ as a whole (although there are still a few uses of base::Bind in media/). Bug: 1007801, 714018 Change-Id: Ia133555172d91cdce4a42f48127424d910fbe268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566355Reviewed-by:David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#832454}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id11ba9f5ef3b50242c1e30e5e99416bbc7568fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568050Reviewed-by:
-
Xianzhu Wang authored
Change-Id: Ia55628c49d82c588ef594ba10df7888e7797947e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561045Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832452}
-
Florin Malita authored
Only use kHigh_SkFilterQuality when actually upscaling. For identity scale, bicubic filtering is unnecessarily expensive and changes the output (not a no-op). Note: Skia used to catch the identity case and downgrade to kMedium_SkFilterQuality internally. That behavior is being removed, and this CL unblocks https://chromium-review.googlesource.com/c/chromium/src/+/2562751/12. Bug: skia:7650 Change-Id: If72511c690df8ad010fe3bd730d1bf81ecfb2958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566777Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#832451}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 174 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-03-01. TBR=chromium-metrics-reviews@google.com Change-Id: Ie6719279a07dff6620942ed72e9a1116098b56ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566368Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#832450}
-
Jeffrey Kardatzke authored
BUG=b:1153320, TEST=Fuzzer passes now, unit tests pass Change-Id: I9b3b0f454f30a04a1b7c83df039db0975930e175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564766Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#832449}
-
Amr Aboelkher authored
As SHELL library is being used by AutoEnrollmentClientImpl*, its tests should always be ran when the platform is ChromeOS. BUG=chromium:1151230 Change-Id: I5adfaaa35ea0367b24cc339ba0981cc85b0b61eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550808 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#832448}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/history Bug: 1113033 Change-Id: I5df2937570e3f72e97a58e78b3d85f4601992f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543383Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#832447}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/831a5a10f4f9..356cef301b81 2020-12-01 csmartdalton@google.com Simplify grvx::approx_angle_between_vectors signature 2020-12-01 brianosman@google.com Test & implement "vector relational intrinsics" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Ieff4babc6d987ce6e923d563e52f1a2d9d288f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567738Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e644010395ee..a3bcd1c0e2e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id2c9984f907486ba8214fa22642f42a487bb505f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567715Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/session... Bug: 1113033 Change-Id: Ibfe199813188358262916b8ba6d1cbdc0c72ef4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561022Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#832444}
-
Ted Choc authored
BUG=1151335,1104873 Change-Id: I887dd7a42182d73b4c6d25cfba6ad920a1e5dcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559319Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#832443}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/42433abb9596..a3bcd1c0e2e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I90b7a6ad5ae2ae018b4ae825b12820e51e550f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566347Reviewed-by:
-
Gavin Mak authored
This change also affects FakeTetherHostFetcher, TetherHostFetcherImpl Bug: 1007635 Change-Id: I4754ad64736452c16afb8d1759c68cd507ea2d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558843Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#832441}
-
Guillaume Jenkins authored
Currently, the machine_name field in device registration and reporting is set to the device's model using Apple nomenclature (e.g. iPad6,11). This makes it hard for administrators to distinguish devices. This CL makes the following changes for both the reporting and the registration protos: - The unsalted Vendor ID is now used as the machine_name field - The unsalted Vendor ID is now used as the browser's client ID in the requests's query parameters - A new device_model field is now used to report the device's model (e.g. iPad6,11) The unsalted VendorID is needed so that administrators can see the Chrome app in the list of apps managed by GEM. Bug: 1150847 Change-Id: I151b8d79b2babfbb5a3159580efaa55d6c946e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557572 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832440}
-
Mark Schillaci authored
This CL updates the behavior of role="combobox" on Android when the node is expanded. Previously we did not explicitly announce that the combobox had been expanded, or the number of items. With this change we now proactively announce to the user that the box was expanded. In a happy path, we should be able to find aria-controls for a given node, and a collection with a number of visible items, for which we would announce something of the form: "expanded, X autocomplete options available." If we cannot say for certain how many options are available, then we will use the string: "expanded, autocomplete options available." In the case that the combobox opens a dialog, we will announce: "expanded, dialog opened." And in all other edge cases where we cannot say for certain what has appeared on the screen (e.g. incorrectly authored page), we fallback to a default string: "expanded." AX-Relnotes: Android now proactively announces that comboboxes have been expanded and, where possible, communicates the number of autocomplete options available. Bug: 1121764 Change-Id: Ibdc48484bbce01d01ef28f7eda51c89745331c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508646Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#832439}
-
Haiyang Pan authored
So that we can clobber a given bot instead of all the bots for the builder Change-Id: I0ccfc1a49433f5d725a436b87bd695ba0cdb939f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567341 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832438}
-
David Roger authored
This CL uses the FocusOutlineManager to disable the outline only when the element is not focussed. Before this CL, the outline was always disabled, and this was inconvenient when using the keyboard. Fixed: 1153637 Change-Id: Ia77fb126e3a05dfe519ad2668cf3d606910fe08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567912Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#832437}
-
Ken Rockot authored
This removes the InterfaceProvider interface exposed by browser frame hosts to render frames. It's no longer used in production. Bug: 977637 Change-Id: Ibb31380435a2fbf32e7ad1c71be3f5a8c7dfee1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546146 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832436}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fda47e8bb6cf..3c1a040a0ffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1152833 Tbr: gab@google.com Change-Id: I677700f0998484126721b92ae3ba9a9bf76ac9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832435}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a6a7e46e5451..c3830d436c47 2020-12-01 rharrison@chromium.org Add support for using Tint Inspector 2020-12-01 cwallez@chromium.org CommandBufferMTL: Address review comments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I4f6709fd158e246d185a25d93cefb35dcb216104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568015 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Garrett Beaty authored
Currently, the xcode_cache enum contains declarations only for the xcode cache itself and builders must specify the matching xcode_build_version property. Additionally, the handling of inserting the cache and setting the property needs to be performed in any wrapper function that wants to set the xcode to a specific value. This change puts the handling in the lowest level and groups all of the xcode details into a single struct so that builders and wrapper functions can just specify the xcode value. Change-Id: Ia90829bb9124f93d4dcc48c67321289288a4c06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566616 Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#832433}
-
Robert Sesek authored
This third-party dependency no longer has an upstream (Caminio is no longer developed), so remove methods that are unused in Chroimum and just add to the maintenance burden (e.g. when updating the macOS deployment target). Bug: 1153883 Change-Id: I7060181d11ac94ed0885c2207d47297d25a01316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567448Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#832432}
-
Johann authored
Change-Id: Ia9d686316e4871da7c5e9656206d3cfa05064904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567072 Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832431}
-
Brian Sheedy authored
This reverts commit 56e68977. Reason for revert: Flake information no longer on the flake dashboard, need to re-enable to see what was actually going wrong. Original change's description: > Disable flaky test testSymbolizedMinidump on Android > > Per #2 from the linked bug, this could also be related to crbug.com/1138060. > > TBR=bsheedy@chromium.org > Bug: 1149237 > > Change-Id: I753dfe6f364f93d9dd01314357cbb6ee8c67924d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557906 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830585} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1149237 Change-Id: I0ec4a00efb6516988fb5264f469c550340eea426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564767 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#832430}
-
Norman Rosas authored
and also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I9ff4c1f2957fa0e3d99a9a969acd0d746aa39af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566070Reviewed-by:
-
Thiabaud Engelbrecht authored
Use scoped_refptr in ClientDiscardableSharedMemoryManager, to prevent it from being destroyed before all the memory it allocated is destroyed. Bug: 1153322 Change-Id: I01675d40bb081480460d5878a18baa58d5fe8507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563898Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3bcd1c0e2e9..6d300e3738db 2020-12-01 marcinoc@google.com Merge "Fix SysUI jank root causing query" 2020-12-01 primiano@google.com Make /tools a bit more Win friendly If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: Id99ea8afd0ce5af72b67dc1838fd070500bb273f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568016Reviewed-by:
-
Robbie McElrath authored
This fixes a comilation error due to FragmentActivityReplacer's interaction with SupportLifecycleFragmentImpl. Bug: 1152898, 1123216 Change-Id: I81de8100f7ddd08310f8a36c8f1c9c62e82c0469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566455Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#832426}
-
edchin authored
Bug: 1099646 Change-Id: Ie8fb8ef1a281b9b170f9ea49ad2e799f14bd7375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567477Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832425}
-
Josh Nohle authored
Records whether an HTTP call to send/receive messages from the Instant Messaging API succeeds or fails. On network failures, we log the network error code, and on HTTP response errors, we log the response code. Manually tested send/receive successes and network failures. I was not able to trigger an HTTP response code failure, however. Note: There are a few net::ERR_TIMED_OUT errors even during successful flows. These might be due to the nature of the Instant Messaging API. We will keep logging these error until they become cumbersome. Bug: 1123172, 1105579 Change-Id: I4852435228aff067e248a01692c3c73896d433a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556381 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832424}
-
Gavin Williams authored
Add a new state CANCELING for showing a continuous progress bar when waiting for a cancel request to complete. http://screen/BJsFQbdZFDZscdV Bug: 1059779 Change-Id: I98ee9863367b602b3a29f8cd3583db36112cc081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561505 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#832423}
-
Tarun Bansal authored
These histograms are still needed as the experiment analysis is still ongoing. Bug: 1151983 Change-Id: Ib0a5884c8b8ec0adbc1623454da2fb60af518571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564444 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832422}
-
manukh authored
Change-Id: I508b6f9cf93b577e984a86754e7353bb6b7ea86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566370Reviewed-by:
-
Ahmed Fakhry authored
It was added by mistake by me. It is possible to get audio frames after we delete the capturer, since they're sent asynchronously from a different thread. BUG=1154087 TEST=None Change-Id: I297cbb7a2373e716dd5a46e7eb9f406914e059ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566717 Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#832420}
-
https://crbug.com/1149654Dmitry Gozman authored
Bug: 1149654 Change-Id: Ib5e819b181d4f7ff36bbf7bb60e100334e854692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543545 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#832419}
-
Stephen Roe authored
Bug: 1126177 Change-Id: Iaa9faee2d54a07818397576c948d2b080bc2cc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566830Reviewed-by:
-
Ali Juma authored
A SafeBrowsingQueryManager can get destroyed in |UrlCheckFinished| when it calls |SafeBrowsingQueryFinished| on its observers. This happens when a prerendered WebState tries to load an unsafe URL: upon receiving the unsafe result, SafeBrowsingTabHelper cancels the prerender, which causes the prerendered WebState to be destroyed, and this destroys the SafeBrowsingQueryManager. Continuing to use the SafeBrowsingQueryManager's instance variables after this point causes a crash in |UrlCheckFinished|. This CL guards against this crash by using a weak pointer to detect that the SafeBrowsingQueryManager has been destroyed. Bug: 1153887 Change-Id: I7913f1bbb26253c0fbdfa5d46ca0b2312ba5558e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566092Reviewed-by:
-
Dominic Farolino authored
This reverts commit 422bc672. Reason for revert: We've collected enough info Original change's description: > Reland "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly" > > This reverts commit 2638a6e6. > > Reason for revert: We thought we had collected enough crash data, however crbug.com/1122182 was not actually fixed yet, so the minidumps did not actually contain the information we needed. agrieve@ has informed me that the issue should be fixed now, and we'll confirm whether or not that is the case by: > 1.) Reverting this change > 2.) Collecting minidumps > 3.) Examining the minidumps to confirm that the debugging information exists > > Original change's description: > > Revert "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly" > > > > This reverts commit b344652b. > > Reason for revert: We have collected enough crashdumps now, and this is > > causing crash metrics to be skewed as it's getting counted as a real > > crash. > > > > Bug: 1132770 > > Change-Id: Ia2e7a92bea2ebeca01c62ca9af73d3fe014685f6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505985 > > Auto-Submit: Mugdha Lakhani <nator@chromium.org> > > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822189} > > TBR=csharrison@chromium.org,nator@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR: charrison@chromium.org > Bug: 1132770 > Change-Id: I31ac96c2c5f4f0738fd2d8c4e60236b2bc0c35a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513109 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Dominic Farolino <dom@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829091} TBR=csharrison@chromium.org,dom@chromium.org,nator@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132770 Change-Id: Ie8515e382ba8d4610aaeb3026909bec63a1e9405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568110 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#832416}
-
