- 28 Feb, 2020 40 commits
-
-
Armando Miraglia authored
It was noted that in the case of WebView the labels are not shown even though the permission to access the devices were granted. After further inspection, crrev.com/c/1964495 exposed an issue in permission checking in the case of WebViews. To give us time to look into the issue further and fix the actual permission checking for WebViews, this CL disables by default the behavior change of enumerateDevices on Android. Bug: 1055770 Change-Id: I9dc557fed9961cf90794c87c4da4fa12213793f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078547 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#745581}
-
Clark DuVall authored
When a request was redirected to a page with a service worker installed, webRequest was not seeing the events. This is because the network loader factory was no longer proxied on the redirect. Bug: 1012977 Change-Id: I1161a8d6ac58711b83427accc8026a0981fa527e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079932Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#745580}
-
Esmael El-Moslimany authored
Change-Id: I5215174f057e1e377216db73b7f0bf7a77086f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079465 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#745579}
-
Chris Mumford authored
TBR=caseq@chromium.org Bug: 1055006 Change-Id: Ie2859a35d586ff2ae9ea54f461c9fd8552e32c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078975 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745578}
-
Yi Xu authored
canvas-lostgpu-context.html is consistently crash in last 3 builds: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29 TBR=thakis@chromium.org Bug: 818426 Change-Id: I77f658d014ca5eab2bfef811e182e27f1c53ad3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079681Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#745577}
-
Esmael El-Moslimany authored
Fixed: 1057032 Change-Id: I594e390ec47d17fed42cb8a374f4d58917addc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079688 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Charlie Hu authored
This CL modifies PageTestBase::NavigateTo accept all http headers through a HashMap. Previously the method only accepts feature policy header and CSP header. The modification is prework to add test for document policy which has its own header. Change-Id: I7cabaaba3c099ff5e77040891ba9950a25271f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080438 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#745575}
-
Greg Guterman authored
Doesn't include internal builders. Bug: 1028719 Change-Id: Iec40cb84086ed23cd7d5ca60c317296460466497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033847 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#745574}
-
Stephen Chenney authored
The test very occasionally times out on Mac 13 and Mac 14. TBR: vmpstr@chromium.org Bug: 1054894 Change-Id: Iff9857cd24b84bc2d5c076ac5bef44d86815b608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080198Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#745573}
-
Dale Curtis authored
R=mlamouri, tguilbert Bug: 1012063 Change-Id: I863429b989244ebd09db76d0d52b9d8b58053347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079512 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745572}
-
Oksana Zhuravlova authored
Change-Id: I9ad0f3e030a95055a93b2a567317f513af641505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076328Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#745571}
-
Yue Li authored
Smaller screen treatment for padding and scaling: https://spec.googleplex.com/crosux-spec/feature-specs/oobe-system-window.html Bug: 1033273 Test: Manual Test Change-Id: I9938b1c728d66f1a914138102fe3ea466b08875c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079544Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#745570}
-
Sammie Quon authored
The view is quite large, so removing the mask will improve draw times and use less GPU memory. Also changed the end gradient colour to match the spec; personally I think using transparent as the end gradient looked better. Test: manual Bug: 1056967 Change-Id: I254e11bca1a85c6bf19a74e8e5e852d00f568f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079687Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#745569}
-
Mike Frysinger authored
Bug: 1050345 Test: loaded Secure Shell & checked chrome.xxx APIs were defined Change-Id: Iff76898eed3ebf86c212560aa9182314c016b87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047769 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745568}
-
Nina Satragno authored
Mirror the behaviour of GetAssertion and obtain a UV token for devices that support it and have UV configured. Handle retries and fallback to PIN. Bug: 1055497 Change-Id: I8c3c524db0da848374f2a68a0166a4420bdd248d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073139 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#745567}
-
sandromaggi authored
Before this change, element coordinates were relative to their window, i.e. frame. For elements in iFrame this meant that the "cutout" was misplaced. This change now keeps a frame-stack while retrieving elements and then sums up the position to get a "global" position of the element for using in a showcast. Bug: b/143942385 Change-Id: I8f3827002df58874d7921e969954f911630cc4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074499 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#745566}
-
Xiaohui Chen authored
Bug: None Change-Id: Iaf4ad87d59a6f957c5aef6623e7c64f72d92c364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080195Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745565}
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of moving OS specific strings from setttings_strings.grdp to os_settings_strings.grdp, specifically languages sub page strings. Bug: 967883 Change-Id: I6309deb37268c2210ffb28b2e02b299a274521c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055968Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#745564}
-
Andrew Grieve authored
with the goal of making it impossible to have values from invoker accidentally clobber values from the template (or vice versa). Bug: 1050094 Change-Id: I7248c76cc7f0b628f756d23d9618271befffb820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079838 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#745563}
-
Rohit Rao authored
This reverts commit d3273ac4. Reason for revert: Causing crashes on (internal) iphone-device and ipad-device. Might be a Debug vs Release issue, rather than a device vs simulator issue. https://ci.chromium.org/p/chrome/builders/ci/iphone-device/7243 https://ci.chromium.org/p/chrome/builders/ci/ipad-device/7808 Original change's description: > [iOS] Plumb Browser into RecentTabsViewController > > Changes RecentTabsViewController to accept a Browser instead of separate > WebStateList and BrowserState inputs. This will make future refactoring > more straightforward. > > (There remains a great deal of work to do to fully refactor Recent Tabs > to properly factor responsibilities into a mediator and coordinator). > > Bug: 845192 > Change-Id: I068b0a343752dba602d2a2226cd0bcf327873446 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078452 > Commit-Queue: Mark Cogan <marq@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745456} TBR=marq@chromium.org,gambard@chromium.org Change-Id: I7119af082ce06b110638bda6ba6782f4382c1f16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079468Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#745562}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some chromeOS settings did not include all applicable test cases. This CL copies missing test cases applicable to chromeOS from cr_settings_browsertest.js to os_settings_browsertest.js. Bug: 990137 Change-Id: Id4f786c83b70e31e2da555ecbbbd6cdc96f0f867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071910 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Wan-Teh Chang authored
The prototype of the pure virtual method VideoDecoder::Reset() changed from virtual void Reset(const base::Closure& closure) = 0; to virtual void Reset(base::OnceClosure closure) = 0; in commit 7ee39c86. Update AomVideoDecoder::Reset() to the new prototype. Tested: $ gn args out/Default In the editor, add the following line: enable_libaom_decoder = true $ autoninja -C out/Default media_unittests $ out/Default/media_unittests Change-Id: I1ccfe15588e6c94817f2d671bc55e9fea7305ae2 Bug: chromium:1055917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079851Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#745560}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e1d74467e0d..fb551728d77b git log 1e1d74467e0d..fb551728d77b --date=short --first-parent --format='%ad %ae %s' 2020-02-28 ynovikov@chromium.org Suppress SwANGLE dEQP-GLES3.functional.texture.compressed.astc.* failures Created with: gclient setdep -r src/third_party/angle@fb551728d77b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ia5d5ad566fef77e62d8823455ce31544cff966f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080463Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745559}
-
rbpotter authored
Bug: 1026426 Change-Id: Ib6be48069cd3fe5f2547587fb6f3cf40678dc336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079898Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745558}
-
Regan Hsu authored
Bug: 1056909 Change-Id: I48f2a52c69cfcd4184b01eb4b4db7d96ac4ece1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078801 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Eric Seckler authored
Switch from StartupTraceWriter(Registry) and their thread-local buffers to startup tracing using producer-supplied shared memory buffers. Each ProducerClient allocates their own SMB now, which is provided to the service when the ProducerClient connects. With this new mechanism, we're aiming for simpler code with fewer race conditions and hopefully fewer chances for data loss, see design doc for details. Note that this breaks startup tracing with the Perfetto system daemon. At the moment, no tooling uses this, so we can probably remove support for the time being. To add it back, we would have to: - start tracing with an SMB allocated by PosixSystemProducer. In sandboxed processes, we can allocate the SMB before the sandbox comes up, or later via mojo's broker (and then somehow plumb it through perfetto's IPC mechanism), or allocate it in the browser + pass an FD to it via the cmdline when spawning. - attempt to connect to the system service using this SMB. - bail out, stop and restart the session with a service-provided SMB if the system service doesn't support producer-provided SMBs (and thus fails to adopt the producer-provided SMB). Design doc (incl. security review): https://docs.google.com/document/d/1FygJQbD29vMkfVfT7m0Lb1u1zZZU1VgXAPi_R0uBoTw/edit Related Perfetto-side patches: https://android-review.googlesource.com/c/platform/external/perfetto/+/1218420 https://android-review.googlesource.com/c/platform/external/perfetto/+/1196779 Bug: 1006753, 941318 Change-Id: I3fa7657d57bbf7261d7d504df8895edfc02d9f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978682Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#745556}
-
Philip Rogers authored
Change-Id: Iee7a9e63a43bbf9ef1eeffdea03f8f2de79d83e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080465Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745555}
-
Chris Mumford authored
This reverts commit f02f7639. Reason for revert: Failed to build on Cast Audio Linux https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/67917 Original change's description: > Improve DoH server availability tracking > > Now that server availability and stats are tracked per-context, DoH > servers only need to be disabled for consecutive failures. And now that > availability behaves much more similarly to normal server failure > tracking, the availability has been mostly merged into the normal > tracking instead of using a separate flag. A DoH server is now > considered "available" (eligible for use in automatic mode) if > |ServerStats::last_failure_count| is less than > |kAutomaticModeFailureLimit| and there has been at least one success > recorded on the current connection. > > Net effect is that DoH servers can be enabled or failure-tracking reset > for any successful request or probe to that server on the same context, > even if a failure disable has taken effect (eg a transaction started > before the server was disabled, or a new probe when we restart probes in > a future CL). > > Also, previously the DoH probe logic reset availability when restarted. > Because the probes were generally only restarted for connection change, > this had the effect of resetting availability for connection change. > Now, the ResolveContext handles that itself on connection change by > resetting the flag that it has seen at least one success on the current > connection. > > Bug: 1022059 > Change-Id: I872057cbb9f7a0a41f580dff57d906b1e4e5d33c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062676 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745551} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: I0005490d361cb8c86583ab1b0f3819eeee13c4cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080446Reviewed-by:
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //components/chromeos_camera to Once or Repeating. Bug: 1007676 Change-Id: I50160fe35211329df7a29b4b2ec64c768695dbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062947Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#745553}
-
Vitaly Buka authored
This variable affects blink_perf.canvas with benchmark on linux with -ftrivial-auto-var-init=pattern. crrev.com/c/2067928 This patch reduces the regression form 14% to 4.5% Somehow pinpoint does not work for this test. So I've attached local results of HEAD vs HEAD+patch are here https://bugs.chromium.org/p/chromium/issues/detail?id=1055652#c13 Bug: 1055652, 977230 Change-Id: Ied2e89ae414728a72659d196d73aa97d1e8532a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072671Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#745552}
-
Eric Orth authored
Now that server availability and stats are tracked per-context, DoH servers only need to be disabled for consecutive failures. And now that availability behaves much more similarly to normal server failure tracking, the availability has been mostly merged into the normal tracking instead of using a separate flag. A DoH server is now considered "available" (eligible for use in automatic mode) if |ServerStats::last_failure_count| is less than |kAutomaticModeFailureLimit| and there has been at least one success recorded on the current connection. Net effect is that DoH servers can be enabled or failure-tracking reset for any successful request or probe to that server on the same context, even if a failure disable has taken effect (eg a transaction started before the server was disabled, or a new probe when we restart probes in a future CL). Also, previously the DoH probe logic reset availability when restarted. Because the probes were generally only restarted for connection change, this had the effect of resetting availability for connection change. Now, the ResolveContext handles that itself on connection change by resetting the flag that it has seen at least one success on the current connection. Bug: 1022059 Change-Id: I872057cbb9f7a0a41f580dff57d906b1e4e5d33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062676Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#745551}
-
Khushal authored
R=sunnyps@chromium.org Change-Id: I67a0bb9643ecbf70c5aa2b9f5f6a070883cf7a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078799 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745550}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=juncai@chromium.org Bug: 1026641 Change-Id: I14264a1265eb4675548aa40f0003c6fd5a8961f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079076Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745549}
-
Clark DuVall authored
This will be needed by code in //components/permissions, and seems to make more sense in PermissionUtil than WebsitePreferenceBridge. Bug: 1025609 Change-Id: I86d229dc1fcf15d2dab9e0fe0bebc7bfb7ced5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079546 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745548}
-
yilkal authored
This CL makes minor changes to check if the absence of SupervisedUserNavigationObserver is the cause of crash in android chrome in TabContentsSyncedTabDelegate::ShouldSync. Bug: 1048643 Change-Id: I8cdb18b30ba42ba781b09d0ba455fc8c26d101f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079004 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745547}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6045fb83..817bf7ab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic4e7c216e25298f3d4f32414bc8eb245f74fe503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079636Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745546}
-
Michael Chang authored
Bug: 1055942 Change-Id: I9f79ba6c696f4fee51cf1ac67e17a4a6ab7cef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076399Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Michael Chang <donchan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745545}
-
Philip Rogers authored
Painted scrollbars are used for overlay scrollbars on MacOS. Thumb movement would cause a commit on every scroll change because the update rect (set via Layer::SetNeedsDisplay) would change. This patch ignores the update rect in PaintedScrollbarLayer::Update and uses part invalidation for causing commits. With this change, scroll offset changes do not cause commits. Bug: 1048384f Change-Id: I79bac7fbd9756cb71af7c3b83be3df824dd7a5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078847Reviewed-by:
-
John Budorick authored
Bug: 1056325 Change-Id: Ic12a263fd56df460434c9ae078e45172ed58e3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075973Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#745543}
-
Connie Wan authored
WebUI doesn't use TabGroupHeaders for tab groups, so Mohnstrudel needs another way to position the Editor Bubble. BubbleDialogDelegateView allows for an alternative way to set an anchor, which is to give it the anchor bounds as a Rect. This CL exposes that method of anchoring the bubble while still defaulting to using the TabGroupHeader in the desktop UI. Bug: 1055537 Change-Id: I9d38971f867a362007abd626aa425515bef16af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071911 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745542}
-
