- 11 Sep, 2018 40 commits
-
-
Francois Doray authored
This will allow use of these constants in constexpr expressions. Change-Id: Ia2d6f8ab6969eedbc9b9b763f7f700ffaaaee14b Reviewed-on: https://chromium-review.googlesource.com/1219769Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#590419}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/f7b0e1d901da..7b945f200339 Following up on leveldb cleanups, this CL also removes the ssize_t definition from port_chromium.h, and the OS_WIN macro definition that was required by it. $ git log f7b0e1d90..7b945f200 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 costan Clean up posix_logger.h. 2018-09-04 costan Remove ssize_t from code that is not POSIX-specific. 2018-09-04 costan Simplify Limiter in env_posix.cc. 2018-09-04 costan Clarify comments for leveldb::Env file reading methods. 2018-09-04 costan Remove GCC on OSX from the Travis CI matrix. 2018-08-19 costan Expose WriteBatch::Append in the C API. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: I4f045f15cdae69e15f5a52c05cff9e7671fb2753 Reviewed-on: https://chromium-review.googlesource.com/1205472Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590418}
-
Stephane Zermatten authored
I had forgotten to initialize pending_precondition_check_count_; running the component tests with asan highlighted that. Bug: 882901 Change-Id: Ia9621e80946da39e3d6ecb8e8c98a09beb4a76e2 Reviewed-on: https://chromium-review.googlesource.com/1219709Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#590417}
-
Will Harris authored
../../chrome/browser/win/chrome_process_finder.cc(97,41): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int' [-Wshorten-64-to-32] timeout_in_milliseconds = new_timeout.InMilliseconds(); ~ ~~~~~~~~~~~~^~~~~~~~~~~~~~~~ BUG=879657 Change-Id: I2a711f97feb92925a3b53e08d06af5da1b61820e Reviewed-on: https://chromium-review.googlesource.com/1214744 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#590416}
-
Xida Chen authored
Right now in InputRouterImpl::OnTouchEventAck, we append a "T" to the debug string in TouchActionFilter when the touch event is a touch sequence start and that the input event ack state is NO_CONSUMER_EXISTS. This CL make changes to append the input event ack state to the debug string. The reason is that all the current crashes seems to be the case that is not acked from the main thread, but we do not know the ack state yet. Bug: 851644 Change-Id: Ia57de7aa2c63e104008893dc8809a5eac679460d Reviewed-on: https://chromium-review.googlesource.com/1219781 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590415}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9039169b64e1..7a45d5722c7e git log 9039169b64e1..7a45d5722c7e --date=short --no-merges --format='%ad %ae %s' 2018-09-11 thestig@chromium.org Fix a regression in CJBig2_Context::HuffmanAssignCode(). Created with: gclient setdep -r src/third_party/pdfium@7a45d5722c7e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:880920 TBR=dsinclair@chromium.org Change-Id: Iafb1581dad97b0064927dad48286a12dbe526e57 Reviewed-on: https://chromium-review.googlesource.com/1220228Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590414}
-
Gabriel Charette authored
As discussed offline. R=ajwong@chromium.org, danakj@chromium.org, dcheng@chromium.org, fdoray@chromium.org, kylechar@chromium.org, mark@chromium.org, thakis@chromium.org, thestig@chromium.org Bug: None Change-Id: I61648ec9e36e0837dce74f211eb30530559d6c96 Reviewed-on: https://chromium-review.googlesource.com/1216602Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#590413}
-
David Tseng authored
Change-Id: I5712c277c3a52b824e35ebc990e78e2131b18a73 Reviewed-on: https://chromium-review.googlesource.com/1217031Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590412}
-
Zentaro Kavanagh authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/41fa30110678..326384d6d8ea $ git log 41fa30110..326384d6d --date=short --no-merges --format='%ad %ae %s' 2018-08-30 zentaro system_api: Add DBus constants and protos for OOBE config 2018-08-30 mqg login: Add retrieve primary user to session manager dbus constants Created with: roll-dep src/third_party/cros_system_api Bug: 869209 Change-Id: I8cb18805e20047ddc8a34d28ed244997ef76f473 Reviewed-on: https://chromium-review.googlesource.com/1220028Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#590411}
-
Clark DuVall authored
This enum was added in http://crrev.com/c/1198102 Bug: 868021 Change-Id: I6f18a3b243a4c02385e160a31db767ae4bfe8f64 Reviewed-on: https://chromium-review.googlesource.com/1219897Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590410}
-
Chris Mumford authored
Prior implementation used net::URLRequestContext, but using SimpleURLLoader is compatible with the network service. Bug: 844979 Change-Id: I26bb07d1b440443ab320979b694eefe1f8e32cf6 Reviewed-on: https://chromium-review.googlesource.com/1176363 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#590409}
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/75b9859caeeb..7d447f5b0021 $ git log 75b9859ca..7d447f5b0 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 yunqingwang Further reduce AVxEncoderThreadTest 2018-08-22 sarahparker Add min gf group length for groups containing a fwd keyframe 2018-09-10 yaowu.google.com Fix two compiling problems with MSVC 2013 2018-09-10 tomfinegan Remove vestigial VP8 token partition support. 2018-09-08 jzern test/test-data*: add park_joy_90p_8_420_monochrome.y4m 2018-09-07 wtc Declare final_filter_fast_internal as static. 2018-09-05 alexanderbokov Update TX type pruning models 2018-09-10 grant.hsu Fix overflow issue in get_est_rate_dist 2018-09-07 wtc Include config/av1_rtcd.h. 2018-09-06 debargha Use curvfit model in various places 2018-09-07 urvang decodeframe and reconinter_enc: Reduce stack use. 2018-09-06 wtc Zero frame buffers on sequence header change. 2018-09-07 yaowu Make funciton definition/declaration consistent 2018-09-04 grant.hsu Improve prune_comp_search_by_single_result 2018-08-16 wtc Pass n to get_msb in the primitive_quniform funcs. 2018-09-07 wtc Remove "const" from pointer parameters. 2018-09-06 yunqingwang Remove single_tile_decoding from aomenc 2018-08-30 deepa.kg AVX2 implementation of 4-tap filter 2018-09-06 sachin.kumargarg Add avx2 variants of highbd 8x8 and 16x16 var modules 2018-09-07 binpengsmail Remove obsoleted skip_block for quantize_b (...) Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@google.com Bug: 879549 Change-Id: Ibf6ceb38788cf5724d01ddf2817c5d1c63bf7342 Reviewed-on: https://chromium-review.googlesource.com/1219892Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#590408}
-
Alex Moshchuk authored
Bug: 882686 Change-Id: I2298e9d4a750a50334ae8047bc9f2ee95a750434 Reviewed-on: https://chromium-review.googlesource.com/1218523 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590407}
-
Mohsen Izadi authored
RenderWidgetHostImpl::SubmitCompositorFrame() checks for surface invariants violation and records Compositing.SurfaceInvariantsViolations histogram in case of violation. However, CompositorFrameSinkSupport already checks for violations and records appropriate histogram values (Compositing.CompositorFrameSinkSupport.SubmitResult). So, the check and histogram in RenderWidgetHostImpl is not very useful and can be removed. BUG=771354 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I24a9e8078be17175e588383259237f27ae8c28b2 Reviewed-on: https://chromium-review.googlesource.com/1217706Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590406}
-
Robert Sesek authored
Bug: 832124 Change-Id: Ieb671aa0111a494ba8f0fff068be100e9f5d5143 Reviewed-on: https://chromium-review.googlesource.com/1217757Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#590405}
-
Tom Anderson authored
This fixes the background tab text color when using the Blackbird GTK theme. Blackbird styles titlebar labels with dark text unless the label has the "title" class [1]. This means creating a label in the titlebar will be illegible on Blackbird since the frame is dark too. This is a bug that was probably never seen since having a non-title label in the frame is rare. This CL adds ".title" to our selector to get the correct light color on Blackbird. Other themes should be unaffected. [1] https://github.com/shimmerproject/Blackbird/blob/master/gtk-3.20/gtk-widgets.css#L4742 BUG=881550 R=pkasting Change-Id: I16ef16c27ab4500c152bb56a105276be4bbf708a Reviewed-on: https://chromium-review.googlesource.com/1217146Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#590404}
-
Clark DuVall authored
These were removed from all other Android bots in http://crrev.com/c/1199682. Bug: 880915 Change-Id: I3da3ddd2651b889bb440e691ef14b2e54e055475 Reviewed-on: https://chromium-review.googlesource.com/1219968Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590403}
-
Mathias Carlen authored
We pass the name and path of a ScriptHandle to Java using two arrays of strings. The java side reconstructs a list of ScriptHandle and uses that to show the script names and trigger the script using the also provided path to it. Bug: 806868 Change-Id: I683ea8c20086af4b9dfe874953b82d43d4677521 Reviewed-on: https://chromium-review.googlesource.com/1213087 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#590402}
-
Ken Rockot authored
Fixes a bug which breaks sandboxed service utility process launching. The launcher was invalidating the child process's Mojo channel handle before launch. Bug: 882158 Change-Id: I406bc3adcf9be2e74dda87f536151b4f05ac3319 Reviewed-on: https://chromium-review.googlesource.com/1220266Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#590401}
-
Xiaohui Chen authored
Bug: None Test: None Change-Id: Ie6f0e98b4e1a1d3bd1756734f38c71c1a2814fa0 Reviewed-on: https://chromium-review.googlesource.com/1217853Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#590400}
-
Vladislav Kaznacheev authored
Added 48px variant to avoid excessive downscaling. Bug: 882176 Test: manual Change-Id: Icfe9e1ea2615987e19b0ac186d2c34b9e8ff5898 Reviewed-on: https://chromium-review.googlesource.com/1219493Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#590399}
-
Ryan Tseng authored
Bug: 868213 Change-Id: I94bfee9ed4840a88473a8bb055ceac34e64e6bb9 Reviewed-on: https://chromium-review.googlesource.com/1219895Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#590398}
-
Daniel Zhang authored
1. Functionality was landed in separate CLs. 2. Refactoring existing unit tests to make it simpler to land additional unit tests in the future. Bug: 882050 Change-Id: I86fa9ebb457f9f17342ce88bc1c3fc7edd274e07 Reviewed-on: https://chromium-review.googlesource.com/1213518 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590397}
-
Paul Hsia authored
ChromeOS will treat type-C dongle as USB device so we need to send its node change event to ARC++ to trigger android input / output routing change. Bug: 113263008, 113267575 Test: Audio Input / Output Routing Notification Test in CTS-V Test: Audio Input / Output Device Notification Test in CTS-V Change-Id: I97dac08bbf22fe2fda3e1ae3314c6c41ae6b925c OWNERS: lhchavez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1219527Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Cr-Commit-Position: refs/heads/master@{#590396}
-
Mugdha Lakhani authored
to align the implementation with the spec. https://wicg.github.io/background-fetch/#enumdef-backgroundfetchresult This change also gets rid of BackgroundFetchState. Bug: 881871, 873630 Change-Id: I2be6087fdb68a4463872013b834611727ff525e6 Reviewed-on: https://chromium-review.googlesource.com/1213508Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#590395}
-
Erik Luo authored
Adds a context menu item onto DOM nodes and elements to store as a global `tempN` variable. Screenshot: https://imgur.com/a/5ph3Rqj Bug: 867855 Change-Id: If76a5c85ec47dae3df6fcb95d843cb4663efbb42 Reviewed-on: https://chromium-review.googlesource.com/1217745Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#590394}
-
Micah Morton authored
Chrome OS metric signifying whether a system is running Shill in a sandbox or not. This is controlled through a Finch flag, but requires 1-2 reboots to take affect. This metric will help us ensure that Shill is being run with sandboxing enabled/disabled at the frequency that we expect. Bug: 649417 Change-Id: Ia88980e813b6c633996f7964c9eb35deb041d248 Reviewed-on: https://chromium-review.googlesource.com/1210862 Commit-Queue: Micah Morton <mortonm@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#590393}
-
Dave Tapuska authored
Media control requests should default to hide instead of auto. BUG=881738 Change-Id: I0aca9635aed16e7ca6d4a9f99607257344a14454 Reviewed-on: https://chromium-review.googlesource.com/1217404Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#590392}
-
Takumi Fujimoto authored
This reverts commit a8e9bac6. Reason for revert: We have a crash in issue 876900 which we're not sure how it happens. Based on when the crash started happening, this CL may be relevant. We're reverting this CL to see if the crashes stop. Original change's description: > [Harmony Cast Dialog] Close dialog after starting a page-initiated route > > The dialog needs to be closed when a PresentationRequest is fulfilled, > so that the user cannot attempt to cast again using the same request. > > Bug: 868186 > > Change-Id: I9d00cc5119257bba046e67c750210104123f0bdb > Reviewed-on: https://chromium-review.googlesource.com/1151890 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579129} TBR=imcheng@chromium.org,takumif@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 868186,876900 Change-Id: I419a343cf8ea85cc92e219b0c5422fa9d095b805 Reviewed-on: https://chromium-review.googlesource.com/1218162Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#590391}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie3803bca746854934ab992d49aa48b1718220aad Reviewed-on: https://chromium-review.googlesource.com/1219907 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590390}
-
Niels Möller authored
Preparation for landing webrtc cl https://webrtc-review.googlesource.com/c/src/+/95103. Bug: webrtc:9378 Change-Id: Ia2510f51392ee7ce7a4c12a791a0efc120f06524 Reviewed-on: https://chromium-review.googlesource.com/1219586 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590389}
-
Friedrich Horschig authored
This is a reland of 87036e9b The compile failure were caused by unhandled redundant initializations which are now blocking (see https://crbug.com/877443#c8). The CL landed between dryrun and submit which explains the late failure. TBR=tedchoc@chromium.org,joedow@chromium.org Original change's description: > [Android] Use a delegate for all keyboard visibility functions > > This CL extends the use of the visibility delegate from affecting > only the isKeyboardShown() function to all keyboard-related methods. > > Using a delegate is also the first step to move towards binding > the keyboard detection to WindowAndroid. This enables other > components like the keyboard accessory to affect the visibility on > an activity-specific level (instead of global and static). > > These changes require more work and will follow in further CLs. > > TBR=joedow@chromium.org > TBR Reason: Renamed an interface which doesn't change any behavior. > > Bug: 857460 > Change-Id: Ia878e84221d68c4a7c90a0dd2bbce9c8858d98bf > Reviewed-on: https://chromium-review.googlesource.com/1190523 > Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590243} Bug: 857460 Change-Id: I89fc9eee5e263328b3d89ea6d908209fafa5a144 Reviewed-on: https://chromium-review.googlesource.com/1219107 Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590388}
-
Eric Seckler authored
This adds TestBrowserThreadBundles to unittests that will need it when we replace BrowserThread::PostTask() and friends with base/post_task.h. The TestBrowserThreadBundle initializes globals that are required for things like posting a task to or obtaining a TaskRunner for a BrowserThread. I'm making this change in a separate patch to make review of the future automated refactoring patches easier. Bug: 878356 Change-Id: I100eefb16afa5490c9c7dee56c9a0bdb72501524 Reviewed-on: https://chromium-review.googlesource.com/1208170Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#590387}
-
Brandon Wylie authored
Change-Id: I779cece06dc42004da5382fa75f5062d38a4e7d4 Reviewed-on: https://chromium-review.googlesource.com/1220267Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#590386}
-
Tom Anderson authored
$ ninja -C out/Release base $ tools/clang/scripts/generate_compdb.py -p out/Release \ > out/Release/compile_commands.json $ cd out/Release $ ~/dev/llvm/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p . -clang-tidy-binary ~/dev/llvm/build/bin/clang-tidy \ -clang-apply-replacements-binary \ ~/dev/llvm/build/bin/clang-apply-replacements -checks=readability-else-after-return -fix ~/dev/chromium_official/src/base/ $ cd ../.. $ git checkout base/third_party $ git cl format R=thestig Change-Id: Ifc44900f372ed4027027ba50f7a7de22d0e2f0ec Reviewed-on: https://chromium-review.googlesource.com/1214691 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590385}
-
Justin DeWitt authored
This adds an ImportCatalogTask that will take a proto directly from the service API and add records to the database. It has the following behavior: * If the timestamp matches the "current" version, it does nothing. This prevents stomping on the currently viewable catalog. * If the timestamp matches the "downloading" version, it overwrites it, since that version is not yet viewable by the user. * Sets the "downloading" version number to the input version timestamp. Bug: 867488 Change-Id: I1c1725a664f348eb5399da2d42d0d8c22c44e1c0 Reviewed-on: https://chromium-review.googlesource.com/1213707Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#590384}
-
Thoren Paulson authored
The extra waiting is unnecessary now, and breaks due to change 1136804, since we don't always get didSwapFrame. Bug: internal b/113850356 Test: repro Change-Id: Icc1d1119d3e451e009951441ede8405884f31fd9 Reviewed-on: https://chromium-review.googlesource.com/1214749Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#590383}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2473d9472049..5831e1113332 git log 2473d9472049..5831e1113332 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 caryclark@google.com fix another pathmeasure fuzz 2018-09-11 caryclark@google.com Revert "Base Gradient FP Refactor" 2018-09-11 halcanary@google.com SkPDF: Device subclass no longer tracks size. Created with: gclient setdep -r src/third_party/skia@5831e1113332 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I0ba497881f4e7e4503ef9f1e2ae9c1f6c582d17c Reviewed-on: https://chromium-review.googlesource.com/1220226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590382}
-
Jacob Dufault authored
Bug: 881214 Change-Id: I21675325deaf351bf2431935652c8bb2247bdb32 Reviewed-on: https://chromium-review.googlesource.com/1217352Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#590381}
-
wutao authored
The notification pref is sent when device starts. At this time the kVoiceInteractionEnabled is not enabled for the first time user. Bug: 881608, b/112853995 Test: manual. Change-Id: I4753dbaa79dca7aaa0dd0781bbee25abef825371 Reviewed-on: https://chromium-review.googlesource.com/1211876Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#590380}
-