- 10 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3f9199a162ff..ad994cd8941d git log 3f9199a162ff..ad994cd8941d --date=short --first-parent --format='%ad %ae %s' 2019-12-10 egdaniel@google.com Store GrSurfaceProxyView on shadow ops. 2019-12-10 herb@google.com Put SubRuns in an alloc on GrTextBlob 2019-12-10 fmalita@chromium.org [skottie] Add frame time histogram to SkottieSlide UI 2019-12-10 jlavrova@google.com Font features 2019-12-10 fmalita@chromium.org [skottie] Initial SkottieSlide UI 2019-12-10 halcanary@google.com utils/mac/SkCreateCGImageRef: cleanup Created with: gclient setdep -r src/third_party/skia@ad994cd8941d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029972 Tbr: djsollen@google.com Change-Id: I547e84ac1af74a5449142a7ce0f669ea0549430e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723566}
-
Henrique Nakashima authored
Offer methods to read and write specific keys instead of generic ones that can access any key. Bug: 1022108 Change-Id: I33d8be0798b9ef4504b14720f159469ebbf80c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958655Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#723565}
-
Connor Lange authored
Instead of contacting the primary agent for UrlRequestRewriteRules, CastRunner will now contact the agent specified by ApplicationConfigManager. If this agent does not provide UrlRequestRewriteRules (which are now optional), then CastRunner will inject an empty vector of rules. Also added a new test to ensure that UrlRequestRewriteRules are in fact optional. Bug: b/141573972 Test: cast_runner_integration_tests, launch application Change-Id: I82cda7117dec88b657d9f6888ad081cc4d248cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959386 Commit-Queue: Connor Lange <connorl@chromium.org> Auto-Submit: Connor Lange <connorl@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#723564}
-
Etienne Pierre-doray authored
Report: "courgette/disassembler_win32.cc:241:44: runtime error: applying non-zero offset 255 to null pointer" courgette::DisassemblerWin32::ParseRelocs courgette::DisassemblerWin32::ExtractAbs32Locations courgette::Disassembler::CreateProgram The fix seems to move bounds check on |relocs_start| before computing |relocs_end|. Bug: 1027893 Change-Id: Iec3f81ab0db077467d28dd8e122aa33d92d52a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960548 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#723563}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd8930f8. With Chromium commits locally applied on WPT: a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." eb00b4d6 "LazyLoad: move invisible-image.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I763d992341b8a844ba57637a196d7c1e71ab65f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960794Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723562}
-
Kevin Bailey authored
This CL adds calls to the sites where we enter and leave keyword search mode, so the user knows that there has been a state change, and plumbs those calls to the View layer. Bug: 785375 Change-Id: Ie5963fc4741979af7be296107ff9704620d41c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955161 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#723561}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9b33e92da7f..c1c5bec5ed00 git log d9b33e92da7f..c1c5bec5ed00 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 mandy.chen@microsoft.com Check for null to avoid UnhandledPromiseRejection in Main.Main.SearchActionDelegate.handleAction 2019-12-10 tvanderlippe@chromium.org Revert "Updates common/ legacy; resoves internal refs" 2019-12-10 aerotwist@chromium.org Updates common/ legacy; resoves internal refs 2019-12-10 aerotwist@chromium.org Migrates main/ to esm 2019-12-10 tvanderlippe@chromium.org Migrate elements/ to use ES-imports 2019-12-10 tvanderlippe@chromium.org Update Runtime to automatically lazy load -legacy files Created with: gclient setdep -r src/third_party/devtools-frontend/src@c1c5bec5ed00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie104c2b936266fa7e331567cd51331976bbbffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960775Reviewed-by:
-
Elly Fong-Jones authored
After this change, ExtensionInstalledBubbleView no longer depends on ExtensionInstalledBubble. The subsequent CL will break the dependency on BubbleReference as well as having ExtensionInstalledBubbleObserver directly create and show an ExtensionInstalledBubbleView, bypassing BubbleUi. Bug: 496955 Change-Id: Ic1a1165da911a5fe8bc8e2840fc23dee8b2f87b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959937 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#723559}
-
danakj authored
These callbacks are run once, though only if ShouldOpenDownload() returns false. Note that some implementations return false but still don't run the callback, which violates the contract defined in the DownloadManagerDelegate header. This adds TODOs in those places. R=avi@chromium.org, qinmin@chromium.org TBR=servolk Bug: 1007763 Change-Id: Iae4e741fe4cc1a6d5c308e7608a4805cc4f17efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959542 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723558}
-
Tim Song authored
Change-Id: I5eb6b0d6b6d333a705294a3334547268cb4fdd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954640Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#723557}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e9aeaee52233..7f9e1a2dc019 git log e9aeaee52233..7f9e1a2dc019 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 iannucci@chromium.org Roll git to 2.24.1. Created with: gclient setdep -r src/third_party/depot_tools@7f9e1a2dc019 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032658 Tbr: agable@chromium.org Change-Id: I40dde7dabfb6402a17489924f4eb9576423c703f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960771Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ded86c1ad80b..947a380b81ec git log ded86c1ad80b..947a380b81ec --date=short --first-parent --format='%ad %ae %s' 2019-12-10 sakal@webrtc.org Split unit tests out of end-to-end PeerConnection test. 2019-12-10 danilchap@webrtc.org Migrate tests from RtpDepacketizer to VideoRtpDepacketizer interface 2019-12-10 mbonadei@webrtc.org Refresh some links in the docs folder. 2019-12-10 hbos@webrtc.org Initial version of ResourceAdaptationProcessor and friends. 2019-12-10 mbonadei@webrtc.org Revert "Moves TransportFeedbackAdapter to TaskQueue." 2019-12-10 dajo@webrtc.org Move audioproc_f to rtc_tools. Created with: gclient setdep -r src/third_party/webrtc@947a380b81ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d4d9643f298062bbf0174854645346ba11a6932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960519Reviewed-by:
-
Trent Apted authored
This is to prepare for writable files support in the next release. These changes were reviewed under go/media-app, but copies are needed in the chromium source tree for integration testing. Bug: 996088 Change-Id: I2fc2b19ef53c78fc54e69b41934b5b03cd53f24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959201 Commit-Queue: Trent Apted <tapted@chromium.org> Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#723554}
-
jorgegil@google.com authored
Implements TouchSelectionMenuClient functions required to request Smart Text Selection actions and to open the Quick Menu on cross-process subframes. Bug: 1020334 Change-Id: Iba3e6139db266a3ed1ea5dfbbf49c83ea7d5f3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954405Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Jorge Gil <jorgegil@google.com> Auto-Submit: Jorge Gil <jorgegil@google.com> Cr-Commit-Position: refs/heads/master@{#723553}
-
Findit authored
This reverts commit bf48f734. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 723529 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JmNDhmNzM0MGJmN2QwY2NiMjg4MmNjZDI2MmRmMTE3YWJhNmJiM2EM Sample Failed Build: https://ci.chromium.org/b/8894421463503746800 Sample Failed Step: compile Original change's description: > Android: Remove obsolete comments in javac.py > > Now that we have migrated to using the javac binary in third_party/jdk > and only turning on the errorprone plugin when it is enabled, we no > longer need this comment. > > Bug: 1030676 > Change-Id: I27a3d8ea19da698fa74e869fdcd878ca922956c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959901 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723529} Change-Id: Ieaa827f4029ddc0154ab848e3f7f12e0f17e3dd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961065 Cr-Commit-Position: refs/heads/master@{#723552}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb7c3388a50c..8ed7ae4c8e9b git log bb7c3388a50c..8ed7ae4c8e9b --date=short --first-parent --format='%ad %ae %s' 2019-12-10 amaiorano@google.com Fix REACTOR_DEFAULT_OPT_LEVEL not actually applying Created with: gclient setdep -r src/third_party/swiftshader@8ed7ae4c8e9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If5a921a6809f04a7e5be04984eda623ce7e1a499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960766Reviewed-by:
-
Sven Zheng authored
Added in crrev.com/c/1919544 trying to fix the bug. But it didn't work and I've fixed the bug in crrev.com/c/1956145. So it's time to delete these lines. Bug: 956016 Change-Id: I73e7c89068652db2976a00cef106f644dbbfbd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958697Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#723550}
-
Xida Chen authored
Right now the PaintRenderingContext2D::setTransform that takes a DOMMatrix would crash because it is NOTREACHED(). This CL implements that and add a layout test. Bug: 1029362 Change-Id: I1038dbe1bfcee14e128c46f73606fabcf3923caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951566 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#723549}
-
Gavin Williams authored
There are three main changes needed to improve the ChromeVox experience for the settings OS language page: -Apply aria-hidden to the language labels to remove them from ChromeVox navigation. Instead only navigate to the associated buttons -When a user chooses a language to display the system text in, a Restart button is displayed on the screen. That Restart button needs a label to better describe/announce its purpose. -Each item in the "Input method" keyboard list used two ChromeVox navigation stops instead of one. Applying aria-hidden to the inner div then aria-label to the outer div fixed this behavior Screen captures: Before: https://bugs.chromium.org/p/chromium/issues/detail?id=976452#c15 After: https://bugs.chromium.org/p/chromium/issues/detail?id=976452#c16 Bug: 976452 Change-Id: I90a70f3c4197a3b0f6eea3f8696d36766eba373d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952091 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#723548}
-
Yun Liu authored
Bug: 1025725 Change-Id: I7a3a7762289ba482093c4847c9406e1238e7081d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957329 Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: Yun Liu <yliuyliu@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#723547}
-
Ken Rockot authored
Moves these classes into Storage Service, including unit tests. No behavioral changes. Bug: 1000959 Change-Id: Icf444ef0e631237340ef6705d5f883c752138823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960808Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#723546}
-
Michael Thiessen authored
Introduces LibraryLoader#ensureMainDexInitialized, which registers MainDex jni, and runs native library initialization, allowing MainDex classes to use the native library earlier during startup. In testing on a Nexus 5 running Kitkat, typical runtimes are: -loadMainDexAlreadyLocked: ~70-100ms (includes loadlibrary call) -loadNonMainDexAlreadyLocked: ~50-75ms -initializeAlreadyLocked: ~3ms So this change allows any classes wanting to use native libraries earlier to block startup by ~50-75ms less on M and below :) Otherwise this should have no effect on startup. Bug: 783819 Change-Id: I410137c004257430acf85960000385247ab0fd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890496 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#723545}
-
Robert Liao authored
Clang-Tidy performed all of the transformations in this change except for the following: * components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm Protected instance variable reference from ConstrainedWindowAnimationBase. BUG=1030028 Change-Id: I1088576034cad4e758d53ed1bfc2c6aaafaf8706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959850Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723544}
-
Clark DuVall authored
This is no longer needed after http://crrev.com/c/1949403. We now have special handling for redirects that restart the loader. Bug: 1029944 Change-Id: I4c4bf3c5cb108e7428c9a047e1071dd3f7f2db04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956387Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#723543}
-
minch authored
Create a GestureProvider for back gesture, then the gesture sequence can be generated and handled in OnTouchEvent. This can avoid tap down event be used by the window that is underneath to do other things (e.g, highlight a menu item) instead of going back. Bug: 1022474 Change-Id: Ib72f5346afad5abfe44f898cbe9f443fdfe008c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955173 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#723542}
-
sczs authored
Moves bookmarks_egtest helpers into a new file BookmarkEarlgreyUtils. Change-Id: Ib03473684b160090428960d6b6b2437d4b748c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956226 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723541}
-
Ian Clelland authored
Bug: 993790 Change-Id: If427b1a27cbd4e67f6296c91936389eb3d8c6215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960515 Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#723540}
-
Hector Carmona authored
Bug: 1031008 Change-Id: I4aece44c572589531cc34aae023ea62dc14f381f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960183Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#723539}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f013e8b39651..e0582c36727b Created with: gclient setdep -r src-internal@e0582c36727b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1032272,chromium:1032343 Tbr: jbudorick@google.com Change-Id: Ieb93e5b3f78af7e5b75ed05db323911a01cc6449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723538}
-
Toni Barzic authored
Shelf orientation changes also change the space available for app list layout, and may cause app list layout/config changes. Generally, when not in tablet mode, this is addressed by dismissing app list when the shelf orientation changes (and updating layout when the app list is shown again). This cl adds similar handling for the case when tablet mode is started (which is expected to cause shelf orientation change for side-shelf) - the app list is dismissed, and then reshown again (with proper is_side_shelf() value). BUG=1031681 Change-Id: Ic7f1c442362e3aab6f544768d2cddaa8e042294e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955923Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#723537}
-
Liquan (Max) Gu authored
Why: Currently, PageInfo shows the page-info dialog for Tab only. Since we would like the dialog works for WebContents in general. We want to refactor PageInfoController to depend on WebContents rather than Tab. This patch is part of the effort. Change: * getOfflinePage() depends on Tab -> WebContents * isShowingTrustedOfflinePage() depends on Tab -> WebContents * TabImpl.getProfile() -> Profile.fromWebContents() * Activity -> ChromeActivity, because ConnectionInfoPopup.show() depends on ChromeActivity. Bug: 999196 Change-Id: Idb432edbbdb839d1b3cae2bfced6a4343861e7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960565Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723536}
-
chrome://conflictsDemetrios Papadopoulos authored
Also adding JS type checking. Bug: 1028829 Change-Id: Ib8b6c924a74495bde4b649a1bc10f308a717bebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957901Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#723535}
-
Becca Hughes authored
This reverts commit d4147193. Reason for revert: Suspect CL for tree closure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/150698 Original change's description: > Add presubmit check to ensure histograms do not have both units and enum > > Bug: 1004564 > Change-Id: I6b013baa1deae61956daf0675e8ebd4e8ffb66cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959414 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Tina Lu <ltina@google.com> > Cr-Commit-Position: refs/heads/master@{#723528} TBR=mpearson@chromium.org,isherman@chromium.org,ltina@google.com Change-Id: I7634c47832c9fdea5d1b557ba223273d8744f594 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960895Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#723534}
-
Maksym Onufriienko authored
Parent cl - http://crrev/c/1940752 Bug: 1940752, 1032184 Change-Id: Ie22a25dcc9c5fd318f522326fd0bc6acfb817c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949291Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#723533}
-
Trevor Perrier authored
This CL uses the refactor in two previous CLs [1][2] to add "af" as a as a locale to Android bundles (trichrome). This is the first step in testing if locales can be added just to Android bundles. This is done by: 1) adding "af" to locales when compiled on Android 2) adding "af" .xml and .pak exports to all .grd files used by Android. It also refactors many hardcoded grit output lists in BUILD files so that future language changes do not need to edit as many files. Note on size increase: SystemWebView does not support bundles so languages can not be split. This means that even in APK builds that do not use the new locales have a size increase. Since SystemWebView should support all languages that Android does this size increase is unavoidable. [1] https://crrev.com/c/1939962 [2] https://crrev.com/c/1940949 Bug: 812837 Change-Id: Id0143cc39bb08715b9b8036c56409b58623eeea1 Binary-Size: Size increase is unavoidable (see above). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941058 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#723532}
-
Lily Chen authored
This adds the domain and path of the cookie (in addition to the name which is already logged) to the NetLog entries for COOKIE_INCLUSION_STATUS. Since the name, domain, and path of a cookie uniquely identify the cookie, this information is helpful for debugging. Bug: 1005217 Change-Id: I74d1a77212c40a096ea76ff0b041bdab0fb31f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959659Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#723531}
-
David Benjamin authored
If c.example has HSTS with includeSubDomains and b.c.example has HSTS *without* includeSubDomains, we currently treat a.b.c.example as *not* HSTS. The b.c.example masks off the c.example entry. This behavior was, at one point, relied on by a corporate deployment per https://crbug.com/469957. However, the analysis in the bug that it matches the spec was incorrect. RFC 6797 sections 8.2 and 8.3 spell out the matching rules explicitly and they do not include the shadowing behavior. The analysis that it matches all other browsers was also incorrect. Chrome and Firefox have the shadowing behavior while Edge and Safari do not. This behavior is also surprising and increases the risk of a misconfigured site losing HSTS's security properties, particularly around cookie injection. As the first step towards fixing this, measure how often this makes a difference, Bug: 469957, 821811 Change-Id: I22cb443cd1f1a378ec1794575b9082905f74150c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955334 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723530}
-
Peter Wen authored
Now that we have migrated to using the javac binary in third_party/jdk and only turning on the errorprone plugin when it is enabled, we no longer need this comment. Bug: 1030676 Change-Id: I27a3d8ea19da698fa74e869fdcd878ca922956c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959901 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Tina Lu authored
Bug: 1004564 Change-Id: I6b013baa1deae61956daf0675e8ebd4e8ffb66cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959414Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tina Lu <ltina@google.com> Cr-Commit-Position: refs/heads/master@{#723528}
-
delima02 authored
Add method to all implementing classes. See go/hotrodsethome for more details. Bug: b:139706624 Change-Id: I7d884e259135b46715e1dbceda6e8aa85a7c32fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917970 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#723527}
-
