GitLab

BUG=none
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2313253003
Cr-Commit-Position: refs/heads/master@{#417075}

We're not actively using them and they make code hard to read and
change.

R=sunnyps@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2314323003
Cr-Commit-Position: refs/heads/master@{#417074}

When profiling some sites that are slow to build an accessibility tree,
a lot of time was spent retrieving the document, root accessibility object,
or focused accessibility object. Introduce the concept of freezing
BlinkAXTreeSource, which precomputes these once, and then allows them to
be reused through the rest of a function scope.

This is safe because the accessibility tree does not change during processing
of an accessibility event.

For one cs.chromium.org page, this sped up initial load by 50% (1000 ms
to 650 ms) and single-node updates by 400% (90 ms to 23 ms).

BUG=631923,638474

Review-Url: https://codereview.chromium.org/2205083002
Cr-Commit-Position: refs/heads/master@{#417073}

Delete the associated GYP files.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2316293002
Cr-Commit-Position: refs/heads/master@{#417072}

This patch adds some comments to describe the cc ScrollNode members.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2310323002
Cr-Commit-Position: refs/heads/master@{#417071}

We shouldn't treat a navigation as NAVIGATION_TYPE_SAME_PAGE if
there is no last committed entry.

BUG=640429
TEST=No known repro steps.  Crashes should go away.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2319843002
Cr-Commit-Position: refs/heads/master@{#417070}

This CL (hopefully) removes all calls to these methods in android_webview:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2315863002
Cr-Commit-Position: refs/heads/master@{#417069}

Some extensions tests had the toolbar redesign disabled by a custom override.
Some of these are testing legacy behavior, but many were just never changed
over. Update
many to remove the custom override, enabling the redesign.

In order to stay targeted, this CL doesn't update behavior expectations
for any tests. That will be done in a followup.

BUG=None

Review-Url: https://codereview.chromium.org/2311533002
Cr-Commit-Position: refs/heads/master@{#417068}

This CL alphabetizes the settings vars by separating the --settings-*
and --paper-* vars.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2315033002
Cr-Commit-Position: refs/heads/master@{#417067}

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/h4ooaB_Y9JE/nh7vXshGBwAJ

BUG=425896,640825
R=sigbjornf@opera.com,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2295863002
Cr-Commit-Position: refs/heads/master@{#417066}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f2348b4..391b9e37

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2319803002
Cr-Commit-Position: refs/heads/master@{#417065}

This will give us an upper bound on the % of iframes for which we can
defer loading.

BUG=635105

Review-Url: https://codereview.chromium.org/2212183004
Cr-Commit-Position: refs/heads/master@{#417064}

The fade-out frames were being calculated with the input sample rate
instead of the output sample rate.

Also updated the logging to make debugging easier.

BUG=

Review-Url: https://codereview.chromium.org/2324533002
Cr-Commit-Position: refs/heads/master@{#417063}

This is a reland of https://codereview.chromium.org/2293603002/.

Reason for revert: Build fails with: jmake: Could not find class file
for
/tmp/tmp7BuImL/java/org/chromium/browser/webapps/ChromeWebApkHostSignature.java.

Original CL description:
> [WebApk] Update verification keys.
>
> Update keys to latest test keys and also break it out by channel.
>
> TBR=rsesek@chromium.org,yfriedman@chromium.org
>
> Committed: https://crrev.com/716cc589da62b7cc48ac0542fe01239808687ec9
> Cr-Commit-Position: refs/heads/master@{#416339}

Patchset 1 on https://codereview.chromium.org/2317273002/ is the original
landed patch from https://codereview.chromium.org/2293603002/. Patchset 2
contains the fix in the build file.

TBR=rsesek@chromium.org,yfriedman@chromium.org,dfalcantara@chromium.org,mdjones@chromium.org

Review-Url: https://codereview.chromium.org/2317273002
Cr-Commit-Position: refs/heads/master@{#417062}

https://chromium.googlesource.com/skia.git/+log/62e9b145a13a..ef6a9b7f9393

$ git log 62e9b145a..ef6a9b7f9 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 halcanary android_skp_capture.sh
2016-09-07 mtklein clang_linux: also build an MSAN libc++
2016-09-07 msarett Delete SkColorSpace::gammaNamed() from public API
2016-09-07 egdaniel Merge building of program desc in Vulkan into one step

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2318343002
Cr-Commit-Position: refs/heads/master@{#417061}

This CL pulls in base's proguard flags when compiling
cronet_sample_apk and cronet_package.

Cronet will not need to duplicate proguard flags and can
benefit from base proguard file changes.

This saves about 1882 - 1471 = 411 methods from our dex
count for CronetSample.apk and 10kB(4.35%).

BUG=634998

Review-Url: https://codereview.chromium.org/2214013002
Cr-Commit-Position: refs/heads/master@{#417060}

This CL (hopefully) removes all calls to these methods in ui:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2315003002
Cr-Commit-Position: refs/heads/master@{#417059}

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2317563004
Cr-Commit-Position: refs/heads/master@{#417058}

Missed in https://codereview.chromium.org/12180027

BUG=None

Review-Url: https://codereview.chromium.org/2324463002
Cr-Commit-Position: refs/heads/master@{#417057}

This is part of a refactor to split WebView/WebWidget.

BUG=583347

Review-Url: https://codereview.chromium.org/2315223003
Cr-Commit-Position: refs/heads/master@{#417056}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b6837ba5832ef4b25103a9e9680e7cd0c275ef41 [Android] Enable USB reset on perf bots. (jbudorick@chromium.org)

R=jbudorick@chromium.org
BUG=644721,642194

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2322663002
Cr-Commit-Position: refs/heads/master@{#417055}

There were instances of crashes during destruction with nested
WebContents, if an inter-process scroll bubble was in progress. This
patch verifies that there the WebContents hasn't been disconnected
from its RenderWidgetHosts before attempting to cancel scroll
bubbling and dereferencing the RenderWidgetHostDelegate pointer.

BUG=644306
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2319633002
Cr-Commit-Position: refs/heads/master@{#417054}

BUG=625847

Review-Url: https://codereview.chromium.org/2302513002
Cr-Commit-Position: refs/heads/master@{#417053}

The elements panel was waiting for DOMSyntaxHighligher to strip the leading newline from script tags, which made testing flaky.

BUG=623802

Review-Url: https://codereview.chromium.org/2300633005
Cr-Commit-Position: refs/heads/master@{#417052}

Any modification to a Chrome installation should be done within the
scope of a SetupSingleton. There can be only one active SetupSingleton
per Chrome installation at a time.

SetupSingleton will be used to ensure that an update process doesn't
run at the same time as a process deleting old files.

BUG=310211

Review-Url: https://codereview.chromium.org/2292293002
Cr-Commit-Position: refs/heads/master@{#417051}

BUG=643523
TBR=georgesak@chromium.org

Review-Url: https://codereview.chromium.org/2317083002
Cr-Commit-Position: refs/heads/master@{#417050}

BUG=644623

Review-Url: https://codereview.chromium.org/2321573003
Cr-Commit-Position: refs/heads/master@{#417049}

Avoid logging "Unable to get cursor width capability:
Invalid argument" and "Could not initialize DRM device"
warnings, as these are expected conditions on some systems.

BUG=644796

Review-Url: https://codereview.chromium.org/2314423003
Cr-Commit-Position: refs/heads/master@{#417048}

BUG=556508

Review-Url: https://codereview.chromium.org/2304863003
Cr-Commit-Position: refs/heads/master@{#417047}

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2315313003
Cr-Commit-Position: refs/heads/master@{#417046}

BUG=635403

Review-Url: https://codereview.chromium.org/2318313002
Cr-Commit-Position: refs/heads/master@{#417045}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Referrer| type and
a |referrer| accessor method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Referrer| being the name of both the type and the accessor method
(with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312

Review-Url: https://codereview.chromium.org/2308063002
Cr-Commit-Position: refs/heads/master@{#417044}

In [1] we switched the under-invalidation color from red to semi-opaque
magenta to differentiate under-invalidation from the red that may be
present in tests. This turned out to lead to confusing results in [2]
and may get mistaken for intended test results. This patch switches to
fully opaque dark red which should be more noticeable as a bad result.

[1] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9
[2] https://codereview.chromium.org/2305023003

Review-Url: https://codereview.chromium.org/2307213002
Cr-Commit-Position: refs/heads/master@{#417043}

Replace them with vector<unique_ptr<T>>.

After this CL there will be only 3 places where ScopedVector
would still be around. Since those (language_settings_private_delegate.cc,
web_navigation_apitest.cc and chrome_content_browser_client_extensions_part.cc)
are non-trivial, I will try to remove ScopedVector from them in subsequent CLs.

BUG=556939
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2310683002
Cr-Commit-Position: refs/heads/master@{#417042}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- accessibility_extension
- echo_private
- first_run_private
- browser
- browsing_data
- commands
- developer_private
- font_settings
- chrome_direct_setting

BUG=634140

Review-Url: https://codereview.chromium.org/2298493003
Cr-Commit-Position: refs/heads/master@{#417041}

Windows buildbot failed, reverting for now.

TBR=thakis@chromium.org
BUG=630728
NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2316353002
Cr-Commit-Position: refs/heads/master@{#417040}

https://chromium.googlesource.com/skia.git/+log/5edf2908a305..62e9b145a13a

$ git log 5edf2908a..62e9b145a --date=short --no-merges --format='%ad %ae %s'
2016-09-07 robertphillips Revert of Add GM/slide to simulate Android-style reveal clip (patchset #6 id:100001 of https://codereview.chromium.org/2316593003/ )
2016-09-07 brianosman Add minimal support for readPixels in raster F16
2016-09-07 msarett Use demux API in SkWebpCodec
2016-09-07 robertphillips Add GM/slide to simulate Android-style reveal clip
2016-09-07 bsalomon Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2319773002
Cr-Commit-Position: refs/heads/master@{#417039}

Original changelist: http://crrev.com/2212853002

This change landed and was then reverted because it broke ChromeVox when
logging in when it was already enabled on the login screen. The issue was
that AccessibilityManager needed to add the component extension to each
profile.

The immediate benefit is that ComponentLoader doesn't need to depend on
AccessibilityManager - previously they both depended on each other.

The end goal is to refactor AccessibilityManager so that it can support
multiple accessibility component extensions. Rather than a separate function
in ComponentLoader to load each one, I think it'd make more sense for
AccessibilityManager to just call ComponentLoader with the appropriate
parameters like the extension id and path.

BUG=634233
TEST=Toggle ChromeVox on/off from login screen, logged-in session, and guest session. Enable ChromeVox in login screen and log in, ensure ChromeVox remains on. Try with both ChromeVox Classic and Next.

Review-Url: https://codereview.chromium.org/2291133005
Cr-Commit-Position: refs/heads/master@{#417038}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0991a2aad45a..1931d2d4322f

$ git log 0991a2aad..1931d2d43 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 eakuefner [Tracing] Fix close button in groupby picker

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2322643002
Cr-Commit-Position: refs/heads/master@{#417037}

Improve naming of PlatformScreen implementations.

BUG=none

Review-Url: https://codereview.chromium.org/2317073003
Cr-Commit-Position: refs/heads/master@{#417036}