- 03 Feb, 2015 40 commits
-
-
dgn authored
Some printing related //android_webview were copied over from //chrome. Now that the ones in //chrome can move to a component, webview should also use these files. Depends on https://codereview.chromium.org/811563008/ BUG=444883, 311308 Review URL: https://codereview.chromium.org/822133003 Cr-Commit-Position: refs/heads/master@{#314307}
-
msramek authored
BUG=452828 Review URL: https://codereview.chromium.org/880223002 Cr-Commit-Position: refs/heads/master@{#314306}
-
p.sergey authored
Make android webview shell behaviour to be like chrome shell: enable zoom and fit we page contents into viewport. BUG=n/a Review URL: https://codereview.chromium.org/872363005 Cr-Commit-Position: refs/heads/master@{#314305}
-
hirono authored
This is the provider by using FileEntry#getMetadata. TEST=FileManagerJsTest.FileSystemMetadataProvider BUG=410766 Review URL: https://codereview.chromium.org/894313002 Cr-Commit-Position: refs/heads/master@{#314304}
-
cschuet authored
Implementation of the NetworkingConfigService and boiler plate code for the networking.config API. Reviewers: Please see 1) https://docs.google.com/document/d/1V8YGouKC477iC11L4PL8H_HU1Ru3R5kMhXppuoIVNeo for the design document. 2) https://docs.google.com/drawings/d/12Hai1LdaPzwtkrQUdCjSpt1s7InRNNBDeWiW5ujfIRg for a flow diagram. Review URL: https://codereview.chromium.org/880073002 Cr-Commit-Position: refs/heads/master@{#314303}
-
kozyatinskiy authored
This reverts commit c511691c. CL added SetUpgradeAndCheckCredentials test. This test failed on Mac 10.6 build bot. TBR=mlerman@chromium.org, NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/875983008 Cr-Commit-Position: refs/heads/master@{#314302}
-
noel authored
Revert of Move the call to CRYPTO_set_NEON_capable up. (patchset #1 id:1 of https://codereview.chromium.org/899463002/) Reason for revert: Suspect this change upset the webkit ChromeOS Test 1, Mac 10.8, encrypted media tests. Reverting to see if these builders turn green. http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/9563 Original issue's description: > Move the call to CRYPTO_set_NEON_capable up. > > BoringSSL needs to probe for NEON support via SIGILL in cases where > getauxval isn't provided and the application doesn't do explicit > initialisation. > > However, Chromium might have gone multithreaded by the time that we > initialise BoringSSL and, although it doesn't look like we'll race the > disposition of SIGILL with anything, it's best not to test that hope. > > So this change causes CRYPTO_set_NEON_capable to always be called, and > to be called before SSL_library_init. BoringSSL will take that as a > signal that probing for NEON support isn't needed. > > BUG=none > > Committed: https://crrev.com/fa9063829e638aeb72ede79e5d0396a81a0211d1 > Cr-Commit-Position: refs/heads/master@{#314201} TBR=davidben@chromium.org,agl@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/895013002 Cr-Commit-Position: refs/heads/master@{#314301}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/b12ea41..fef4c32 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/884033003 Cr-Commit-Position: refs/heads/master@{#314300}
-
fsamuel authored
BUG=none TBR=kenrb@chromium.org Review URL: https://codereview.chromium.org/896753002 Cr-Commit-Position: refs/heads/master@{#314299}
-
plundblad authored
The test was disabled because it was flaky. This CL tries to address that and reenables the test. This relands the previous attempt which was still flaky on slow enough environments (such as the memory bots). BUG=346797 R=dtseng@chromium.org Committed: https://crrev.com/e03f042d1c76262248e42334b1d0326b0e4319e7 Cr-Commit-Position: refs/heads/master@{#313467} Review URL: https://codereview.chromium.org/866713002 Cr-Commit-Position: refs/heads/master@{#314298}
-
hirono authored
The CL adds: * Assertion for property names passed to NewMetadataProvider. * Existance check for results obtained from getImpl. BUG=410766 TEST=FileManagerJsTest.NewMetadataProvider Review URL: https://codereview.chromium.org/899603002 Cr-Commit-Position: refs/heads/master@{#314297}
-
v8-autoroll authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/891183004 Cr-Commit-Position: refs/heads/master@{#314296}
-
yawano authored
ListThumbnailLoader is a thumbnail loader for list style ui. For the images in the viewport, either thumbnailLoaded event is dispatched or getThumbnailFromCache will return from cache. BUG=438050 TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader Review URL: https://codereview.chromium.org/885323002 Cr-Commit-Position: refs/heads/master@{#314295}
-
rickyz authored
BUG=387037 Review URL: https://codereview.chromium.org/885423003 Cr-Commit-Position: refs/heads/master@{#314294}
-
alexandrec authored
The main toolbar of the Material Design PDF Viewer (at the top containing page selection functionality) is set to use the 'core-narrow' class, setting it to the same height as the toolbar in Inbox by Google. BUG=110020 Review URL: https://codereview.chromium.org/891563004 Cr-Commit-Position: refs/heads/master@{#314293}
-
xhwang authored
Previously ProtectedMediaIdentifierPermissionContext is only used on Android. In this CL: - ChromeOS is using the stanand infobar/bubble permission UI. - ChromeOS is using the same strings as Android. This should be fixed or reevaluated. See below. Follow up work: 1. Make sure the infobar/bubble UI (including strings) is good for ChromeOS. 2. Fix the icon for the infobar/bubble on ChromeOS. 3. If we cannot get (1) and (2) done, use the current ChromeOS UI (see PlatformVerificationDialog) for ProtectedMediaIdentifierPermissionContext. TBR=cpu@chromium.org BUG=446263 TEST=Tested on ChromeOS build. Review URL: https://codereview.chromium.org/863263007 Cr-Commit-Position: refs/heads/master@{#314292}
-
alexandrec authored
Previously, typing Ctrl-G would pop up the "find-text" box, appearing to be an alias for Ctrl-F. Doing so will now highlight the page number in the viewer-page-selector, allowing for a quick and easy method to go to another page. Changed viewer-page-selector to use a combination of paper-input-decorator and input instead of a sole paper-input. This affords us greater flexibility and should ease maintenance. BUG=55920 Review URL: https://codereview.chromium.org/888343003 Cr-Commit-Position: refs/heads/master@{#314291}
-
yurys authored
ScriptPreprocessor is being deprecated and will be removed soon. This CL prepares page_handler for removing scriptPreprocessor parameter from Page.reload command. BUG=394230, 438626 Review URL: https://codereview.chromium.org/898433002 Cr-Commit-Position: refs/heads/master@{#314290}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#314289}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/e67164d..b12ea41 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/890233003 Cr-Commit-Position: refs/heads/master@{#314288}
-
jam authored
TBR=vabr@chromium.org BUG=346297 Review URL: https://codereview.chromium.org/896723003 Cr-Commit-Position: refs/heads/master@{#314287}
-
wuyingbing authored
BUG=422869 Review URL: https://codereview.chromium.org/898443004 Cr-Commit-Position: refs/heads/master@{#314286}
-
mgiuca authored
In FindPreviousFocusableViewImpl, in the recursive call to visit the sibling node, preserves can_go_up, rather than forcing it to true. Added FocusTraversalNonFocusableTest (test the pathological case outlined in the bug report). Also fixed existing comment in test file describing the view hierarchy to match reality. BUG=453699 BUG=438425 BUG=451140 Review URL: https://codereview.chromium.org/886033002 Cr-Commit-Position: refs/heads/master@{#314285}
-
rickyz authored
BUG=312380 Review URL: https://codereview.chromium.org/881733002 Cr-Commit-Position: refs/heads/master@{#314284}
-
hidehiko authored
In nacl_helper_nonsfi, getpid() is prohibited to be called by seccomp-bpf (will be implemented somehow soon). So, base::GetCurrentProcID() used in IPC library, which uses getpid(), would cause a SIGSYS crashing. As, in nacl_helper_nonsfi, PID is actually not used, so this CL replaces it with -1 (dummy PID). Note that the more generic CL crrev.com/695353005, which replaces PID with dummy also on Linux platforms, was landed once, but reverted due to it was still in use (crbug.com/441312). This CL extracts only Non-SFI related part to avoid breakage. TEST=Ran bots. BUG=358465, 441312 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm Review URL: https://codereview.chromium.org/879303004 Cr-Commit-Position: refs/heads/master@{#314283}
-
bokan authored
The visible viewport is the area of the window that is visible. For example, when the on-screen keyboard obscures part of the window we shrink the visible viewport to allow the page to "overscroll" the obscured area into view. When we resize the window, the visible viewport should be resized along with it. Also renamed ResizeSynchronously since it sets the rect, not just the size. Same for initial_pos_. This was breaking the css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html layout test upon turning on virtual-viewport. BUG=444952 Review URL: https://codereview.chromium.org/894193003 Cr-Commit-Position: refs/heads/master@{#314282}
-
miu authored
Adds support for automatic on-line reconfiguration of the VP8 software encoder whenever the video frame size changes. libvpx supports shrinking frame sizes without tearing down the encoder, but growing frames sizes still requires a full tear-down and re-creation. Most of this change involves adding extensive unit testing to confirm media/cast is now capable of handling variable frames sizes end-to-end. In addition, the cast_sender_app and cast_receiver_app diagnostic tools have been updated. An upcoming change will eliminate the width and height properties from media::cast::VideoSenderConfig, which are both being ignored now. BUG=451277 TBR=hubbe@chromium.org Review URL: https://codereview.chromium.org/892383002 Cr-Commit-Position: refs/heads/master@{#314281}
-
dmazzoni authored
See bug for details. This patch makes it so that we fire the events IA2_EVENT_TEXT_INSERTED and IA2_EVENT_TEXT_REMOVED when the children referenced by the embedded object characters changed, not just when the text changed. This patch also avoids incorrectly firing these same two events on a newly-created node. BUG=425861 Review URL: https://codereview.chromium.org/859133003 Cr-Commit-Position: refs/heads/master@{#314280}
-
hirono authored
The class will be used as the base class of all metadata provider. The class has abstrct getImpl method and sub-class of the class should inherit the function. The class also contains MetadataProviderCache that is a sub-class of MetadataCacheSet, and caches the result of getImpl method. BUG=410766 TEST=FileManagerJsTest.NewMetadataProvider Review URL: https://codereview.chromium.org/894283002 Cr-Commit-Position: refs/heads/master@{#314279}
-
kelvinp authored
Currently most objects in the Chromoting Webapp doesn't unhook events until the page is unloaded. This introduces unintentional coupling between an object's lifetime and the app's lifetime. This CL implements a lightweight utility class to make unhooking listeners easier. BUG=454552 Review URL: https://codereview.chromium.org/863863003 Cr-Commit-Position: refs/heads/master@{#314278}
-
raymes authored
BUG=454335 Review URL: https://codereview.chromium.org/863863005 Cr-Commit-Position: refs/heads/master@{#314277}
-
skuhne authored
BUG=452608 TEST=existing unit tests Review URL: https://codereview.chromium.org/890293002 Cr-Commit-Position: refs/heads/master@{#314276}
-
sammc authored
A previous change to skip displaying zoom levels for host and scheme zoom changes caused host-only zoom changes to be skipped due to surprise case fallthrough. This adds a break so the correct zoom settings are displayed. BUG=454254 Review URL: https://codereview.chromium.org/879333003 Cr-Commit-Position: refs/heads/master@{#314275}
-
thestig authored
Revert of offset namespace ids (patchset #7 id:120001 of https://codereview.chromium.org/881253004/) Reason for revert: Tests now only work if they ran in the "right" order. DOMStorageContextImplTest.Basic fails if the tests are shuffled: content_unittests --gtest_filter=DOMStorageContextImplTest.*:DOMStorageAreaTest.* --gtest_shuffle Original issue's description: > [DOMStorage] Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another. > > Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e > Cr-Commit-Position: refs/heads/master@{#314256} TBR=jsbell@chromium.org,michaeln@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/896733002 Cr-Commit-Position: refs/heads/master@{#314274}
-
dfalcantara authored
* Create a new skeleton InfoBarDelegate for app banners containing information about apps defined by web manifests. * Displays an infobar when the user navigates to a page with a manifest. * Adds a string for "Add to homescreen" for the new infobar. BUG=453170 Review URL: https://codereview.chromium.org/893073002 Cr-Commit-Position: refs/heads/master@{#314273}
-
mitchelljones authored
This feature should exist for hosted apps, currently there is no option to search a page. Instead of removing these two menu items, they are now hidden if the app that is currently focussed is not a hosted app. BUG=450834 Review URL: https://codereview.chromium.org/864153003 Cr-Commit-Position: refs/heads/master@{#314272}
-
Daichi Hirono authored
BUG=410766 TEST=None R=yawano@chromium.org Review URL: https://codereview.chromium.org/895723003 Cr-Commit-Position: refs/heads/master@{#314271}
-
Daichi Hirono authored
Currently the startRequests method of metadata models has a responsibility to create requests as well as to mark the cache as loading. In the following patch, we need to apply the requests that are generated by another cache set. Thus the method should be split into two methods (one is for creating requests and another is for marking cache as loading). BUG=410766 TEST=FileManagerJsTest.MetadataCacheSet,FileManagerJsTest.MetadataCacheItem R=yawano@chromium.org Review URL: https://codereview.chromium.org/895783003 Cr-Commit-Position: refs/heads/master@{#314270}
-
jbauman authored
The trees this composites may contain SurfaceLayers, so they have to be aggregated into a Display before being drawn. Also move OnscreenDisplayClient and SurfaceDisplayOutputSurface into cc/surfaces/ so they can be used by ui/compositor. Review URL: https://codereview.chromium.org/888783002 Cr-Commit-Position: refs/heads/master@{#314269}
-
tapted authored
On Mac, events need to be mapped to "Action" messages by an NSResponder to obey platform behaviour and user customizations (e.g. a "Home" keypress should be interpreted as beginning of document, not beginning of line). Action messages are also the manner by which a user on Mac can add custom keybindings, by making entries in ~/Library/KeyBindings/DefaultKeyBinding.dict ActionMessages map well to editing commands for text fields, but not as well for other controls. For example, MenuController needs to catch the action message "cancel:" to handle the escape key. The approach in this CL is for BridgedContentView, an NSResponder, to map Action Messages to the editing command as well as the KeyCode that toolkit-views expects for that action. To test, textfield_unittests are updated to allow two kinds of event dispatch. Before this CL, all the TextfieldTest views_unittests were already passing on a toolkit-views Mac build. This is because the tests send KeyCodes directly to the InputMethod rather than to the window. However, this meant that action messages didn't come into play. To test "real" keystrokes on Mac and get good coverage of the action message overloads, the ui::test::EventGenerator is now used in textfield_unittest.cc to generate platform-specific events that are dispatched to the Window. Previously, all keyboard events were redirected to the InputMethod. BUG=378134 Review URL: https://codereview.chromium.org/879253002 Cr-Commit-Position: refs/heads/master@{#314268}
-