GitLab

BUG=596555

Review URL: https://codereview.chromium.org/1900373002

Cr-Commit-Position: refs/heads/master@{#388566}

BUG=b:24572007

Review URL: https://codereview.chromium.org/1891423003

Cr-Commit-Position: refs/heads/master@{#388565}

Remaining dependencies are necessitated by DockedWindowLayoutManager.

BUG=603369
TEST=covered by other tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1901593004

Cr-Commit-Position: refs/heads/master@{#388564}

Also makes SetServicesDiscoveryComplete virtual. This way we can have
different implementations of these functions.

Also modifies mock adapters to specify what this now virtual functions
return.

BUG=599472

Review URL: https://codereview.chromium.org/1908523002

Cr-Commit-Position: refs/heads/master@{#388563}

The let's add more params approach makes the test very hard to
read, so this pulls out a params/builder-ish method that hopefully
clears this up (for people other than just me).

BUG=

Review URL: https://codereview.chromium.org/1909503003

Cr-Commit-Position: refs/heads/master@{#388562}

CreateSharedMemory() has been deprecated and no longer needs to be
overridden in DesktopCapturer::Callback implementations.

Review URL: https://codereview.chromium.org/1902593004

Cr-Commit-Position: refs/heads/master@{#388561}

If the timeConstant is not strictly positive, setTargetAtTime should
throw an error.

BUG=604775
TEST=audioparam-exceptional-values.html updated with new test

Review URL: https://codereview.chromium.org/1897293002

Cr-Commit-Position: refs/heads/master@{#388560}

After thre refactoring related to remoteviews based bottom bar, the old
API stopped working. This CL fixes the breakage.

BUG=604849

Review URL: https://codereview.chromium.org/1895813004

Cr-Commit-Position: refs/heads/master@{#388559}

Revert of [tracing] Turn StackFrame into struct. (patchset #5 id:80001 of https://codereview.chromium.org/1891543003/ )

Reason for revert:
Broke build on Windows x64 (warning was treated as error): heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>
> BUG=602701

TBR=primiano@chromium.org,ssid@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602701

Review URL: https://codereview.chromium.org/1907593002

Cr-Commit-Position: refs/heads/master@{#388558}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d3578ff8c479..5a702cdeb6e3

$ git log d3578ff8c..5a702cdeb --date=short --no-merges --format='%ad %ae %s'

BUG=602701

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1902103004

Cr-Commit-Position: refs/heads/master@{#388557}

I want to store some state in properties that needs to be valid from
the LayoutManagers destructor. This means the LayoutManager needs to
be destroyed before owned properties.

BUG=603369
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1910483002

Cr-Commit-Position: refs/heads/master@{#388556}

TBR=mattm@chromium.org
BUG=598752

Review URL: https://codereview.chromium.org/1908613002

Cr-Commit-Position: refs/heads/master@{#388555}

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599

Review URL: https://codereview.chromium.org/1896163003

Cr-Commit-Position: refs/heads/master@{#388554}

This change turns StackFrame (aka const char*) into a struct and
introduces 'type' field which controls how stack frame is formatted
when it's written to trace file. As an example, thread name, which
previously was just a string like any other function name, is now
formatted as '[Thread: %s]'.

More stack frame types will be added in the future, for example
native allocation tracing will add 'program counter' type.

BUG=602701

Review URL: https://codereview.chromium.org/1891543003

Cr-Commit-Position: refs/heads/master@{#388553}

I suspect that the task runner is null for some reason which caused the
crash in the bug. Since I can't repro locally, adding a CHECK so help
investigation.

BUG=604869

Review URL: https://codereview.chromium.org/1896173003

Cr-Commit-Position: refs/heads/master@{#388552}

Currently CanvasPathMethods does a premature optimization in
stroking line, curve, arc, rect---it drops the point when the
 point is identical to current point, or in the case or
curve, drops the curves when the two given points are
identical. The results in incorrect rendering of zero-length
paths with caps, based on the specification
(https://www.w3.org/TR/2dcontext/#drawing-paths-to-the-canvas).

The five layout tests in philip/tests/2d.path.stroke.prune.*.html
are outdated canvas tests. Based on the spec change and the test
results here
 (https://philip.html5.org/tests/canvas/suite/tests/results.html),
other browsers report false positive errors on these
tests too. We thus match what other browsers do in this
aspect and rebaseline the expected outputs.

BUG=322807,577655

Review URL: https://codereview.chromium.org/1883693002

Cr-Commit-Position: refs/heads/master@{#388551}

The spec calls for one additional pt of space between the icon and the
text.

R=avi@chromium.org
BUG=596684

Review URL: https://codereview.chromium.org/1900873004

Cr-Commit-Position: refs/heads/master@{#388550}

Browser tests that do media playback have never worked on internal
builds (they are disabled there) because we block media playback
until an application moves to foreground.  The test page never
reaches this state because it is managed outside ApplicationManager.

With this change, starting a test page can be delegated to internal
code and handled through ApplicationManager.  This allows the test
to reach foreground status and play media.

BUG=internal b/27192870

Review URL: https://codereview.chromium.org/1870443003

Cr-Commit-Position: refs/heads/master@{#388549}

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1895413005

Cr-Commit-Position: refs/heads/master@{#388548}

The OzonePlatform instance doesn't exist in the chrome browser process
when running mash. ImeKeyboardOzone tries to access the instance and
crashes. Always use FakeImeKeyboard with mash until mash IME work is
started and this can be done properly.

BUG=603959

Review URL: https://codereview.chromium.org/1908583002

Cr-Commit-Position: refs/heads/master@{#388547}

BUG=604728

Review URL: https://codereview.chromium.org/1910523002

Cr-Commit-Position: refs/heads/master@{#388546}

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

TBR=lcwu@chromium.org,mmenke@chromium.org
BUG=576864,554287

Review URL: https://codereview.chromium.org/1897033002

Cr-Commit-Position: refs/heads/master@{#388545}

This patch enables non-activities to receive intent callbacks for
intents that they have not launched. For example, Android Pay API
launches an intent with the given callback ID on your behalf:

  Wallet.Payments.loadFullWallet(apiClient, dataRequest, CALLBACK_ID);

https://developers.google.com/android-pay/android/tutorial#request_the_full_wallet

BUG=602658

Review URL: https://codereview.chromium.org/1902903003

Cr-Commit-Position: refs/heads/master@{#388544}

Fix handling of replies to DevTools commands which don't include any
parameters. Previously we used th presence of the reply dictionary to
decide between a callback with or without parameters, but this
dictionary can be present in the reply also when there are no actual
parameters in it.

BUG=595353

Review URL: https://codereview.chromium.org/1898633006

Cr-Commit-Position: refs/heads/master@{#388543}

Renamed many methods and constants. Updated their associated comments
to be consistent with how they're actually used and to hopefully be less
confusing to future readers. Also did some minor code cleanup.

No visible differences are intended as a result of this change.

Review URL: https://codereview.chromium.org/1869163003

Cr-Commit-Position: refs/heads/master@{#388542}

This CL directs the Settings link in sign in confirmation screen to sign in settings screen instead of sync settings screen.

BUG=595349

Review URL: https://codereview.chromium.org/1893643002

Cr-Commit-Position: refs/heads/master@{#388541}

Also check that AVDATimerManager is only accessed on one thread.

BUG=604869
TEST=No functionality change.

Review URL: https://codereview.chromium.org/1903013002

Cr-Commit-Position: refs/heads/master@{#388540}

This removes the definition of use_openssl from build/common.gypi since
nothing should be relying on it anymore.

R=thakis@chromium.org
BUG=604728

Review URL: https://codereview.chromium.org/1904453002

Cr-Commit-Position: refs/heads/master@{#388539}

This contains the changes to net_util.*, which now uses "localhost" instead of "127.0.0.1", so that we can connect to IPv6-enabled instances of DevTools. It also contains some extra logging for debugging purposes.

BUG=chromedriver:779
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/1879863002

Cr-Commit-Position: refs/heads/master@{#388538}

https://chromium.googlesource.com/skia.git/+log/09aa1fce69b2..36db3f44b6cd

$ git log 09aa1fce6..36db3f44b --date=short --no-merges --format='%ad %ae %s'
2016-04-20 brianosman Add control of the sRGB global hack flag in SampleApp
2016-04-20 halcanary gyp: add osmesa target to factor out common code
2016-04-20 halcanary SkFontHost/FreeType/ToUnicode: add an assert
2016-04-20 scroggo Add instructions for building with MSAN

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/1909583002

Cr-Commit-Position: refs/heads/master@{#388537}

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1900013004

Cr-Commit-Position: refs/heads/master@{#388536}

New pdfviewer starts to handle http scheme.
As a result, clicking a pdf link will no longer trigger a download.
Instead, the navigation will be intercepted and passed to pdfviewer.
We previously added the referrer extra for analytics purpose for pdfviewer.
But that only happens in the download code.
This CL fixes the referrer field issue for intercepted navigations.

BUG=603730

Review URL: https://codereview.chromium.org/1887173003

Cr-Commit-Position: refs/heads/master@{#388535}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/373e8ae0a5f8..d3578ff8c479

$ git log 373e8ae0a..d3578ff8c --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1910513002

Cr-Commit-Position: refs/heads/master@{#388534}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/05c1f97e..afcc5532

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1898033007

Cr-Commit-Position: refs/heads/master@{#388533}

This sets the default value of --pageset-repeat, so it doesn't have to
be known or specified by, e.g., bisect bots.

The benchmark is split in two versions:
- memory.memory_health_quick: pageset_repeat of 1, same as before.
- memory.memory_health_plan: pageset_repeat of 5, disabled by default on bots
  (but can be run manually just fine).

BUG=605079
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1902423002

Cr-Commit-Position: refs/heads/master@{#388532}

BUG=604558

Review URL: https://codereview.chromium.org/1903163002

Cr-Commit-Position: refs/heads/master@{#388531}

The loading trace database is now reloaded from the cloud when the
worker starts, which prevents losing data when the worker restarts after
a failure.

There is also now one trace database per worker, which solves the issues
of concurrent access to the database.

The CL also adds supports for the 'pushStart' and 'pushEnd'
events that were added by CL:
https://codereview.chromium.org/1828203005/

Review URL: https://codereview.chromium.org/1908483002

Cr-Commit-Position: refs/heads/master@{#388530}

  In order to roll GN e5510883..b17c5d23 (r387371:r388502) and pick up
  the following changes:

  fb8986d4 GN: Make write_runtime_deps take effect only a target is resolved
  e4b98e2d Fix GN freeze on generating Visual Studio projects
  440b117b Add arflags to GN
  31500019 GN: Use std::unique_ptr for owned pointers in VisualStudioWriter.
  959ec4e4 GN: Use std::unique_ptr for owning pointers in InputFileManager.
  f9b6b5ae GN: Use std::unique_ptr in Loader::ToolchainRecordMap.
  ac5bf2c0 GN: Use std::unique_ptr for owning pointers in Scope::NamedScopeMap.
  647a1af2 GN: Use std::unique_ptr for owned pointers in ImportManager.
  6ce99c70 GN: Replace vector<ParseNode*> with vector<unique_ptr<ParseNode>> in parse_tree.h.
  c065bd83 gn: Use .obj extension for pch objects on Windows.
  8ea3910c [MIPS] Fix gn_unittests LoaderTest.Foo test
  a67a258a Make it easy to run `gn format' on an emacs buffer.
  3a93fa5a Add shell=True for gn-format.py on Windows

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Review URL: https://codereview.chromium.org/1909523002

Cr-Commit-Position: refs/heads/master@{#388529}

Rationale: The benchmark is causing persistent redness on one Linux and
several Android perf bots:

https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20(2)

TBR=skyostil
BUG=600377,605120
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1907463002

Cr-Commit-Position: refs/heads/master@{#388528}

Implement conveniene overloads for DevTools commands which only take
required parameters. For example, instead of this:

    client->GetPage()->Navigate(
        page::NavigateParams::Builder()
            .SetUrl("https://www.example.com"))
            .Build());

you can now do this:

    client->GetPage()->Navigate("https://www.example.com");

BUG=595353

Review URL: https://codereview.chromium.org/1906503002

Cr-Commit-Position: refs/heads/master@{#388527}