- 22 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a5aa6680ce4..bdd89366d34e git log 6a5aa6680ce4..bdd89366d34e --date=short --first-parent --format='%ad %ae %s' 2020-01-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@bdd89366d34e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Id785b3c5c49d0b89690271dbe7a548c0f32820a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734198}
-
Xing Liu authored
This CL adds code to compare a version in Finch parameter and local version cached in PrefService, and show a notification when the version from Finch is newer. The notification logic will be added in following CL. Bug: 1042124 Change-Id: Ie2ab1250557517554abb142a0a0c5ee31eb95d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006418Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734197}
-
Liquan (Max) Gu authored
menthod -> method Change-Id: I93d84de0e7105a27ae765488cf0ec000c0c84909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015048Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734196}
-
Dan Harrington authored
This CL begins organizing code for Feed v2 by pulling some enums into a new common directory. Putting shared code in a different place makes it easier to understand implications of modifying code, and will make it easier to understand what pieces of code effect the 'v2' effort. I'm starting with a few enums because they are very likely to remain identical. More code will be moved here soon. Bug: 1044139 Change-Id: I51f83f2fdc212aba9f72a1e9afd2ef8e79437e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012903 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#734195}
-
Peng Huang authored
Currently, SkiaOutputDeviceBufferQueue::Reshape() will cancel all pending swap completion callbacks. It will generate wrong UMA data. So instead of canceling pending callbacks during Reshape(), we just make the image bind to the callback be weak ptr. So the callback can handle it properly. Bug: None Change-Id: I05e943d193ff868063538899eb899fcd767ae7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013807 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#734194}
-
Ayu Ishii authored
This test fails because the cleanup to "unsubscribe" cookies would occur after the registration has already been unregistered for non-workers. This change removes the cleanup to "unsubscribe" and just relies on "unregister" for cleanup. The flaky failures can be reproduced locally using the following gn args and commandline. (Googlers: http://screen/E7px76cVS2E) gn args: dcheck_always_on = true ffmpeg_branding = "Chrome" is_component_build = false is_debug = false mac_deterministic_build = true proprietary_codecs = true symbol_level = 1 use_goma = true command: python third_party/blink/tools/run_web_tests.py -t LinuxTest third_party/blink/web_tests/external/wpt/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.js --gtest_repeat=20 Bug: 1029713 Change-Id: Ifa766b974bddfcc6ee43e60be0766c1cb80cb742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014100 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#734193}
-
Sean Gilhuly authored
Split GpuMode::HARDWARE_ACCELERATED into HARDWARE_GL, HARDWARE_VULKAN, and HARDWARE_METAL. Then, during GpuDataManagerImpl initialization, add GL to the |fallback_modes_| stack, followed by Vulkan or Metal if they are enabled. GL can still be used in the Vulkan and Metal modes, but disable Vulkan and Metal when the GPU is not running in that mode. This way, the first GPU fallback will still leave hardware acceleration available. Note that this doesn't check what Vulkan or Metal are being used for. For instance, with the flag --use-vulkan=native, Vulkan will be initialized, but Skia GL will still be used for compositing without the flag --enable-features=Vulkan. In this case, the first fallback will disable Vulkan anyway, and the second will disable GL. Bug: 1005383 Change-Id: I2cc46b4861f325883f8324bde541410440764c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976827 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#734192}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b291043..1bcbb571 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I682f7f579c9316eb42a851aa5debc5284da1cdc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014822Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734191}
-
Bo Liu authored
Bug: 1042063 Change-Id: Ic419294853e42f951ca7586b81a19b5171ff7e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013927Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734190}
-
Dale Curtis authored
Not sure why it was not done previously. R=sandersd Change-Id: Ifc72071add5ce1a753d4ffab977826a9ac56d964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013910 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#734189}
-
Jeroen Dhollander authored
If a physical keyboard is connected to a tablet, the virtual keyboard is disabled and trying to show/hide it will trigger a DCHECK. My newly introduced code in |AssistantDialogPlate| did not take that into account (it now checks KeyboardUiController::IsEnabled()). While writing the unittest to test this, I discovered the existing |AshTestBase::SetTouchKeyboardEnabled| did not actually work: - Trying to enable the keyboard by using |SetTouchKeyboardEnabled(true)| does not actually enable the keyboard, as it was immediately disabled again as soon as the |DeviceDataManager| detected the presence of the actual physical keyboard connected to the test PC. To work around this, everybody who used this method also set the command line switch |kEnableVirtualKeyboard|, which simply overruled the value set by |SetTouchKeyboardEnabled|. - Trying to disable the keyboard later on by using |SetTouchKeyboardEnabled(false)| didn't disable the keyboard as the change was overruled by the command line switch |kEnableVirtualKeyboard|. So to solve this, I removed the |SetTouchKeyboardEnabled| and replaced it with a |AshTestBase::SetVirtualKeyboardEnabled| method which uses a different set of flags (|kPolicyEnabled|/|kPolicyDisabled|) which are always respected during the unittests. Bug: b/147700828 TBR: shend@ Change-Id: I6137993a4ce5200cff400e882820580fa87d592c Tests: New ash_unittest |AssistantPageViewTabletModeTest.ShouldNotShowKeyboardWhenItsDisabled|. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002742 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#734188}
-
Laís Minchillo authored
Fix a TODO in code to replace 29 with Build.VERSION_CODES.Q Bug: 993538 Change-Id: I8b50ffa775912078a2b1b30579ffbeca0129e42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007743Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734187}
-
Jonathan Freed authored
Bug: 1035491 Change-Id: I753b551900e7646558031f36b2ab011f671c3c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006308Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734186}
-
Bin Wu authored
Change-Id: I17e63afd2b8dfc5e6758b7b02e74887c2c605cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012888 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#734185}
-
Chris Cunningham authored
Plumbs through various implementations including mojo. Adds typemaps for the new mojo types. Necessary for making predections in the renderer. A follow up CL will call the API to make smoothness predictions for MediaCapabilities. Change-Id: Ib6e46b2ac7f375bd343e1b9cda389ecf82eb880f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009843 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#734184}
-
Ahmed Mehfooz authored
This fix changes focus ring colors for all ui elements in the system menu to Google blue 300. Bug: 960116 Change-Id: I2ad84b88168521240ac12434ab2a2d83fd704bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006266Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734183}
-
Hui Wang authored
The opacity filter canvas should calculate the alpha with opacity according to the origin paint's alpha. Bug: 1044493 Change-Id: I8f1ba00ffd75a7d455b925ed841a14ae92419a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012360Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#734182}
-
Sebastien Lalancette authored
TBR=masonfreed@chromium.org Bug: 1044715 Bug: 1044712 Change-Id: I7bcdc1b00ab1b31dd210ae25265d553990d5f5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015643Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734181}
-
David Bienvenu authored
Specifically, .EmitsMetricsWhenTimerFires. I know these tests are going away soon, but I'll like to get the failures off Sheriff-Omatic. Bug: 1040458 Change-Id: Ib7601ccc2291a5e2813e5edacbac68f93d004d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015484 Auto-Submit: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#734180}
-
Michael Thiessen authored
This is a necessary pre-cursor to cleaning up scheme initialization. No GURLs should be created before schemes are modified/added and GURL is ready to use. Enforcement of this will come in a followup CL. See the bug for additional context. Replacing static initalizers with functions ensures the GURLs are only initialized when used, which happens after test setup. Bug: 783819 Change-Id: Ib93ce491807221c17b0bf5b8dd688cf103ae5027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008048 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#734179}
-
Connie Wan authored
This is a similar change to crrev.com/c/1823729, but for keyboard interactions instead of mouse drag. It essentially adds extra "drop points" for a tab at the beginning and end of a group (and on either side of the group header). The bug attached to crrev.com/c/1823729 contains a description of these drop points and a screencast of how the drag works - this is similar, but with discrete movements instead of partial drags. I renamed "MoveTabLeft" to "ShiftTabLeft" (and same for Right) because the implementation can only really handle the case where the tab is moved by one index. That's fine for the keyboard interactions, which are the only times these are called. Bug: 1039921 Change-Id: I0ea0a4fe74b1c322e034322f5d25166654348575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003922 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734178}
-
Shakti Sahu authored
This CL reverts the changes for recreateTranslucentSurfaceForSurfaceControl. There were multiple issues due to this change, one being the transition between opaque and translucent surfaces doesn't happen correctly after the app is backgrounded and the resulting page seems blank. Secondly there is a flicker on the screen anytime text selection is used due to transition between surfaces. Reverting the patch fixes this, although it gives rise to the original issue in ThinWebView where it goes transparent after main compositor surface recreation. The safest thing to do now seems be to revert the changes and land a separate fix for ThinWebView. TBR=dtrainor@chromium.org Bug: 1042344 Change-Id: I04dadf17c954c112b547e692f9b7fd1cf265881c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007940 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5dd9bf9e. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc mkwst@chromium.org: external/wpt/trusted-types NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ifa98967b81a9ea3c5ecf64c883b1c7b568aa32b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014849Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734176}
-
Elly Fong-Jones authored
Per request from waffles@ :) Bug: None Change-Id: Ia0499c064c4c098c47bb208d0d6dd2d3244081da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015604Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734175}
-
Luke Zielinski authored
TBR=robertma Change-Id: Icd82857de549cb4f6812f172b749adce6bdda4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015347Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734174}
-
Naoki Fukino authored
Following errors are not automatically fixed by eslint. I fixed these manually. ui/file_manager/file_manager/foreground/js/import_controller.js 6:1 error Unexpected var, use let or const instead no-var ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js 180:9 error Unexpected var, use let or const instead no-var 193:9 error Unexpected var, use let or const instead no-var ui/file_manager/file_manager/foreground/js/ui/file_table.js 131:10 error Unexpected var, use let or const instead no-var ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js 111:9 error Unexpected var, use let or const instead no-var 139:9 error Unexpected var, use let or const instead no-var Bug: 778674 Test: Ran browser_tests/closure_compiler Change-Id: I77ddedbc46f3ac5d63f29836156b5e584e2a7fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014620 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734173}
-
Chase Phillips authored
Bug: 989611 Change-Id: I44bc45661e194f78f5cfa90d59e0e78c8b20c278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005670 Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Mark Schillaci authored
This CL addresses various coupled bugs in both text selection and non- default granularity navigation for input fields/contenteditables on Android. It fixes various issues with improper announcements, announcements at the wrong time, and text selection not functioning in general. It also addresses AccessibilityEvent discrepancies under-the- hood in cases where we appeared to have the correct functionality to the user, but only by happenstance as we were passing bad data to TalkBack. This CL addresses: Bug 1041649 - Text selection on Android broken/not functioning Bug 1017466 - Contenteditable word granularity navigation not reading correctly Bug 1041587 - Beginning/End of field announcements being read at wrong index Bug: 1041649,1017466,1041587 Change-Id: I30a8888e99e90356398d14319fbdf225839f5dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998829 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734171}
-
Toni Barzic authored
When showing a context menu, shelf view uses ShelfItemDelegate::GetContextMenu to get the item's context menu model. This operation is async, and may take non-trivial amount of time, during which the user might start the app item drag. If the context menu is shown after the drag starts, it will consume subsequent pointer events and leave drag operation in dangling state (e.g. drag view does not get hidden). To prevent this, wrap GetContextMenu callback in cancellable callback, and cancel it when drag starts (thus cancelling context menu showing). BUG=1042505 Change-Id: I30af7f4514bfa8318e84e04b91b284a2d42b3715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013527Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#734170}
-
Ahmed Fakhry authored
UX decided we should remove the "Turn off for tonight" button from the Auto Night Light notification, and change the body's text slightly. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=1034761#c4 BUG=1034761 TEST=Adjusted unit tests, manually. Change-Id: I5c4de30e94b431d56de3692c702949b835c09830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008014Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Theresa Wellington authored
Create a new/separate build target for native_page classes: - BasicNativePage - FrozenNativePage - NativePage - NativePageHost Several classes that are currently only used by the NTP/Explore Sites were left behind (for now). There are also several "glue" classes that will stay with the main chrome_java target. BUG=1026637 Change-Id: Ia31413241b5da4d15a87950e96a438c82ca166ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009841 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Bug: 1044104 Change-Id: Ieb4361fe15122ea676b638af4be649f81fb0f9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012880Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734167}
-
Aaron Gable authored
This is an emergency measure. On Jan 8th, many browser_tests were re-enabled on Mac10.13 Tests, and were thereby also re-enabled on the mac-rel CQ bot. This resulted in a 50% increase in browser_tests runtime at both the median and atthe 90th percentile (approximately 2hrs to 3hrs). This has led to capacity shortages and significant violations of the Chromium CQ cycle time SLO. We are disabling this test suite as a simple emergency measure until better long-term solutions (disabling just a subset of the tests, having mac-rel mirror Mac10.14 Tests instead, or other ideas) are in place. Bug: 1042757 Change-Id: Iad8e9f852dccf8c630b4fe165103d25b0bc3bbd7 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015786Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#734166}
-
David Bienvenu authored
This reverts commit 4189e014. Reason for revert: <may have broken blink_heap_unittests on fuschia> Original change's description: > [fuchsia] Stop overriding safestack & shadow-call-stack settings. > > Fuchsia builds have been forcibly disabling safestack because it broke > V8 tests under Fuchsia, and forcibly enabling shadow-call-stack in > advance of it becoming the toolchain default, to gauge size impact. > > Enabling shadow-call-stack under x64 is not recommended and breaks code > which uses C++ exceptions, which is true of some V8 code & tests. > > Since the toolchain default should now be correct, remove the overrides > entirely. > > Bug: 1028617, 821951 > Change-Id: I36333f8cff5ea62584032a802337cdeb95f33466 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014407 > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734110} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: I182cb1fd966d08b9af68f5c50bb67928567cfb61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028617, 821951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015355Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734165}
-
wutao authored
Required to extend finch experiment. Bug: b/147229300 Test: pass the PRESUBMIT.py Change-Id: I0342367e91aa0ea89ef846d33a52a77e15ac230a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008067Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6b66b67f69e2..8ffd3f23331d git log 6b66b67f69e2..8ffd3f23331d --date=short --first-parent --format='%ad %ae %s' 2020-01-22 cwallez@chromium.org Move EXPECT_LAZY_CLEAR to TextureZeroInitTests.cpp Created with: gclient setdep -r src/third_party/dawn@8ffd3f23331d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2e432291b37415b1bb56bbd73d3f19808ac6ad58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013666Reviewed-by:
-
Mike Dougherty authored
BrowserState and application wide breadcrumbs are combined and attached to crash reports under a single key. Rename this key to a more appropriate name. Bug: 1003922 Change-Id: Ic1c6cb04d5d1047c090c51fdc5e5df82c78cacb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013816 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#734162}
-
Jeremy Roman authored
Bug: 1040627 Change-Id: If4f98b2269a0266ea9c56630a7f968d5b04af2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013486 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#734161}
-
Vasiliy Telezhnikov authored
This CL modifies BeginFrameSourceWebView::BeginFrameObserver to prevent reentrancy of OnBeginFrame. If the clients of this BeginFrameSource add or remove observers during OnBeginFrame this will cause the source to subscribe/unsubscribe from upstream BeginFrameSource and potentially get missed BeginFrame. To avoid this we save last_used_begin_frames_ before actually processing BeginFrame. Bug: 1044340 Change-Id: I6df71952c0efa1e8bf7db4953453684b955c42e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013808Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#734160}
-
Matthew Mourgos authored
In this change, the hotseat background will change color for different shelf states and will animate between colors when changing. When in-app shelf is shown the hotseat color should have an alpha value of 90%. When the home shelf is shown the hotseat color should have an alpha value of 60%. Bug: 1041132 Change-Id: I9459fbb61cbc538029039cd48c04144a98ab82c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003919Reviewed-by:
-
