- 20 Aug, 2020 40 commits
-
-
Garrett Beaty authored
Some CI builders are mirrors for CQ try builders despite not being a part of the main waterfall. These builders are handled by separate sheriffing rotations for trunk, but the branches only have a single rotation, so make sure that when config is generated for the branch, they appear on the main console. Change-Id: I6e7370606968d9a255eb08b5a7c4d2c0fef90220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367635Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800281}
-
Nick Burris authored
Add the body view to complete the secure payment confirmation UI. This patch adds the title text and the merchant, instrument, and total rows. Bug: 1110322 Change-Id: Ied9d2c36cf3581108f811d82aab73c207c37dbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365364 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800280}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c58b2beba89..e592b36b32d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1113326 Tbr: xialinyan@google.com,mohsen@google.com Change-Id: I3247007ef560f1dce015779b1f60c46751d0888b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367280Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800279}
-
Tommy Martino authored
Change-Id: Ie7416541017fcb2a8dcbfaa61477319b48c1e50f Bug: 1061949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364223 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#800278}
-
Thomas Guilbert authored
This CL front-loads the configuration parsing and codec support verification into the Configure() method. This means that and invalid or unsupported config should immediately throw an exception, rather than being reported in the error callback. This CL also allows encoders to be re-configured. Bug: 1116783, 1094166 Change-Id: I88df452cfa2a1b0fcfeb4da6c279665661d7380f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363711 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800277}
-
Luca Hunkeler authored
Bug:b/165589862 Change-Id: I997f539bace25aecd3ca6c4e50ff307f27a06964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364612 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#800276}
-
Evan Stade authored
It's not used. Moving these files and deps to the enable_extensions branch of the build target matches what's done in //chrome/browser/media/router/BUILD.gn Bug: 1057100 Change-Id: I5c3cb21071776a3a22bedbef00ebe998e43e4253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364557Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#800275}
-
Becca Hughes authored
We should change the string conversion from UTF8 instead of ASCII. BUG=1119506 Change-Id: I202e36568125c6a52d99db60e4101130421833f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363843 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#800274}
-
Victor Hugo Vianna Silva authored
After this CL, when DecoupleSyncFromAndroidMasterSync is enabled, Chrome will no longer be in the list of auto-sync apps. In particular this toggle will disappear [1]. Users who previously disabled that toggle will remain with Chrome Sync disabled until they enable it again on Chrome settings. [1] https://screenshot.googleplex.com/9uR0qxTzVzK Context: the Android APIs setIsSyncable(..., int) and setSyncAutomatically(..., bool) control 2 *independent* settings per (account, app) pair, "syncable"[2] and "enabled"[3], persisted to an XML file. The first one controls whether the toggle in the screenshot will exist. A value >0 means yes, =0 means no and <0 means an unknown state (where the toggle isn't shown either)[4]. What the CL does is basically set "syncable" to 0 for any Chrome account. "enabled" can continue to be set safely and will still mirror the sync.requested pref [5], as happens today. [2] https://cs.android.com/android/platform/superproject/+/eed78aea1f49cba01c737220a6f834bca7feeef7:frameworks/base/services/core/java/com/android/server/content/SyncStorageEngine.java;l=283 [3] https://cs.android.com/android/platform/superproject/+/eed78aea1f49cba01c737220a6f834bca7feeef7:frameworks/base/services/core/java/com/android/server/content/SyncStorageEngine.java;l=282 [4] https://developer.android.com/reference/android/content/ContentResolver#setIsSyncable(android.accounts.Account,%20java.lang.String,%20int) [5] https://source.chromium.org/chromium/chromium/src/+/master:components/sync/base/sync_prefs.h;l=90 The CL also: a) Replaces code that checked specifically whether "syncable" valued 1, 0 or -1 with more generic checks for >0, =0 or <0. 1, 0 and -1 do have special meanings in SyncStorageEngine, but that's an implementation detail of a lower layer. The layer where the APIs live (ContentResolver) never ensures those values. b) Modifies the implementation of MockSyncContentResolverDelegate to be more consistent with the real Android behavior. E.g. one should be allowed to set "enabled" before "syncable". In next CLs the DecoupleSyncFromAndroidMasterSync feature toggle will be renamed to mention auto-sync rather than master sync. Bug: 1105795 Change-Id: I091981506ff64c33a6c259862eee07d28825527f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366895 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#800273}
-
Nicolas Ouellet-Payeur authored
This is a reland of fdb80c24 Original change's description: > [Traffic Annotations] Roll traffic_annotation_auditor > > Following the change that adds the grouping.xml check: > https://chromium-review.googlesource.com/c/chromium/src/+/2303313 > > Also updates grouping.xml to make sure the test passes on CQ. > > Bug: 1107860 > Change-Id: Icb4eea6540c6ddeb95dcd5efa9ea86ccec2afc13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362988 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799619} TBR=rhalavati@chromium.org Bug: 1107860 Change-Id: Iab0616ab9302ac6c00dd4607f5c3b97c9efcafcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364818 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#800272}
-
Rushan Suleymanov authored
While removing all user bookmarks the call site of UrlIndex::Remove is collecting all |removed_urls|. Each next call already contained all previously deleted urls. These |removed_urls| were used to check if there are other bookmarks with the same URL. This led to quadratic number of iterations over |removed_urls| as each next call iterated over all previously deleted URLs. This CL slightly changes behaviour of UrlIndex::Remove. It doesn't read |removed_urls| anymore, hence it's safe to pass non-empty value. Bug: 1096984 Change-Id: I4a9aadefe94e6becdc7c6c08ccc7b8d7b98f27f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362966Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#800271}
-
Jeroen Dhollander authored
Log with |AssistantDebugging| enabled: Assistant: OnTextResponse: [PII](What do cats eat for breakfast?) Log without that flag: Assistant: OnTextResponse: [Redacted PII] This flag also controls the LibAssistant back-end, as using the LibAssistant beta back-end might also log some PII. Bug: b/162894119 Change-Id: Ie888a9b4bf636f1cd0ad6f54df58012b782136c4 Tests: Ran with and without this flag. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366073 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800270}
-
David Maunder authored
CriticalPersistedTabData is a redesign/replacement of TabState and has been integrated behind a flag. Being a redesign/replacement of TabState, this has increased the binary size. When TabState is deprecated it is expected the binary size will reduce by a similar amount. Binary-Size: Increase is temporary. Bug: 1114312 Change-Id: I01053eed2ca2179b86f436a2685660fd422399c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359371 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#800269}
-
Charlie Hu authored
This reverts commit 9c2422bd. Reason for revert: Fixed root cause that caused deterministic build failure. The reason was make_document_policy_features_util.py was not included in build input. The change of the script alone will not cause re-generation of output files, which caused incremental build to differ with fresh build. Original change's description: > Revert "Add bool constructor with type for PolicyValue" > > This reverts commit 30d9990c. > > Reason for revert: Suspected cause of build failure on ilder Deterministic Linux (dbg) Build 18293: > https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/18293?blamelist=1#blamelist-tab > > Checking libblink_common.so difference: (10672 deps) > obj/third_party/blink/common/common/document_policy_features.o > > Original change's description: > > Add bool constructor with type for PolicyValue > > > > Previously, boolean PolicyValue is missing a constructor with type > > specification on PolicyValue class. It caused some inconvenience > > on code generation and testing. With the introduction of enum > > PolicyValue, this becomes more obvious because enum type's constructor > > also comes with a type parameter. > > > > In order to simplify the codegen and testing logic, this CL adds a dummy > > constructor for boolean type PolicyValue. > > > > Note: the constructor with type parameter aims to distinguish policy > > values that have same C++ type representation but different policy value > > type, e.g. IncDouble and DecDouble, Enum and Int. > > > > Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365 > > Commit-Queue: Charlie Hu <chenleihu@google.com> > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > Reviewed-by: Ian Clelland <iclelland@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798714} > > TBR=iclelland@chromium.org,foolip@chromium.org,chenleihu@google.com > > Change-Id: I79f53710b14f22a7c81b4c757cbee03160c6addb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360796 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798853} TBR=iclelland@chromium.org,foolip@chromium.org,thomasanderson@chromium.org,chenleihu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If27e29103d61220e82b1cab769d695a955222e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364053Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#800268}
-
Moe Ahmadi authored
Bug: 1110077 Change-Id: Ie167aa8a1d9317b431769f009e01a5550c8e371c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364119Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800267}
-
Collin Baker authored
This gives equivalent functionality, but avoids the need to construct a complex object for each params object. Plus, it makes the params copy-constructible. Bug: 1106523 Change-Id: If35476314b33cdaf19703d58a084370c95a5f709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353574Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#800266}
-
Garrett Beaty authored
Bug: 1109276 Change-Id: I907d30149f06355e35a372127064ef01d2b2c87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366670 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#800265}
-
Anastasia Helfinstein authored
This is a reland of a5f47e82 Original change's description: > [Switch Access] Convert event handler into event rewriter > > Switch Access is not receiving some key events that it should be when > certain UI elements are focused. The events are instead passed directly > to those UI elements (e.g. Launcher text field, omnibar), effectively > trapping the user and leaving them unable to use the device. > > This change converts the SwitchAccessEventHandler into an event > rewriter, so that Switch Access will receive events before any other > source. > > AX-Relnotes: n/a. > Bug: 1106573 > Change-Id: Ib34de857acc8d6985e769fb83adb93b9ea41649e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317833 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798766} Bug: 1106573 Change-Id: I082484d1e414dc8c5508d28a0c2f07dfd2675dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363487 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#800264}
-
Asanka Herath authored
R=caraitto@chromium.org Bug: 1108942 Change-Id: I2bd72849d79a64d85cb9b61e87efe226d48a0cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366662 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#800263}
-
Jeffrey Cohen authored
The fallback dialog passes its dismissal runnable to be called on a successful image_editor installation. Bug: 1117675 Change-Id: I08a536b77ec459741940d20082b270aa4e900f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363813 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800262}
-
mark a. foltz authored
This adds a histogram MediaRouter.PresentationUrl.BySink that records the types of URLs passed into the Presentation API and what types of sinks (screens/devices) they are rendered on. This is to help assess the real-world usage of various scenarios and inform the future roadmap of the API. Note that the kExtension bucket will exclusively capture Google Meetings by the time this hits the beta channel; however, I'm naming that bucket kExtension for consistency with MediaRouteProviderId. Bug: 1112866 Change-Id: Idc21cf0fff6d3b3984a21163ec26a01f4ed929df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350840 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#800261}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7f265d1d4074..ab4e4feb01ac 2020-08-20 jiawei.shao@intel.com Workaround Intel Mesa driver issue about T2B copy with stencil aspects 2020-08-20 cwallez@chromium.org Remove MapRead/WriteAsync and CreateBufferMapped 2020-08-20 tommek@google.com Refactoring Queue::WriteTexture implementation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0a5c4f8dc9b34357cdd11b38559de3736c81483d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800260}
-
Vladimir Levin authored
This patch limits the selection of priority candidate to focused elements with editable style. That is, previously we would consider any focused element as a priority scroll anchor. Now, this is only true if the element is editable. This should be a middle ground that allows most cases in referenced bug to be fixed (> 30 stars, multiple merged bugs). However, it would also preserve the layout stability when editing forms with text input. R=chrishtr@chromium.org Fixed: 1102229 Change-Id: I7341f0e513b70f8a4d836cebb68b931f2518534f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363079 Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800259}
-
Guido Urdaneta authored
The runtime flag remains for the legacy API, which will continue as an origin trial and will be removed later. Intent to ship: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/XFO4OXrdSRA Intent to experiment for legacy API: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/LLtmsTDMnXg Bug: 1059912 Change-Id: I65d3ecf490fb6b0e229b7ee4c153c2f541a3c6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367063Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#800258}
-
Solomon Kinard authored
Bug: 1108940 Change-Id: I1ed44c12ebddb2a156b2677afb62add26c9221a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367027Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#800257}
-
Becca Hughes authored
Adds fetching that is not automatic selection and instead uses which feeds a user has picked. BUG=1053599 Change-Id: Ib1c16d0efa409354c68845472484bfd33bf5145c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362997 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#800256}
-
Caleb Raitto authored
Bug: 973801 Change-Id: I7f50ede21dd71a63702b3b9e478f7c37bae2d01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362869 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#800255}
-
Sundoo Kim authored
There is no change in behavior. ui::ImageModel should be preferred to gfx::ImageSkia. Bug: 1100034 Change-Id: I7ccd38bbcc1eb72112d7efdb0a0b84490d037887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346087 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#800254}
-
Eric Orth authored
Bug: 1116579 Change-Id: Ifd4958aa53824914335715df58bd8a8d89913ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363401 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#800253}
-
Jeffrey Young authored
BUG=b:163526303 Change-Id: I2ff2dbbf66dbf380d13cf163c1376278aa947649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353489Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#800252}
-
Maciek Slusarczyk authored
When SAML user is sent through online login the sync token may need to be updated locally. This CL introduces logic analogous to token sync on lock screen implemented in InSessionPasswordSyncManager: when new session is started after online SAML flow we fetch a token from sync token API and save it in local settings. Bug: 1090341 Change-Id: Iee64115a1950a14a6cbcccbaf0d0607fbca1ba2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359998Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#800251}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56d9df4fa53f..77419b0f04e8 2020-08-20 lalitm@google.com Merge "ui: implement quantization for thread state tracks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic8914e222aeca60130588e1facfff8ed5251501f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366678Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800250}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008200800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/ATO87Kt3GVbWvrrrePqcpzq_uVeSNAO_zG5viw3VGvUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162466284,b/165378070 Tbr: help-app@grotations.appspotmail.com Change-Id: I28eec59880ba576a35f8c2f6c0d851e3a7efc9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366819Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800249}
-
Eric Orth authored
Remove everything related to the "default" socket pool that is completely unused. Also simplify the DnsSocketPool interface for the remaining much simpler usage of the class. Also delete dns_session_unittest.cc since it was really only testing that allocated sockets were properly freed in the pool, but that no longer matters and it wasn't worth maintaining the mockability and hooks in the pool needed for the test. Bug: 1116579 Change-Id: Ib322bffb653e85a9c33a4b3835f4067fd8d29530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357615 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#800248}
-
Dan Harrington authored
This is the chromium/src side of the change. It introduces a getViewType() API in ListContentManager, and implements it. This CL fixes a secondary bug: if a native view is added, removed, and then added again to the FeedListContentManager, we would previously try to wrap the view multiple times, which throws an exception. Now, we wrap a view at most once. Bug: 1119516, b/165317997 Change-Id: I2163c0e159c6d434329ea34f0449356a561a0c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364965Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#800247}
-
Han Leon authored
Considering Mojo is used so heavily in Chromium, even such a small change might bring us some perf improvement overall. Bug: 896419 Change-Id: I9f4729fee0e3eed3ffb0448d4d0ac80a71997b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362083 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#800246}
-
John Abd-El-Malek authored
Bug: 1117626 Change-Id: I24af96b8149565d111950d82e4d3919470b5ff9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366559Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#800245}
-
Ioana Pandele authored
This CL makes sure that we don't start a check before we can be sure that all preconditions are fulfilled: * saved passwords are loaded * first set of compromised credentials is displayed * scripts are fetched (if necessary) To prevent a third boolean value, this CL stores all applicable preconditions as flags. Bug: 1119366, 1092444 Change-Id: I81bf4577185709bd14b99cc0e878c5d38fbc4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366759 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#800244}
-
Noah Rose Ledesma authored
Implement the new UI for the audio device picker in global media controls. As part of this change, the MediaNotificationBackground will draw a gradient between the device picker and notification artwork if the picker is availabile. Screenshots of this updated UI will be posted on the crbug. Change-Id: Ic7186c770102663b08e85b56eeddfbfa13833c3c Bug: 1117160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358512 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#800243}
-
Shimi Zhang authored
WebCompositorInputHandler is no longer exist in the code base. Bug: None Change-Id: I3562b09949bdc87b4f6bdb36cc4b5514dd862e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367437 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#800242}
-