- 13 Mar, 2020 40 commits
-
-
Yao Xiao authored
LGTMs to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/JdAQ6HNoZvk/m/B1aMS33oAAAJ whatwg/html spec: https://github.com/whatwg/html/pull/4293 Bug: 539938 Change-Id: Ib875fe971ff8ab93ed733f6a0c1d4dd3ee5c7489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095602Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#750209}
-
Peter Qiu authored
Bug: b/149794488 Test: Build Change-Id: I93b96001ba9b0b5f539a1799c29e15b22c13465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101828Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Auto-Submit: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750208}
-
Ulan Degenbaev authored
This fixes a mistake in crrev.com/747632 where the flag was added as a runtime-enabled feature that is not visible to Finch. The flag now is moved to blink/public/common/features.h Bug: 1049132 Change-Id: I2d13e6cb97fd57535861379ae5fc80dba9dc252d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102547Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750207}
-
Elly Fong-Jones authored
This change renames: * set_default_button -> SetDefaultButton * set_buttons -> SetButtons * set_button_label -> SetButtonLabel * set_accept_callback -> SetAcceptCallback * set_cancel_callback -> SetCancelCallback * set_close_callback -> SetCloseCallback so that these methods can start having side-effects (specifically, some consistency DCHECKs). This change was generated by this shell script: #!/bin/sh DD=DialogDelegate find . -type f -name '*.cc' -o -name '*.h' -o -name '*.mm' | \ xargs sed -i \ -e "s/$DD::set_default_button/$DD::SetDefaultButton/g" \ -e "s/$DD::set_buttons/$DD::SetButtons/g" \ -e "s/$DD::set_button_label/$DD::SetButtonLabel/g" \ -e "s/$DD::set_accept_callback/$DD::SetAcceptCallback/g" \ -e "s/$DD::set_cancel_callback/$DD::SetCancelCallback/g" \ -e "s/$DD::set_close_callback/$DD::SetCloseCallback/g" with a tiny amount of manual fixing-up afterwards. Bug: 1011446 Change-Id: Ic9d34ac05c759e9bcb0bd2ce3d26d2fc0dd2f611 Tbr: joedow@chromium.org,avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099084 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#750206}
-
Andrew Grieve authored
GN recently gained a filter_exclude() function, which is much more readable than set_sources_assignment_filter(). This changes uses of set_sources_assignment_filter() to use the new function in places where it was currently being used to perform explicit filtering (as opposed to the implicit filtering it was designed for). Bug: 1018739 Change-Id: I68eff058a6250f49b0adda2b4c5958bcfa2431e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102771Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#750205}
-
Garrett Beaty authored
Phase D migrates all of the try builders that are not includable-only. Migrate the try builders and the builders that they mirror to the versioned subdirectory. bucketed_triggers is set to False for the ci builders since there are not yet multiple builders with the same name to result in a different scheduler job name. They will be removed on branch day. Bug: 1024644 Change-Id: I68f05c82b631b0ae56200f62599a440ecb02d70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098274 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#750204}
-
Sorin Jianu authored
This CL provides the COM client code to call when --ua runs. The code is not working yet since the query interface for IUpdater returns "type libraries not registered (0x8002801d). It seems that the server also does not get activated by COM and it needs to be manually started with --server for now. Bug: 1053729 Change-Id: Iaafd96ad81617537ee693cf702274b68cf3b374a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101938Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750203}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a115a24bfd7..ef7ec269b5b5 Created with: gclient setdep -r src-internal@ef7ec269b5b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058993 Tbr: jbudorick@google.com Change-Id: I4e69fb93d147319a5e0165721c3333758a939eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750202}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c9ba12998fd2..658be97b1940 git log c9ba12998fd2..658be97b1940 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 lalitm@google.com Merge "ui: switch process summary tracks to use track_ids" 2020-03-13 skyostil@google.com Merge "docs: Add documentation for recording traces programmatically" 2020-03-13 hjd@google.com ui: Use experimental_counter_dur Created with: gclient setdep -r src/third_party/perfetto@658be97b1940 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2e25049af14942ce643517ac4c55846d575e0f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750201}
-
yilkal authored
This Cl ensures that system notifications for a particular application are delayed until AppActivityRegistry receives a signal from AppService that an application has been installed. Bug: 1056469 Change-Id: Ifb38093ee04f17ee88787e6f2824b6840822e4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101709 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#750200}
-
Raymond Toy authored
Change GetClosure() in test_helpers.h to return a OnceClosure instead of Closure. This remaining changes are knock-on effects of the GetClosure() change. Basically need to call RunOnceClosure() instead of RunClosure() and need to update some class members to be OnceClosure instead of Closure. Bug: 1007799 Change-Id: I53024573f6e3cca94787a8213b00c069cb7c3aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095858Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#750199}
-
David Maunder authored
This is causing the app to crash for frozen Tabs Bug: 1059153 Change-Id: If5c10f629fd6e4396cdf34421dc02b80224006cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095396 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750198}
-
Nico Weber authored
No behavior change. Bug: 346399 Change-Id: Ie643a6cba6607ba333bad7fc35601b9d43856dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102632 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#750197}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c5ee8e0342d1..b1b6a171ee02 git log c5ee8e0342d1..b1b6a171ee02 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 courtneygo@google.com Vulkan: Disable robustness support Created with: gclient setdep -r src/third_party/angle@b1b6a171ee02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I842cff5f7033aa779dd0158425ed22efb9597e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102749Reviewed-by:
-
Arthur Eubanks authored
If I currently have a branch with commits checked out, upload_revision.py will create a branch from that. The "-r" flag doesn't work for me, omitting it does work. Given that the new branch is directly branched off of origin/master, `git cl try` should work without the "-r" flag. Change-Id: I54e66b3318a8d0548cda63b2906d206db0d02987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101533 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750195}
-
Mario Sanchez Prada authored
This CL converts the message that requests a one-time snapshot of the accessibility tree from the renderer along with the response message that should be sent back to the browser process once the message has been handled. Note on android-binary-size increase (+17,454 bytes): the reason for this size increase is the need to use the new mojo typemappings for structs AXContentTreeUpdate, AXContentTreeData and AXContentNodeData, added in CL2050270[1], to efficiently migrate this legacy IPC message to mojo. This shouldn't have been a problem in itself but those new typemappings rely on other typemappings (AXTreeUpdate, AXTreeData and AXNodeData) that were already present in the codebase before [1] even though they were not used, meaning that this CL is pulling new symbols related to all those 6 structs at once, increasing the binary size a bit over the limit of 16,384 bytes. [1] https://crrev.com/c/2050270 Bug: 1010831 Binary-Size: Size increase is unavoidable (see above). Change-Id: I6a89974b485b9fd845126d31ad4216f0ea20133f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050272 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#750194}
-
Majid Valipour authored
This is a reland of da0cc146 Original change's description: > Prepare CSSOMViewScrollCoordinates for finch trial > > Following best practice advice from go/finch-blink: > - Update testing config variation to enable the flag > - Update file_manager test to expect the new behavior > > Bug:721759 > > Change-Id: I727eef6b50cf09027945bcd645335b39ee83ba2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087422 > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749856} TBR: flackr@chromium,noel@chromium.org Bug: 721759 Change-Id: Iaf9d9803e2baa2032de9335432fb5442cc8be4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101188Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#750193}
-
Jeffrey Cohen authored
Bug: 1025362 Change-Id: Ib30fcca4826d7102deabf0589958fab7dd853a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101293Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#750192}
-
Stepan Khapugin authored
Fixes the test. Bug: 1060699 Change-Id: Id487a1a01f8adae811c501c95193f7fa4dd983e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102488 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#750191}
-
Himanshu Jaju authored
WebRTC service is only available on Desktop but the sender is enabled by default on all OS. This can cause sending for shared clipboard to fail if a user is trying to send text from Android to Desktop if the Desktop client falls under the experimentation. Bug: 1061393 Change-Id: I3804e784b3dc72d90bb673d22a9d57ebbe76d99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100858 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750190}
-
Chong Gu authored
Fix fuchsia_telemetry_gpu_integration_test DEPS. Add fuchsia_telemetry_gpu_integration_test to gn_isolate_map. Add fuchsia_gpu_telemetry_tests test suite. Bug: 1058255 Change-Id: Iaaccc6d165ebf8e1c928eca032224a11a043fe95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099022Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#750189}
-
Josh Nohle authored
When setting host states, verify both legacy device ID and Instance ID. Bug: 1060859, 951969, 1019206 Change-Id: I8bcc27f4e228a9b1e468f887b91ff640ceb8837e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101733 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#750188}
-
Sylvain Defresne authored
Creating symlinks in src/ can mess with the build because some scripts incorrectly re-invoke `gn gen` as part of the build. Also, it does not make sense to create symlinks in src/ based on a gn variable that can have different value for different build directories. Bug: 1060666, 1061419 Change-Id: I2367aa6436489b77540454da8f7ae17d41c6f9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102649Reviewed-by:
-
Rune Lillesveen authored
Iframes where the color-scheme of the iframe element and the iframe document's root does not match, will get a backdrop matching the color- scheme of the iframe's root element. Also adjust existing test according to spec change. See: https://github.com/w3c/csswg-drafts/issues/4772 Bug: 1058822 Change-Id: I82fd3cc3c2bbf5b4835b157a7522cb22c459ff20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095112Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#750186}
-
Mark Schillaci authored
This CL continues the Android performance improvements for users that have accessibility features enabled. In this CL we delay the creation of AccessibilityEvents until we are ready/certain they will be sent. In previous work we throttled the amount of events being sent to the system, but we did not modify the creation of those events. This meant we were creating events that were sometimes discarded, or we were creating events before they needed to exist, and both of these negatively impacted performance. We now wait to create an event until immediately before it will be sent to the system. Change-Id: I35bc7f5b21990caa23bc80677823d3a46f9736a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100669 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
-
David Van Cleve authored
After adding Trust Tokens code to the network service led to a ~15K android binary size increase, we initially added platform-specific ifdefs excluding iOS to avoid a corresponding iOS binary size increase (since the code is the network service side of a new Web Platform feature, it's a no-op on iOS). It turns out iOS binary size is much less severely constrained than Android, and the conditional includes were leading to a bit of implementation complexity, so this change removes the buildflag and makes Trust Tokens code built in the network service on all platforms. R=mmenke Change-Id: I6d61a0711333157cac89a9392693cb6d810d05c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102587 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#750184}
-
Andy Paicu authored
The directive has been behind a flag for a year and we have received no [negative] feedback. Spec: https://w3c.github.io/webappsec-csp/#directive-navigate-to I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EJ4xF_DwZyk Bug: 805886 Change-Id: I746aed4032149b86a5f9974246e2ec35bf8eb356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856100Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750183}
-
Yuke Liao authored
It's unclear why use_lld was there, but it prevents PGO from working on Mac and iOS because they don't use lld. Bug: 1058979 Change-Id: I0c984db2abe3bc8ff59f068221dd6de1edbf887d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101232Reviewed-by:
-
Mikel Astiz authored
Follow-up to https://crrev.com/c/2079641 which overlooked one calling site, now adopting the same workaround. SupervisedUserNavigationObserver should never be null for supervised profiles but crash reports indicate the opposite. Hence, the null case is handled to avoid a crash, and TODOs are introduced to follow up with the investigation. Change-Id: Ia1797168ff491cc500a5bf925e65f9d83eee8bc9 Bug: 1058914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102527 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750181}
-
Maxim Kolosovskiy authored
This CL propagates a leaked username to the leak dialog (the password change copy). The copy of the dialog should be able to start a password change flow, therefore the dialog needs to know the username. Bug: 1057608 Change-Id: I66a7e696c28f1c672283e8bee390bcb7ff180436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100976 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#750180}
-
Rahul Arakeri authored
The CL adds new tests for rtl scrollbar manipulations. Bug: 1012590 Change-Id: I70ac4ac73cfb3b41683e56fd13da4b19fbbfb372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071904Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#750179}
-
Jose Lopes authored
This CL has been automatically generated by running the clang tool base_bind_rewriters on media/ and with a build config for Android because a lot of modules in media/ are only compiled for Android and therefore other build configs (e.g., Linux) don't see those modules. This clang tool automatically updates base::Bind calls to match the type expected by the callee. This is part of the base::Callback migration. Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r Bug: 714018 Change-Id: I7715444d131ab42aa754e185bbfe822ad3ce765a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100936 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#750178}
-
behdad authored
The PendingTreeDuration metric corresponds to the sum of a few existing stages of CompositorLatency metrics of: - .Commit - .EndCommitToActivation - .Activation Bug: chromium:1039312 Change-Id: I28c1b0c6d24c8613b988a2dd8082c87142c04106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101236Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#750177}
-
Maxim Kolosovskiy authored
The flag will be used Autofill Assistant to verify the password change flow is triggered by the password manager. Once the proper intent signing is implemented, these changes should be removed (b/151391231). The CL is an extracted part of https://chromium-review.googlesource.com/c/chromium/src/+/2074761 Bug: 1057608 Change-Id: Ib76314ff35c31c328e0df6d7243f1079e74ad774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102567 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Move the implementation into an AppShimHandlerDelegate. Also, while doing a bit cut-and-paste, rename many instances of app_id as a string to app_id as a web_apps::AppId. Bug: 1057501 Change-Id: Ief7177b0df70f842410774c1a68d0f9a4a831929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102068Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#750175}
-
Vladimir Levin authored
This patch is the first refactor patch out of a few that I have planned: - Remove budget functionality which was used for updateRendering, which we do not currently support - Move the logic from StyleAdjuster to DisplayLockContext, so that the values, activation masks, and style adjustments are all in the same place R=chrishtr@chromium.org Change-Id: I508f24312ff83346a72b3e0f98686071d2292ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100713Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750174}
-
Sadrul Habib Chowdhury authored
The switch to INSTANT from STEP_INTO made the trace-events much less useful. The older trace-events were useful for tracking dropped frames (doc [1]). So replicate the older behaviour of STEP_INTO with some custom code. [1] https://chromium.googlesource.com/chromium/src.git/+/master/docs/speed/debug-janks.md#find-the-jank BUG=1034193 Change-Id: Ifc64e992b11d1eed60f7d40365a3b80ea6b3c8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102075Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#750173}
-
Andrew Grieve authored
This will let GN validate that deps are not missed. Bug: 1054892 Change-Id: Ie69f607847dfe22bc3e0e54ff86fbd339fd226dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102630Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#750172}
-
Mikel Astiz authored
By dropping support for the feature toggle kSyncUSSPasswords, which has been launched for some time now, the legacy SyncableService-based implementation of passwords sync can be deleted. Passwords were the last remaining user of GenericChangeProcessor as well as AsyncDirectoryTypeController, so a lot of code can be trivially deleted, representing the pre-USS codepath. This unlocks further code removal and refactorings in future patches. Change-Id: Iee49a10761fa32ccfe0c7f5ca45f88a365c5390c Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066900Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
George Steel authored
It previously returned the resolved value as produced by ValueForLineHeight (this property is unique in that the computed and resolved values differ even without a layout object). Introduce another serializer ComputedValueForLineHeight which produces the actual computed value. Change-Id: Ic27d9a4fe7c67cbbb577ec4e4efed14a88a846c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101858Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750170}
-
