- 25 May, 2018 40 commits
-
-
Yoichi Osato authored
VisualRect() should cover all visual effects including selections on SPVv175 because SPv175 uses VisualRect() instead of LocalSelectionRect() to invalidate selection. SPv1 also did that and the future SPv175 will do that when the DisplayItemClient needs full invalidation. This patch updates ComputeVisualRectInBacking to add selection rect to NGPaintFragment.VisualRect() for selection invalidating. Since NGPaintFragment.VisualRect() didn't consider selection rect, we missed invalidation. This patch fixes the problem by updating ComputeVisualRectInBacking to compute whole visual rect which consists of physical_fragment.VisualRect and NGPaintFragment::ComputeLocalSelectionRect(). ToT: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/5662/layout-test-results/paint/selection/text-selection-newline-across-blocks-actual.png This patch: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/5710/layout-test-results/paint/selection/text-selection-newline-across-blocks-actual.png Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie72e3dca922cba0a4c4585cb757156dd543b9bfc Reviewed-on: https://chromium-review.googlesource.com/1068947Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#561802}
-
Trent Apted authored
This reverts commit 2c03b1bd. Reason for revert: tests fail in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19267 leak log like ({"numberOfLiveDocuments":[1,2],"numberOfLiveFrames":[1,2],"numberOfLiveNodes":[4,9],"numberOfLivePausableObjects":[2,3],"numberOfLiveResourceFetchers":[1,2]}) Original change's description: > Check page exist after dispatch dragstart > > frame_->GetPage() may be null. need to check before use GetDragState > This CL reorder the some checks in MouseEventManager::TryStartDrag > to make sure GetPage is valid before start drag. > > Bug: 843502 > Change-Id: Ifdf5b20d7132ca4b089c9a5b7652ebbd41370c33 > Reviewed-on: https://chromium-review.googlesource.com/1064878 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561262} TBR=dcheng@chromium.org,nzolghadr@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843502 Change-Id: I9412bbdf67a93acccbe4a75c5b50deee832eac97 Reviewed-on: https://chromium-review.googlesource.com/1072968Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561801}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af2ffd933d0e..4d2e8bfffdbd $ git log af2ffd933..4d2e8bfff --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I70795d0b79cdc808603abd07dc065ed8fdaf0b87 Reviewed-on: https://chromium-review.googlesource.com/1072705Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561800}
-
Koji Ishii authored
Following bot results are included. 5817 5821 5829 5832 5835 5838 5844 5848 5850 5856 26 lines were removed and 3 lines were deflaked by consecutive results since 5769. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idd8b756bf4f4c8f2d2c1507375919efad09e8d07 Reviewed-on: https://chromium-review.googlesource.com/1071268 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#561799}
-
Tetsui Ohkubo authored
This CL implements DetailedViewController for the network detailed view. The change is a step to remove the reference to SystemTray from UnifiedSystemTray. It fixes the behavior of the back button, and enables further UnifiedSysetmTray specific tweaks to the detailed view. To implement the common behavior for UnifiedSystemTray detailed views, this CL also adds UnifiedDetailedViewDelegate. TEST=manual BUG=835733 Change-Id: I2c005db58e410d33a36e6b6e16083b30917bc053 Reviewed-on: https://chromium-review.googlesource.com/1071490Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#561798}
-
Christian Biesinger authored
I already changed the other use of that function in this file, but I missed this spot in 2093cb98 R=eae@chromium.org,mstensho@chromium.org Bug: 839661 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6bc69933e12ad9d4fdfe9813337ec54f552dcf98 Reviewed-on: https://chromium-review.googlesource.com/1072322 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#561797}
-
Colin Blundell authored
The reasoning for this change is analogous to that described in https://chromium-review.googlesource.com/1061494 for IdentityManager's interactions with SigninManager. As with that change, once the codebase is converted away from direct usage of PO2TS entirely to IdentityManager, it could be a good idea to reintroduce the asynchronous interaction; reintroducing that implementation would be a good intermediate move to switching in the Identity Service-backed implementation. As part of this change, we remove a test of PrimaryAccessTokenFetcher that assumes that the implementation handles access token requests asynchronously. Bug: 843510 Change-Id: Ie9a9b06460044fd12cd63299f21c7e24660d8cc1 Reviewed-on: https://chromium-review.googlesource.com/1068669 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561796}
-
Trent Apted authored
It was marked flaky on Linux, but flakes everywhere. TBR=junov@chromium.org Bug: 831673 Change-Id: Ibe96bd18afc2ea1ce847b8e70b569ac7ebf8ede0 Reviewed-on: https://chromium-review.googlesource.com/1073129Reviewed-by:
-
Takashi SAKAMOTO authored
Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash. If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid. Bug: 837498, 846426 Change-Id: Ic23f779b5d64eec90467494a2158c0d6e81ae4b2 Reviewed-on: https://chromium-review.googlesource.com/1073109 Commit-Queue: Takashi Sakamoto <tasak@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561794}
-
Matt Falkenhagen authored
This relands r561423. Original code review: https://chromium-review.googlesource.com/1069956 The original patch had a problem because the shadow page was created before UnguessableToken. The fix is to not create the shadow page early, which was only needed in an earlier patchset to get the task runner from it. Bug: 839982, 846545 Change-Id: Id6545d9d86a3a56a04e7f83a840d9acddd55f51b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR: kinuko, dcheng Reviewed-on: https://chromium-review.googlesource.com/1073037 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#561793}
-
Hayato Ito authored
This is similar to https://crrev.com/c/1068571, but does check for DOM mutations. There are two code paths which violate the assumption: - ListItemOrdinal::ItemInsertedOrRemoved(), which was fixed at https://crrev.com/c/1068646 - Document::HoveredElementDetached, which is fixed in this CL The reason we can't add a scoped check at the beginning of ContainerNode::RemoveChild is that synchronous DOM mutation events can happen in WillRemoveChild(*child) or DispatchSubtreeModifiedEvent(). Ditto for ContainerNode::AppendChild. There are other DOM mutation operations where we should add check. That can be done later. Once I am sure that the coverage is enough, I'll refactor so that this kind of check can be done in more better places. Bug: 776656,845770 Change-Id: I7ce0e99292165b698b69c6b90d71d71a90c19135 Reviewed-on: https://chromium-review.googlesource.com/1070169Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#561792}
-
Gauthier Ambard authored
This CL adds a unified commands for loading a query from the different features in the app. Bug: 821560 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia44f468957b7cc96f5d48467d5c0bb423c9f60a3 Reviewed-on: https://chromium-review.googlesource.com/1070156 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#561791}
-
Trent Apted authored
TBR=guidou@chromium.org Bug: 846582 Change-Id: I9d56948be36ff8b672f41fece3e028f2bae0de2f Reviewed-on: https://chromium-review.googlesource.com/1073110Reviewed-by:
-
Daniel Park authored
> Displays an IPH on the NTP Button on cold start > IPH text is based on finch config Bug: 843639 Change-Id: Ibaf1e085d52d233b3be95b9f16d146fdf74d902c Reviewed-on: https://chromium-review.googlesource.com/1070414Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561789}
-
Trent Apted authored
It's marked flaky on Win but flakes on Mac also. TBR=hbos@chromium.org Bug: 824830, 846496 Change-Id: I829bd7345a5c78d5e2b0e459a731d902ffabe1ac Reviewed-on: https://chromium-review.googlesource.com/1073043Reviewed-by:
-
Trent Apted authored
TBR=einbinder@chromium.org Bug: 846471 Change-Id: Ic86a36e1b11be09fb69837a3b6146b223e1a2b0d Reviewed-on: https://chromium-review.googlesource.com/1073108Reviewed-by:
-
Hitoshi Yoshida authored
This CL supports an extended attribute [LenientSetter] https://heycam.github.io/webidl/#LenientSetter Bug: 845883 Change-Id: I764f91d38c9b89cd6bf7138c6d53bb40d60f7fe2 Reviewed-on: https://chromium-review.googlesource.com/1071150Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Trent Apted authored
This reverts commit 6c352304. Reason for revert: suspected for webkit_unit_tests failing on Android CFI since https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/1351 ScriptWrappableVisitorTest.InObjectUsingTraceWrapperMember fails with ../../third_party/blink/renderer/core/testing/death_aware_script_wrappable.h:85:7: runtime error: control flow integrity check for type 'blink::(anonymous namespace)::InObjectContainer' failed during virtual call (vtable address 0xe0726938) 0xe0726938: note: vtable is of type 'blink::(anonymous namespace)::InObjectContainer' Stack Trace: RELADDR FUNCTION FILE:LINE 205e4f5 blink::DeathAwareScriptWrappable::TraceWrappers(blink::ScriptWrappableVisitor*) const Original change's description: > [wrapper-tracing] Add ScriptWrappableVisitor unit tests > > Add unit tests that make sure that visitor dispatch reaches the expected leafs. > > Bug: chromium:841830 > Change-Id: I7dba068b66759312a41adfd0a2090af8b007e6fe > Reviewed-on: https://chromium-review.googlesource.com/1072212 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561762} TBR=haraken@chromium.org,mlippautz@chromium.org Change-Id: I1728cfd29313c0f7dfbaeb41c9045d82fd193f89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:841830 Reviewed-on: https://chromium-review.googlesource.com/1072988Reviewed-by:
-
Trent Apted authored
All these "frame-policy" tests probably have some copy-pasted flaky part. TBR=qyearsley@chromium.org Bug: 846472, 626703 Change-Id: Ife5452747dbafb5813f4060fbac88b8bc53f17d1 Reviewed-on: https://chromium-review.googlesource.com/1073107Reviewed-by:
-
Trent Apted authored
Mark virtual/outofblink-cors/external/wpt/fetch/security/redirect-to-url-with-credentials.https.html flaky TBR=toyoshim@chromium.org Bug: 846497 Change-Id: Idfdaad963ebde87772b85ed5967dd2386772cdd4 Reviewed-on: https://chromium-review.googlesource.com/1073041Reviewed-by:
-
Matt Menke authored
ProfileBrowserTest.SendHPKPReport and ProfileBrowserTest.SendHPKPReportServerHangs were failing due to not being able to enable HPKP for local trust anchors. This CL uses a mock cert verifier to make it look like the test server's cert was issued by a known root instead. Bug: 837776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I178b3dea602122cfd9d9926090a577c13c869f00 Reviewed-on: https://chromium-review.googlesource.com/1072527 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561782}
-
Gyuyoung Kim authored
Extract a common helper function which takes the switches and values of kMSEVideoBufferSizeLimit or kMSEAudioBufferSizeLimit from |SourceBufferState::SetStreamMemoryLimits|. And also, the helper function handles the input values as a megabyte. To change the unit of the input value, this CL updates the related part of layout test as well. Bug: None TEST: Covered by virtual/mse-1mb-buffers/http/tests/media/media-source/stream_memory_tests/ Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I42dd6cdf511b5098c2c595d99b41f571f8062945 Reviewed-on: https://chromium-review.googlesource.com/1056452Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#561781}
-
Kent Tamura authored
The 'name' field of entries produced by Json5File.load_from_files() was a str, and this CL makes it a NameStyleConverter object. The original string is accessible via |entry['name'].original|, and |str(entry['name'])|. This will make filter setup simpler because we don't need to provide filters for naming style conversion. * name_style_converter.py: - Provide |original| getter, and __str__(). - Provide __lt__() for sort(). - Provide __eq__() for groupby(). Some Jinja2 templates use built-in sort and groupby filters, and it's hard to specify key object in templates. * json5_generator.py Sets entry['name'] to a NameStyleConverter object, and remove entry['tokenized_name']. * DEPS Clean stale *.pyc in blink/renderer/build/scripts too. Some buildbots has media_feature_symbol.pyc in build/scripts/core/css/. * Other files - If code requires a string name, access entry['name'].original. - Use entry.name instead of entry.tokenized_name Bug: 843927 Change-Id: Ic47c90c51c8e88f08307a41b052ecfce971a4545 Reviewed-on: https://chromium-review.googlesource.com/1068575Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#561780}
-
Xiaocheng Hu authored
Existing EditorTest has test cases about copying text into clipboard, which checks clipboard text before the copy is complete. This patch adds RunPendingTasks() call to ensure copy completion before checking clipboard text, following the approach in crrev.com/c/1034022. It also adds another test case to show the correctness of this fixup. Change-Id: I5c9085520010fa4176f1d57f688d4e4201d4279a Reviewed-on: https://chromium-review.googlesource.com/1072639 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
chrome://flagsDominic Mazzoni authored
This is important for testing on Chrome OS and Android where it's not always possible to run Chrome with a command-line switch. Bug: 746523 Change-Id: I8326cdaa44b6013dd0b6a9d1c1f7ca1022cb208e Reviewed-on: https://chromium-review.googlesource.com/1072505Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561778}
-
Noel Gordon authored
Remove the concept of LegacyEvents: irrelevant. Instead change concept to the use of Trusted JS Events, which are used to force Blink to send Tab key events to the Files.App page under test (add a comment). If we don't use trusted Events, Blink consumes Tab key events with its default handlers and the Tab key never reaches the JS page under test. This affects the browser tests involving "tabindex" -- they won't work unless they receive Tab key JS Events [1]. Clean up the TestCase struct: remove the accessors, and access members directly since all access is const anyway. Add a new struct EventTest, to specialize TestCase for the few tests that need trusted Events. No change in behavior, no new tests. [1] see crbug.com/482121 crbug.com/480491 Bug: 836254,482121,480491 Change-Id: Ic1906c6033ccc65be43b2c8cbe1344e5ffec4655 Reviewed-on: https://chromium-review.googlesource.com/1072220Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561777}
-
Kent Tamura authored
* Remove the CString-version of NormalizeLineEndingsToCRLF() It's not used. * Remove CStringBuffer. Only the CString NormalizeLineEndingsToCRLF() used it. * Fold VectorCharAppendBuffer into InternalNormalizeLineEndingsToCRLF() OutputBuffer abstraction isn't necessary due to the removal of CStringBuffer, and InternalNormalizeLineEndingsToCRLF() is the only user of OutputBuffer. * Wrap InternalNormalizeLineEndingsToCRLF() with OS_WIN. It is used only on Windows. This CL has no behavior changes. Change-Id: I01d6177601f8be5fd5137f1554e7824080422d8f Reviewed-on: https://chromium-review.googlesource.com/1072222Reviewed-by:
-
Xiaocheng Hu authored
This is a workaround for crbug.com/845849. In some buggy cases, we get ComputeVisibleSelectionInFlatTree() returning non-null, but ComputeVisibleSelectionInDOMTree() returning null. This makes FrameSelection::Contains() return true erroneously. As we don't have a fix to the inconsistency, this patch adds a workaround that, we call ComputeVisibleSelectionInDOMTree() first to set the cached VisibleSelections to null also for flat tree, so that the following computation does not work on a non-null VS in flat tree erroneously. Bug: 845849 Change-Id: I7255d8224b8b6e29d479dd635e2c4ee99b366fc1 Reviewed-on: https://chromium-review.googlesource.com/1072924Reviewed-by:
-
Makoto Shimazu authored
Bug: 828331 Change-Id: I6198fe5be6de71a33fc3bc191d16802c92b2751f Reviewed-on: https://chromium-review.googlesource.com/1025593 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561774}
-
Trent Apted authored
TBR=bajones@chromium.org,zmo@chromium.org Bug: 846547 Change-Id: I222688c2c5bfe9f3740f9f747264310c1822c0dd Reviewed-on: https://chromium-review.googlesource.com/1073032 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Michael Moss authored
This reverts commit 20a5f39c. Reason for revert: Breaking official linux builds. Original change's description: > [FileUtil] Test thread-safety of temp file APIs. > > Ruling out https://crbug.com/826408#c17 as the source of the issue. > > R=thestig@chromium.org > > Bug: 826408 > Change-Id: I00396084d674fa2f700eb917300280b6eed1684d > Reviewed-on: https://chromium-review.googlesource.com/1072030 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561666} TBR=gab@chromium.org,thestig@chromium.org Change-Id: Icc838da2c247563b94c5e6508c8c268df68f3ce9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826408, 846563 Reviewed-on: https://chromium-review.googlesource.com/1072966Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#561772}
-
Michael Lippautz authored
This is in preparation of using Trace instead of TraceWrappers for wrapper tracing. Bug: chromium:841830 Change-Id: I59a2ee4ad923361109ee387be76f8d08d1b67413 Reviewed-on: https://chromium-review.googlesource.com/1072214Reviewed-by:
-
Sam McNally authored
Bug: 844294 Change-Id: I6f91d058e6c8bbd3dec574c2ac5b6ea1ae2b42b5 Reviewed-on: https://chromium-review.googlesource.com/1071489 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#561770}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b2eda420234d..04796cdada00 $ git log b2eda4202..04796cdad --date=short --no-merges --format='%ad %ae %s' 2018-05-24 jmadill Remove gl::PrimitiveType. 2018-05-24 jmadill Add PrimitiveMode packed GLenum. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I9eab8588cdb2e72909accd54e02245accc055f36 Reviewed-on: https://chromium-review.googlesource.com/1072324 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561769}
-
Ehsan Karamad authored
Unlike frames, plugin elements (<embed> and <object>) are updated when their layout tree is rebuilt. However, due to an oversight, <embed> or <object> elements displaying subframes would only have the associated content view (FrameView) torn down, leaving a dangling content frame. This led to some interesting side effects: - When transitioning from a local frame to a plugin, the content frame would remain live, with JS still happily running. - When transitioning from a remote frame to a plugin, - When navigating a remote frame from one URL to another, the element would stop updating since the FrameView would be torn down but a new one would never be created. Note that this was not (as much of) a problem for local frames, since local frames re-create the LocalFrameView on every navigation. With this CL, if a plugin element has an associated content frame, use that to clean up the state associated with the element when the layout tree is detached. This can cause the browser context to be re-created: this matches the behavior of Edge and Firefox. Note that there is still one edge case where Blink behaves oddly: if the navigation fails and should display fallback content, the content frame still remains attached. This will be addressed in followups. Link to whatwg issue: https://github.com/whatwg/html/issues/3576 Bug: 776510, 781880 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id18605fbe602ea6c0076c1d579345cdcf28cc984 Reviewed-on: https://chromium-review.googlesource.com/996314 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#561768}
-
Stuart Langley authored
Currently change_list_loader and directory_loader only work for the users default corpus. We can fix this by passing the team_drive_id and the root_entry_path as parameters during construction rather then just assuming the users default corpus root. With this change we can not use directory_loader and change_list_loader to also processes changes from team drives by passing the appropriate team_drive_id and root_entry_path. Bug: 835703, 833690 Change-Id: I5ba3ed8fa3323dfd520c9e1837934eeef79a30a7 Reviewed-on: https://chromium-review.googlesource.com/1068642 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561767}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 376a94c1. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18539 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I79c8700e152738718535e8f26d1b63c37f6ac966 Reviewed-on: https://chromium-review.googlesource.com/1072694 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561766}
-
Trent Apted authored
Flaky. TBR=fsamuel@chromium.org,phoglund@chromium.org Bug: 846554 Change-Id: I4eb5ef90717fd417aae68ef843365ad7cafaa87f Reviewed-on: https://chromium-review.googlesource.com/1073031 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
chcunningham authored
Using "max" minimizes the chance of creating gaps in the buffered range due to bad estimates (see bug). We previously used "min" out fear that max would trigger bad audio splicing. But this CL deprecates splicing on overlapped audio buffers that contain estimated durations. This is safe after UMA demonstrated that no one splices on these buffers at this time. This CL also removes the additional info about estimation confidence from StreamParserBuffer. This was originally added to see if it would help us preserve some portion of desired splices... but there were no splices to save, so it's just needless complexity. Bug: 396634 Test: New unit test, Verified fixed repro from bug Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic0d533759b2abc269f52a05c1275d33b223fb863 Reviewed-on: https://chromium-review.googlesource.com/1068215Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#561764}
-
Xing Liu authored
Currently when user removes files in download home, the actual file is not getting deleted on Android M, the Android DownloadManager may not delete the file when calling DownloadManager.remove(). This bug is introduced in: https://chromium.googlesource.com/chromium/src/+/63c0b59001b40d4221aa87c332828793e5090690 between commit 13 and 14: https://chromium-review.googlesource.com/c/chromium/src/+/577720/13..14/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java We need to return false here to let DownloadManagerUI to delete the actual file in here: https://chromium.googlesource.com/chromium/src/+/68.0.3439.0/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java#164 In native code, we only remove the history db record for completed download, and in Java, we remove the download through Android DownloadManager. Bug: 844713 Change-Id: Idf6e5ec870eaef92aaa8698c27b2c1ab283679e6 Reviewed-on: https://chromium-review.googlesource.com/1072424Reviewed-by:
-
