- 27 Jul, 2010 40 commits
-
-
jeremy@chromium.org authored
Port magic from GTMFadeTruncatingTextFieldCell to Chrome's GradientButtonCell, used by buttons in the bookmark bar. Any button that inherits from this class will now get overflowing titles truncated with a nice gradient (same as tab titles), rather than the default ellipsis. Using GTMFadeTruncatingTextFieldCell in this case wasn't feasible because bookmark buttons are subclasses of NSButtonCell and already use a bunch of specialized behavior provided by it. BUG=45104 TEST=Add a bookmark to the bookmark bar and increase the length of it's title. Once you get past a certain length, rather than truncate the title should fade out nicely. Exactly in the same way long tab titles do. Bookmark buttons with titles that aren't truncated should look exactly the same. Also test with Dolce & Gabbana theme which has inverted contrast. Review URL: http://codereview.chromium.org/2806066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53773 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
TBR=timurrrr BUG=50347,50348,50349,50345,50335,50334,50336 Review URL: http://codereview.chromium.org/3044027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53772 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
TBR=glider Review URL: http://codereview.chromium.org/3064010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53771 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=None TEST=Tests that use a regular PrefService are green. Review URL: http://codereview.chromium.org/3046023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53770 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=50346 TBR=glider Review URL: http://codereview.chromium.org/2847077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53769 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@google.com authored
Add test register form page. Added extra debug logging. Full cycle: 1. Register screen navigates to chrome://register (host page). 2. host page requests DOMUI for register form URL: getRegistrationUrl msg on DOM load event. 3. Once URL is received it is loaded in an iframe. 4. When register form is loaded it sends get_user_info msg via postMessage to host page. 5. host page requests DOMUI for system/user info: getUserInfo msg. 6. Once info is received host page sends that to an iframe with set_user_info msg. 7. Register form notifies host page on registration success/skip status with complete_registration msg. 8. Based on registration result host page navigates to cros://register/[success|skipped] so that Out of box wizard is notified. BUG= http://crosbug.com/4813 TEST=manual Review URL: http://codereview.chromium.org/3058006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53768 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53766 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
Implement the "Configure modifier keys" drop-down which enables users to swap Alt/Ctrl keys and Search/Ctrl keys. BUG=chromium-os:2636 TEST=manually on eeepc Review URL: http://codereview.chromium.org/3038025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53764 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
TBR=timurrrr Review URL: http://codereview.chromium.org/3061020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53763 0039d316-1c4b-4281-b951-d872f2087c98
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/3035026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53762 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=50334,50335,50336 TEST=Linux Memcheck bot (3) should become green Review URL: http://codereview.chromium.org/2856064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53761 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
* Removing library name from stack. * Relaxing suppresion for 19775. * Removing anonymous name part from 22450 * new suppressino for 46570. Chould have been merged to _b, but i wasn't sure if it's safe. * 50304 relaxing suppression TBR=glider@chromium.org BUG=50304, 46570, 22450, 19775 TEST=chromeos valgrind should cycle green (crossing finger) Review URL: http://codereview.chromium.org/3041023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53760 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
Several integration tests use the wrong method to wait for sync to complete, as a result of which they fail during verification. Also making the condition for the detection of sync completion more robust. BUG=50114 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3037019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53759 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
TEST=confirmed that the layout names added in generated_resource.grd appear in the languages and input dialog. also confirmed that error messages are gone from logs. BUG=chromium-os:3440 Review URL: http://codereview.chromium.org/3063007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53758 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
ChromeFrame cookie requests would incorrectly get routed to the first host browser connected to the renderer. This basically meant that if the browser process exited then other popups could not query cookies from the host. Part of the fix for http://b/issue?id=2277519 Bug=2277519 Review URL: http://codereview.chromium.org/3066004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53757 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=21276 Review URL: http://codereview.chromium.org/3028027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53755 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=bulach TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53754 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
Move utility functions into a header file (currently chewing and pinyin are the customers). TEST=manually check on the netbook by uncommenting TODO lines. BUG=chromium-os:4808 Review URL: http://codereview.chromium.org/3015028 Patch from Takayoshi Kochi <kochi@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53753 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@google.com authored
BUG=chromium-os:2636 TEST=manually on eeepc, ran the browser_tests Review URL: http://codereview.chromium.org/2806077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53752 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
BUG=50300 TEST=mac intl2 tests are green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/3027028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53748 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
BUG=49997 TEST=ftp_directory_listing_parser_windows_unittest.cc Review URL: http://codereview.chromium.org/3013029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53747 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=bulach TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53746 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
called after AtExitManager initialization, and call InitLogging() only if !unit_test_mode. InitLogging() needs AtExitManager because it uses PathService. TEST=This is a part of test code. BUG=none Review URL: http://codereview.chromium.org/3030018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53743 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Use EncoderZlib / DecoderZlib as default encoder and decoder. BUG=50246 Review URL: http://codereview.chromium.org/3034035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53742 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Cleanup: Rename gtk button state names to (a) match other platforms and (b) not be misleading (e.g. "depressed" where it should be "disabled"). Better indenting. Inline a function that has only one caller for simplicity. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3029032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53741 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Make the throbber and tab close button correctly respond to theme changes. This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless). BUG=50107 TEST=Throbber responds to theme changes Review URL: http://codereview.chromium.org/3064006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53740 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53739 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Encoder and decoder using zlib for chromoting. This implementation has zero copy out of the decoder and encoder. The consequence is that we have to break out the zlib stream into rect boundaries which requires the synchronication flush feature in zlib. This feature will hurt compression ratio but the effect still need to be measured. This patch also provides tests for testing the Encoder and Decoder pair with zlib. TEST=remoting_unittests Review URL: http://codereview.chromium.org/2868062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53738 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
Before this change, the language name and the input method list were hard-coded in the HTML file. With this change, these values will be displayed based on the underlying data from C++ world. TEST=manually BUG=chromium-os:4573 Review URL: http://codereview.chromium.org/3008016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53737 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Make theme change notifications auto-propagate through the view hierarchy, instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change. Make naming for theme and locale changes consistent and clear. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/2878055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53736 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
Add boilerplate line for experimental api pages BUG=48582 TEST=NONE Review URL: http://codereview.chromium.org/2881038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53734 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Remove IDR_OMNIBOX_*_TRANSPARENT images. The comments for why we need them are out-of-date -- the normal images no longer have white backgrounds, and we don't need an extra "transparent" set. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3075001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53733 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Review URL: http://codereview.chromium.org/3052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
-
jiesun@google.com authored
forget to putCurrentFrame for this renderer. Review URL: http://codereview.chromium.org/3018021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53730 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/2806070zelidrag@chromium.org authored
Checking in http://codereview.chromium.org/2806070 and http://codereview.chromium.org/3028018 on behalf of zbehan@. third_party: add a stub cros directory and cros_api.gyp for libcros to satisfy gyp depdendencies cros: fix more of the third_party includes, forbid similar includes for future BUG=none TEST=make sure both chrome and chromeos builds are happy. TBR=zelidrag Review URL: http://codereview.chromium.org/3035021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53729 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
Chromeos's stack is slightly different from one for linux. TBR=glider@chromium.org BUG=45254 TEST=none Review URL: http://codereview.chromium.org/2819068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53727 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=bulach TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53726 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
TBR=asargent@chromium.org BUG=50304 TEST=none Review URL: http://codereview.chromium.org/2883040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53725 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
TEST=make sure desktopui_BrowserTest autotest works on ChromeOS BUG=chromium-os:4828 Review URL: http://codereview.chromium.org/2881026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53724 0039d316-1c4b-4281-b951-d872f2087c98
-
feldstein@chromium.org authored
Readibility review code using the cocoa browser accessibility stuff for objective c Review URL: http://codereview.chromium.org/2951011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53723 0039d316-1c4b-4281-b951-d872f2087c98
-