- 26 Sep, 2017 40 commits
-
-
Owen Lin authored
The callback is used for only once. There is no need to keep it in the callback map. Bug: None Test: None Change-Id: I0a40faa323b1c9f98ad05f15bcb8451fe28041c2 Reviewed-on: https://chromium-review.googlesource.com/683915 Commit-Queue: Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504321}
-
tzik authored
The upcoming unification of WTF::RefCounted and base::RefCounted causes compile errors around AdoptRef, Bind, Passed due ADL. This CL converts them to fully qualified names before it happens. Bug: 763844 Change-Id: Ib2361e02e70de193f3b6d0401ff626426d0a162c Reviewed-on: https://chromium-review.googlesource.com/684095 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#504320}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/030de5515608..639e972bf15c $ git log 030de5515..639e972bf --date=short --no-merges --format='%ad %ae %s' 2017-09-25 yukiy Add tab.StopAllServiceWorkers() Created with: roll-dep src/third_party/catapult BUG=736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7e1d0b5fa661a50b05e839ccce96b4b732f7936c Reviewed-on: https://chromium-review.googlesource.com/684194 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504319}
-
Mattias Nissler authored
This reverts commit 2ade99c3. Reason for revert: Breaks compile on Closure_Compilation_Linux, see https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClosure_Compilation_Linux%2F120458%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Add TPM firmware update option to about page. > > BUG=chromium:742985 > TEST=New webui test case in CrSettingsAboutPageTest.AboutPage > > Change-Id: Ie5d5d4f61efb56aa8fe61988bfdbdc44450a34b7 > Reviewed-on: https://chromium-review.googlesource.com/678728 > Commit-Queue: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504315} TBR=xiyuan@chromium.org,stevenjb@chromium.org,mnissler@chromium.org Change-Id: I974a2ff1b144fc912444d41d98c6421270f81987 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:742985 Reviewed-on: https://chromium-review.googlesource.com/684374Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504318}
-
Akari Asai authored
Modify HandleElementNode() and add HandleChildren() to make SelectionSample Parser traverses on DOMTree with shadow contents. testing/SelectionSample.{cpp, h} is a utility class for C++ to take HTML style inputs with template tages,build a pure DOM tree with shadow roots and return the shadow dom tree. This patch modifies HandleElementNode() and HandleChildren() in this SelectionSample to make SelectionSample Parser traverses over a DOM tree with single or multiple shadow roots, since the current implementation assumes the dom tree doesn't have any shadow root, and only traverse over body content. This change is for making SelectionSample class to take HTML style inputs with template tags. This patch also add some tests to check if SelectionSample actually traverses over a DOM tree with single or multiple template tags, template with slots. Bug: Change-Id: Id3e1935335a3468ed39ec2e0a65c0bca4e07657e Reviewed-on: https://chromium-review.googlesource.com/671165Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Akari Asai <akariasai@google.com> Cr-Commit-Position: refs/heads/master@{#504317}
-
Philip Jägenstedt authored
fullscreen-pseudo-class-manual.html is written in such a way that the failure message still prove that it works, except that like :-webkit-full-screen it doesn't match an inner fullscreen element when nested. This will be fixed separately. Bug: 402378 Change-Id: I556d0dbd868119da309456cce6c9b3a08cf7b40f Reviewed-on: https://chromium-review.googlesource.com/681356Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#504316}
-
Mattias Nissler authored
BUG=chromium:742985 TEST=New webui test case in CrSettingsAboutPageTest.AboutPage Change-Id: Ie5d5d4f61efb56aa8fe61988bfdbdc44450a34b7 Reviewed-on: https://chromium-review.googlesource.com/678728 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504315}
-
Marc Treib authored
This reverts commit fed2d25e. Reason for revert: Breaks compile on chromium.webkit Android Builder: https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/121292 Original change's description: > Basic image content based approach added to HighContrastImagePolicy. > > To correctly decide if an image should be inverted or not for high- > contrast view, a very simple classifier is added under kFilterSmart > HighContrastImagePolicy and the decision on an image is stored in the > blink::Image objects for next references. > > Bug: 685242 > Change-Id: I47242c237e7f34291bba53a7a02a9d6c9ef632a1 > Reviewed-on: https://chromium-review.googlesource.com/654644 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504305} TBR=dmazzoni@chromium.org,chrishtr@chromium.org,rhalavati@chromium.org Change-Id: I181904195ec796271c14b1e1664ed0c575c5214c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 685242 Reviewed-on: https://chromium-review.googlesource.com/684314Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504314}
-
Marc Treib authored
This reverts commit 5b37246c. Reason for revert: hover-after-affected-by-change.html consistently fails on WebKit Linux Trusty Leak: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Original change's description: > Store new ComputedStyle object if style did not change. > > The comparison of ComputedStyle does not take additional flags into > account. For instance, the AffectedBy* flags used for updating pseudo > classes like :hover. We used to call SetStyleInternal, but this was > removed because the previous comment said it was because of style > sharing which is now removed. > > The display:contents case (768406) never worked because the code path > for StoreNonLayoutObjectComputedStyle() was always skipped when > computed style compared to be equal. > > Bug: 768406, 767832 > Change-Id: Iac4708e3cd3a6451d99c1bb2bb69efb74289b8eb > Reviewed-on: https://chromium-review.googlesource.com/681755 > Reviewed-by: nainar <nainar@chromium.org> > Commit-Queue: Rune Lillesveen <rune@opera.com> > Cr-Commit-Position: refs/heads/master@{#504285} TBR=rune@opera.com,nainar@chromium.org Change-Id: I34a54b694bb719b278426f9a76076fa77cd9e82f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768406, 767832 Reviewed-on: https://chromium-review.googlesource.com/684275Reviewed-by:
-
Doug Turner authored
Bug: None Change-Id: I434055fd471e6fcd3579999df7379c42313133ec Reviewed-on: https://chromium-review.googlesource.com/683834Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#504312}
-
Doug Turner authored
Bug: 703369 Change-Id: Icbab14a1d81201cde6d21a9ccf73e6ac9bd0286a Reviewed-on: https://chromium-review.googlesource.com/678439Reviewed-by:
-
Rune Lillesveen authored
We used to update counters on every layout as long as there was at least on LayoutCounter in the rendered document. Also, the update was triggered by marking the changed element for layout. We need to update counters when we add/remove LayoutCounter, or when computed counter directives change on rendered elements during style recalc. We update counters immediately after style recalc and layout tree rebuild in Document::UpdateStyle(). Bug: 768357 Change-Id: I32693fefaa7bdb74cf959ef5ead4256d2ec2d0da Reviewed-on: https://chromium-review.googlesource.com/678676 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#504310}
-
Marc Treib authored
...and into BrowserInstantController. This reduces the number of "Instant things" that Browser has to know about from 4 to 2. Bug: 627747 Change-Id: I1d9dbfe37bda88e59ce6fa4759f8b3a8428eaacc Reviewed-on: https://chromium-review.googlesource.com/678502Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504309}
-
Dominick Ng authored
The required icon sizes for adding a site to homescreen or desktop are constants per platform. However, for legacy reasons, these sizes are currently passed as parameters to InstallableManager::GetData. This requires every caller of InstallableManager to know about icon sizes, which isn't really necessary since every caller uses the same sizes on desktop and on Android. This CL consolidates all installable icon size specifications in InstallableManager. Custom icon sizes can no longer be requested. BUG=767767 Change-Id: Iee36e14854b3dd80d597e0c0d9370b6ebea46911 Reviewed-on: https://chromium-review.googlesource.com/678695 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#504308}
-
Yoichi Osato authored
Bug: Change-Id: I918ea9781189c3aeba223e4ef0af7085e4e78c19 Reviewed-on: https://chromium-review.googlesource.com/683975Reviewed-by:
-
Mike West authored
koto@ added [`TrustedScriptURL`][1] to the explainer as a mechanism to distinguish URLs that directly lead to script execution (e.g. via assignment to `<script>`'s `src` attribute). This patch is a first pass at an implementation, along with restrictions on `script.src` so we can test it out. [1]: https://github.com/mikewest/trusted-types/commit/834163e519b579e5566908cafcedb2efe24be6da Bug: 739170 Change-Id: Ie784ff3992dbcf750521fd55710befe3ed26036c Reviewed-on: https://chromium-review.googlesource.com/677390 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#504306}
-
Ramin Halavati authored
To correctly decide if an image should be inverted or not for high- contrast view, a very simple classifier is added under kFilterSmart HighContrastImagePolicy and the decision on an image is stored in the blink::Image objects for next references. Bug: 685242 Change-Id: I47242c237e7f34291bba53a7a02a9d6c9ef632a1 Reviewed-on: https://chromium-review.googlesource.com/654644 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#504305}
-
Daniel Bratell authored
The two implementations of ToV8 for testing collided in jumbo builds so to avoid having to exclude some files in bindings tests from jumbo this patch moves the template to a shared header. Bug: 745732 Change-Id: Iaa7cf7e19d987e7a048fc606eafaedb49606959a Reviewed-on: https://chromium-review.googlesource.com/677394Reviewed-by:
Jens Widell <jl@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#504304}
-
Yafei Duan authored
Fix msan test. TBR=fgorski@chromium.org Bug: NONE Change-Id: I1a8083af308fc0869e0f20d22155d6a97f986f5e Reviewed-on: https://chromium-review.googlesource.com/683601 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#504303}
-
Charles Reis authored
BUG=768575 TEST=See bug for repro steps Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I0c64d13dcea6a13b622ec250d55327972fe77390 Reviewed-on: https://chromium-review.googlesource.com/683341 Commit-Queue: Charlie Reis (catching up) <creis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504302}
-
Will Harris authored
Also, move the DCHECK out of the comma operator. BUG=427616 Change-Id: Id5aa46c1b5d7976640777f83c9828ee8b02cc0d3 Reviewed-on: https://chromium-review.googlesource.com/683231Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#504301}
-
Piotr Swigon authored
Need to cut down on noise in my inbox. Change-Id: Ic958ac4aba2f3ac50180ffa3fdac392f4baf9344 Reviewed-on: https://chromium-review.googlesource.com/684094Reviewed-by:
Kendra Carattini <kcarattini@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#504300}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8a218af5. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2432 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I788a661845af22730282202c1191fa4c8b299100 Reviewed-on: https://chromium-review.googlesource.com/683737 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504299}
-
Hiroki Nakagawa authored
This CL... - wraps sourcecodes at the 80th column. - uses modern JS features (arrow functions), and - removes the unused |opt_path| arg on runImportTests(). Bug: n/a Change-Id: I8f73f76b9c3e11a835464796e095d4de155e3593 Reviewed-on: https://chromium-review.googlesource.com/683776 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#504298}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae4cc909a3bb..030de5515608 $ git log ae4cc909a..030de5515 --date=short --no-merges --format='%ad %ae %s' 2017-09-25 dmazzoni Add support for Tab key, needed by an accessibility story. Created with: roll-dep src/third_party/catapult BUG=712417 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id70fefec2fe404d9c3243f42972af5f579027d18 Reviewed-on: https://chromium-review.googlesource.com/683816 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504297}
-
Tetsui Ohkubo authored
This CL sets current timestamp to the default notification of push messaging. Previously, invalid time was shown when new style notification chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG=768695 Change-Id: Id253c990d39a8f8df71472c47137b8252a9186d4 Reviewed-on: https://chromium-review.googlesource.com/683914 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#504296}
-
Demetrios Papadopoulos authored
Bug: 762346 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ea349b1e1c99ad0c1a2b9e0f63b5049b9c4f30f Reviewed-on: https://chromium-review.googlesource.com/683458 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#504295}
-
Takashi Toyoshima authored
Since I ensure that the assumption is correct, I will replace one existing SECURITY_CHECK with DCHECK as I planned. Bug: 768325 Change-Id: I1a653d8d3d3a7e62df537e9e4d3017798078a108 Reviewed-on: https://chromium-review.googlesource.com/681394Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#504294}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ccb28b4fd165..ae4cc909a3bb $ git log ccb28b4fd..ae4cc909a --date=short --no-merges --format='%ad %ae %s' 2017-09-25 dmazzoni Add metric for accessibility. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I50f86ee290e7cc9464f68c881d5f091f573b063a Reviewed-on: https://chromium-review.googlesource.com/683800 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504293}
-
Will Harris authored
These leaks could occur under certain conditions such as when a policy evaluation in the broker has denied access but the request has still been made from the target. The leaked data is only visible in the shared memory, and never passed to the caller. This CL also fixes an inconsistency in behavior between the Open and Create functions for file and registry keys. BUG=765846 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I8fabbb8431cd2205d18b8cbe9553efd482d9b40f Reviewed-on: https://chromium-review.googlesource.com/673714 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504292}
-
Kyle Horimoto authored
There are race conditions in Bluetooth which can cause errors when starting and stopping discovery sessions too close to one another. In the worst case, these issues can cause a crash. This CL rate-limits BLE advertisements and scans to at most one per 200ms. This reduces the possibility of race conditions in the kernel. Bug: 768523, 672263 Change-Id: I985aec16b6f9cd80c385ab9af199daff4fb50ced Reviewed-on: https://chromium-review.googlesource.com/683756Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#504291}
-
Khushal authored
The animation can be reset to start from the beginning in blink. Plumb this to cc to replicate this behaviour if image animations are being ticked by the compositor. This uses a counter sequence incremented on the main thread each time the animation is reset to act as a synchronization point, which is necessary since recordings can be cached and resued by blink. Bug: 735743 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ff6fe22b1c5179a1ea8ec893f5d239895a4d2a4 Reviewed-on: https://chromium-review.googlesource.com/664245 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504290}
-
Colin Blundell authored
https://codereview.chromium.org/2673443002 introduced a bug in the Identity extension API implementation: it assumed that there would be only one IdentityGetAuthToken instance that needed to listen for IdentityAPI shutdown at a given time, but in fact, there can be many. An example is if the user has multiple tabs open that each call the getAuthToken() function with interactive set to true, so that they end up hanging waiting for the user to authenticate. The result of this bug is that if the browser shuts down with multiple getAuthToken() calls active, only the last call will receive notice of IdentityAPI shutdown. Other calls can then end up calling back into Profile during its shutdown process, e.g. if they get notified by OAuth2TokenService as part of *its* shutdown process that it has failed their token requests. These calls can result in CHECKs (see crash reports linked from crbug.com/720073). This CL fixes the bug while maintaining the property that IdentityGetAuthToken does not require an interface dependence on IdentityAPI (i.e., the property that was the motivation of the original CL). To do so, it changes IdentityAPI to maintain a CallbackList that gets invoked on its shutdown. This CL also introduces a browsertest that fails without this change. Bug: 720073 Change-Id: I44daaa0c0bbc27e54da9ab826e256c70f3d5a2a8 Reviewed-on: https://chromium-review.googlesource.com/680974Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#504289}
-
Wei Li authored
Change windows sandbox policy to allow ppapi utility process to access font directory in file system. Also set pdf compositor service's sandboxing type as ppapi so it can access font system on various platforms. BUG=455764 Change-Id: I356ddfe57e172e90a6d6deaf4bcf6d39dc1b5b97 Reviewed-on: https://chromium-review.googlesource.com/682767Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#504288}
-
Xianzhu Wang authored
Bug: 637313 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icad7f9354b7cb92ddfe8caa5224e3ba2540f7440 Reviewed-on: https://chromium-review.googlesource.com/667756 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Lei Zhang authored
Change-Id: I2bbe2154f8be8e727b7adad8ff809ff1668c55df Reviewed-on: https://chromium-review.googlesource.com/683235 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#504286}
-
Rune Lillesveen authored
The comparison of ComputedStyle does not take additional flags into account. For instance, the AffectedBy* flags used for updating pseudo classes like :hover. We used to call SetStyleInternal, but this was removed because the previous comment said it was because of style sharing which is now removed. The display:contents case (768406) never worked because the code path for StoreNonLayoutObjectComputedStyle() was always skipped when computed style compared to be equal. Bug: 768406, 767832 Change-Id: Iac4708e3cd3a6451d99c1bb2bb69efb74289b8eb Reviewed-on: https://chromium-review.googlesource.com/681755Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#504285}
-
Walter Korman authored
Will be useful for folks working on font support in out-of-process raster. For more see: https: //docs.google.com/document/d/1vsJsk1zGSagxxBggd8j5G9u0rMzD1NTaQWgEbUabEvY/preview#heading=h.xzi2kl5b59mm Change-Id: I77797cb295495b9adcef1a620754d71882dee79f Reviewed-on: https://chromium-review.googlesource.com/683463 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Expected to save ~700kb of .text on Android Bug: 738155 Change-Id: I58886003c259a65cd2e66baa71e38bfa962a2b3d Reviewed-on: https://chromium-review.googlesource.com/682647 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#504283}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fb921410. With Chromium commits locally applied on WPT: 4d3c601c "Refactor wpt/2dcontext/drawing-images-to-the-canvas/ layout tests:" f493473b "[Media Router] Update Cast Presentation URL logic - tests only" 9d3055f4 "Moving URL bar fires visualViewport resize event" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2431 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes-1 tyoshino@chromium.org: external/wpt/navigation-timing TBR=qyearsley@chromium.org No-Export: true Change-Id: Ife6cf23dc57834a100f46260f97802664323c291 Reviewed-on: https://chromium-review.googlesource.com/683535 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
