GitLab

Explain what the method actually does
preflightSuccess -> loadActualRequest
preflightFailure -> handlePreflightFailure

BUG=none

Review URL: https://codereview.chromium.org/300893002

git-svn-id: svn://svn.chromium.org/blink/trunk@174947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(We're not sure if they're real or not yet, but apprently they
seem to coming from the same cause)

BUG=364390
TBR=kouhei@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/302633011

git-svn-id: svn://svn.chromium.org/blink/trunk@174946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376194

Review URL: https://codereview.chromium.org/295633003

git-svn-id: svn://svn.chromium.org/blink/trunk@174945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A crash bug which an attached test case causes is following: 
1. Selection.deleteFromDocument calls Range.deleteContents which removes a node through Node.removeChild. 
2. Node.removeChild calls a DOMNodeRemoved event which removes the node. 
3. Then Node.removeChild asserts a DOM exception NOT_FOUND_ERR. 
4. Range.deleteContents picks the exception and it causes crash because Selection.deleteFromDocument calls Range.deleteContents with ASSERT_NO_EXCEPTION. 

This cl changes Selection.deleteFromDocument to delay the mutation event dispatching when it calls Range.deleteContents.
Especially, DOMNodeRemoved will be not kicked.

BUG=339186

Review URL: https://codereview.chromium.org/199383004

git-svn-id: svn://svn.chromium.org/blink/trunk@174944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously the AnimationPlayer's finish event could have been dispatched
after the event handlers had been collected. As these events are queued
then dispatched asynchronously via ScriptedAnimationController some
special handling is required (tracking when the event is actually
dispatched).

BUG=376349

Review URL: https://codereview.chromium.org/284323004

git-svn-id: svn://svn.chromium.org/blink/trunk@174943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

GYP split step 3/4

Last remaining step (shown in FIXMEs) is the global constructors.

Needed to modify the interfaces_info merging function due to
existing of partial interface definitions that cross
components, primarily lots of
partial interface Navigator
in modules.
This is not a layering violation (since partial
interfaces *extend* interfaces), but it causes added
complexity.

One nice side effect:
touching a core IDL file means we now only need to parse all
core files, but not modules files, and conversely for
modules, which makes incremental build a bit faster.

R=haraken
TBR=thakis
BUG=358074

Review URL: https://codereview.chromium.org/304643003

git-svn-id: svn://svn.chromium.org/blink/trunk@174942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Multi-sided patch:
1/3: chromium-side, https://codereview.chromium.org/299003002/
2/3: blink-side, THIS PATCH
3/3: chromium-side, cleanup & re-enable test (n/a yet)

BUG=376733
TEST=http/tests/serviceworker/response.html
TEST=http/tests/serviceworker/headermap.html

Review URL: https://codereview.chromium.org/287363004

git-svn-id: svn://svn.chromium.org/blink/trunk@174941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350571

Review URL: https://codereview.chromium.org/291303003

git-svn-id: svn://svn.chromium.org/blink/trunk@174940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test is asserting that the FontFace status is "loading" right after
load(), but since Ahem.ttf are loaded by the three test cases, it can be
"loaded" if ResourceFetcher reuses the FontResource. To avoid this,
adding dummy query strings to Ahem.ttf urls.

Review URL: https://codereview.chromium.org/300683011

git-svn-id: svn://svn.chromium.org/blink/trunk@174939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

-crbug.com/366387 [ Debug ] svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html [ Crash ]
-crbug.com/366387 [ Debug ] svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html [ Crash ]
-crbug.com/370789 fast/dom/document-contentType-data-uri.html [ Failure ]


BUG=366387, 370789
TBR=alph, esprehn
NOTRY=true

Review URL: https://codereview.chromium.org/298313002

git-svn-id: svn://svn.chromium.org/blink/trunk@174938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- ScriptState::current() should be called only from the binding layer. This CL removes ScriptState::current() from IDBRequest. For that goal, this CL passes ScriptState around in a lot of places in IDB code.

- This CL also introduces ScriptStateForTesting. It's hard to use ScriptState for testing purposes because webkit_unit_tests doesn't create DOMWindow nor ExecutionContext, and thus ScriptState cannot be associated with a valid ExecutionContext. On the other hand, ScriptStateForTesting allows us to mock the ExecutionContext for testing purpose.

- This CL renames V8ExecutionScope to V8TestingScope. This is because V8TestingScope uses ScriptStateForTesting, and thus it's only for testing.

- This CL stops using V8ExecutionScope in V8GCController, because V8GCController is not for testing.

BUG=357144
TBR=adamk

Review URL: https://codereview.chromium.org/295163005

git-svn-id: svn://svn.chromium.org/blink/trunk@174937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The CSS parser and CSSComputedStyleDeclaration use the none keyword for the
shape-outside property. CSSAnimatableValueFactory and StyleBuilderFunctions
treat the same shape value as the auto keyword.
The effect of this is that the none shape value is never applied.

According to the spec we should be using the none keyword.
http://dev.w3.org/csswg/css-shapes-1/#shape-outside-property

BUG=378071

Review URL: https://codereview.chromium.org/303473009

git-svn-id: svn://svn.chromium.org/blink/trunk@174936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Preparatory refactoring: no changes to generated bindings.

Next step in splitting bindings build is splitting compute_interfaces_info
into core and modules.

For several reasons, I'm *first* splitting the compute_interfaces_info step
into two steps (vertical split): individual and overall.
In follow-up I'll split the individual step in two – core and modules
(horizontal split) – but to keep it simple I'll do that separately.

The reasons are:
1. To treat different IDL files differently, depending on component;
(In follow-up I'll split individual into core vs. modules, and then we'll
finally be able to distinguish components in the CG, and generate qualified
include paths w/o hideous path hacks!)

2. To avoid duplication (we want to avoid reading in all core IDL files for
core, and then reading in all core IDL files *again* and module IDL files for
modules);

3. Simplify build, by having simpler steps.

R=haraken
TBR=Nico
BUG=358074

Review URL: https://codereview.chromium.org/300273005

git-svn-id: svn://svn.chromium.org/blink/trunk@174935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

toGMTString is deprecated, and its results are cumbersome.
toISOString output is much more clear and useful.

BUG=377595

Review URL: https://codereview.chromium.org/300103007

git-svn-id: svn://svn.chromium.org/blink/trunk@174934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This prepares |SMILTimeContainer::m_scheduledAnimations| for oilpan.
- Vector<SVGSMILElement*> is changed to LinkedHashSet, as oilpan do not support having weak members as vector element.
- Entries pointing to disposing elements are automatically rewritten by oilpan weak processing. They are explicitly removed at |updateAnimations()|

BUG=357163

Review URL: https://codereview.chromium.org/304453002

git-svn-id: svn://svn.chromium.org/blink/trunk@174933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

termiante-during-sync-operation.html was slow.  It sometimes took 89 seconds to
pass on debug bots.

BUG=357427

Review URL: https://codereview.chromium.org/293363014

git-svn-id: svn://svn.chromium.org/blink/trunk@174932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=79180

Review URL: https://codereview.chromium.org/273893002

git-svn-id: svn://svn.chromium.org/blink/trunk@174931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since we have subpixel positioning, we can permanently switch to
using so called "printer fonts" on Mac and remove the platform
specific property from FontDescription. This permanently disables
hinting, as discussed with eseidel and behdad.
For LayoutTests, as on other platforms, we keep hinted fonts, 
only disable hinting for a group of subpixel positioning tests,
as previously done on Windows for DirectWrite testing.

BUG=373240,377696
R=eae,dglazkov,leviw

Review URL: https://codereview.chromium.org/275913005

git-svn-id: svn://svn.chromium.org/blink/trunk@174930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec: http://w3c.github.io/webcomponents/spec/shadow/#satisfying-matching-criteria

BUG=370670

Review URL: https://codereview.chromium.org/279763002

git-svn-id: svn://svn.chromium.org/blink/trunk@174929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=378129
TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/297203010

git-svn-id: svn://svn.chromium.org/blink/trunk@174928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=tkent@chromium.org
BUG=378129

Review URL: https://codereview.chromium.org/296403013

git-svn-id: svn://svn.chromium.org/blink/trunk@174927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Backported from Webkit: http://trac.webkit.org/changeset/169318 (patch by ddkilzer@apple.com) with a modified test to work for Blink.

BUG=376800
R=eseidel

Review URL: https://codereview.chromium.org/298023006

git-svn-id: svn://svn.chromium.org/blink/trunk@174925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=174909

BUG=338794
TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/300683010

git-svn-id: svn://svn.chromium.org/blink/trunk@174924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this change, SVGAnimateElement cached resolved element instances in 
|m_animatedElements|. However, this is not updated synchronously when <use> 
shadow dom/instance tree is torn down or new instances are added.

The patch changes SVGAnimateElement to resolve its target instances on the fly 
when needed.

As |m_animatedElements| are no longer kept, we do not guarantee that 
animationStarted hook is called before each animation. animationEnded
hook is guaranteed to be called for elements stayed in the tree 
when the animation ended, but it may not be called for the animated element 
|removedFrom| the document tree while animation.

BUG=369860

Review URL: https://codereview.chromium.org/298873003

git-svn-id: svn://svn.chromium.org/blink/trunk@174923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=377330
TEST=test-webkitpy, jsonresults_unittest.py
NOTRY=true

Review URL: https://codereview.chromium.org/296423002

git-svn-id: svn://svn.chromium.org/blink/trunk@174922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/301773002

git-svn-id: svn://svn.chromium.org/blink/trunk@174921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds most of the blink bindings and code to the GN build. It runs but I have only spot-checked that
the outputs are identical to the GYP ones.

Moved the feature defines to config.gni. Added a string version of these defines (GN doesn't
have a nice way to do this in the format the scripts expect, so I also added a python script).
This is used in various actions.

Provide GN equivalents for the core and bindings gypis.

The bindings BUILD.gn file is a bit icky with rebase_path all over the place and it's difficult to
follow where the names are relative to. We read the file lists from gypis and the source isn't
really the way GN would prefer. I'm planning to add a function to GN to convert a path to a
source-absolute path which will clean up some of these calls (in a later pass).

R=nbarth@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/298703005

git-svn-id: svn://svn.chromium.org/blink/trunk@174920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a build failure caused by https://codereview.chromium.org/292173009/
due to an unused local variable in release.

NOTRY=TRUE

Review URL: https://codereview.chromium.org/306483012

git-svn-id: svn://svn.chromium.org/blink/trunk@174919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

An additional option flag was added to the WHATWG Encoding Living
Standard's API to allow callers to disable the minimal BOM handling
the API supports.

BUG=362609

Review URL: https://codereview.chromium.org/232513003

git-svn-id: svn://svn.chromium.org/blink/trunk@174918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Extend the font WidthCache to always compute and cache the glyph bounding box,
regardless of whether the glyphOverflow parameter is supplied. This ensures that
subsequent calls can always be served from the cache and as such the cache can
now also be used for text measurements where the bounding box of the glyphs is
required. 

BUG=347186
R=dominik.rottsches@intel.com

Originally landed as r174230 and reverted as r174318 due to snowleopard debug
test failures.

Review URL: https://codereview.chromium.org/295853002

git-svn-id: svn://svn.chromium.org/blink/trunk@174917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163
TBR=oilpan-reviews,haraken
NOTRY=true

Review URL: https://codereview.chromium.org/302763005

git-svn-id: svn://svn.chromium.org/blink/trunk@174916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL might cause small regression of indexeddb_perf on some
platforms. It's expected.

BUG=366528

Review URL: https://codereview.chromium.org/297803002

git-svn-id: svn://svn.chromium.org/blink/trunk@174915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're getting rid of the forceCompositingMode setting. This
is one of two remaining callers that sets it to false. For now,
disable accelerated compositing entirely. Verified that the
test still fails when r173949 is reverted.

BUG=377851,363772

Review URL: https://codereview.chromium.org/306453006

git-svn-id: svn://svn.chromium.org/blink/trunk@174914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews@chromium.org,dcheng@chromium.org,ericwilligers@chromium.org
BUG=

Review URL: https://codereview.chromium.org/303673005

git-svn-id: svn://svn.chromium.org/blink/trunk@174913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Continuations aren't guaranteed to share a repaint container.
Teach the focus rect code to not cross repaint container bounds
to generate focus rects in the case of continuations, but
instead allow the subsequent repaint containers to handle their
own rects.

BUG=377536

Review URL: https://codereview.chromium.org/301763002

git-svn-id: svn://svn.chromium.org/blink/trunk@174912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to make the layout tests deterministic and prevent flakes.

BUG=377736

Review URL: https://codereview.chromium.org/302543006

git-svn-id: svn://svn.chromium.org/blink/trunk@174911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Computed style of resource references drops hash from fragment, include it when returning the computed property value for start-marker, mid-marker, end-marker, filter, mask and clip-path.
Also add a test.

BUG=232904

Review URL: https://codereview.chromium.org/302553002

git-svn-id: svn://svn.chromium.org/blink/trunk@174910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test consistently fails on the bots, but looks fine.

TBR=ccameron@chromium.org
BUG=338794

Review URL: https://codereview.chromium.org/306593002

git-svn-id: svn://svn.chromium.org/blink/trunk@174909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current SVGGraphicsElement::animatedLocalTransform() tries to work
around pre-scaled CSS length values but it doesn't handle percentage
transform-origin properties correctly: the bounding box used in the CSS
transform calculation is not scaled the same way as the other lengths.

The CL addresses this case and also refactors the workaround: instead of
post-tweaking the translation components directly, compute the CSS
transform under an effective 1.0 zoom factor (as expected under SVG).

BUG=375664
R=ed@opera.com,fs@opera.com

Review URL: https://codereview.chromium.org/305603002

git-svn-id: svn://svn.chromium.org/blink/trunk@174907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a followup to https://codereview.chromium.org/287043002/ where
content_webkit_unit_test_support got collapsed into
test_support_content_target.  This is the only include of that target.

BUG=none

Review URL: https://codereview.chromium.org/286213004

git-svn-id: svn://svn.chromium.org/blink/trunk@174906 bbb929c8-8fbe-4397-9dbb-9b2b20218538