- 20 Jul, 2020 40 commits
-
-
Tommy Nyquist authored
The test testStorageDoesNotLeakFromActivityToActivity is flaky. TBR=roagarwal@chromium.org Bug: 1107600 Change-Id: Idd775416640e0b9b9d7e2866307261397abc4d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308932Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#790172}
-
Peter Kasting authored
* IWYU * Eliminate using declarations via explicit qualifiers * Replace deprecated DISALLOW_COPY_AND_ASSIGN macro * Replace explicit GetClassName() override with View metadata macros * Prefer file-scope constants to class-scope ones * Declare constants as close to their use as possible, i.e. inline them into methods when only used once * Comment tweaks, including removing some unhelpful or inaccurate ones, adding TODOs, and being more consistent * Add utility functions CenterY(), ExecuteCommand(), UseNewWarnings() for common functionality. This also results in adding a member. * Inline ConfirmDeepScanning() and BypassDeepScanning() into their callers using ExecuteCommand(). * Eliminate |focus_ring_|, which is never set. * Re-order class members in hopes of grouping related items more closely * Set up more of |accessible_alert_timer_|'s functionality in the constructor and simplify the usage site as a result * Extract a chunk of ButtonPressed() handling relating to showing an "open download" dialog into its own function, ShowOpenDialog(), in preparation for reorganizing the caller in a subsequent CL Bug: none Change-Id: I917ac3ab195d158fa82f5a51274b8ce5563bb15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304720 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#790171}
-
Kyle Milka authored
Wrap the various scan_tab layouts in a scrollview so all the options are usable on small devices. Bug: 1107575 Change-Id: I8578e0a2e018a78ed17c0eaa14e98ad6e681d0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308209 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790170}
-
Sophey Dong authored
Screencast: http://dr/file/d/1Cl221h7j9noHqAPXUU0G4H5hKrKacAwS/view Bug: 1105139 Change-Id: Ibe242764a2d5728e9c1ca006aa3ee0278ad9ae52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303977 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 165e7384. With Chromium commits locally applied on WPT: 96b35d0f "Fix executor.html path in property.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ib754288651de7bb12597c27e81b4a0c3136063a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308230Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790168}
-
Kenneth Russell authored
These histograms have expired and the data gathering code is causing flaky GPU process crashes. Bug: 1090360 Tbr: vitalybuka@chromium.org Change-Id: I57bc7534406ab66c413b355fcfed4d1a725c2271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302620 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#790167}
-
Daniil Lunev authored
trace: [3348438:3348438:0716/193315.071834:645381268976:FATAL:identifiability_study_settings.cc(60)] Check failed: !initialized_.IsSet(). ... BUG=none TEST=unittest Change-Id: Idd43aed91cbc864b960f91215fce7afcfdd791a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301750 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
Entity suggestions inaccurately used slightly smaller font to present the 1st line of text. Bug: 1107537 Change-Id: I42c111601d2205e6ff6ae188aabf71842bcdc841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308455 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790165}
-
Jeff Yoon authored
Bug: 1105117 Change-Id: I0830887588653c435fbbb5748d00a9f03c5dd085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295820 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#790164}
-
Lexi Stavrakos authored
Bug: 1088004 Change-Id: Ic606b07825aa79be971d8d97a0409573d1aecb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242846 Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790163}
-
Michael Thiessen authored
Native java unittests are going away in favor of batched instrumentation tests. This CL migrates the Omnibox tests. Note that I had to make changes to the tests that used the clipboard service, as these tests run without a focused Activity, and so calls to the real clipboard service are rejected. Bug: 1103344, 1102026 Change-Id: Iec82e26ce28e503944dff82027f3a3e083ab7742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288379 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790162}
-
Jenny Zhang authored
Bug: 1103012 Change-Id: I97894b8246edaddb610c1887954e0e7822258f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307616 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#790161}
-
Etienne Pierre-Doray authored
This reverts commit fb56fbc5. Reason for revert: Trace event creates deadlock Original change's description: > Reland "[Jobs API]: Use worker_lock in JobTaskSource." > > This is a reland of 6eb566d2 > > Reason for revert: Cause failure in CheckedLockImpl::Acquire > crbug.com/1099649 > Mark worker_released_condition_ declare_only_used_while_idle > to prevent priority queue from being acquired in ScopedBlockingCall. > > Original change's description: > > [Jobs API]: Use worker_lock in JobTaskSource. > > > > Possible race when Join(): > > - thread A: Join: worker_released_condition_->Wait() > > - thread C: WillRunTask: > > GetMaxConcurrency() returns > 0 > > - thread B: already running, finishes all the work > > GetMaxConcurrency() goes 0 > > - thread B: DidProcessTask: > > worker_released_condition_->Signal(), > > - thread A: Join returns (GetMaxConcurrency() is 0) > > - thread C: TryIncrementWorkerCountFromWorkerRelease > > worker count goes 1 > > - thread C: runs worker_task after Join > > > > To fix race when Joining, all writes to |state_| are protected by > > |worker_lock|. Memory ordering is no longer necessary. > > > > Alternative: cancel before Join returns with a compare and swap and > > loop again if new workers. > > > > Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781453} > > Change-Id: I1c7c0054a52b9b12dd6d0edd049ab2a7912df361 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272942 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789526} TBR=gab@chromium.org,etiennep@chromium.org Bug: 1099649 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic765e35c5404387e9ba8771b31650414218fbf94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308689Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#790160}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/6af6e625573f..2105106cf8e6 2020-07-20 rharrison@google.com Roll 5 dependencies and update expectations (#1111) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I6120365db41ab8e2631fd8487001629f2c83de0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790159}
-
Albert J. Wong authored
This leaves just the ref_count_ variable left as thread hostile. CL is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 See this design doc for more details on the larger motivation for this change: https://docs.google.com/document/d/1hp7h6zfD5S6mnMI4cHe1PpacRnb2rNpRRkn1gBBJHuQ/edit#heading=h.erv1bv18t616 Bug: 1083392 Change-Id: I9ab3b1d86c8e27d887b6dbb34ac4ae4fd720af0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301589 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790158}
-
Etienne Pierre-doray authored
This is a reland of ec645d52 Error: stack_sampling_configuration.cc:77:41: error: code will never be executed [-Werror,-Wunreachable-code] Fix: Tweak macro logic (see patchset 3) Original change's description: > [Clank SSM]: Enable stack sampling in android browsertests. > > android_browsertests must depend on libunwindstack directly instead of > through DFM, since loading of a partitioned library is not supported in > an APK. > (internal discussion) > https://groups.google.com/a/google.com/g/clank-components/c/ktt285Gtax4/m/yRy8qm8LAQAJ > > This CL also re-enables tracing use of StackSampingProfiler, which > was accidentally disabled in https://crrev.com/784147? > > Bug: 1004855 > Change-Id: I5967bf3815008843ba8a77e926977e39a4ccfbd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293071 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789530} Bug: 1004855 Change-Id: Ia43ec87456572f75c513e950c9b120c81c7a4d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305010Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#790157}
-
Kenichi Ishibashi authored
This CL replaces old writers with new mojo-based writers in tests. Bug: 1055677 Change-Id: I68959e056092d2b6560067002b8ccfe466d8010a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306113Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790156}
-
Joshua Peraza authored
498c36b82a03 mac arm64: Provide something more useful from SystemSnapshot::CPURevison e3c94b87f0ef [fuchsia] Move //zircon/system/ulib/fdio to //sdk/lib/fdio fd001f792eb7 build: Make crashpad_dependencies="external" work in the GN build ef8a063055c6 Fuchsia: Propagate failure to initialize exception snapshot 06a688ddc1bc linux: setup a signal stack 9f66d569fb87 linux: put test attachment in temp directory 070b18d326b6 linux: fix alt-stack tests with asan Change-Id: Idcc5fd3ec95619844c36a505f4e2bafa6b13dcfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308850 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790155}
-
Xianzhu Wang authored
Bug: 1104064 Change-Id: I518bc448da22853a2e58eb59b9373965d6dfb343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304989 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#790154}
-
Garrett Beaty authored
(cherry picked from commit b2d7d5eb3cab76d97b381040f217f82456d3b587) Bug: 1056428 Change-Id: I53a06c4fa23faec756e303372922eba774bd1c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298295Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/4195@{#4} Cr-Original-Branched-From: 1d94de40-refs/heads/master@{#785504} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303987 Cr-Commit-Position: refs/heads/master@{#790153}
-
Ayu Ishii authored
Migrate to more inclusive terminology. Bug: 1097275 Tbr: siggi@chromium.org Change-Id: I7546b5aa80b5d8e8c5dec24ec01b7e8053955ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258354 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#790152}
-
My Nguyen authored
This metric is used for Chrome OS Language Settings Update Bug: 1106033 Change-Id: Ifee2f391b02777108c8a6fedcbc38bb5c7c763f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302973 Auto-Submit: My Nguyen <myy@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#790151}
-
Eric Orth authored
When configuring NetworkService to do DNS in SECURE mode, override the configuration to allow up to two retries. The retries themselves aren't super important, but as the DNS stack lets the original request continue in parallel with retries, this has the overall effect of significantly increasing the effective timeout. Bug: 1105138 Change-Id: Id8aec72a555c3a0e1bafdf16333d4efdc59b39d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308037Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#790150}
-
chinsenj authored
When a user has a windowed app that can be fullscreened and they toggle overview, if they also toggle fullscreen fast enough it will cause visual glitches with overview mode(no blur, no opaque background, etc.) This CL addresses this by adding a check to HandleToggleFullscreen() to see whether the overview is in its start animation. If it is, the toggle fullscreen call is ignored. Otherwise, it proceeds normally. Test: AcceleratorControllerTest.DontToggleFullscreenWhenOverviewStarts Bug: 1094739 Change-Id: Ifff8afa39f238e2725220a0bbb4a92836ea1393d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303380Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#790149}
-
Lan Wei authored
Since we will not transfer user activation through post message to autoplay videos in a cross-origin subframe without any user activation. We will delete the ExperimentalAutoplayDynamicDelegation flag. Bug: 1067307 Change-Id: I183318d207c999fe7c97b7a8b1c9052866aaeec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291212Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#790148}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5efa529cc107..d71ded6e61c7 2020-07-20 ddorwin@google.com Update tests/presubmit.sh with modern syntax for Fuchsia bugs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2aa9a990b49f72b46fdd6f33137ce1d4f116153d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308364Reviewed-by:
-
Anders Hartvoll Ruud authored
This was only needed for the pre-CSSCacade path, and can be now be removed. Change-Id: Ib4e93b1ac142abcddeb15f78be616efc75801e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299340 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790146}
-
Ben Pastene authored
Currently, CrOS HW tests will wait 10min for a device on an up-to-date OS, and fallback to a device running any OS after that. With crbug.com/1057152, we are now flashing the device to the right OS as part of the task. So we no longer need to wait so long for the right device when we can flash it ourselves. Flashing takes about 5min, so a 5min deadline maintains a 10min delay at the worst. This also moves the expiration value from an arg to a module constant since the arg was never passed, and likely won't ever be. Bug: 1057152 Change-Id: Ia66e714b02f9f4b6b0d011fd96a80f42d0294d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287954Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#790145}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55e855496d00..49108a1283c3 2020-07-20 geofflang@chromium.org Support BGRA_1010102 IOSurfaces in CGL and Vulkan. 2020-07-20 cnorthrop@google.com Capture/Replay: Fix vertex array objects for MEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1100599 Tbr: timvp@google.com Test: Test: NBA2K20 MEC Change-Id: I019fba5b8aa45570bf9f9e578976bc33d2a618cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308354Reviewed-by:
-
Mei Liang authored
crrev.com/c/2247404 removes two methods from StaticLayout that are explicitly plumbed through the layout system by acquiring through Observers: * onTabCreated * onTabModelSwitched The removal causes the TabStrip in Tablet to misbehave, since the TabStrip SceneOverlay is expecting those removed plumbed signals. This CL fixes the issue by replacing those signals with observers in the StripLayoutHelperManager. After the fix, those two plumbed signals can be removed completely from the SceneOverlay interface. So, this CL also removes those two signals. Change-Id: Ic53428e8cec934a034a065cb82e643cbfc0859f6 Bug: 1106752, 1100332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305374Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790143}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. This CL we should replace eventSender.mouseScrollBy with wheelTick which uses gpuBenchmarking.smoothScrollByXY in events/mouse-event-buttons-attribute.html. Bug: 1047176 Change-Id: Ife50b732a6ec0733e84b034c07565a4a5138b51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173614 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790142}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de55e0b54668..62a87ddd43fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tinazwang@google.com,karandeepb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1078815,chromium:1105530 Tbr: tinazwang@google.com,karandeepb@google.com Change-Id: I7cec952c87663a00d5e311ce00b60c26275cdff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308671Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790141}
-
Vikas Soni authored
Remove estimated_size from constructor of SharedImageBackingScopedHardwareBufferFenceSync. It is not required since estimated size is calculated from format and size. Bug: 1091945 Change-Id: I1f763eb9e19cc5a427b647edcf884e3dda37307e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307355 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790140}
-
Mila Green authored
Bug: 1105589 Change-Id: I6d7e8b0b7858a4f1a538684758644f134318c0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298045 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790139}
-
Karandeep Bhatia authored
Skip the following tests on Mac as they seem to be failing consistently: * http/tests/devtools/tracing/timeline-layout/timeline-layout-with-invalidations.js * http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidations.js * http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.js BUG=1107572 TBR=tkent@chromium.org Change-Id: I75082401e41f2b11df3013b0b84349026d3094df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308519Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790138}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3c13bf1fa865..026b1e2be09a 2020-07-20 aninditaghosh@google.com Merge "Load in trace_processor shell given file path to trace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia751c6308d0c6119f6e8da6fecaf6b3824fc5ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308273Reviewed-by:
-
Alex Cooper authored
This reverts commit 715c3a3a. Reason for revert: Fix Test Class setup Original change's description: > Revert "Update vr_pixeltests exceptions" > > This reverts commit 7da56cfe. > > Reason for revert: Test is still failing: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20(dbg)(1)/83673 > > Original change's description: > > Update vr_pixeltests exceptions > > > > https://crrev.com/c/2304097 updated the tests that originally required > > this exception to be added so that they now automatically skip/pass on > > Windows 7, so we don't need to keep these exceptions anymore. > > > > Bug: 1106809 > > Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 > > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789684} > > TBR=thakis@chromium.org,alcooper@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1106809 > Change-Id: Id8a98cce9da8ec8933e75686718f92e7b7ec2d15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307011 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789861} TBR=thakis@chromium.org,aboxhall@chromium.org,alcooper@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1106809 Change-Id: Ia8e1f6261091de3bde7de3f55d4ea77771c1a59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307636 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/5f43fedcddba..747e80a9b369 $ git log 5f43fedcd..747e80a9b --date=short --no-merges --format='%ad %ae %s' 2020-07-20 dneto [spirv-reader] Drop NonWritable NonReadable for now 2020-07-20 rharrison Fix issues with BUILD.gn 2020-07-20 dsinclair [msl-writer] Cleanups and refactors. 2020-07-20 dsinclair [msl-writer] Handle uniform buffers. 2020-07-20 dneto [spirv-reader] Support DescriptorSet and Binding 2020-07-20 dneto [spirv-reader] Handle old-style storage buffers 2020-07-17 dneto Rolling 6 dependencies 2020-07-16 dneto [spirv-reader] Support Location on module vars 2020-07-16 dneto [spirv-reader] Ignore empty string user names Created with: roll-dep src/third_party/tint/src Change-Id: I02397ad4a90cc8e31a6706d2e8258a3076728691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308453 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#790135}
-
Sammie Quon authored
NotificationMD already had a clip installed previously, so the mask code was never called, so its safe to just delete. ScrollArrowView has only one override ScrollableScrollArrowView which turns of ink drop ripples and highlights, so its safe to remove the ink drop codes. Test: manual Bug: 1056490 Change-Id: I3e4b068f3e819901b1da7d4ab42bc74e62a0295f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308450Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790134}
-
Kristi Park authored
Fix symbol not found error for org.chromium.base.annotations.UsedByReflection Change-Id: I7505cfe99a276ba6083f82521bb9f8c86cc7509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309132 Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790133}
-
