- 28 Jun, 2018 40 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fcb04d853ec4..8849c9571022 git log fcb04d853ec4..8849c9571022 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader b41a9d6f0bbc..539468cef869 (1 commits) 2018-06-28 enne@chromium.org Return nullptr from readFlattenable when invalid 2018-06-28 mtklein@chromium.org add --sync to adb push in bin/droid 2018-06-28 mtklein@google.com unify term/crash handlers, include SIGINT 2018-06-28 timliang@google.com added TextureRenderTarget to Metal gpu backend 2018-06-28 jvanverth@google.com Reland "Improve precision and speed of oval rendering." 2018-06-28 mtklein@chromium.org cut SkMaskBlurFilter code size by about half Created with: gclient setdep -r src/third_party/skia@8849c9571022 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 854947 TBR=jcgregorio@chromium.org Change-Id: I0a49c9a63772d399280b1766fea5045ebba98d31 Reviewed-on: https://chromium-review.googlesource.com/1118805Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571233}
-
David Reveman authored
Transient child should not be activatable unless it has an application id. This allows aura shell clients to create popup style windows without using the xdg popup API that requires the ability to dismiss a surface. Bug: 857465 Test: exo_unittest --gtest_filter=ShellSurface.SetParent Change-Id: I628e51af113ab7e3cd73925b9af7e339ef1442cd Reviewed-on: https://chromium-review.googlesource.com/1118855 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#571232}
-
Sky Malice authored
Specifics: +559,559 bytes normalized apk size +3 zip entries file count +16,644 bytes main lib size +376,028 bytes main dex size InstallSize: +183,531 bytes APK size +1,702,684.12 bytes Estimated installed size InstallBreakdown (+1,702,248.12 bytes): +1,571 bytes Non-compiled Android resources size +16,644 bytes Native code size +170 bytes Package metadata size +1,678,855.12 bytes Java code size +5,008 bytes Compiled Android resources size Dex: +1,856 entries fields +2,589 entries methods +638 entries types +1,291 entries strings Change-Id: I8985160524863216d52560bf66991669b1fcd2f5 Reviewed-on: https://chromium-review.googlesource.com/1118712Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571231}
-
Min Qin authored
DownloadInfobarController depends on profile, which may not be available on startup. Lazily create this when needed. BUG=842245 Change-Id: Ieecc314dc6e3cf7d12b8209fa38f4c34385f5204 Reviewed-on: https://chromium-review.googlesource.com/1115347 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571230}
-
Yi Gu authored
This reverts commit cfb0eff9. Reason for revert: failing https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac/43110 due to adding a static const string16 in the anoymous namespace Original change's description: > [omnibox] Vertically center single line entity suggestions > > Omnibox entity suggestions with two lines of text will layout > as before, but now if the second line description is absent, > the primary content text line will be vertically centered. > > Bug: 856703 > Change-Id: Ie672ccece28be79d18bf6f7f07f9937af434178d > Reviewed-on: https://chromium-review.googlesource.com/1115760 > Commit-Queue: Orin Jaworski <orinj@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571174} TBR=jdonnelly@chromium.org,orinj@chromium.org Change-Id: I2f7b31736edc2e66240717749961092875002e2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856703 Reviewed-on: https://chromium-review.googlesource.com/1118788Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571229}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3511a8352adf..37c0f8c6bbd2 git log 3511a8352adf..37c0f8c6bbd2 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@37c0f8c6bbd2 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0a54420ab21de18939d063cc8d88693d50f149cf Reviewed-on: https://chromium-review.googlesource.com/1118806Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571228}
-
Matt Reynolds authored
Adds --gamepad-polling-interval [INTERVAL], where INTERVAL is the delay in milliseconds between successive polls of gamepad button and axis inputs. Decreasing the interval improves latency, but may cause a loss in performance due to more CPU time spent in the input polling thread. The interval must be between 4 and 16 ms, inclusive. If no interval is specified the max value (16ms) is used. Also adds chrome://flags#gamepad-polling-rate to allow selection of the target polling rate from the flags page. BUG=855188 Change-Id: I9ec58c7320eff952c46bce263da8526459ad8a9b Reviewed-on: https://chromium-review.googlesource.com/1110742 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#571227}
-
Chris Blume authored
Currently, users of Vulkan need to get the global function pointer class. And calls into those functions look like: vulkan_function_pointers->vkCreateDevice(); Our OpenGL code hides that behind macros. This patch adds macros to mimic the OpenGL code in Chrome. Now that looks like: vkCreateDevice(); BUG=856360,848101 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3aff1719b366748b9236a9e4c9e7ec69260be18 Reviewed-on: https://chromium-review.googlesource.com/1116195 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571226}
-
Yi Gu authored
Add virtual/service-worker-servicification/external/wpt/service-workers/service-worker/about-blank-replacement.https.html to TestExpectation TBR=carlosk@chromium.org NOTRY=true Bug: 856330 Change-Id: Id82dc29562058664dc85265c3ddd1ed9559d988d Reviewed-on: https://chromium-review.googlesource.com/1119085Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571225}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac9c7e7edefa..7ddf0ed7f771 git log ac9c7e7edefa..7ddf0ed7f771 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 benjhayden@chromium.org Add 90th percentile to results.html. 2018-06-28 dtu@chromium.org [pinpoint] Fix and test JobState.Explore and Compare. Created with: gclient setdep -r src/third_party/catapult@7ddf0ed7f771 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1917506f3df7ef62e8d1c331c3d7d9d22a5681f2 Reviewed-on: https://chromium-review.googlesource.com/1118758Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571224}
-
liberato@chromium.org authored
Previously, VDAVideoDecoder, MCVD and D3D11VideoDecoder used the validating GLES decoder's TextureRef (possibly indirectly, via GLES2DecoderHelper and CommandBufferHelper) to retain textures. This CL moves them all over to use AbstractTexture, in preparation for supporting the passthrough GLES decoder. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I13985223443b8e0897c1508f052d0f35d77746fe Reviewed-on: https://chromium-review.googlesource.com/1091649 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#571223}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9ca72e1a. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20301 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: Iafc599cf98c6a79cddd0b14d42c74e127d5a1912 Reviewed-on: https://chromium-review.googlesource.com/1118623 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571222}
-
Emil A Eklund authored
Optimize performance of ShapeResult offset and x-position computation by introducing a new data structure mapping from character index to advance from the logical start of the shape result. This allow for constant time lookup from offset to x-position and O(log n) mapping from x-position to offset using binary search. This speeds up blink_perf.layout::line-layout test by a factor of three. Currently only enabled for left to right text, right to left will follow in a later CL once the approach has been proven. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38ebd605e9fbe74fc9d383776defce987cb34d0a Reviewed-on: https://chromium-review.googlesource.com/1092013 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571221}
-
dpapad authored
Users of cr-slider rely on a bubbling immediate-value-changed event to be fired. In Polymer 2 this event does not bubble by default, and needs to be re-fired. As a result of this change CrSettingsSliderTest.All passes with Polymer 2. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifc5bf914fe57c61a7ad7360e9ee0c6a2fb859daf Reviewed-on: https://chromium-review.googlesource.com/1117626 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571220}
-
Ryan Sturm authored
This keyed service owns a blacklist and the blacklist is used in the triggering pipeline to prevent over triggering of the feature. Bug: 797981 Change-Id: Ib6afd870b48032363af9235184d1df24c51a195e Reviewed-on: https://chromium-review.googlesource.com/1114331 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571219}
-
John Abd-El-Malek authored
Flash and other plugins with universal access can make cross-origin requests that bypass CORB. NaCl and other plugins without universal access make all cross-origin requests with CORS, and they should remain subject to CORB. TBR=nasko Bug: 853239 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1dbae19fbced1b46eaa889708bda926da994903b Reviewed-on: https://chromium-review.googlesource.com/1117711 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571218}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01b356851646..f1ba1dcd5882 git log 01b356851646..f1ba1dcd5882 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 dproy@google.com Add tslint presubmit Created with: gclient setdep -r src/third_party/perfetto@f1ba1dcd5882 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8d3f0f69cf57dcba9dbec83a1c0ac490f07b168b Reviewed-on: https://chromium-review.googlesource.com/1118807 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571217}
-
Ryan Hamilton authored
Change-Id: Ie4175e128ae7ad4118b5ace086211abf69dca70a Reviewed-on: https://chromium-review.googlesource.com/1118283Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#571216}
-
Yi Gu authored
Update test expectation for http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio.js TBR=carlosk NOTRY=true Bug: 857477 Change-Id: I80a2157ff1b4bd94789497cd38cb436549a24932 Reviewed-on: https://chromium-review.googlesource.com/1118852Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571215}
-
Scott Chen authored
Bug: 832177 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I552d8ba9107b82aca3a24d24299181b788fc54d8 Reviewed-on: https://chromium-review.googlesource.com/1108918 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571214}
-
Evan Stade authored
Go through CursorFactoryOzone to load the PlatformCursor (which confusingly could be CursorData, but for now is X11CursorOzone). Also set fields on the cross-platform Cursor type so that code which relies on it such as CursorWindowController::UpdateCursorImage will work. That code path can be exercised with --ash-enable-cursor-motion-blur although there is currently no use of custom cursors with ws2. Bug: 837705 Change-Id: I9f725c5a5350e28cf8bded6b53bf48759cb644f8 Reviewed-on: https://chromium-review.googlesource.com/1105562 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#571213}
-
Emily Hanley authored
This change also update the oauth token to generating ne per run to one per benchmark Bug:713357,854162 Change-Id: If06e71c53fe8083f82307584a6e92104e33b2f65 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:obbs_fyi Change-Id: If06e71c53fe8083f82307584a6e92104e33b2f65 Reviewed-on: https://chromium-review.googlesource.com/1114690 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571212}
-
Kurt Horimoto authored
This class is responsible for deciding what toolbar buttons should be displayed for the UITableView-based ReadingList implementation. Bug: 805209, 805211 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic619f746d4ecd52a700f57efc959c587c4976803 Reviewed-on: https://chromium-review.googlesource.com/1106970Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#571211}
-
Donn Denman authored
Adds an Engagement Suppression heuristic that sends several new signals to the ML model for Tap Suppression. These signals quantify user engagment by registering the number of lifetime opens, quick actions taken, translations shown, etc. Note that the additional signals in this CL are documented in http://go/ukm-cs-4 (with privacy approval noted there). BUG=776156 Change-Id: I1e9457a18a5624ceb97e7236761f99173af6dabe Reviewed-on: https://chromium-review.googlesource.com/1079810Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#571210}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/77cc8182aef6..0601d68ac85e git log 77cc8182aef6..0601d68ac85e --date=short --no-merges --format='%ad %ae %s' 2018-06-28 srte@webrtc.org Adds field trial for disabling pacer queue draining. 2018-06-28 gustaf@webrtc.org AEC3: Avoid entering non-linear mode when the filter is slightly diverged 2018-06-28 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before DataChannel in ObjC 2018-06-28 kthelgason@webrtc.org Delete unused file. 2018-06-28 hta@webrtc.org Fix usage logging of TURN and STUN servers 2018-06-28 orphis@webrtc.org Add PeerConnection GetRtpSender/ReceiverCapabilities 2018-06-28 jonasolsson@webrtc.org Remove incorrect test from api/units/ 2018-06-28 hta@webrtc.org Correct data histogram entry for incoming DC Created with: gclient setdep -r src/third_party/webrtc@0601d68ac85e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:857018,chromium:None,chromium:718508,chromium:718508 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3058d8caf5418bab4717636a2cd196da923fc49c Reviewed-on: https://chromium-review.googlesource.com/1118571Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571209}
-
Tessa Nijssen authored
Currently, the SuggestedTextTouchBarController generates text suggestions based only text being selected and doesn't take any surrounding text into account. The goal is to generate text suggestions from all the text present in the textfield and the current cursor position, which results in behavior more similar to Safari's text suggestions. First, WebContents::DidChangeTextSelection() and WebContentsObserver::DidChangeTextSelection() were modified to pass in the whole text in the textfield and the current selection range instead of the selected text. The method requestSuggestionsForText: was modified to requestSuggestionsForText:inRange: so that it may receive the full text in the textfield along with the range of the current selection. The WebContentsTextObserver was edited to also observe when a webpage finishes loading. This way, the controller can check whether the cursor is in a textfield before the text selection changes. This is necessary for websites in which a textfield is autofocused. This currently does not account for text that may be in the autofocused textfield, which will be addressed in a later CL. Bug: 717553 Change-Id: I3d56d7e590ba11c9a6c1c2e55f5bf1bb1b398985 Reviewed-on: https://chromium-review.googlesource.com/1101962 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#571208}
-
David Trainor authored
Add a DownloadManagerCoordinatorFactory to make it easy to build either the old or new download home UI. This CL also ports the DownloadManagerUi class to be an instance of a DownloadManagerCoordinator. As such, the DownloadUiObserver also changed and became the DownloadManagerCoordinator#Observer. BUG=850604 Change-Id: I9491338445b0dff854c6d4c2738f3e377049b4d2 Reviewed-on: https://chromium-review.googlesource.com/1100161 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571207}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/774c90d5ec92..35ab1bd0328a git log 774c90d5ec92..35ab1bd0328a --date=short --no-merges --format='%ad %ae %s' 2018-06-28 art-snake@yandex-team.ru Simplify CPDF_PageOrganizer::UpdateReference method. 2018-06-28 tsepez@chromium.org Use unique_ptr in ccodec_tiffmodule.cpp 2018-06-28 tsepez@chromium.org Use spans and std::unique_ptrs in fx_codec_flate.cpp 2018-06-28 thestig@chromium.org Replace DCHECKs with ASSERTs. Created with: gclient setdep -r src/third_party/pdfium@35ab1bd0328a The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7d7164da97b4322ffe5b0c2d42fc58facd83141f Reviewed-on: https://chromium-review.googlesource.com/1118568Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571206}
-
James Cook authored
Explaining why we look up a Profile for accessibility events even though we don't use it. Bug: none Change-Id: I7edf8958612c87569900faa06c1d7e3d7a63caac Reviewed-on: https://chromium-review.googlesource.com/1119027Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571205}
-
Jeremy Roman authored
Its callers are AudioNodeInput::Enable and AudioHandler::MakeConnection, which already assume that they own the graph. Bug: 856641 Change-Id: I04b8c910a335129e6c522f968fb2b913805cdc18 Reviewed-on: https://chromium-review.googlesource.com/1118757Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571204}
-
Matt Swartwout authored
The dependency on content/public/browser is causing linker errors for some builds. Switching this to a forward declaration solves the problem. Bug: 110846462 Test: Builds correctly for targets the previously had missing symbols Change-Id: Icd83e5f149f463d70bfcc730ba6fe416654d2d38 Reviewed-on: https://chromium-review.googlesource.com/1115774Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#571203}
-
Aga Wronska authored
Bug: 827376 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828 Reviewed-on: https://chromium-review.googlesource.com/1105568 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#571202}
-
Arthur Hemery authored
As per dgozman@ TODO. Bug: 789577 Change-Id: Ia2fd373ea8b1578af35c15d86aa5d4b853dbf765 Reviewed-on: https://chromium-review.googlesource.com/1117688Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#571201}
-
Qiyu Hu authored
This patch implements StartNotify such that it can take a cccd_value and notify the application on what type of notification is requested by a remote device. In addition, we read optional device_path also in Start/StopNotifiy(). A relevant patch is crrev.com/c/1114351 Bug: b:78593133 CQ-DEPEND: CL:1114351 Test: Pass Android CtsVerifier test on server sending indication/notification Change-Id: I51812ab29292fe5af9958b9b0c2314f4b801b9c2 Reviewed-on: https://chromium-review.googlesource.com/1114310 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571200}
-
Rune Lillesveen authored
Apparently, the ComputedStyle on a child may change during LayoutBlock::ComputeBlockPreferredLogicalWidths. We used to keep a reference to the ComputedStyle on the stack before [1]. Re-introducing scoped_refptr here. The reduced test exposed a DCHECK problem tracked by 389648. Instead of adding an almost identical new test, with another TestExpections line, we add writing-mode to the existing test which would expose the ASAN issue as well. [1] https://crrev.com/0aca50f1552c882bc72ed5c419085fa975847a9c Bug: 853538, 389648 Change-Id: I5cb09c8cd9a7ae6d0621758f4690fce2abbb8096 Reviewed-on: https://chromium-review.googlesource.com/1117697 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#571199}
-
Ryan Hamilton authored
Merge internal change: 202416832 Change-Id: Id6d5e9d5cd8bf2c43bca133ef2fa830b1faea3de Reviewed-on: https://chromium-review.googlesource.com/1117930Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#571198}
-
Jeremy Roman authored
webaudio: Use AudioHandler::BreakConnectionWithLock in BaseAudioContext::PerformCleanupOnMainThread. PerformCleanupOnMainThread acquires the lock on the associated context, so acquiring it recursively is unnecessary. Bug: 856641 Change-Id: I603a0f1ca070076dcfb841bdeddd2876e28ec0d8 Reviewed-on: https://chromium-review.googlesource.com/1118606Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571197}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kTitleIconSize in views/ime/ime_window_frame_view.cc, views/relaunch_notification/relaunch_recommended_bubble_view.cc and views/relaunch_notification/relaunch_required_dialog_view.cc. This commit solves the issue by moving the variables from the namespace to the class. It also moves other variables in the same namespace, to keep the files locally consistent. Bug: 773275 Change-Id: I0ec9b735f6f6c579bebe61ab6a1a8cfcac876f56 Reviewed-on: https://chromium-review.googlesource.com/1107619 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571196}
-
Becca Hughes authored
Inset media contols by the safe area to avoid overlapping the display cutout. BUG=857252 Change-Id: I38c25a07f880cd93caf6c89662e541f52096e638 Reviewed-on: https://chromium-review.googlesource.com/1117835Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571195}
-
Tiger Oakes authored
Created new flag, --diff-with, which will diff two .size files and display their relative sizes instead of the absolute sizes in a single .size file. Preview at: https://notwoods.github.io/chrome-supersize-reports/monochrome-diff-2018-06-27/ Reports can be compiled by running: ``` tools/binary_size/supersize html_report after.size --diff-with before.size --tree-view-ui --report-dir diff-report xdg-open diff-report/index.html ``` Bug: 847599 Change-Id: I860ce6cd70c7261d3053d6a259f0208d74f0b35e Reviewed-on: https://chromium-review.googlesource.com/1117758 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571194}
-