- 31 Jul, 2019 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I286a9626dba28aae156556c48d02838309a58d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727655Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682574}
-
Antonio Gomes authored
This is the first of 'n' CLs that dismantle both MediaStreamCenter classes in content and blink. It is part of phase 4.7 in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ As a first step, this CL starts by embedding the blink::MediaStreamCenter methods used by other blink/renderer/platform/mediastream classes into their respective callsides. This steps makes further work easier, since the remaining users of the blink::MediaStreamCenter APIs are in blink/renderer/modules/. The methods being moved here are: - MediaStreamCenter::SetContentHint - MediaStreamCenter::GetSourceSettings BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I75a8487c4fca0838f49b92311f5d80ec4e929435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726569 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#682573}
-
Glenn Hartmann authored
TBR=loonybear@chromium.org Change-Id: Iaa0e65037f861eb7c78bccfff44204cde5de77ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727523Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#682572}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5ae853a163e7..e08ca23ec9fe git log 5ae853a163e7..e08ca23ec9fe --date=short --no-merges --format='%ad %ae %s' 2019-07-30 bryanf@microsoft.com Include overlapping dialogs when capturing a window via screen cropping Created with: gclient setdep -r src/third_party/webrtc@e08ca23ec9fe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I391e2320570c9e18b049870a4f3889b9cc414e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682571}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ffff6c5fcc92..7264bc930f9b git log ffff6c5fcc92..7264bc930f9b --date=short --no-merges --format='%ad %ae %s' 2019-07-30 tsepez@chromium.org Remove last circular include between fpdfapi/page and fpdfapi/render. Created with: gclient setdep -r src/third_party/pdfium@7264bc930f9b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I8593e5c9c6aa203808270fd0043e1f715204f124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727589Reviewed-by:
-
Alexey Baskakov authored
Now we can distinguish kUserInstallDeclined case. Bug: 789381 Change-Id: I3ae8a8c04a9615940e8aa7aaa3e024c0f90e2be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725531 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#682569}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b7089ee5024..b9c76515a890 Created with: gclient setdep -r src-internal@b9c76515a890 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4055a01f0da1be4b691b9973f9937bd4d39dcc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727715Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682568}
-
Rob Schonberger authored
Do so by creating a Factory for PalmDetectionFilter, controlled by flags and feature parameters, called PalmDetectionFilterFactory. Thoroughly unit test this factory. Add an instance of SharedPalmDetectionFilterState to InputDeviceFactoryEvdev, and pipe it through to instances of TouchEventConverterEvdev so that all PalmDetectionFilter get the same shared instance, as intended. Bug: 982118 Change-Id: I5878bc126a9e4bf809b9d5869520bef814aace8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716000 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682567}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79a5354d..b38939a8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I555a583e41c9ffe8b866e75e16473be1b8a7cae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682566}
-
Rob Schonberger authored
Add tests for these metrics. Bug: 982118 Change-Id: I0626727ea968e3fbd970bfa32df0a35d2ae5d285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720117 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Ethan Jimenez authored
1. Changing the behavior of `ITextRangeProvider` methods `Move` and `ExpandToEnclosingUnit` with `TextUnit_Word`. Previously we relied on both, word start and end offsets, computed from Blink, but such approach didn't matched every AT's expectations. Updated logic makes use of start offsets only, this forces movement by word to include whitespace and punctuation characters before the next word start; the only special case being the last word, whose end offset will be located after the last character on the document. 2. Removing `AXPosition`'s methods `AsLeafTextPositionBeforeCharacter` and `AsLeafTextPositionAfterCharacter` in favor of refactoring `AsPositionBeforeCharacter` and `AsPositionAfterCharacter`. This is a follow-up optimization since the former methods called their `AsLeafTextPosition` equivalents, but reverted the result if the position was not adjusted to another anchor. 3. Adding a new browser test to cover some AT's expectations. Rebaselining `AXPlatformNodeTextRangeProviderWin` unit and browser tests to account for the new word movement behavior. Bug: 928948 Change-Id: Iab689fde2a2ea973e86f7cdb10c1c22cf1af1704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718064 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682564}
-
Ren-Pei Zeng authored
This CL continues the work in crrev.com/c/1558746 to support DMA-buf output buffer in V4L2 MJDA. The decoded buffer is converted into mapped output frame in I420, NV12, or YV12 format. At this time we only support V4L2 JPEG decoder on MT8173 platform, which doesn't support allocating NV12 format in minigbm, so the MJDA unittest will selectively use YV12 format for DMA-buf tests instead. Bug: b:120057531 Test: Pass JDA unittest in elm. Change-Id: Ibe03a50940150169115d3ac3b5f2d7b38fbfcd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645712 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682563}
-
John Abd-El-Malek authored
This is in preparation of removing ResourceRequestInfo which isn't needed anymore. Bug: 934009 Change-Id: I1f799afa6ddf2dc926898d6e18c92849f722ad12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726766Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#682562}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/896a6b4b220f..334a2b1fa8b9 git log 896a6b4b220f..334a2b1fa8b9 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 treehugger-gerrit@google.com Merge "traced: add metatrace support via in-process producer (folding in LazyProducer)" Created with: gclient setdep -r src/third_party/perfetto@334a2b1fa8b9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I2537aa529677bccf638eee88c1cbe4e898fa7626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727579Reviewed-by:
-
Pavel Yatsuk authored
The feature is tracked in crbug.com/955951. It is rolled out to dev/canary/beta. R=isherman@chromium.org Change-Id: I4f5c3c02b0dc088977e77561fbd29216b904939c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726819Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#682560}
-
Patrick Monette authored
This avoids an unnecessary char conversion now that the old blacklist code is no more. Bug: 986926 Change-Id: I80564b4680ac7b45941a913b335ba0d49adea6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720123 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#682559}
-
Carlos Caballero authored
This translation unit is using THREAD_CHECKER but not including the header. Change-Id: Ifb594fe48ef0e9b08f80b3fc9898325f5c0d4f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725644 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#682558}
-
Olivier Yiptong authored
Adding review changes from https://chromium-review.googlesource.com/c/chromium/src/+/1692325 I prematurely hit the submit button. Bug: 968550 Change-Id: I52b85c70d5b47845a60398d1c453a118e1be5a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726660Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#682557}
-
Keith Lee authored
Change-Id: I3ccee265fb87f8ba62aa4b11932e752c2c4bdb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727518Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#682556}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 669ae3a7. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/IndexedDB NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I1f415d856db43e5e9f18ad36603d60853f5c7e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726991Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682555}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4ed5b087f57f..5ae853a163e7 git log 4ed5b087f57f..5ae853a163e7 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 394c077f..bb33f8cf (682353:682476) Created with: gclient setdep -r src/third_party/webrtc@5ae853a163e7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I24d88e2836e2a76dd0fd1acbfd2e3488398156f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726644Reviewed-by:
-
Tom Anderson authored
Ubuntu's top bar expects properties returned in the order they were requested. The returned properties have IDs associated with them, so ordering really shouldn't be necessary. Alas, keep them ordered to appease Unity. BUG=981201 R=thestig Change-Id: I2907c264cc4346a47aa6304f7302c6d58555c9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716958 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#682553}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b63730a701a4..6b7089ee5024 Created with: gclient setdep -r src-internal@6b7089ee5024 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:987378,chromium:None,chromium:988998 Change-Id: Ibe73943e6270db708b24c65e00ba9c56f5757f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727576Reviewed-by:
-
Xing Liu authored
This CL wraps all user action data into a struct, which loweres the difficulty for maintenance and simplifies the code. Also plumb the button id through the user action pipeline. Bug: 979770 Change-Id: I91b9e8c9d35ff413051d9cc937ef6c2283112464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717312Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682551}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/35ad5221fb55..d08611b7a8dc git log 35ad5221fb55..d08611b7a8dc --date=short --no-merges --format='%ad %ae %s' 2019-07-30 jiawei.shao@intel.com Move all the implementations of Toggle to Toggles.cpp Created with: gclient setdep -r src/third_party/dawn@d08611b7a8dc The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9776b0342f2ccf5c37acf82f78e6240aa3b7a2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726647Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/245c002bc098..6980c4e0aef8 git log 245c002bc098..6980c4e0aef8 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 egdaniel@google.com Remove isConfigCopyable from GrCaps. 2019-07-30 fmalita@chromium.org [skottie] Safe div-by-zero in LevelsEffectAdapter::apply Created with: gclient setdep -r src/third_party/skia@6980c4e0aef8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I9ca1df013b4fd2e21f6be5c5bb71fb6f00953264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726645Reviewed-by:
-
Jeremy Chinsen authored
Currently the logic in PDFiumEngine::FillPageSides() for drawing the empty space below a page only handles single-up view. In two-up view, a page may be shorter than the one adjacent to it. In this case, the bottom gap must have height as tall as the difference in the adjacent pages' height. This CL changes FillPageSides() such that when |two_up_view_| is true, it calls draw_utils::GetBottomGapBetweenRects() with the current page and |dirty_in_screen|, computing the space of |dirty_in_screen| that is below the page, and finally drawing it as empty space. This allows FillPageSides() to properly draw the bottom empty space for a page in two-up view. Bug: 51472 Change-Id: Idd01fd959419fd8aebc2f70f514eb83ba61c160c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720792Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c39e7c7cc884..324bdfed0692 git log c39e7c7cc884..324bdfed0692 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 capn@google.com Use a finite maxSamplerLodBias limit Created with: gclient setdep -r src/third_party/swiftshader@324bdfed0692 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138670766 Change-Id: Ia4a409c84d7cb4d204d514900226db05aab85dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726643Reviewed-by:
-
Miyoung Shin authored
This CL renames mojo to mojom in //media/capture/video/chromeos. media/capture/video/chromeos/mojo => media/capture/video/chromeos/mojom Bug: 806965 Change-Id: I2b739ea05a99a02e9654659ec2b04a309b8dc26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724901Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#682546}
-
tby authored
This CL moves Roselle out of the search providers and into our ranking infrastructure. The logic for scoring apps is kept the same, but now happens in two different places: its time-based relevance score is still set in the AppSearchProvider but, if it is present in the ranker, the relevance is overridden by the ranker's score. Roselle is also used in the ArcAppShortcutsSearchProvider. Since we've finished the experiments ranking Arc app shortcuts and don't have plans to in the near future, this logic has been removed. Bug: 989350 Change-Id: I5c1e891508b669c5b91e7164e94af9fa7a6fbbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694561 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#682545}
-
Theresa authored
We still need these to collect data for various experiments. Extends the following histograms to M82. - Settings.ShowHomeButtonPreferenceState - Settings.HomePageIsCustomized - Settings.ShowHomeButtonPreferenceStateChanged - Settings.GivenShowHomeButton_HomePageIsNewTabPage - Settings.ShowHomeButton BUG=986514,986515 Change-Id: Ie1e4156010a783e310997c2dded55816b8cde83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727514Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682544}
-
Miguel Casas authored
This CL adds a histogram for Media.MojoVideoDecoder.Decode; this is already tracked as an async trace, for the purpose of CrOs Tast, a histogram is needed.(This is basically the same case as crrev.com/c/1680764) Bug: 953253 Change-Id: I4cab76dd739f7b8196b29ec5870e141f04b1076c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725313Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#682543}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. OAuth2TokenService has been folded completely into ProfileOAuth2TokenService on https://crrev.com/c/1712560. So, it's not valid to comment OAuth2TokenService on the current codebase. This CL updates comments for OAuth2TOkenService with IdentityManager, the access token fetcher or OAuth2AccessTokenManager. Bug: 967598 Change-Id: I1aba6c57d8cc65063f12be512cece3404d602fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725222 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2ddb2cc3..79a5354d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9ad500efd1806b331d56b5b2f71493d7975a8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727170Reviewed-by:
-
Tina Wang authored
Previously the omnibox icon will show and hide according to whether the user focuses on the omnibox. Now it won't hide when the user unfocuses the omnibox. There is a updated summary of how send tab to self omnibox icon shows and hides: - If showing: keep showing til the user start to edit the url. - If hidden: show if send tab to self feature is offered, omnibox is focused, and the url has not been edited. Bug: 978520 Change-Id: Id3f2a368a283c43f35dbe83847d593eba2498e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715511 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682540}
-
Xing Liu authored
This CL catches an exception in PackageMetrics.getPackageStatsForAndroidO. The crash happens if (Binder.getCallingUid() != appInfo.uid). Currently we don't know the reason. Something tries to launch Chrome process in a remote process. Bug: 984761 Change-Id: If6186d9218fdde99be95c4ad8ec4da896abbba4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725473Reviewed-by:
-
Alex Cooper authored
This addresses feedback submitted to crrev.com/c/1725319 after it was submitted. Mainly around using exact equality for whole numbers and the math around a length of zero. Bug: 977703 Change-Id: Ia43f204a9f754077cda6bd74b2e901f724c7ee9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727571 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#682538}
-
Dominic Battre authored
This CL improves the readability of votes uploads: Before the CL, you would see "autofill_type: [51]". After the CL, you now see "autofill_type: [51/CREDIT_CARD_NAME_FULL]". If std::vector<std::string> elements are piped into the LogBuffer, these are automatically represented as a comma separated list in the output. R=kolos@chromium.org Bug: 928595 Change-Id: I68c917be57c5dbf32a7932235b8c52dc8916cf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724521 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#682537}
-
Yuly Novikov authored
Start running tests on Win10 x64 Intel experimental bot. TBR=kbr Bug: 988833 Change-Id: Iadea428fd44ec07477c574d06d1cd8dc7d52890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726758Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#682536}
-
Ian Wells authored
When sharing an offline page after opening it from Downloads Home, share the original URL if a content URI can't be generated. Also, on Android Q+, if the page's file path is already a content URI, share that directly. Bug: 985699 Change-Id: I53c2e6effb929a00c4e083206bce01338610dc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713765Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#682535}
-
