GitLab

Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL.

This CL will be reverted once the necessary information has been collected, including re-enabling of any tests.

SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test.  I'll re-enable it when reverting this after the necessary data has been collected.

BUG=588946

Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4
Cr-Commit-Position: refs/heads/master@{#378957}

Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86
Cr-Commit-Position: refs/heads/master@{#379323}

Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5
Cr-Commit-Position: refs/heads/master@{#379489}

Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030
Cr-Commit-Position: refs/heads/master@{#379690}

Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e
Cr-Commit-Position: refs/heads/master@{#380070}

Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d
Cr-Commit-Position: refs/heads/master@{#380474}

Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa
Cr-Commit-Position: refs/heads/master@{#380889}

Review URL: https://codereview.chromium.org/1719363002

Cr-Commit-Position: refs/heads/master@{#381774}

This replaces the unconditional update done in (or right after) construction in
the subclasses.

I need to add a ViewHierarchyChanged() override anyway, so I can set up a widget
observer later, but I'm separating this bit out first to try to tease out what's
causing trybot failures.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1785643002

Cr-Commit-Position: refs/heads/master@{#381773}

This CL moves the common iron-icon coloring and sizing
to the settings shared style-module.  The variations
and one-offs are now in more specific files (such as
the side nav icons).

BUG=589630

Review URL: https://codereview.chromium.org/1813643002

Cr-Commit-Position: refs/heads/master@{#381772}

This breaks hardware decoded video since ownership of video frames
is tied to the hardware decoder.

BUG=595716
TEST=none

Review URL: https://codereview.chromium.org/1813883002

Cr-Commit-Position: refs/heads/master@{#381771}

This one is a bit subtle. The two removed "helper" AppLaunchParams
constructors were using HostDesktopType as an unrelated boolean to
choose one or the other of the two constructors (unrelated to the actual
value of HostDesktopType).

I pulled those two out and had them use the now-single constructor, and
tried to give the two names that made some sense according to their
comments.

R=benwells@chromium.org, sky@chromium.org
BUG=558054, 587387, 586862

Review URL: https://codereview.chromium.org/1807743003

Cr-Commit-Position: refs/heads/master@{#381770}

Instead of writing it ourselves. Note that StaticAtomicSequenceNumber
does not work here since it can only be used in global scope.

R=piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1809753003

Cr-Commit-Position: refs/heads/master@{#381769}

Those reports needed to be queued nicely and each report should be sent
with its correct respective system information not the one of the previous
report.

BUG=593452
Test=manually

Review URL: https://codereview.chromium.org/1794513002

Cr-Commit-Position: refs/heads/master@{#381768}

This adds a flags argument to watch callbacks and exposes a flag
to indicate that the callback was invoked as a result of some
external process event (i.e. an incoming EDK IPC message). The
public C++ Watcher implementation is updated to take advantage
of this, effectively allowing us to dispatch to Mojo bindings
synchronously when they live on the IO thread and are servicing
messages from out-of-process.

BUG=590495

Review URL: https://codereview.chromium.org/1811433002

Cr-Commit-Position: refs/heads/master@{#381767}

The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.

BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)

Review URL: https://codereview.chromium.org/1810583003

Cr-Commit-Position: refs/heads/master@{#381766}

If the provider is not null, it will have a context that is not null.
The provider is a WebGraphicsContext3DProviderImpl, which is given
a ContextProviderWebContext.

The ContextProviderWebContext is a ContextProviderCommandBuffer, the
factory for which returns a null provider if the underlying context
is null.

Further, the provider comes from RenderThreadImpl's
SharedMainThreadContextProvider(), which will return null if
the provider is null, or if the provider fails to initialize its
GL context.

R=junov@chromium.org, kbr@chromium.org
BUG=584497

Review URL: https://codereview.chromium.org/1813603003

Cr-Commit-Position: refs/heads/master@{#381765}

Revert of Re-land: Enable XFA-Forms for the PDFium plugin. (patchset #1 id:1 of https://codereview.chromium.org/1811743002/ )

Reason for revert:
Causing "Target image has run out of space" errors on Chrome OS builders:

http://crbug.com/595763

Original issue's description:
> Re-land: Enable XFA-Forms for the PDFium plugin.
>
> This reverts commit 13fe4645.
> See https://codereview.chromium.org/1761673002/
>
> TBR=thakis@chromium.org
>
> Committed: https://crrev.com/ed07b3773e3aad4a44a79a48c17162ef57ca82ee
> Cr-Commit-Position: refs/heads/master@{#381573}

TBR=thakis@chromium.org,ochang@chromium.org,jschuh@chromium.org,rpop@chromium.org,dsinclair@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1814843003

Cr-Commit-Position: refs/heads/master@{#381764}

Clusterfuzz identified a race between the media thread calling SetVolume
and the audio device thread calling ProvideInput. Add a lock to
synchronize access to |volume_| between threads.

Also adds some thread_checkers to just firm up the contract that the
majority of these methods are called only by the media thread.

BUG=588992

Committed: https://crrev.com/57c6958a99f2c62a4408d2a9d262a22129309106
Cr-Commit-Position: refs/heads/master@{#379349}

Review URL: https://codereview.chromium.org/1748183006

Cr-Commit-Position: refs/heads/master@{#381763}

Review URL: https://codereview.chromium.org/1811023002

Cr-Commit-Position: refs/heads/master@{#381762}

Although the root cause of crash is not clear now,
maybe we'd better add guard firstly to avoid crash.

BUG=594644

Review URL: https://codereview.chromium.org/1813673002

Cr-Commit-Position: refs/heads/master@{#381761}

This fixed the issue that enum generated code didn't work when variant is
specified.
This is a quick fix, we need more fundermental improvement for variant handling
code.

BUG=595791

Review URL: https://codereview.chromium.org/1811853004

Cr-Commit-Position: refs/heads/master@{#381760}

1.) Added |suppressDialogs| property to CRWWebController, which should
    be used instead of |setPageDialogOpenPolicy|.
2.) Suppress all dialogs in native code instead of JavaScript (except
    navigation dialogs which can not be suppressed w/o JS override).
3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES.

BUG=595463
TEST=window.open, window.prompt, window.confirm, window.alert,
           geolocation and http auth dialogs should be blocked for preload
           pages. All these dialogs should work normally for regular pages.

Review URL: https://codereview.chromium.org/1806043004

Cr-Commit-Position: refs/heads/master@{#381759}

BUG=595490
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/1812963003

Cr-Commit-Position: refs/heads/master@{#381758}

This CL updates the section names (shown on the
side nav and above each section).  They use
sentence case.  The & symbol is replaced with
'and'. The Reset and Languages names have been
shortened.

BUG=593989

Review URL: https://codereview.chromium.org/1803363003

Cr-Commit-Position: refs/heads/master@{#381757}

When the whitelist is created we save the path to the locally stored
icon. During the suggestions creation save that information and when
trying to get the large icon for the NTP, first check if we have a
locally stored one first.

This does not yet handle the case when whitelist entry point becomes
part of most visited.

For more information on whitelists - go/chrome-whitelists

Screenshot - https://screenshot.googleplex.com/3eTZ3wghRvH.png

BUG=586097

Review URL: https://codereview.chromium.org/1772363002

Cr-Commit-Position: refs/heads/master@{#381756}

BUG=595772
NOTRY=true

Review URL: https://codereview.chromium.org/1814903002

Cr-Commit-Position: refs/heads/master@{#381755}

BUG=589630

Review URL: https://codereview.chromium.org/1798133002

Cr-Commit-Position: refs/heads/master@{#381754}

[ChromeDriver] Add nested frame xpath expression in order to switch to frame present inside nested frameset.

BUG=chromedriver:107

Review URL: https://codereview.chromium.org/1799183002

Cr-Commit-Position: refs/heads/master@{#381753}

This should allow device switching even when the new device
is specified as an advanced constraint or an old-style "optional".

BUG=589669

Review URL: https://codereview.chromium.org/1806303002

Cr-Commit-Position: refs/heads/master@{#381752}

Dependency resolution in gyp uses relative paths from the target, so usage
of the `for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738

Review URL: https://codereview.chromium.org/1808253002

Cr-Commit-Position: refs/heads/master@{#381751}

Should be fixed with https://codereview.chromium.org/1800283002/

BUG=592594,592627,591224

Review URL: https://codereview.chromium.org/1814593002

Cr-Commit-Position: refs/heads/master@{#381750}

This change has been mirrored from google3 png fuzzer. Should prevent some timeouts.

R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, krasin@chromium.org
BUG=584819
TBR=aizatsky@chromium.org

Review URL: https://codereview.chromium.org/1808123004

Cr-Commit-Position: refs/heads/master@{#381749}

This patch adds a unittest that fails without the patch, and passes
with it.

R=enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1814643002

Cr-Commit-Position: refs/heads/master@{#381748}

system_webview_apk target only exists when
use_webview_internal_framework is false. Removing this additional_apk
to fix the build.

BUG=595605
TBR=sgurun@chromium.org

Review URL: https://codereview.chromium.org/1811033002

Cr-Commit-Position: refs/heads/master@{#381747}

The //crypto library uses some constants that comes from the Security
framework (kSecClassGenericPassword, ...). Add this framework to the
list of libraries to link on iOS and OS X.

BUG=459705

Review URL: https://codereview.chromium.org/1797243002

Cr-Commit-Position: refs/heads/master@{#381746}

BUG=None
R=ttuttle@chromium.org

Review URL: https://codereview.chromium.org/1811983003

Cr-Commit-Position: refs/heads/master@{#381745}

It2me host can use spake2_hmac authentication method and it works
properly with the current client, so there is no reason to keep
spake2_plain for It2Me.

Review URL: https://codereview.chromium.org/1799293002

Cr-Commit-Position: refs/heads/master@{#381744}

BUG=579697

Review URL: https://codereview.chromium.org/1808993002

Cr-Commit-Position: refs/heads/master@{#381743}

According to the style guide a nested codeblock within a list, which is
the case we are changing here, should be indented, otherwise it will
break the numbering of the list, like it is now. Without this
indentation the numbering looks like: 1., 2., 1.. But that is just
wrong, and should be 1., 2., 3.. The indentation should restore the
right numbering here.

https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#nest-codeblocks-within-lists

BUG=None
R=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/1811613003

Cr-Commit-Position: refs/heads/master@{#381742}

Rationale: The benchmark is consistently failing on the "Android One
Perf (2)" bot (see the associated bug).

BUG=593973
TBR=skyostil
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1804413004

Cr-Commit-Position: refs/heads/master@{#381741}

https://codereview.chromium.org/1781433002 enabled auto-resize for
constrained web dialogs on Mac. It updated a number of callsites for
`new ConstrainedWindowMac`, but didn't update the callsite in
`password_prompt_view_bridge.mm`.

Tests continued to pass, as the chooser _was_ being popped up, it was
simply constrained to a 0x0 frame. According to
https://codereview.chromium.org/1781433002/#msg15, it's not clear that
we can add a test that would verify that this doesn't regress. That
seems unfortunate. :(

BUG=217034,
R=vabr@chromium.org, apacible@chromium.org, thakis@chromium.org
TBR=vasilii@chromium.org

Review URL: https://codereview.chromium.org/1809043002

Cr-Commit-Position: refs/heads/master@{#381740}

VideoResourceUpdater software planes use VideoFrame raw pointer and
video timestamp as the unique ID for each VideoFrame. However, if the
VideoFrame is destructed and the pointer is reused by a new VideoFrame,
and if the timestamp is not correctly set, the resource maybe
incorrectly reused. This CL marks the resource as destructed when the
original VideoFrame is destructed, and monitors if the destructed
resource is re-used. The CL only takes effect in Debug mode.

BUG=581480
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1688033005

Cr-Commit-Position: refs/heads/master@{#381739}

While we have an inaccessible browser find, let ChromeVox take care of find using its incremental search.

TEST=ctrl+f brings up i-search.

Review URL: https://codereview.chromium.org/1807843005

Cr-Commit-Position: refs/heads/master@{#381738}

This adds a heuristic such that if a study only references a single
feature from any of its groups, its other groups will be associated
with that feature as well, for reporting only. This allows a config like
25% Enabled, 25% Disabled and 50% Default to still report the users
in the default group to UMA, so that they show up in the data.

More details in the code comments.

BUG=587135

Review URL: https://codereview.chromium.org/1809633003

Cr-Commit-Position: refs/heads/master@{#381737}

Revert of Shape unicode-range: font faces in only one iteration (patchset #7 id:180001 of https://codereview.chromium.org/1806653002/ )

Reason for revert:
Reverting on a suspicion that this is a root cause to the failures of webkit_unit_tests on Webkit Android (Nexus4) bots, e.g.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/44725

Original issue's description:
> Shape unicode-range: font faces in only one iteration
>
> Previously, we incorrectly split CSS composite faces into multiple faces
> for shaping, one for each comma-separated entry of unicode-range:. This
> breaks shaping of ligatures and other features when the characters that
> ought to be shaped combined were in different unicode-range entries. It
> is also inefficient for subsetted web fonts that use unicode-range:
> extensively, for example Google Fonts and Adobe TypeKit.
>
> The fix is to transfer the UnicodeRangeSet information from CSSFontFace
> to HarfBuzzFace and only restrict the glyph lookup function to the whole
> unicode-range information, instead of restricting it to a single entry
> and shaping multiple times with the same face. This should have a slight
> performance benefit as well.
>
> BUG=583450
> TEST=fast/css/font-face-unicode-range-ligatures.html
> R=eae, behdad
>
> Committed: https://crrev.com/9694005f93116f9c9cc73fa99132fa4475a0cdab
> Cr-Commit-Position: refs/heads/master@{#381683}

TBR=behdad@chromium.org,eae@chromium.org,drott@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583450

Review URL: https://codereview.chromium.org/1806363002

Cr-Commit-Position: refs/heads/master@{#381736}

The inclusion of sys/syscall.h was introduced in crrev.com/4916 to
obtain the current thread ID via `syscall(__NR_gettid)`. The code was
later changed in crrev.com/118152 to use
`base::PlatformThread::CurrentId()` instead. The inclusion of
sys/syscall.h is no longer needed and thus removed by this CL.

BUG=None

Review URL: https://codereview.chromium.org/1812733002

Cr-Commit-Position: refs/heads/master@{#381735}