GitLab

This CL merges the two update type fields in RenderLayer compositor. They were
both doing the same thing. In the future, we want to set more of the
RenderLayerCompositor dirty bits from the new m_updateType field, but this is a
start.

Also, remove the mutable keyword from a field where it wasn't needed.

Review URL: https://codereview.chromium.org/213833014

git-svn-id: svn://svn.chromium.org/blink/trunk@170509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Put the squashing layer underneath the ancestor clipping layer if present. (https://codereview.chromium.org/218313002/)

Reason for revert:
The breakage is only with --enable-universal-accelerated-overflow-scroll true. Since that feature is not launched and not tied to squashing, going to re-lad the original CL.

Original issue's description:
> Revert of Put the squashing layer underneath the ancestor clipping layer if present. (https://codereview.chromium.org/215823002/)
> 
> Reason for revert:
> This appears to have unexpected effects on rendering. Bits of gmail are missing for example.
> 
> Original issue's description:
> > Put the squashing layer underneath the ancestor clipping layer if present.
> > 
> > Previously, this was the case for m_graphicsLayer but not m_squashingLayer.
> > Since they now are guaranteed to have the same clipping ancestor, this is both
> > safe and correct.
> > 
> > BUG=336563
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170348
> 
> TBR=hartmanng@chromium.org,chrishtr@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=336563
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170413

TBR=hartmanng@chromium.org,vollick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336563

Review URL: https://codereview.chromium.org/219223008

git-svn-id: svn://svn.chromium.org/blink/trunk@170507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to specification, onaudioprocess() evenhandler should delever playbackTime attribute to JS.
The time when the audio will be played in the same time coordinate system as AudioContext.currentTime.
playbackTime allows for very tight synchronization between processing directly in JavaScript
with the other events in the context's rendering graph.

BUG=332782

Review URL: https://codereview.chromium.org/210973002

git-svn-id: svn://svn.chromium.org/blink/trunk@170505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=358226

Review URL: https://codereview.chromium.org/219523004

git-svn-id: svn://svn.chromium.org/blink/trunk@170504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts: https://src.chromium.org/viewvc/blink?revision=170491&view=revision

Failed attempt to land two-sided patch. The chromium side broke the blink build and then this patch further broke it after the chromium side was reverted.

In the future, please do a three-step commit if that's required to ensure no build breakage.

TBR=a.renevier@samsung.com
BUG=348071

Review URL: https://codereview.chromium.org/220503002

git-svn-id: svn://svn.chromium.org/blink/trunk@170503 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes two possible crash:
1. document->frame() could be null when ServiceWorkerContainerClient::from is called
2. NavigatorServiceWorker.m_serviceWorker could be null in ServiceWorkerContainer::detachClient

BUG=355998,356017
TEST=fast/serviceworker/access-container-with-invalid-context.html

Review URL: https://codereview.chromium.org/217023003

git-svn-id: svn://svn.chromium.org/blink/trunk@170501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of having one scheduling function per callback type, we can use
a single shared one except for the attribute callback case.

Review URL: https://codereview.chromium.org/220013003

git-svn-id: svn://svn.chromium.org/blink/trunk@170500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NotifyPositionChange pass on stored m_currentPos, and didn't use its
input variable. Removing its input variable from signature to reflect
this.

BUG=

Review URL: https://codereview.chromium.org/212063004

git-svn-id: svn://svn.chromium.org/blink/trunk@170499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Styles generated by animations and transitions are currently applied
following adjustment (to avoid triggering transitions on adjustment).

Special handling existed for mirroring the adjustment behavior of
auto z-index when animating transform, however this failed to account
for animations of perspective. This has been broken as far back as
I am able to bisect and remains broken in WebKit for the same reason.

Review URL: https://codereview.chromium.org/219013002

git-svn-id: svn://svn.chromium.org/blink/trunk@170498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is an object LineFragmentationData that is used for pagination
that is created on demand. That object was created for normal documents
and cost roughly 32 bytes per line, adding up to 3-5 MB on a big text
document (5% of all memory usage).

Testcase: http://norvig.com/big.txt - 3-10 MB RAM savings.

I don't know what I'm doing but this patch prevents the allocation and
saves the memory.

BUG=353993

Review URL: https://codereview.chromium.org/200053007

git-svn-id: svn://svn.chromium.org/blink/trunk@170497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename LayoutBox to CSSBoxType. Also rename the functions and methods that mention "LayoutBox" to something that makes sense for each specific situation.

This is a merge of http://trac.webkit.org/changeset/165843 by Bem Jones-Bey <bjonesbe@adobe.com>.

BUG=358377

Review URL: https://codereview.chromium.org/220023003

git-svn-id: svn://svn.chromium.org/blink/trunk@170496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357707

Review URL: https://codereview.chromium.org/217053009

git-svn-id: svn://svn.chromium.org/blink/trunk@170495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit d1eea2e66e64c3c019885ad7e94933aa0fc05576.
On top of that, this CL makes sure that only the preloader uses the thread safe MQ parser. That's in order to reduce the risk of breaking content when introducing the new MQ parser.

BUG=358078

Review URL: https://codereview.chromium.org/219183002

git-svn-id: svn://svn.chromium.org/blink/trunk@170494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan
BUG=

Review URL: https://codereview.chromium.org/216443004

git-svn-id: svn://svn.chromium.org/blink/trunk@170493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357782
TEST=no change

Review URL: https://codereview.chromium.org/219163005

git-svn-id: svn://svn.chromium.org/blink/trunk@170492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is the blink side.
The chromium side is handled on issue #180153010

It doesn't revert functions anymore in blink. Instead, it sets the
direction parameter to WebAnimation, which will in turn pass it to the
compositor

BUG=348071

Review URL: https://codereview.chromium.org/178263006

git-svn-id: svn://svn.chromium.org/blink/trunk@170491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When reading property on a CSSStyleDeclaration object, the property name
is transformed into a possible CSS property name and looked up as such.
This transformation involves copying the property name to a StringBuilder
while converting from camelCase to dash-separated.

Positive matches are cached in a local static hash map, but negative
matches were not.  A script reading properties like "getPropertyValue"
would trigger the conversion to "get-property-value" and CSS property
lookup every time.

Optimize by caching negative matches as well as positive ones.

BUG=

Review URL: https://codereview.chromium.org/219153002

git-svn-id: svn://svn.chromium.org/blink/trunk@170490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates FrameView::repaintTree to skip issuing invalidations for any
RenderObject if they don't have a layer and their RenderView did a full
invalidation. This seems to be closer to the behaviour that the system exhibits
with repaint-after-layout disabled.

BUG=320139

Review URL: https://codereview.chromium.org/212553004

git-svn-id: svn://svn.chromium.org/blink/trunk@170489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This API will function as a temporary shim to enable
history functionality to move to content/renderer, without
any broken intermediate steps.

This is step 1 of 5 from http://crbug.com/357327

BUG=357327

Review URL: https://codereview.chromium.org/214723003

git-svn-id: svn://svn.chromium.org/blink/trunk@170488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/219023006

git-svn-id: svn://svn.chromium.org/blink/trunk@170487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a few trace events in to gather information about the cause
and size of repaints.

BUG=320139, 351498

Review URL: https://codereview.chromium.org/208143003

git-svn-id: svn://svn.chromium.org/blink/trunk@170486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a nice cleanup, and sets us up for separating StyleInvalidator from 
RuleFeatureSet, which will allow us to more easily  TargetedStyleRecalc for style 
sheet loads.

BUG=318468

Review URL: https://codereview.chromium.org/217713002

git-svn-id: svn://svn.chromium.org/blink/trunk@170485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Current code always mark the grid as dirty in RenderGrid::removeChild().

If the grid auto flow property is different to none, the grid has to be
marked as dirty when a child removed. Just in case, the grid contains
auto-placed items, that might need to be re-positioned.

Otherwise, we can simple remove the child from the grid cells where it
is present and update the coordinates cache accordingly.

BUG=248151
TEST=fast/css-grid-layout/grid-item-removal-auto-placement-update.html

Review URL: https://codereview.chromium.org/211053002

git-svn-id: svn://svn.chromium.org/blink/trunk@170484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The parameter was never NULL but the code wasn't clear about it.
This lead to a couple of unneeded NULL-checks that obfuscated
what could happen.

Review URL: https://codereview.chromium.org/217563003

git-svn-id: svn://svn.chromium.org/blink/trunk@170482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=kbr@chromium.org
BUG=358313

Review URL: https://codereview.chromium.org/218623010

git-svn-id: svn://svn.chromium.org/blink/trunk@170481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code is only used in a test, and cc-side support is going away, so
remove it in Blink.

Review URL: https://codereview.chromium.org/215033003

git-svn-id: svn://svn.chromium.org/blink/trunk@170480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink revision 170347 introduced a crash because Document::focusedFrame()
fails to check properly for having a null Frame. This corrects the
check.

BUG=358172
R=eseidel@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/219453004

git-svn-id: svn://svn.chromium.org/blink/trunk@170478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357782
TEST=no change

Review URL: https://codereview.chromium.org/218743002

git-svn-id: svn://svn.chromium.org/blink/trunk@170477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chrome side: https://codereview.chromium.org/109283006

R=eseidel@chromium.org,abarth@chromium.org
BUG=277886

Review URL: https://codereview.chromium.org/100563004

git-svn-id: svn://svn.chromium.org/blink/trunk@170476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r170454 was almost Oilpan-ready, add missing bits.

R=mvanouwerkerk@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/219753004

git-svn-id: svn://svn.chromium.org/blink/trunk@170475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- numbers are formatted with thousands separators in the Allocation view similar to other views
- all numeric columns' text is aligned on the right hand side

BUG=277984

Review URL: https://codereview.chromium.org/219383003

git-svn-id: svn://svn.chromium.org/blink/trunk@170474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderLayer should not be friending a bunch of other classes.
Better for the de facto public API to be the de jure public API.

Review URL: https://codereview.chromium.org/218053002

git-svn-id: svn://svn.chromium.org/blink/trunk@170473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code was intending to make sure that layout() timers get
a chance to fire before parser timers do.  However we no longer use
SharedTimer for schedulingLayout.  Instead we use the compositor's
scheduleAnimation timer which is only called when the compositor
actually is going to put up a frame.

I could imagine scenerios whereby a layout was scheduled and either
was called and didn't clear the m_pendingLayout bit due to
the Document being inactive or some other early-return, or a scenerio
in which a layout was scheduled but the compistor never needed to
put up a frame, which would result in the Parser spinning like this
waiting for the layout timer to fire and clear the m_pendingLayout
bool, but it never happened.

As the FIXME said, the real fix here is to reduce the max duration
of the parser and possibly coordinate with the compositor to allow
the parser to do work directly after the frame has been put up, in
the time when the main-thread is otherwise idle waiting for the
compositor and gpu threads to actually put up the frame.

This may cause a regression on SpeedIndex benchmarks and we may
need to find a different way to implement what this code
was trying to do.

I was not able to produce a test which triggered this bug, but I'm
confident it's possible to get Blink into such a confused state.

BUG=288265

Review URL: https://codereview.chromium.org/218373002

git-svn-id: svn://svn.chromium.org/blink/trunk@170472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This relands the following changes:
http://crrev.com/208393008 Preserve autosizing multiplier on style recalc.
http://crrev.com/209853007 Fix line height when changing multiplier.
http://crrev.com/209353003 Clean up handling of autosizing state changes.

These changes were reverted in http://crrev.com/212163006, because the first
one broke AwSettingsTest.testLayoutAlgorithmWithTwoViews.

They are safe to reland due to the fix in http://crrev.com/215063004.

BUG=353309

Review URL: https://codereview.chromium.org/215503003

git-svn-id: svn://svn.chromium.org/blink/trunk@170471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to specification, minDecibels, maxDicibels and smoothingTimeConstant are defined to double.
Specification mismatched, internal member valuables already are defined to double as well.
Do not need to cast from float to double.

http://www.w3.org/TR/webaudio/#AnalyserNode

BUG=356636

Review URL: https://codereview.chromium.org/212793002

git-svn-id: svn://svn.chromium.org/blink/trunk@170469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Implied a bug: https://code.google.com/p/chromium/issues/detail?id=358136

Original issue's description:
> DevTools: fix xhr breakpoint text overflow
> 
> BUG=357520
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170337

TBR=vsevik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357520

Review URL: https://codereview.chromium.org/219473005

git-svn-id: svn://svn.chromium.org/blink/trunk@170468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Caused build failures on Android.

TBR=zvorygin
BUG=

Review URL: https://codereview.chromium.org/219243006

git-svn-id: svn://svn.chromium.org/blink/trunk@170467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Speeds up blink compilation ~ 1.5%

BUG=

Review URL: https://codereview.chromium.org/218583007

git-svn-id: svn://svn.chromium.org/blink/trunk@170466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=earthdok
BUG=328552

Review URL: https://codereview.chromium.org/219673002

git-svn-id: svn://svn.chromium.org/blink/trunk@170465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should help us better understand long
HTMLDocumentParser::insert blocks when we encounter
them on traces.

BUG=356292

Review URL: https://codereview.chromium.org/208793004

git-svn-id: svn://svn.chromium.org/blink/trunk@170464 bbb929c8-8fbe-4397-9dbb-9b2b20218538