- 21 Jan, 2021 40 commits
-
-
Eugene But authored
Bug: None Change-Id: I8959d5ef64a2242bf7002cb826a40087d96ef292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638418Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845753}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0d023562bd9..230cd50238f2 2021-01-21 mtklein@google.com close out simple assembler TODO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ie33af84899b2882904cc92d804eb775c56165ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845752}
-
Shengfa Lin authored
This reverts commit 28c5a54b. Reason for revert: The test failure cases mostly are real failures. Original change's description: > Disable __main__.ChromeDriverTest.testCanSwitchToPrintPreviewDialog > > It's flaky. > > I can't figure out how to mark it as flaky using this test harness, so disabling instead. > > BUG=1166314 > > Change-Id: I744540f637ec527dc33acf7d96190fd9a89e5914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626415 > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Shengfa Lin <shengfa@google.com> > Cr-Commit-Position: refs/heads/master@{#843395} TBR=mpearson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,shengfa@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1166314 Change-Id: Ia8c5f9f0bef64a21f2b0066ba1f218b5aed0874d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641099Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#845751}
-
Matt Reynolds authored
This CL adds a histogram to record the reason why the HID device chooser was closed. Bug: 964041 Change-Id: I1fbe006314b0d2faab57771f07ccf57c5ed01c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600218Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845750}
-
Ahmed Fakhry authored
When recording a window or a partial region, the display can be rotated, or its device scale factor can change, leading to the DIPs display bounds changing. If we don't propagate this change to the recording service, the video capturer will try to fit (i.e. center and letter-box) the new frame dimensions into the original requested video resolution. This is ok when recording fullscreen, but leads to completely broken cropping when recording a region (See bug for video demo). It can also lead to a bad quality window recording. This CL fixes this issue by propagating display bounds changes to the service to reconfigure the video capturer and encoder if necessary (Demo of fix is on the bug). BUG=1168434 TEST=Manually, added a new test Change-Id: I9db5d29bddc217042b007b422b1084c86d8be959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641082Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#845749}
-
Joshua Pawlicki authored
If the device ID cannot be fetched, we prefer to still send the request with no ID. The client will be counted by CR counting, and we still prefer the client to get up-to-dateness info rather than fail the entire request. Bug: 1158707 Change-Id: Ic6a1a8653ff6db7fbfa2ed79d1906d2c8b50095a Fixed: 1158707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643178Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#845748}
-
Caitlin Fischer authored
The server-side config shows that the study has ended. Bug: 1126640 Change-Id: I8093fccdd6ab46e36178bb020ffec2ce3ed968ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631932Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845747}
-
Avi Drissman authored
Bug: 1164487 Change-Id: I7a2fbfd53d7321b3fead090ead52f1de699f53af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631428Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845746}
-
David Maunder authored
Speedup: 14397ms -> 5191ms (64% improvement) Bug: 1168647 Change-Id: Idbf3a3e10cd4e4b04e5f34d0d997ca4bd8b05f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640919 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845745}
-
Ben Pastene authored
This will prevent the goma bots from running tests on 10.10, which is being deprecated, and which appears to fail the tests anyway. Change-Id: I17ed6c430e5ea3ee7b7eaa95fd6653038706fece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641146Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845744}
-
Yuwei Huang authored
Looks like calls to AudioQueue APIs don't always trigger audio capture permission request, e.g. it doesn't seem to pop up the permission dialog after I reset microphone permission with `tccutil reset Microphone`. Without audio capture permission, calls to AudioQueue APIs will still succeed as if everything works, but what we get will be empty buffers. Bug: 1168729 Change-Id: I5491e420fb907a1e438f57ef172ecb997f99e6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641145Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#845743}
-
Alice Wang authored
This CL uses AccountManagerTestRule instead of SyncTestRule in SigninFragmentTest to facilitate ProfileDataCache update tests in the future. Bug: 1167672 Change-Id: If3d8753b5a894a76b9db2d961aaa336306b717ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632678 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845742}
-
Olivier Yiptong authored
This adds the ability in TableView to add a range of items comprised of only 1 item. This requirement manifests itself when using a "select-all" capability. Prior to this CL, only ranges of 2+ items would be allowed. Furthermore, this fixes a bug when all items are selected while there is no 'active' row in a table. This can occur when the selection UI is outside of the TableView. Change-Id: I950fca34e8c83b650d14e0d6da3e7ad9d0b84f33 Fixed: 1169260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641320 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845741}
-
Dan Harrington authored
get_element_shadow_root Bug: 1168659 Change-Id: I0f6ae65d0ea995d5ea9cc2effa34053be7423db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640639Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#845740}
-
Austin Sullivan authored
This method just overrode the identically behaving implementation from the base WritableStream class. Intent to Implement and Ship thread here: https://groups.google.com/a/chromium.org/g/blink-dev/c/98OnGPp1_M8/m/HK4lRghLAgAJ Bug: 1163351 Change-Id: I8b6ffc033bbef22eb699eac50d8f79b829fa5a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613527 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#845739}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/54d70996a75a..21b394fcfab2 2021-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-21 vapier@chromium.org cros_sdk: drop cgroups usage 2021-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-20 vapier@chromium.org gs: update to latest 4.57 release 2021-01-20 vapier@chromium.org gs: fix unicode handling w/python2 2021-01-20 vapier@chromium.org apiclient: drop old alias 2021-01-20 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iac01d2e095adbf2b238d92c1db0274f4bab98c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642820Reviewed-by:
-
Austin Eng authored
Bug: dawn:565 Change-Id: I530a1126c9b7043f35deadd1f5aaa6c256ca2bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633198 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#845737}
-
Matthias Körber authored
Currently, the return value is conditions on the actual import of an address. However, the import can only fail if the incognito mode is enabled, which is already checked beforehand. Therefore, the return value for an importable profile is set to be always true if the profile is importable to support a consistent behavior with future asynchronous import flows. Bug: 1135178 Change-Id: I7f062151706919439c82a6bd150ec8be7f219f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632963 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#845736}
-
Eugene But authored
Bug: None Change-Id: I6f21624edbe5bc5e428913265b078eee1de80430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638450Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Zhiyuan Cai authored
When users clicks the menu item "Track prices" in grid tab switcher, a PriceTrackingSettings dialog will pop up allowing users to turn on/off the features "Track prices on tabs" and "Price drop alerts". Bug: 1163136 Change-Id: I9d1d3401185f5d118ba7bfa2cfb4e35837c69d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611275 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845734}
-
dpapad authored
Fixed: 1168475 Change-Id: I3e63b2c710a12389e635803ccb473bf12e49e7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641985Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845733}
-
Anders Hartvoll Ruud authored
This adds support for using basic pseudo-elements in @container rules. Complicated pseudo-elements (e.g. ::first-line) are deferred for later CLs. Bug: 1145970 Change-Id: I0b67ce446c16d3204fe14188981393ed6f2da269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637556 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#845732}
-
Regan Hsu authored
Previously, if the user clicked the (i) tooltip icon, the tooltip would not appear. Now it does. Bug: 1168153 Change-Id: I1bba717a760961ae1088d0bfba6b740940d05d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639228 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845731}
-
Mike Dougherty authored
This reverts commit 8904382c. Reason for revert: This CL breaks AppStateTest.resumeSessionWithStartupParameters for iOS 12 devices. See https://ci.chromium.org/ui/p/chrome/builders/ci/iphone-device/15349/blamelist. Original change's description: > [iOS] Fix Session.TotalDuration metric with multiwindow. > > Track the session as open while there is at least one foreground window. > Log this in a dedicated app agent to avoid polluting AppState. > The same is done to IOSProfileSessionDurationsService's session > start/end events. > > Bug: 1156586 > Change-Id: I37586f989039206fbaa90f7ec4046fbf9582e70a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599870 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845653} TBR=mpearson@chromium.org,marq@chromium.org,msarda@chromium.org,stkhapugin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Icd927a3252658933c02c8101067657f3ac7365b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643264Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845730}
-
Maksim Sisov authored
This test suite was disabled by accident in https://crrev.com/c/2476731 Enable it back. PS also added shards as in other places in test_suites.pyl file. Change-Id: I7a07fd729c09141859e8e6129d384f847345a87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642778 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845729}
-
Stephen Roe authored
Add SDK arch directory to test data to allow discovery of SDK libraries. Adjust test size limits. Bug: 1126177 Change-Id: I807539c53153af6b804b7bad60c96a8e60fe515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638075Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#845728}
-
Alan Screen authored
There were no preexisting unit tests for LocalPrinterHandlerDefault, even though some tests did exist for the ChromeOS-specific counterpart of LocalPrinterHandlerChromeos. Start to introduce some support for getting capabilities which will benefit testing coverage of new paths to support printer handling performed out of the browser process. This is basically just a slightly modified version of the StartGetCapability() tests which already exist for ChromeOS. Bug: 809738 Change-Id: Icee1fc72eddb4bd1f3721eb0e848ab14cd85f28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628025 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845727}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e41b3bb941a6..ea17cd60ebc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164189,chromium:1166926 Tbr: lgrey@google.com Change-Id: I0abc4bed9977ab6a3c9ed08ad73c8c3b92d9579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845726}
-
Takuto Ikuta authored
This is to prevent failure causing revert like https://crrev.com/c/2639349 Bug: 1127205 Change-Id: I6d6fac6a900caa3c64fc80f3b33cf4be5b7713c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642838 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845725}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a7e34d33fe70..6031b74664d0 2021-01-21 ivoc@webrtc.org Implement a Neon optimized function to find the argmax element in an array. 2021-01-21 sprang@webrtc.org Fixes issue triggered by WebRTC-VP9-PerformanceFlags trial. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167353,chromium:12355 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1db0278740ff3e8346c4dc293edd633f6efd2982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643136Reviewed-by:
-
Jiewei Qian authored
This is a reland of 38aeef20 The first reland adds a test for behaviors during browser shutdown, and doesn't yield consistent result. The second reland removes that test. The shutdown test was intended to fix https://crbug.com/1121894, where we hit CHECK in Browser constructor. The bug was fixed by checking browser isn't shutting down in LaunchSWAImpl.] It's okay to not test shutdown in LaunchSWAAsync (the added test in first reland), because LaunchSWAAsync doesn't attempt to create browser windows, and calls methods on objects (Profile, AppService) that are still valid during Browser shutdown sequence. So the LaunchSWAAsync API shuoldn't experience similar crashes observed in https://crbug.com/1121894. Original change's description: > Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API" > > This is a reland of 62cb2352 > > The original CL fails when AppBrowserControllerBrowserTest.Shutdown > passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK > because the use of GetCreationStatusForProfile already makes sure the > DCHECK is always successful. > > Original change's description: > > system-web-apps: implements a new LaunchSystemWebAppAsync API > > > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > > chrome components to launch a SWA safely. This new API should be used > > for SWA launches. > > > > The new API uses AppService to record metrics, handle disabled apps, > > etc. > > > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > > > LaunchSWAImpl is publicly declared because certain browser tests need to > > know the browser that hosts the SWA. It shouldn't be used to launch the > > App (other than LaunchSWA and Web app implementations). Subsequent CLs > > will attempt to migrate these browsertests to work with the new API. > > > > Bug: 1154540 > > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#843939} > > Bug: 1154540 > Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845049} Bug: 1154540 Change-Id: I823b43be08c4fb6aefd53a92442359eee296bab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641605 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
The Assistant failed to restart, as we consumed the bootup config the first time it started, and we were sending an empty config the second time (which violated the signature of the |ServiceController::Initialize| mojom method). Steps to reproduce: - Go in ChromeOS settings. - Enable assistant. - Disable assistant. - Enable assistant. This CL also fixes a potential race condition I spotted in |ServiceControllerProxy|, where we told the mojom service to start before setting the initialize callback that is required. Bug: b/178097002 Test: new chromeos_unittest "AssistantManagerServiceImplTest.ShouldAllowRestartingAfterStopping" and manually reproduced. Change-Id: Iefbe8bcee02f17305baa8d4bee7f13a22fe5c10c Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642752 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845722}
-
Takuto Ikuta authored
This is not used anymore. https://source.chromium.org/search?q=%22--auth-service-account-json%22%20f:recipe Bug: 1127205 Change-Id: Ia6cb9dc263a238073ac988210c99079c173f0f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642656 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611230296-c6265b318ac69ceb3057c4103fbc67710d80a9da.profdata to chrome-win32-master-1611241154-e1663486a23de2e3bc4e3496ca3a854ed6ee6faf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I486d93b21aff5dafe9ac2c0864adc3b7ae0d986e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642814Reviewed-by:
-
Evan Stade authored
This reverts commits d4449153 and 79cee575 which are no longer necessary after f6658bc4 Bug: 1161143 Change-Id: I0893d147bb4a6384204198738df7a46cd855a932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640378Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845719}
-
Sigurdur Asgeirsson authored
This is a reland of 5fce665c Original change's description: > PM: Enable service worker relationships in graph. > > Bug: 1143281 > Change-Id: Ibc54e560a2a2a5f38c6ef48c7352c40c1b82109c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636273 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844550} Bug: 1143281 Change-Id: I6bfd41ce7826d14fbeb6aaabf80129d8af9816ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642982Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845718}
-
Jon Mann authored
The order of destruction for members of WifiConfigurationSyncService was incorrect, possibly causing a crash on shutdown. Bug: 1145366 Change-Id: I227c805c3eba2d7aed21114de7a3318f0e7decd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641475Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#845717}
-
Takuto Ikuta authored
It seems --shard-index is always specified now. This is partial re-land of https://crrev.com/c/2639441 Bug: 1127205 Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Change-Id: If26fc49d61581635ae9260805d982768e285823a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640526 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611230296-6b85df13abed72480b96a917e46b214e59288b63.profdata to chrome-win64-master-1611241154-5f537a5e634f10cbf823c07501b1298a461fb817.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4eafdebe7923a87505b7b15c8c51fc05137f2cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643176Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/477bd92472cc..3b349f3ea9c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9707b6ebd1ea87d6996a87026e63bdbd5b6ed851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643022Reviewed-by:
-
